[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #10: Adding/fixing sort functionality to the standard list views

2019-11-11 Thread GitBox
rhtyd commented on a change in pull request #10: Adding/fixing sort functionality to the standard list views URL: https://github.com/apache/cloudstack-primate/pull/10#discussion_r344604498 ## File path: src/utils/sort.js ## @@ -0,0 +1,102 @@ +// Licensed to the Apache Soft

[GitHub] [cloudstack-primate] rhtyd merged pull request #10: Adding/fixing sort functionality to the standard list views

2019-11-11 Thread GitBox
rhtyd merged pull request #10: Adding/fixing sort functionality to the standard list views URL: https://github.com/apache/cloudstack-primate/pull/10 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] rhtyd closed pull request #2: Added config options to enable HTTPS and custom vhost names

2019-11-11 Thread GitBox
rhtyd closed pull request #2: Added config options to enable HTTPS and custom vhost names URL: https://github.com/apache/cloudstack-primate/pull/2 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] rhtyd commented on issue #2: Added config options to enable HTTPS and custom vhost names

2019-11-11 Thread GitBox
rhtyd commented on issue #2: Added config options to enable HTTPS and custom vhost names URL: https://github.com/apache/cloudstack-primate/pull/2#issuecomment-552353200 Manually tested, LGTM and made some changes. Manually squashed and merged the PR. --

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #2: Added config options to enable HTTPS and custom vhost names

2019-11-11 Thread GitBox
rhtyd edited a comment on issue #2: Added config options to enable HTTPS and custom vhost names URL: https://github.com/apache/cloudstack-primate/pull/2#issuecomment-552353200 Manually tested, LGTM and made some changes. Manually squashed and merged the PR as I did not have push rights on

Re: [DISCUSS] Storage-based Snapshots for KVM VMs

2019-11-11 Thread Slavka Peleva
Hello Andrija, We totally agree that it needs to be tested. This one of the reasons we have implemented it as an opt-in feature. As a side note - there are no changes in the current storage providers implementation. We just use the existing logic to take disk snapshots. So far we have tested with

Re: [DISCUSS] Storage-based Snapshots for KVM VMs

2019-11-11 Thread Slavka Peleva
Hi Sven, If you are asking if a VM will break if it is left fs-frozen for an extended period of time, in our experience, we have not observed such a case. We have seen a VMs fs-frozen by mistake for hours and after fs-thaw they continue operating normally. In the code there is currently no hard li

[GitHub] [cloudstack-primate] onitake opened a new issue #11: Runtime issues due incompatible core-js dependency

2019-11-11 Thread GitBox
onitake opened a new issue #11: Runtime issues due incompatible core-js dependency URL: https://github.com/apache/cloudstack-primate/issues/11 When running primate CentOS 7/Node 10.17.0 using the dependency installation instruction in the README, it will fail during webpack or startup due

[GitHub] [cloudstack-primate] rhtyd commented on issue #11: Runtime issues due incompatible core-js dependency

2019-11-11 Thread GitBox
rhtyd commented on issue #11: Runtime issues due incompatible core-js dependency URL: https://github.com/apache/cloudstack-primate/issues/11#issuecomment-552381413 @onitake I'm not sure, I tested and deployed Primate on a centos7 env and it seems to install/work OK: ``` [root@trl-86-

[GitHub] [cloudstack-primate] rhtyd commented on issue #11: Runtime issues due incompatible core-js dependency

2019-11-11 Thread GitBox
rhtyd commented on issue #11: Runtime issues due incompatible core-js dependency URL: https://github.com/apache/cloudstack-primate/issues/11#issuecomment-552381665 Do you think nodejs 10.17.x could be an issue? This is an aut

[GitHub] [cloudstack-primate] onitake opened a new issue #12: Add instructions on how to avoid system-wide global npm package installation

2019-11-11 Thread GitBox
onitake opened a new issue #12: Add instructions on how to avoid system-wide global npm package installation URL: https://github.com/apache/cloudstack-primate/issues/12 Commands like ```bash sudo npm install -g @vue/cli webpack eslint ``` will install global dependencies system-

[GitHub] [cloudstack-primate] rhtyd commented on issue #12: Add instructions on how to avoid system-wide global npm package installation

2019-11-11 Thread GitBox
rhtyd commented on issue #12: Add instructions on how to avoid system-wide global npm package installation URL: https://github.com/apache/cloudstack-primate/issues/12#issuecomment-552384718 @onitake thanks, we're all new to UI so best practices are likely not known or followed but PRs are

[GitHub] [cloudstack-primate] onitake commented on issue #11: Runtime issues due incompatible core-js dependency

2019-11-11 Thread GitBox
onitake commented on issue #11: Runtime issues due incompatible core-js dependency URL: https://github.com/apache/cloudstack-primate/issues/11#issuecomment-552452164 I'm not sure. I installed node.js from the nodesource RPM repo, as indicated in the README. The issue started to app

[GitHub] [cloudstack-primate] onitake commented on issue #11: Runtime issues due incompatible core-js dependency

2019-11-11 Thread GitBox
onitake commented on issue #11: Runtime issues due incompatible core-js dependency URL: https://github.com/apache/cloudstack-primate/issues/11#issuecomment-552503591 I did a fresh install of the whole system, and the issue is back. I think it's really caused by an incompatible core-

[GitHub] [cloudstack-primate] rhtyd commented on issue #11: Runtime issues due incompatible core-js dependency

2019-11-11 Thread GitBox
rhtyd commented on issue #11: Runtime issues due incompatible core-js dependency URL: https://github.com/apache/cloudstack-primate/issues/11#issuecomment-552510597 @onitake - okay, what should we do? Since, most web devs don't develop against CentOS7 the getting started was specific