[GitHub] borisstoyanov commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
borisstoyanov commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297259317 @priyankparihar, I've just restarted the smoke tests on this, since the last run did not executed. IMHO, I

[GitHub] DaanHoogland commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
DaanHoogland commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297259664 @karuturi please do not merge this untill integration test runs have completely passed for all hypervisor ty

[GitHub] priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297251540 Hi @borisstoyanov Bhai, Most of the developer has dependency on this code. They need it urgently. They

[GitHub] borisstoyanov commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
borisstoyanov commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297261066 I'll start test runs for xen and KVM as well @blueorangutan test --

[GitHub] blueorangutan commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
blueorangutan commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297261254 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297264774 Hi @DaanHoogland Sir, >please do not merge this untill integration test runs have completely passed for

[GitHub] DaanHoogland commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
DaanHoogland commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297266619 Thanks @priyankparihar , looking forward to the dependend PRs ;) btw I don't agree with @borisstoyanov tha

[GitHub] priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297268059 Hi @borisstoyanov Bhai, >as a user I would expect to be able to do the changes from the Cloudstack cons

[GitHub] priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297264774 Hi @DaanHoogland Sir, >please do not merge this untill integration test runs have completely passed for

[GitHub] priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297277028 >please do not merge this untill integration test runs have completely passed for all hypervisor types.

[GitHub] rhtyd commented on issue #2030: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time

2017-04-26 Thread git
rhtyd commented on issue #2030: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time URL: https://github.com/apache/cloudstack/pull/2030#issuecomment-297305453 LGTM This is an automated message from the Apache Git

[GitHub] abhinandanprateek commented on issue #2030: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time

2017-04-26 Thread git
abhinandanprateek commented on issue #2030: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time URL: https://github.com/apache/cloudstack/pull/2030#issuecomment-297307447 LGTM on code review. This is an automated

[GitHub] blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-26 Thread git
blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297309552 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-26 Thread git
rhtyd commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297309405 @blueorangutan package This is an automated message from the Apache Git

[GitHub] DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297315318 @blueorangutan package This is an automate

[GitHub] blueorangutan commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
blueorangutan commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297315554 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297316011 code LGTM, i'll be kicking tests on vmware to make sure ;)

[GitHub] DaanHoogland commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-04-26 Thread git
DaanHoogland commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-297317260 the virtio test failures should be gone after #2066 code LGTM

[GitHub] priyankparihar commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume

2017-04-26 Thread git
priyankparihar commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume URL: https://github.com/apache/cloudstack/pull/803#issuecomment-297321145 Hi Guys, I have teste

[GitHub] karuturi commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume

2017-04-26 Thread git
karuturi commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume URL: https://github.com/apache/cloudstack/pull/803#issuecomment-297321883 @priyankparihar BVT results are

[GitHub] karuturi commented on issue #2063: Fix typo on label.gpu

2017-04-26 Thread git
karuturi commented on issue #2063: Fix typo on label.gpu URL: https://github.com/apache/cloudstack/pull/2063#issuecomment-297322135 simple change. merging. This is an automated message from the Apache Git Service. To respond

[GitHub] karuturi commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-04-26 Thread git
karuturi commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC URL: https://github.com/apache/cloudstack/pull/1606#issuecomment-297322769 @rhtyd Can you run tests on this please? This is an automated message f

[GitHub] priyankparihar commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume

2017-04-26 Thread git
priyankparihar commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume URL: https://github.com/apache/cloudstack/pull/803#issuecomment-297323177 >Can you run CI? @

[GitHub] karuturi closed pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule

2017-04-26 Thread git
karuturi closed pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped to load balancing rule URL: https://github.com/apache/cloudstack/pull/1978 This is an automated

[GitHub] borisstoyanov commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
borisstoyanov commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297325200 Hi @priyankparihar Bhai, Sorry, I was referring to the user experience change I've suggested in the UI.

[GitHub] karuturi closed pull request #2063: Fix typo on label.gpu

2017-04-26 Thread git
karuturi closed pull request #2063: Fix typo on label.gpu URL: https://github.com/apache/cloudstack/pull/2063 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] rhtyd commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-26 Thread git
rhtyd commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297326553 @blueorangutan test This is an automated message from the Apache Git Ser

[GitHub] blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-26 Thread git
blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297326884 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
DaanHoogland commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297326964 @blueorangutan test centos7 vmware-55u3 Th

[GitHub] blueorangutan commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
blueorangutan commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297327239 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

[GitHub] priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297327692 Hi @borisstoyanov Bhai, >user experience change I've suggested in the UI For that answered is al

[GitHub] priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
priyankparihar commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297327692 Hi @borisstoyanov Bhai, >user experience change I've suggested in the UI For that answered is al

[GitHub] borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-04-26 Thread git
borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-297329868 @blueorangutan test centos7 vmware-60u2 This is

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-04-26 Thread git
blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-297330026 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests -

[GitHub] borisstoyanov commented on issue #1836: [4.10/master] Smoketest Health

2017-04-26 Thread git
borisstoyanov commented on issue #1836: [4.10/master] Smoketest Health URL: https://github.com/apache/cloudstack/pull/1836#issuecomment-297330714 @blueorangutan test centos6 mgmt + xs65sp1 This is an automated message from th

[GitHub] cloudmonger commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
cloudmonger commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297331885 ### ACS CI BVT Run **Sumarry:** Build Number 585 Hypervisor xenserver NetworkType Advanced

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-26 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-295582577 @borisstoyanov In this PR the secretkey is removed from the user apis (disable, enable, get, lock and updateuser) response. Ca

[GitHub] karuturi commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
karuturi commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297343813 code LGTM. will merge once the tests are ok. T

[GitHub] koushik-das commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-04-26 Thread git
koushik-das commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-297344397 @mrunalinikankariya The problem you are describing shouldn't be related to ping.interva

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-26 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-297345251 @borisstoyanov From the logs it seems the test client getting secretkey as None. When I run in my local setup I did not

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-26 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-295582577 @borisstoyanov In this PR the secretkey is removed from the user apis (create, disable, enable, get, lock and updateuser) resp

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-26 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-295582577 @borisstoyanov In this PR the secretkey is removed from the user apis (list, create, disable, enable, get, lock and updateuser

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-26 Thread git
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-297345251 @borisstoyanov From the logs it seems the test client getting secretkey as None. When I run in my local setup I did not

[GitHub] resmo opened a new pull request #2068: systemvm: fix pep8 errors

2017-04-26 Thread git
resmo opened a new pull request #2068: systemvm: fix pep8 errors URL: https://github.com/apache/cloudstack/pull/2068 fixed pep8 errors. in `baremetal-vr.py` also replaced "windows carriage return" to "unix carriage return". Before: ~~~ $ pep8 --max-line-length=160 systemvm/pa

[GitHub] yvsubhash commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes

2017-04-26 Thread git
yvsubhash commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes URL: https://github.com/apache/cloudstack/pull/2013#issuecomment-297374427 @SudharmaJain plz check the possibility of moving the previous select and the update to one transaction --

[GitHub] DaanHoogland commented on issue #2068: systemvm: fix pep8 errors

2017-04-26 Thread git
DaanHoogland commented on issue #2068: systemvm: fix pep8 errors URL: https://github.com/apache/cloudstack/pull/2068#issuecomment-297384777 thanks @resmo , good to see someone cares. provided the import changes are correct I see no issues so based on the code LGTM -

[GitHub] resmo commented on issue #2053: deb: Only build binary packages

2017-04-26 Thread git
resmo commented on issue #2053: deb: Only build binary packages URL: https://github.com/apache/cloudstack/pull/2053#issuecomment-297385771 LGTM This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] rhtyd commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-04-26 Thread git
rhtyd commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC URL: https://github.com/apache/cloudstack/pull/1606#issuecomment-297391328 @blueorangutan package This is an automated message from the Apache Git Se

[GitHub] blueorangutan commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-04-26 Thread git
blueorangutan commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC URL: https://github.com/apache/cloudstack/pull/1606#issuecomment-297391416 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2055: CLOUDSTACK-9887 ignore bogus default gateway

2017-04-26 Thread git
rhtyd commented on issue #2055: CLOUDSTACK-9887 ignore bogus default gateway URL: https://github.com/apache/cloudstack/pull/2055#issuecomment-297392273 @karuturi can this be merged? This is an automated message from the Apach

[GitHub] resmo commented on issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility

2017-04-26 Thread git
resmo commented on issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility URL: https://github.com/apache/cloudstack/pull/2037#issuecomment-297392741 LGTM (I tested the settings weeks ago on 5.7 and can confirm they worked) ---

Re:Re:Re: Fw: [4.10] VPN disconnected while network changes taken

2017-04-26 Thread Will Stevens
I will look into the VPN user issue. I did not look at that and it is a different code path. I need to be able to reconfigure the VPN legitimately, so I will see if I can reload while not touching the established connections. Thanks for testing, I should be able to look at this today to see if I ca

[GitHub] nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-04-26 Thread git
nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/1859#issuecomment-297402316 Hi @rafaelweingartner : I have created one more PR with reduced number of commits. Please find this PR #2031 . --

[GitHub] cloudmonger commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume

2017-04-26 Thread git
cloudmonger commented on issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume URL: https://github.com/apache/cloudstack/pull/803#issuecomment-297404850 ### ACS CI BVT Run **Sum

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297415749 Thanks @ustcweizhou Wei, but I think adding 'throw' might generate some additional traffi

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297415780 @blueorangutan package

[GitHub] resmo opened a new pull request #2069: follow-up CLOUDSTACK-8793: fix missing doc when projectid was added

2017-04-26 Thread git
resmo opened a new pull request #2069: follow-up CLOUDSTACK-8793: fix missing doc when projectid was added URL: https://github.com/apache/cloudstack/pull/2069 Also see 110f66ff13a81671dadd9b2c527d232ceb2d5411 and https://github.com/apache/cloudstack/pull/879 -

[GitHub] ramkatru commented on issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off

2017-04-26 Thread git
ramkatru commented on issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off URL: https://github.com/apache/cloudstack/pull/1852#issuecomment-297422948 tag:mergeready This is an automated message fro

[GitHub] resmo commented on issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off

2017-04-26 Thread git
resmo commented on issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off URL: https://github.com/apache/cloudstack/pull/1852#issuecomment-297423573 LGTM (based on code review) This is an automated m

[GitHub] nitin-maharana commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for NCC Integration with CloudStack (Original PR : #1859)

2017-04-26 Thread git
nitin-maharana commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for NCC Integration with CloudStack (Original PR : #1859) URL: https://github.com/apache/cloudstack/pull/2031#issuecomment-297425286 ping @rajesh-battala @sowmyakrishn @karuturi

[GitHub] rafaelweingartner commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for NCC Integration with CloudStack (Original PR : #1859)

2017-04-26 Thread git
rafaelweingartner commented on issue #2031: CLOUDSTACK - 8672 : Alternate PR for NCC Integration with CloudStack (Original PR : #1859) URL: https://github.com/apache/cloudstack/pull/2031#issuecomment-297427259 @nitin-maharana Awesome work!! Thank you very much. I think we can continue with

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297453636 @blueorangutan package

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297415780 @blueorangutan package

[GitHub] ustcweizhou commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
ustcweizhou commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297457226 @rhtyd that is actually what is working in 4.5 and previous versions.

[GitHub] blueorangutan commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
blueorangutan commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297463712 Trillian test result (tid-1037) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] cloudmonger commented on issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor

2017-04-26 Thread git
cloudmonger commented on issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor URL: https://github.com/apache/cloudstack/pull/1664#issuecomment-297464989 ### ACS CI BVT Run **Sumarry:** Build Number 587 Hypervisor xenserver NetworkType Adva

[GitHub] rhtyd commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
rhtyd commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297466682 LGTM. @nathanejohnson does this also affect 4.9, if so please change the base branch to 4.9 thanks. -

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297482953 Thanks @ustcweizhou I'll evaluate the fix @blueorangutan test ---

[GitHub] sateesh-chodapuneedi commented on a change in pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor

2017-04-26 Thread git
sateesh-chodapuneedi commented on a change in pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor URL: https://github.com/apache/cloudstack/pull/1664#discussion_r113517524 ## File path: server/src/com/cloud/vm/UserVmManagerImpl.java #

[GitHub] sateesh-chodapuneedi commented on a change in pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor

2017-04-26 Thread git
sateesh-chodapuneedi commented on a change in pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor URL: https://github.com/apache/cloudstack/pull/1664#discussion_r113517524 ## File path: server/src/com/cloud/vm/UserVmManagerImpl.java #

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297487753 @blueorangutan test Thi

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297487753 @blueorangutan test Thi

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297488235 @blueorangutan test Thi

[GitHub] rhtyd commented on issue #2068: systemvm: fix pep8 errors

2017-04-26 Thread git
rhtyd commented on issue #2068: systemvm: fix pep8 errors URL: https://github.com/apache/cloudstack/pull/2068#issuecomment-297488434 @blueorangutan package This is an automated message from the Apache Git Service. To respond

[GitHub] blueorangutan commented on issue #2068: systemvm: fix pep8 errors

2017-04-26 Thread git
blueorangutan commented on issue #2068: systemvm: fix pep8 errors URL: https://github.com/apache/cloudstack/pull/2068#issuecomment-297488560 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297488235 @blueorangutan test Thi

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297488685 Kicking test @blueorangutan test

[GitHub] kiwiflyer commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
kiwiflyer commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297492925 @rhtyd The original PR was only pulled into master (4.10) as far as I'm aware. --

[GitHub] blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-26 Thread git
blueorangutan commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297521060 Trillian test result (tid-1038) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 3564

[GitHub] swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops

2017-04-26 Thread git
swill commented on issue #2062: CLOUDSTACK-9878: remove unnecessary VPN drops URL: https://github.com/apache/cloudstack/pull/2062#issuecomment-297525299 Haijiao from the mailing list has confirmed that the majority of the cases are fixed, but the connection still drops when a new VPN user i

[GitHub] rhtyd commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
rhtyd commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297529312 Thanks @kiwiflyer This is an automated message f

[GitHub] blueorangutan commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

2017-04-26 Thread git
blueorangutan commented on issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware and XenServer. URL: https://github.com/apache/cloudstack/pull/1813#issuecomment-297544835 Trillian test result (tid-1036) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7

[GitHub] blueorangutan commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
blueorangutan commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297570994 Trillian test result (tid-1039) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7

[GitHub] blueorangutan commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-04-26 Thread git
blueorangutan commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-297596610 Trillian test result (tid-1042) Environment: kvm-centos7 (x2), Advanced Network

[GitHub] nathanejohnson commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py

2017-04-26 Thread git
nathanejohnson commented on issue #2066: CLOUDSTACK-9893 / CLOUDSTACK-8239 fix test_deploy_virtio_scsi_vm.py URL: https://github.com/apache/cloudstack/pull/2066#issuecomment-297596699 @DaanHoogland could you kick this off one more time? I should have the issue with the class teardown reso

[GitHub] karuturi commented on issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2017-04-26 Thread git
karuturi commented on issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used URL: https://github.com/apache/cloudstack/pull/1302#issuecomment-297615320 @rhtyd can you review again? This is an automated mes

[GitHub] sudhansu7 commented on issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised

2017-04-26 Thread git
sudhansu7 commented on issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised URL: https://github.com/apache/cloudstack/pull/1797#issuecomment-297616271 tag:mergeready This is an automated message from the Apach

[GitHub] sudhansu7 opened a new pull request #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in VPC

2017-04-26 Thread git
sudhansu7 opened a new pull request #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in VPC URL: https://github.com/apache/cloudstack/pull/1850 Unable to limit the Public IPs in VPC. In VPC network, while acquiring the IP addresses, in the resource_count table, count for the domai

[GitHub] sudhansu7 commented on issue #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in VPC

2017-04-26 Thread git
sudhansu7 commented on issue #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in VPC URL: https://github.com/apache/cloudstack/pull/1850#issuecomment-297616466 tag:mergeready This is an automated message from the Apach

[GitHub] sudhansu7 closed pull request #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in VPC

2017-04-26 Thread git
sudhansu7 closed pull request #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in VPC URL: https://github.com/apache/cloudstack/pull/1850 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] sudhansu7 commented on issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in the vm_instance table

2017-04-26 Thread git
sudhansu7 commented on issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in the vm_instance table URL: https://github.com/apache/cloudstack/pull/2002#issuecomment-297616823 tag:mergeready This is an automated messa

[GitHub] sudhansu7 commented on issue #2012: CLOUDSTACK-9842: Unable to map root volume usage to VM

2017-04-26 Thread git
sudhansu7 commented on issue #2012: CLOUDSTACK-9842: Unable to map root volume usage to VM URL: https://github.com/apache/cloudstack/pull/2012#issuecomment-297616919 tag:mergeready This is an automated message from the Apach

[GitHub] karuturi closed pull request #1918: Management Server UI (VM statistics page) CPU Utilized value is incorrect.

2017-04-26 Thread git
karuturi closed pull request #1918: Management Server UI (VM statistics page) CPU Utilized value is incorrect. URL: https://github.com/apache/cloudstack/pull/1918 This is an automated message from the Apache Git Service. To

[GitHub] karuturi commented on issue #1918: Management Server UI (VM statistics page) CPU Utilized value is incorrect.

2017-04-26 Thread git
karuturi commented on issue #1918: Management Server UI (VM statistics page) CPU Utilized value is incorrect. URL: https://github.com/apache/cloudstack/pull/1918#issuecomment-297617365 @kiwiflyer Thanks for the tag :) This i

[GitHub] karuturi commented on issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised

2017-04-26 Thread git
karuturi commented on issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised URL: https://github.com/apache/cloudstack/pull/1797#issuecomment-297617658 failures in BVT are not related to this PR. This is an auto

[GitHub] karuturi commented on issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised

2017-04-26 Thread git
karuturi commented on issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised URL: https://github.com/apache/cloudstack/pull/1797#issuecomment-297617658 failures in BVT are not related to this PR. This is an auto

[GitHub] karuturi closed pull request #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised

2017-04-26 Thread git
karuturi closed pull request #1797: CLOUDSTACK-9630: Cannot use listNics API as advertised URL: https://github.com/apache/cloudstack/pull/1797 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] karuturi closed pull request #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off

2017-04-26 Thread git
karuturi closed pull request #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off URL: https://github.com/apache/cloudstack/pull/1852 This is an automated message from the Apache Git Service. To respond

[GitHub] SudharmaJain commented on issue #2015: CLOUDSTACK-9843 : Performance improvement of SSHHelper

2017-04-26 Thread git
SudharmaJain commented on issue #2015: CLOUDSTACK-9843 : Performance improvement of SSHHelper URL: https://github.com/apache/cloudstack/pull/2015#issuecomment-297617926 LGTM for the code changes. This is an automated messag

[GitHub] karuturi closed pull request #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility

2017-04-26 Thread git
karuturi closed pull request #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility URL: https://github.com/apache/cloudstack/pull/2037 This is an automated message from the Apache Git Service. To r

  1   2   >