[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1953 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...

2017-02-21 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1897 @ramkatru Checked and addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-02-21 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1953 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1953 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...

2017-02-21 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1897 @koushik-das @kishankavala Please review the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-21 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner thanks for reviewing! I extracted code to new methods and also added unit tests for them --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @jburwell That was default behavior for few years to allow deletion of the template even if active VMs exist. Deletion of the template on secondary doesn't remove the template copy on primary sto

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-02-21 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd Thanks for running these test. The failures/errors are not related to this PR changes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-02-21 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @sateesh-chodapuneedi @rhtyd Please review the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-21 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1935 @nvazquez great work. However, there is a catch there that I think you might have overlooked. This problem is caused by the method extraction I suggested. If you take a loo

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-21 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1915 @serbaut Can you do a force push to kick off jenkins again. I'm guessing Jenkins just had an issue and not the PR. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-21 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @remibergsma Same MAC for RVR has been re-introducted as part of [CLOUDSTACK-985](https://issues.apache.org/jira/browse/CLOUDSTACK-985). It confirms that peer NICs of RVRs should have sam

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-21 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1954 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...

2017-02-21 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1875 @rhtyd Thanks for running tests. The test failures/errors above are failing in other PRs as well, not related to the changes in this PR. --- If your project is set up for it, you can rep

[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...

2017-02-21 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1875 @sateesh-chodapuneedi @rhtyd Please review the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102336557 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102342529 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -584,18 +584,36 @@ public void defFileBasedDisk(Stri

[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-02-21 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1861 ping @karuturi @koushik-das --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
Wido den Hollander wrote: > >> Op 25 januari 2017 om 4:44 schreef Simon Weller : >> >> >> Maybe this is a good opportunity to discuss modernizing the OS >> selections so that drivers (and other features) could be selectable per >> OS. > > That seems like a good idea. If you select Ubuntu 16.0

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Sergey Levitskiy
On vmware rootdiskcontroller is passed over to the hypervisor in VM start command. I know for the fact that the following rootdiskcontroller option specified in template/vm details work fine: ide scsi lsilogic lsilogic1068 In general, any scsi controller option that vmware recognizes should work

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
Sergey Levitskiy wrote: > On vmware rootdiskcontroller is passed over to the hypervisor in VM start > command. I know for the fact that the following rootdiskcontroller option > specified in template/vm details work fine: > ide > scsi > lsilogic > lsilogic1068 > > In general, any scsi control

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Sergey Levitskiy
Here it is the logic. 1. Default value is taken from a global configuration vmware.root.disk.controller 2. To override add the same config to template or VM (starting from 4.10 UI allows adding advanced settings to templates and/or VMs). If added to a template all VMs deployed from it wil

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
Sergey Levitskiy wrote: > Here it is the logic. > 1. Default value is taken from a global configuration > vmware.root.disk.controller > 2. To override add the same config to template or VM (starting from 4.10 > UI allows adding advanced settings to templates and/or VMs). If added to > a

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Sergey Levitskiy
Actually, minor correction. When adding to VM/templates the name of the detail is rootDiskController for Root controller and dataDiskController for additional disks. Also, if you want to make changes on a global scale the changes need to go to vm_template_details and user_vm_details tables respe

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-21 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 There are not failed test cases on CI run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
Sergey Levitskiy wrote: > Actually, minor correction. When adding to VM/templates the name of the > detail is rootDiskController for Root controller and dataDiskController > for additional disks. > Also, if you want to make changes on a global scale the changes need to > go to vm_template_d

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1953 Trillian test result (tid-877) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26001 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-21 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner I think I got your point, I tried to keep code as similar as it was before, by declaring `rollBackState` as static class variable on line 114. This way inner `finally` block

[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa closed the pull request at: https://github.com/apache/cloudstack/pull/1910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : This is due to the change in my remote urls. Closing the old PR https://github.com/apache/cloudstack/issues/1910. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-21 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 @serg38 Not sure to understand what you mean with: > If I get it right with your proposed changes, upgrade scripts become obsolete since all the changes can be done in upgrade scripts.

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1935 Trillian test result (tid-876) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35807 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-21 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1958 CLOUDSTACK-5806: add presetup to storage types that support over prov… …isioning Ideally this should be configurable via global settings You can merge this pull request i

[GitHub] cloudstack pull request #1959: CLOUDSTACK-9786:API reference guide entry for...

2017-02-21 Thread Ashadeepa
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1959 CLOUDSTACK-9786:API reference guide entry for associateIpAddress needs additional information Going through the code & implementation, it seems like either of the parameters are not required

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-21 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 I'll try to make my point clearer with a better use case. Let say you were running version ACS 4.4.2 and wish to upgrade to 4.7.1. After installing the 4.7.1, when ACS starts for the first ti

Re: apidocs build failure

2017-02-21 Thread Rohit Yadav
Will, any specific use-case? For a live running cloudstack an apidocs plugin could also be written that displays apidocs for a role/user-account consuming from listApis. Regards. From: williamstev...@gmail.com on behalf of Will Stevens Sent: 21 February 2017

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-21 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1957 tested. LGTM btw, you can use "git push --force" to overwrite the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

RE: apidocs build failure

2017-02-21 Thread Daan Hoogland
@Rajani @Rohit I missed this mail and fixed the apidoc on build.a.o yesterday. I can disable it or throw it away might we so wish daan.hoogl...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands @shapeblue -Original Message- From: R

Re: [QUESTION] Upgrade path to JDK8

2017-02-21 Thread Marc-Aurèle Brothier
No there isn't any issue except having the bugs & fixes of the JDK you're using. You can compile it with a JDK 1.8 as long as you don't change the target bytecode version for 1.7 On Tue, Feb 21, 2017 at 8:15 AM, Wei ZHOU wrote: > Marco, > > Good point. Is there any issue if we compile code with

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1813 Trillian test result (tid-864) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43562 seconds Marvin logs: https://github.com/blueoran

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-21 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1955 Very nice indeed! I will take a look asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-21 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1773 Hi @koushik-das @rajesh-battala , >The default value of forced is false, might cause issue on backwards compatibility. Should i make changes according to @serg38 and @us

[GitHub] cloudstack issue #1872: CLOUDSTACK-3223 Exception observed while creating CP...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1872 Trillian test result (tid-860) Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45192 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1779 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-21 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 Added the missing license on one js file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1949 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1878 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-21 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1949 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1949 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1878 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-21 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1878 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

Re: Handling of DB migrations on forks

2017-02-21 Thread Daan Hoogland
Good strategy and I would make that not a warning but a fatal, as the resulting ACS version will probably not work. On Tue, Feb 14, 2017 at 12:16 PM, Wei ZHOU wrote: > Then you have to create your own branch forked from 4.10.0 > > In our branch, I moved some table changes (eg ALTER TABLE, CREATE

Re: [DISCUSS][FS] Host HA for CloudStack

2017-02-21 Thread Koushik Das
See inline. Thanks, Koushik On 21/02/17, 11:47 AM, "Rohit Yadav" wrote: Hi Koushik, Thanks for sharing your comments and questions. 1. Yes, the FS is divided into two parts - a general HA framework which makes no assumption about the type of resource and HA provider

Re: Handling of DB migrations on forks

2017-02-21 Thread Marc-Aurèle Brothier
IMO the database changes should be idempotent as much as possible with "CREATE OR REPLACE VIEW..." "DROP IF EXISTS". For other things like altering a table, it's more complicated to achieve that in pure SQL. A good call would be to integrate http://www.liquibase.org/ to manage the schema and ch

RE: Handling of DB migrations on forks

2017-02-21 Thread Daan Hoogland
Marc-Aurele, you are totally right and people agree with you but no one seems to give this priority daan.hoogl...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands @shapeblue -Original Message- From: Marc-Aurèle Brothier [mailto:ma

Re: Handling of DB migrations on forks

2017-02-21 Thread Jeff Hair
Something like Liquibase would be nice. Hibernate might be even better. Even idempotent migrations would be a step in the right direction. Perhaps reject any migration changes that aren't INSERT IGNORE, DROP IF EXISTS, etc? I'm not sure why the DAO was originally hand-rolled. Perhaps the original

RE: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

2017-02-21 Thread Kishan Kavala
Sure Daan. I'll publish the design on cwiki and share the link. -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] Sent: Monday, February 20, 2017 7:27 PM To: dev@cloudstack.apache.org Subject: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSA

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-21 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r102173991 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange(DedicateGuestVl

[GitHub] cloudstack issue #859: Bug-ID: CLOUDSTACK-8882: calculate network offering u...

2017-02-21 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/859 ### ACS CI BVT Run **Sumarry:** Build Number 369 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder (search

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102187534 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102177792 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102181285 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102179249 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102178630 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-21 Thread HrWiggles
Github user HrWiggles commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102184780 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {

[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...

2017-02-21 Thread ramkatru
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1897 @sureshanaparti, please look into these failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request #1882: CLOUDSTACK-8737: Removed the missed out-of-ba...

2017-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1882 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1881: CLOUDSTACK-9721: Remove deprecated/unused glo...

2017-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1881 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...

2017-02-21 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1824#discussion_r102192868 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -232,28 +233,50 @@ def deleteFile(session, args): return txt +#using all

[GitHub] cloudstack issue #859: Bug-ID: CLOUDSTACK-8882: calculate network offering u...

2017-02-21 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/859 @kishankavala i forgot about this one, guess we won't make 4.7 ;) can you appease cloudmonger? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1861: CLOUDSTACK-9698 [VMware] Make hardcorded wait timeou...

2017-02-21 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1861 @borisstoyanov, thanks for running tets. I see 1 test error in the above results, this test has been failing in many other PRs as well, and doesn't seem related to changes h

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-21 Thread Ashadeepa
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1957 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with it’s user name, you will not be able to search.

[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 @ustcweizhou : Thanks. I have made the changes. New PR : https://github.com/apache/cloudstack/pull/1957. --- If your project is set up for it, you can reply to this email and have yo

Re: Attaching more than 14 data volumes to an instance

2017-02-21 Thread Friðvin Logi Oddbjörnsson
On 18 February 2017 at 20:51:42, Suresh Anaparti ( suresh.anapa...@accelerite.com) wrote: I checked the limits set for VMware hypervisor and observed some discrepancies. These can be either updated from the updateHypervisorCapabilities API (max_data_volumes_limit, max_hosts_per_cluster after impro

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-21 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1957#discussion_r102209429 --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java --- @@ -621,6 +627,10 @@ public void doInTransactionWithoutResult(Transa

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-21 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar I agree with @ustcweizhou regarding the default value of `forced` in terms of backwards compatibility. Also, why we permit deletion of a template when it is associated w

Re: [QUESTION] Upgrade path to JDK8

2017-02-21 Thread Ron Wheeler
http://stackoverflow.com/questions/10895969/can-newer-jre-versions-run-java-programs-compiled-with-older-jdk-versions You can run code compiled by the java 1.7 or 1.6 or earlier SDKs on a Java 8 JVM. This gets you the improved speed of the Java 8 JVM even if you do not rebuild the code. If

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-21 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 @rhtyd Changing the sequence is only idempotent if you have been upgrading to each new versions step by step. If you jumped other versions, then the path is different for each original versio

Re: Handling of DB migrations on forks

2017-02-21 Thread Marc-Aurèle Brothier
Jeff, I do wonder the same thing about the ORM... I hit the ORM limitation in many places now without being able to do joins on the same table specifically for capacity check, and you can see in the code many hand made SQL query on that part. I think the views came into the pictures for the same re

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @ustcweizhou : My bad. Amended the changes . Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1957#discussion_r10411 --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java --- @@ -621,6 +627,10 @@ public void doInTransactionWithoutResult(Transact

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-21 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1915 @serbaut I agree with @ustcweizhou. Please remove delaycompress and up to 10. I'd like to get this PR in as it is the second part of the problem resolution for my issue. After that LGTM. ---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-21 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1955 We are deploying this to our QA environment right now and hope to have it tested in a few days. Great work @kiwiflyer and @nathanejohnson. --- If your project is set up for it, you can reply to

Re: apidocs build failure

2017-02-21 Thread Will Stevens
Is there any chance we can fix the 'roles' issue with the API doc so we can get the docs split into the 'Admin', 'Domain Admin' and 'User' again? The introduction of the dynamic roles broke the generation of the API docs with the different roles and I was not able to figure out how to fix it. Any

Re: Handling of DB migrations on forks

2017-02-21 Thread Frank Maximus
I'm also in favor of Liquibase. Hibernate might be smart enough to add new columns, but to be able to for example change the type of a column, more complex data migration might be necessary. Liquibase preconditions, combined with good identifiers make up that upgrades will be more granular. *Fran

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

2017-02-21 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1878#discussion_r102226833 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2071,6 +2120,14 @@ protected StartA

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-21 Thread serbaut
Github user serbaut commented on the issue: https://github.com/apache/cloudstack/pull/1915 Is it safe to remove delaycompress across the board, I assume it is there for a reason? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-21 Thread leprechau
Github user leprechau commented on the issue: https://github.com/apache/cloudstack/pull/1915 We always want `compress` ... but the only time you need or want `delaycompress` is if you can't be sure that the program writing to the log can be successfully told to stop appending to that

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-21 Thread serbaut
Github user serbaut commented on the issue: https://github.com/apache/cloudstack/pull/1915 Ok. I removed it from rsyslog since it should be safe there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Handling of DB migrations on forks

2017-02-21 Thread Daan Hoogland
On Tue, Feb 21, 2017 at 3:19 PM, Marc-Aurèle Brothier wrote: > > Daan, the project maintainers should enforce that. I also posted another > finding that the upgrade path are not identical due to the order in which > upgrade files are executed, see (https://github.com/apache/ > cloudstack/pull/1768

Re: Handling of DB migrations on forks

2017-02-21 Thread Rafael Weingärtner
I think this might be others doubt as well. Sorry if it seems a naïve/silly question. By idempotent, I understand something that you can make as many operations as possible and it does not change (broadly speaking). For example, (in theory), when you do an HTTP Get requests, the response would be

Re: Handling of DB migrations on forks

2017-02-21 Thread Daan Hoogland
No Rafael the other way around, The first time you call it it might change things, but no matter how often you call it it will have changed in exactly the same way. On Tue, Feb 21, 2017 at 5:41 PM, Rafael Weingärtner wrote: > I think this might be others doubt as well. Sorry if it seems a naïve/

Re: Handling of DB migrations on forks

2017-02-21 Thread Rafael Weingärtner
Ah, great. Thanks for clarifying that for me. On Tue, Feb 21, 2017 at 11:44 AM, Daan Hoogland wrote: > No Rafael the other way around, > > The first time you call it it might change things, but no matter how > often you call it it will have changed in exactly the same way. > > On Tue, Feb 21, 2

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1948 Trillian test result (tid-870) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33543 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1949 Trillian test result (tid-872) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29754 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-21 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1948 @ProjectMoon may I ask you a question? The "net" object is already an array/map, right? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-21 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102265150 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-21 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102265306 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-21 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102264841 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1878 Trillian test result (tid-873) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33766 seconds Marvin logs: https://github.com/blueoranguta

  1   2   >