Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
---
If your project is set up for it
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1754
Trillian test result (tid-503)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39084 seconds
Marvin logs:
https://github.com/blueoranguta
Hi there,
I have been away for a while, but would like to let you now that I will try
to follow a a bit more closely the development around CloudStack. :)
After I left Schuberg Philis I forgot to change my email address on the
dev-list. It means that I might have missed some messages. Sorry for t
Welcome back Wilder!
I am also back as I manged to have a decent filtering of all the github
mails :)
René
On 11/30/2016 09:58 AM, Wilder Rodrigues wrote:
> Hi there,
>
> I have been away for a while, but would like to let you now that I will try
> to follow a a bit more closely the development
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1799
CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55
- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
-
Welcome back Wilder !
2016-11-30 9:58 GMT+01:00 Wilder Rodrigues :
> Hi there,
>
> I have been away for a while, but would like to let you now that I will try
> to follow a a bit more closely the development around CloudStack. :)
>
> After I left Schuberg Philis I forgot to change my email addres
GitHub user borisstoyanov opened a pull request:
https://github.com/apache/cloudstack/pull/1800
CLOUDSTACK-9633:test_snapshot is failing due to incorrect string consâ¦
â¦truction in utils.py
You can merge this pull request into a Git repository by running:
$ git pull https://
Hi List
As I know there are a few Ansible users here using the CloudStack
modules, let me give you an update:
New Modules in 2.2
- cs_router
- cs_snapshot_policy
In the upcoming 2.2.1, the modules also work with python3.
Roadmap for 2.3
===
New modules planned
---
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
I might need that filter, Rene! :D
Cheers,
Wilder
On 30 November 2016 at 10:34, Wei ZHOU wrote:
> Welcome back Wilder !
>
> 2016-11-30 9:58 GMT+01:00 Wilder Rodrigues :
>
> > Hi there,
> >
> > I have been away for a while, but would like to let you now that I will
> try
> > to follow a a bit mo
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1320
Hi @rhtyd, I observed there is a change in the way we were maintaining the
dictionary. The messages*.properties and dictioanry*.jsp file was removed and
the content was moved to the l10n
GitHub user murali-reddy opened a pull request:
https://github.com/apache/cloudstack/pull/1801
fix marvin test failure test_router_dhcp_opts
marvin, VirtualMachine objects are not in any particualr order in the
array. so
check isdefault attribute to the get non-default nic
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1638
Packaging result: âcentos6 âcentos7 âdebian. JID-285
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
LOL
On 11/30/2016 11:46 AM, Wilder Rodrigues wrote:
> I might need that filter, Rene! :D
As I run my own mail server and read my mails on mobile devices, I put
the filter on my mail server with a header check (postfix). This might
not work for you :)
/^Subject: \[GitHub\] cloudstack .*/
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
re
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
LGTM.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@murali-reddy can you use a JIRA id in the git commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
re
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1801
I've kicked packaging and will test matrix this pr, LTGM on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1511
I'll close this PR in favour of PR #1799
@jburwell I'll fixed the issues you've reviewed in #1799 thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Hi Wilder,
Good to hear from you, welcome back! You may also want to change your
@apache.org email fwd-ing to your email, change it through
https://id.apache.org.
Regards.
From: Wilder Rodrigues
Sent: 30 November 2016 14:28:12
To: dev@cloudstack.apache.org
S
Thanks Rene, and for your work. Trillian [1] is certainly powered by your work.
[1] https://github.com/shapeblue/Trillian
Regards.
From: Rene Moser
Sent: 30 November 2016 15:41:57
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: Ansible 2.2:
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@serg38 I have the same understanding about the agent LB. And this is one
of the problems I think we have found here. It seems that this method is
removing the balance created with age
Thanks, Rohit!
I already had 2 forwarding rules, but anyway it's nice to remove the
non-existing email from one of them. :)
Cheers,
Wilder
On 30 November 2016 at 12:32, Rohit Yadav wrote:
> Hi Wilder,
>
>
> Good to hear from you, welcome back! You may also want to change your @
> apache.org e
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1320
@nitin-maharana yes, the master branch is JSP free now. The UI is purely
JS/html/css based.
Yes, you'll need to add new keys only to the l10n (localisation) specific
files and use them in the
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma @fmaximus @nlivens thanks, I've kicked some tests. I'll be
willing to merge the PR once they pass and we've no outstanding review items.
---
If your project is set up for it, you
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Packaging result: âcentos6 âcentos7 âdebian. JID-286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220410
--- Diff: client/pom.xml ---
@@ -168,6 +168,11 @@
org.apache.cloudstack
+ cloud-plugin-network-vsp
--- End diff
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220849
--- Diff: api/src/com/cloud/network/Network.java ---
@@ -215,6 +216,8 @@ public static Provider getProvider(String providerName)
{
public stat
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90221150
--- Diff: server/src/com/cloud/network/NetworkModelImpl.java ---
@@ -1558,6 +1558,32 @@ public boolean checkIpForService(IpAddress userIp,
Service service,
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90221096
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -2968,8 +2939,45 @@ public Vlan doInTransaction(final TransactionStatus
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220227
--- Diff: api/src/org/apache/cloudstack/api/ApiConstants.java ---
@@ -639,6 +639,7 @@
public static final String READ_ONLY = "readonly";
p
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90221275
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -45,4 +45,6 @@ CREATE TABLE `cloud`.`vlan_details` (
`display` tinyint(1) NOT NULL DEFAULT 1 COMM
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220265
--- Diff:
api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java ---
@@ -120,6 +120,10 @@
@Param(description = "true if network o
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220642
--- Diff: engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java ---
@@ -142,6 +142,9 @@
@Column(name="supports_streched_l2")
boolea
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Packaging result: âcentos6 âcentos7 âdebian. JID-287
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
repl
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
Packaging result: âcentos6 âcentos7 âdebian. JID-288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1799
Packaging result: âcentos6 âcentos7 âdebian. JID-289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90227580
--- Diff: client/pom.xml ---
@@ -168,6 +168,11 @@
org.apache.cloudstack
+ cloud-plugin-network-vsp
--- End diff
GitHub user murali-reddy opened a pull request:
https://github.com/apache/cloudstack/pull/1802
CLOUDSTACK-9635: fix test_privategw_acl.py
ensure VLAN used for createPrivateGateway is determined after the guest
networks in the VPC is created, so that we skip VLAN allocated for gue
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@murali-reddy a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1802
Packaging result: âcentos6 âcentos7 âdebian. JID-290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user fmaximus commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90236739
--- Diff: api/src/com/cloud/network/Network.java ---
@@ -215,6 +216,8 @@ public static Provider getProvider(String providerName)
{
public s
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@blueorangutan test centos7 kvm-centos6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
LGTM
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@blueorangutan test centos6 kvm-centos6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
LGTM
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@murali-reddy a Trillian-Jenkins test job (centos6 mgmt + kvm-centos6) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
r
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-506)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29877 seconds
Marvin logs:
https://github.com/blueoranguta
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-505)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 34519 seconds
Marvin logs:
https://github.com/blueoran
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1753
Trillian test result (tid-504)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39047 seconds
Marvin logs:
https://github.com/blueoranguta
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-507)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40678 seconds
Marvin logs:
https://github.com/blueoranguta
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma please ignore my last comment. It appears that we have
found an issue with the `test_router_dhcp_opts` test case. #1801 has been
submitted to fix it. Once #1800 and #1801 hav
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@borisstoyanov there is a Jenkins failure, but the results page returns a
404. Could you please re-push this PR to re-trigger the Jenkins/Travis run by
running `git commit --amend --no-edit &&
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma the redundant router/VPC failures are known. We have a fix
pending for the `test_snapshot` failures in XenServer (#1800). However, I am
concerned about that`test_router_dhcp_o
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1803
CLOUDSTACK-9636: The host alerts box should be named as hosts in Alerts.
The host Alerts box shows hosts in Alerts. The name host Alerts is
misleading,
it should be changed to hosts
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
Thanks Guys for testing this out. I had a question @jburwell You wanted me
to port this to 4.9 and then it would be forward merged to 4.10 and master. How
would the DB changes be handled? right now
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1769
So, should we go forward and merge #1435 + #1769 to master?
I might just need to rebase and update version number of the current commit.
With those 2 PR, we would have master back o
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1769
@resmo could you do a PR on top of #1435 ? or this have to be merged
first? so we can get your chances and some of mine.
---
If your project is set up for it, you can reply to this email and
Github user resmo commented on the issue:
https://github.com/apache/cloudstack/pull/1769
@pdion891 I would say merge #1435 first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1769
ok, I'll update the PR and merge it I think the PR go all required LGTM.
I'll confirmed with John, in case he is in a code freeze period.
---
If your project is set up for it, you can reply to
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
Trillian test result (tid-510)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33387 seconds
Marvin logs:
https://github.com/blueoranguta
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Trillian test result (tid-509)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33518 seconds
Marvin logs:
https://github.com/blueoran
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
Addressed all the changes suggested and rebased. With vSphere 4.0/4.1, when
the ports per dvportgroup is set to less than 256 (current default), then it is
set to the default 256, else it
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90310270
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90311210
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90310775
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90314781
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -226,14 +226,14 @@ public void runUploadSslCertSelfSignedNoPassword()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90310643
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90314765
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -176,18 +176,18 @@ public void runUploadSslCertSelfSignedWithPassword
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90312334
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90338915
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90315376
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
@O
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90338636
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -240,68 +245,71 @@ public void deleteSslCert(DeleteSslCertCmd
deleteS
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90315448
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -150,26 +155,26 @@ public SslCertResponse uploadSslCert(UploadSslCertC
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90312936
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90340246
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90312667
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90314823
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -125,48 +125,48 @@ public void runUploadSslCertWithCAChain() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90339460
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCert
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90313790
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90315176
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
@O
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90309869
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import jav
1 - 100 of 168 matches
Mail list logo
