[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1727 @nvazquez can you look at comments from @koushik-das @serg38 do we have lgtms on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...

2016-11-24 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1765#discussion_r89574062 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -100,36 +100,25 @

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1623 @abhinandanprateek @murali-reddy and others -- can we have review on this, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1606 LGTM on tests and code review. @leprechau @kiwiflyer can we have a JIRA id for this and use that in the commit summary. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack issue #1573: CLOUDSTACK-9396:fixing issue related to script test_...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1573 @nitt10prashant can you rebase against 4.9, change the base branch for the PR to 4.9. Thanks. /cc @jburwell --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1519: Cloudstack 9339: Virtual Routers do not handle Multi...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1519 @murali-reddy @abhinandanprateek ping, please review this one as well, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack issue #1470: Make the generated json files unique to prevent conc...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1470 @remibergsma can you address comments from @jburwell, especially remove the `new String()`. I can help with further reviewing and testing once code changes are finalized, thanks. --- If your pro

[GitHub] cloudstack issue #1519: Cloudstack 9339: Virtual Routers do not handle Multi...

2016-11-24 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1519 @LGTM on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request #1635: CLOUDSTACK-9451

2016-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1738: CLOUDSTACK-9566 instance-id metadata for bare...

2016-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed UR...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1733 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multipl...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1760 @marcaurele an upgrade path such as `Upgrade4910to4920` would only work if your destination/final version is 4.9.2.0, have a look at the db upgrade checker workflow and you'll see how to trigger y

[GitHub] cloudstack issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed UR...

2016-11-24 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1733 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply ap

<    1   2