Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@jburwell that is great; probably I have just read half of an email thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1605
@serg38 merged bases on reviews, tests (marvin and unit ones).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1651
@serg38, @PaulAngus, @jburwell I was checking this PR, do we need this
history of commits? Wouldn't it be better a single commit in this case?
---
If your project is set up for it, yo
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1651
@rafaelweingarter I prefer squashed commits with a commit message with an
80 character summary as the first line and a paragraphs/bullets following
explaining the reason for the change and any
@PaulAngus @jburwell @rafaelweingartner Squashing commits sounds like a good
idea
On 9/11/16, 4:24 AM, "rafaelweingartner" wrote:
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1651
@serg38, @PaulAngus, @jburwell
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1560
LGTM for testing. Re-ran smoke tests:
test DeployVM in anti-affinity groups for project ... === TestName:
test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
ok
test
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@rafaelweingartner @jburwell This PR seems to be ready for merging as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@nvazquez this PR has merge conflicts that must be resolved before we can
merge it. @serg38 after @nvazquez has resolved the merge conflicts, could you
please re-execute your tests to ensure t
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1660
Great! Thanks guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
Thanks @rafaelweingartner!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
Great, thanks @jburwell!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/798
Hi @maneesha-p,
This is a really nice feature and would be nice to include it in latest
version. If you're not planning to continue with this PR, do you mind if I
continue with it, by o
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1672
LGTM merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1672
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
15 matches
Mail list logo
