Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1624
We can have someone test it. Are you looking for results of a manual test,
reproduction tests, or something automated? A manual test is probably the best
from our side because we don't reall
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r77325991
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -677,6 +679,17 @@ public boolean deleteAccount(AccountVO account, long
callerUserId, Acc
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r77326112
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account,
long callerUserId,
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1660
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
Tests performed:
- Upgraded from 4.9.0, upgrade path ran (whose sql file names were
changed)
- Clean db deployment
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
Tests performed after fwd-merge, all pass:
- Upgraded from 4.9.1.0
- Clean db deployment
---
If your project is set up for it, you can reply to this email and have your
reply
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1665
LGTM.
Tested on CS 4.9.0 to 4.9.1.0-snapshot installation.
(perhaps just change the comment below inside the SQL file to indicate
4.9.1.0 (missing .0?)
"-- Schema upgr
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1635
@jburwell sorry I've been silent, I've been on vacation for a bit and I
will be juggling plans this weekend as well. I plan to update this PR soon,
and as far as a Marvin test I am not a
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r77363519
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +201,16 @@ public static void scpTo(String host, int port, String
user, F
Look like anything in Config.java is not applied when upgrading CloudStack,
so if that file change, we need to update the configuration name="init".
This is the case for anyone upgrading prior 4.6.
https://issues.apache.org/jira/browse/CLOUDSTACK-9489
I'm not sure how we should proceed with this
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@jburwell @rhtyd I post test results:
```
[root@ussarlabcsmgt41 cloudstack]# cat
/tmp//MarvinLogs/test_volumes_SAGNPP/results.txt
test DeployVM in anti-affinity groups for proje
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
Thanks @milamberspace
Based on the tests and LGTMs, I'll proceed with merging this on 4.9. On
fwd-merging, I've fixed conflicts and renamed a subsequent class to match the
change. Fwd-merged
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1660
LGTM thanks @nvazquez for the change. Can you help with testing,
unfortunately I don't have the resources (some infra issues) to run tests
across vmware and xenserver.
---
If your project is set
Hi John,
I would like to rise the following issue recently found that I think
affect any update past 4.6.
https://issues.apache.org/jira/browse/CLOUDSTACK-9489
I think it should be relatively easy to fix but I'm scared about the impact
of overriding costumized value. I'm testing this these days..
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Hi PL,
That's correct, all new global settings should use the ConfigKey class to setup
new global settings. Any changes that may be done recently (4.6+) that added
new global settings directly in Config.java won't get added to the
configuration table unless it's a fresh installation. Can you g
I'll investigate further but setting init to false dynamite my db at the
first try :-S.
I'll continue next week but might be a dangerous path so far :-S
On Fri, Sep 2, 2016 at 2:03 PM, Rohit Yadav
wrote:
> Hi PL,
>
>
> That's correct, all new global settings should use the ConfigKey class to
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1671
Adding support for cross-cluster storage migration for managed storage when
using XenServer
This PR adds support for cross-cluster storage migration of VMs that make
use of managed stor
19 matches
Mail list logo
