[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76197541 --- Diff: debian/rules --- @@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 1) SYSCONFDIR = "/etc" DESTDIR = "debian/tm

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76200059 --- Diff: debian/rules --- @@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 1) SYSCONFDIR = "/etc" DESTDIR = "d

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1660 RMs please help review /cc @jburwell @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76202771 --- Diff: debian/rules --- @@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 1) SYSCONFDIR = "/etc" DESTDIR = "debian/tm

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Thanks @vincentbernat I'll update the dependencies, and in the post-installation step we can modify the default JAVA_HOME path of the host in the default/{cloudstack-usage, cloudstack-agent} files

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1654 @jburwell I've added an empty upgrade path. Tested the db upgrade locally. LGTM. When you fwd-merge on 4.9 use: `git merge -X ours 4.8` to avoid fixing merge conflicts in pom.xm files by hand.

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76206826 --- Diff: debian/rules --- @@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 1) SYSCONFDIR = "/etc" DESTDIR = "d

Re: CS 4.9 NIO Selector wait time PR-1601

thanks for your reply. This morning we repeated the upgrade process from 4.8 to 4.9 with the following repository: http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/. Unfortunately we run into the same issue: /2016-08-25

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido @vincentbernat I've incorporate all the changes now, including refactoring of systemd file and now we've both centos and ubuntu/debian packaging consuming from the the same service/default s

RE: CS 4.9 NIO Selector wait time PR-1601

Martin, Can you provide more detail about your haproxy setup? Are you running it on separate servers, or on the management server itself? - Si Simon Weller/ENA (615) 312-6068 -Original Message- From: martin kolly [martin.ko...@senselan.ch] Received: Thursday, 25 Aug 2016, 5:04AM To: Roh

[GitHub] cloudstack issue #1662: Fix bug juniper srx

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1662 @digitalgust please squash the changes, the changes look like bugfixes so please edit the PR and change the base branch to 4.9 branch, and please open a ticket on JIRA and edit the commit message

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76225900 --- Diff: packaging/centos7/cloud.spec --- @@ -482,7 +488,7 @@ pip install --upgrade /usr/share/cloudstack-marvin/Marvin-*.tar.gz %dir %attr(0

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76226318 --- Diff: debian/cloudstack-agent.postinst --- @@ -41,6 +41,12 @@ case "$1" in mkdir /etc/libvirt/hooks fi

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76226387 --- Diff: packaging/centos7/cloud.spec --- @@ -482,7 +488,7 @@ pip install --upgrade /usr/share/cloudstack-marvin/Marvin-*.tar.gz %dir %attr(0770,root

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76226635 --- Diff: packaging/centos7/cloud.spec --- @@ -482,7 +488,7 @@ pip install --upgrade /usr/share/cloudstack-marvin/Marvin-*.tar.gz %dir %attr(0

Re: CS 4.9 NIO Selector wait time PR-1601

@Simon: We have one management server with local DB. KVMs connect directly to the management server without any security/loadbalancing device. Thanks Martin On 08/25/2016 12:41 PM, Simon Weller wrote: > Martin, > > Can you provide more detail about your haproxy setup? > Are you running it on sep

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76227609 --- Diff: packaging/centos7/cloud.spec --- @@ -482,7 +488,7 @@ pip install --upgrade /usr/share/cloudstack-marvin/Marvin-*.tar.gz %dir %attr(0770,root

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76227828 --- Diff: debian/cloudstack-agent.postinst --- @@ -41,6 +41,12 @@ case "$1" in mkdir /etc/libvirt/hooks fi cp -a

Re: Virtio vs IDE emulation, per OS - where is this info ?

Hi Simon, thanks a lot for this info - but I'm not sure if this is complete list ? For example: "Windows PV" is present in DB etc, but it's not here in the code you sent (Windows PV = virtio hardware, other Windows X = ide/intel) Do I miss something - I tried to crosscheck DB and code, and d

Re: CS 4.9 NIO Selector wait time PR-1601

Hi Martin, Thanks for sharing, on the surface there does not seem to be any issue in configuration causing the failures. I'm personally running KVM and Ubuntu hosts based env without issues, I'm on Ubuntu 14.04.4 (Linux bluebox 3.16.0-45-generic #60~14.04.1-Ubuntu) and java 1.7.0_79. Can you t

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1645 @kiwiflyer So does the mgmt server know the snapshot is now in QCOW2? Or does it still think it's RAW? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1647 LGTM for me right now. One side note, I hate changes being made in postinst files. But I wouldn't know a different route though. --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request #:

Github user wido commented on the pull request: https://github.com/apache/cloudstack/commit/fa3fe7bb05fcf26d8fedb9f5ad6d902281504922#commitcomment-18774932 Yes, that looks much better. LGTM --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Thanks @wido I'll see if I can fix the issue without including the changes in postinst files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...

Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1644 Seems logical to me. But we can't revert a RBD snapshot yet, can we? Sorry, it's getting a bit rusty for me as I haven't looked at that code for a while. Still, sane feature. ---

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido @vincentbernat I could not get rid of the postinst step as shell is not executed when I move the code in the EnvironmentFile itself. I've reduced its impact to only run when the default /et

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1605 Thanks @rafaelweingartner! I pushed new changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1605 @nvazquez great. What about squashing the commits now? LGTM for the code, giving my reviews. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Packaging tests confirmed, PR is OK. Debian packages tested on Ubuntu 12.04/14.04/16.04, rpms tests on CentOS 7.2. Both usage, agent came up on installation. --- If your project is set up for it

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1605 Done, thanks @rafaelweingartner! I'll start working on adding Marvin tests for this PR as @jburwell suggested. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1645 @wido I don't know that the management server knows explicitly, it doesn't actually seem to store the disk image format in the snapshot related tables at all, only in volumes as far as I

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1645 @jburwell the smoke test completed successfully Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk | Status : SUCCESS === ok

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Update: postinstall code has been removed now @wido @vincentbernat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: CS 4.9 NIO Selector wait time PR-1601

Hi Rohit We are running java version 1.7.0.111 on KVM and management server. mgmt# java -version java version "1.7.0_111" kvm# java -version java version "1.7.0_111" We get the same error message. Attached are the logs with TRACE enabled. "success consists of going from failure to failure withou

[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...

Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1644 Pure RBD based revert is not supported today (plus it's really slow). The way we do it is we snap to volume (clone), shut the vm down, then detach the old disk and reattach the new disk to the

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 I took a look at the code last night and it seems that we're no longer specifying the source format when calling qemu-img convert. We're relying on qemu-img's auto detection of source format

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76281415 --- Diff: packaging/systemd/cloudstack-usage.default --- @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76281544 --- Diff: debian/rules --- @@ -35,13 +37,20 @@ override_dh_auto_install: # cloudstack-agent mkdir $(DESTDIR)/$(SYSCONFDIR)/$(PACKAGE

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76283738 --- Diff: packaging/systemd/cloudstack-usage.default --- @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @vincentbernat @wido thank you for your suggestion and review, I've pushed the final version from my end. Packages works on both CentOS7 and Ubuntu 12.04/14.04/16.04. --- If your project is set

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76284726 --- Diff: debian/rules --- @@ -35,13 +37,20 @@ override_dh_auto_install: # cloudstack-agent mkdir $(DESTDIR)/$(SYSCONFDIR)/$(PACKAGE)/agent

Re: CS 4.9 NIO Selector wait time PR-1601

Hi Martin, Thanks for sharing. Alright, I'm not sure what's causing issue but based on the logs seems like only KVM agents are having issues while connecting to mgmt server as I don't see any Nio related exceptions in the management server logs. I could not see the cloudstack-agent version in

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1642 I have been performing additional tests manually on this PR and noticed one issue that I want to investigate: When I put the managed primary storage that the system VMs are runnin

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76320192 --- Diff: debian/rules --- @@ -35,13 +37,20 @@ override_dh_auto_install: # cloudstack-agent mkdir $(DESTDIR)/$(SYSCONFDIR)/$(PACKAGE

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76320932 --- Diff: packaging/systemd/cloudstack-agent.default --- @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 LGTM with smoke testing. RHEL 6 management servers, advanced networking, Vmware 5.5 .and 6 hypervisors [root@ussarlabcsmgt41 smoke]# cat /tmp//MarvinLogs/test_volumes_340FH1/result

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76323706 --- Diff: packaging/systemd/cloudstack-agent.default --- @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1642 Ah, I think I "jumped the gun" on this. It looks like the three SRs (and corresponding volumes on the SAN) were to be deleted by a background thread (which I didn't wait for). I

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski we usually increase the garbage collection frequency and reduce any wait time global settings in order to speed up tests. Coupled with the wait_until Marvin, you build fairly

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1642 Sounds good, @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a