RE: Metrics UI - Incorrect metrics data for zone/cluster

Rashmi, I've left comments on the JIRA ticket you've created. Can you follow them and let me know if the workaround (with pagesize=-1) works for you. Since we're doing the calculations and performing HTTP requests on UI/client side, it's a known limitation that it will perform O(m*n) http request

Re: Question: commands.properties.in deprecated

All, I've updated the docs PR, that should be merged soon after one more review/LGTM. I've updated the following cwiki pages on how to authorize APIs in the post-dynamic-roles world: (/cc Mike) https://cwiki.apache.org/confluence/display/CLOUDSTACK/Annotations+use+in+the+API https://cwiki.apach

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218677864 tag:mergeready /cc @swill all green now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-218678381 @pdion891 let's merge this now that the feature PR has been accepted --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

Github user borisstoyanov commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-218687261 LGMT! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-218690491 Thanks @borisstoyanov merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1483#discussion_r62985942 --- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java --- @@ -466,7 +466,7 @@ public boolean deletePrivateGateway(final Priva

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218699781 Thinking about closing this PR and coming up with two new ones. One which only adds the channel and installs Qemu Guest Agent in the SSVM. --- If your project

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218699576 @rhtyd thanks, looks like @swill is right and this needs more tlc. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62989315 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR6.java --- @@ -0,0 +1,95 @@ +// +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-218706540 LGTM did a code walk through and I know of a production install this code is running in. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218712059 @swill, I have to correct myself. The timeout is in the before_script.sh. This is run several times without problems and then fails in a test set. In the 'p

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62994401 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: Disable NioTest

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1538#issuecomment-218713327 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218713732 @DaanHoogland there is a known issue in test_list_ids_parameter test causing issue. You can force travis by doing a pull --rebase and/or git commit --amend and then p

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62994980 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218714480 @rhtyd the issue seems to occur in the prepare script not in the tests: ./tools/travis/before_script.sh --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62995623 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

Github user olivierlemasle commented on the pull request: https://github.com/apache/cloudstack/pull/1503#issuecomment-218715075 Any chance reviewing this pull request? The error is quite critical because it causes HTTP 530 errors in API requests. Thanks! CC @swill

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1503#issuecomment-218716828 LGTM, always better to have real json handling as opposed to string parsing. @swill, can you schedule the integration suite on this? --- If your project is se

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user marcaurele commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218731447 I don't get what's the relation between my change and the jenkins build failling. Should I trigger another one? --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218732878 @marcaurele I don't think it is related to your code either. can you open/close your pr to see if it works. If not, maybe we need to empty the jenkins-workspac

RE: Metrics UI - Incorrect metrics data for zone/cluster

Thank you Rohit. The workaround you have provided works. -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: Thursday, May 12, 2016 12:32 PM To: dev@cloudstack.apache.org Subject: RE: Metrics UI - Incorrect metrics data for zone/cluster Rashmi, I've left comme

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63011147 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218742950 Once I get #1539 merged, I will ask you to re-push since we are working to fix the issue that is causing Travis to fail in that PR right now. Thx... --- If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63011767 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-218743823 Can I get one more review on this one? @remibergsma are you choosing not to squash because you are not the original author of some of the commits? If that is th

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63012011 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

Github user PaulAngus commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218744867 Jenkins has run successfully @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1503#issuecomment-218745932 @DaanHoogland & @olivierlemasle thanks for the heads up guys. I will get CI run against this today... --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-218746528 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1540 CLOUDSTACK-9377: Fix metrics pagesize issue Fixes listing of clusters and host to list all clusters/hosts by passing pagesize=-1. /cc @koushik-das @swill @DaanHoogland -- fixes the is

[GitHub] cloudstack pull request: Disable NioTest

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1538#issuecomment-218760612 @rhtyd I was able to successfully run mvn -P developer,systemvm clean install -D noredist now on Mac OS X El Capitan 10.11.4, so LGTM. --- If your project i

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1541 Systemd packaging for Ubuntu 16.04 This PR is for introducing packaging for Ubuntu 16.04 Ubuntu 14.04 still uses sysvinit and Java 7. 16.04 uses systemd and Java 8. The 'build-deb

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-218761324 Can @sverrirab look at the comments of @jburwell ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218763389 @rhtyd I'll work on pulling some trace logs and a debugger on the agent if the trace logs don't show anything. For reference, These patches were on our QA 4.8

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-218764129 Also, tested in a 4.8 lab and I was able to migrate VMs between hosts when using VXLAN Guest Isolated network. LGTM --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-218765751 I tested this in our 4.8 HW Lab and it worked as expected. I found the MASTER VR for a TEST VPC with a private gateway configured. I started a ping to the private

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-218761024 Asking @rhtyd for a review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218766563 @swill @rhtyd @DaanHoogland I reordered cleanup as in [@rhtyd's commit](https://github.com/apache/cloudstack/pull/1502/commits/6135f6d98fa6b363b0468c17a8e713aeb5054

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63026066 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: Disable NioTest

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1538#issuecomment-218771021 Hi guys, Please do not take me in a bad way, but why do we keep a test code that does not work? To me it is clearly that the test and the code being t

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218774260 @rhtyd I have had a couple independant reports of CPU going to 100% with this patch and the problem not existing if they revert this PR (along with #1534). D

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218776521 @rhtyd With the agent in trace mode, I see this scrolling through very rapidly: 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-218783498 Force pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218784278 @swill @rhtyd LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Handle private gateways more reliably

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/816 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1528 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218789994 @nvazquez, @rhtyd's commit has been merged as part of his larger PR at #1502, so we can close this PR since the result of this PR has already been merged. Thanks eve

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218790646 @PaulAngus I just pushed a fix for the Travis problems you experienced. Can you please re-push this PR so we can try to get it all green so we can get it merged. Th

[GitHub] cloudstack pull request: Remove classes with no references

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-218791773 Can I get one more code review on this one??? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-218792730 @dsclose we have pushed fixes to both Jenkins and Travis today. Can you please do a force push or close and reopen this PR in order to kick off Jenkins and Travis ag

[GitHub] cloudstack pull request: CPU socket count reporting correction

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-218793268 @NuxRo I have pushed fixes to both Jenkins and Travis this morning. Can you close and reopen the PR to kick off the Jenkins and Travis runs again. Thanks... --- I

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218794307 @remibergsma can you re-push this one. Jenkins and Travis should be fixed now, so we should be able to get this green with a new push. I am missing one code

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218802890 @swill We'll pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218804870 Thanks guys. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218805790 @mike-tutkowski can you rebase this PR as we now have merge conflicts. Can you review the recent comments and I will get this queued up to get CI run against it as s

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218806166 @marcaurele I have merged fixes to Jenkins and Travis, can you force push again to kick off those runs again. Sorry for the inconvenience, hopefully this is the last

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218806800 @SudharmaJain please rebase as we now have merge conflicts. Ideally we would have some verification that this works as expected. I don't have the ability to test thi

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-218807140 @sudhansu7 I pushed fixes to Jenkins and Travis this morning. Can you please force push again so we can get this green. Thanks... --- If your project is set up for

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1455#issuecomment-218807584 @sanju1010 we have merge conflicts now. Can you please rebase against the current master. Thanks... --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: L10n update master 20160127

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-218808022 @milamberspace can you do a force push again. I have pushed fixes to Jenkins and Travis this morning, so with a new push we should be able to get this green. Thx...

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-218808523 @syed can you force push this one again to see if we can get Jenkins to pass now. We have fixed some issues with Jenkins and Travis this morning. Thx... --- If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-218810209 @DaanHoogland can you force push as we should have fixes for Jenkins and Travis in place now. If we can get some final verification on this one then we can get into

[GitHub] cloudstack pull request: [CLOUDSTACK-9337]Enhance vcenter.py to cr...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1464#issuecomment-218810586 anyone able to pick this up for validation and giving me a final code review??? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-218811415 @remibergsma sorry to do this to you again. can you force push again. I have pushed fixes to jenkins and travis this morning so hopefully we can get this all green.

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-218811089 @ustcweizhou can you force push again so we get this PR all green. We pushed some fixes to jenkins and travis this morning, so we should be good with a force push.

[GitHub] cloudstack pull request: [Bug-Id: CLOUDSTACK-9306]Replace testdata...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1436#issuecomment-218813851 @sanju1010 can you please review this? I am not worried about the issue with `` because I have verified that issue already existed. However, the following problem s

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

GitHub user PaulAngus reopened a pull request: https://github.com/apache/cloudstack/pull/1537 Remove extraneous log directory and add catalina.out log rotation rebased and squashed replacement for PR: https://github.com/apache/cloudstack/pull/1087 Remove extraneous log d

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

Github user PaulAngus closed the pull request at: https://github.com/apache/cloudstack/pull/1537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218830874 @swill Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218835105 @remibergsma I'm porting this patch set into our 4.8 QA branch currently. I noticed 709be45 is in here as well (force encap). Can you pull that out of this set, a

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218836777 Thank you @SudharmaJain. Is there anything you can provide to show this works as expected? Screenshots or something? I don't have the ability to CI this, so it woul

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218838012 ok, I'm just blind and didn't see the additional commit to remove the forceencaps. :-) --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1456#issuecomment-218838385 Can I get another code review so this can be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1456#issuecomment-218838201 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 4h 19m 54s ``` **Summary of the p

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-218838753 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 4h 19m 11s ``` **Summary of the p

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-218838932 Can I get some code review on this PR? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Remove classes with no references

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-218839589 LGTM @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1450#issuecomment-218839655 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 8h 34m 12s ``` **Associ

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1450#issuecomment-218839846 Can I get some code review on this one? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1297 CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts: api/src/org/apache/cloudstack/api/command/user/

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-218841768 I'm an ass but no. I can close and reopen however. should do the trick --- If your project is set up for it, you can reply to this email and have your reply ap

Build failed in Jenkins: build-master-noredist #4862

See Changes: [Remi Bergsma] apply static routes on change to master state [Remi Bergsma] Add private gateway IP to router initialization config [Remi Bergsma] CLOUDSTACK-9287 - Generate new mac address if router is redunda

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-218842214 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 9 Errors: 10 Duration: 10h 09m 15s ``` **Summary of the

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-218842740 @dsclose we have merge conflicts on this one now. Also, prior to merging the PRs that caused the conflicts, I ran the above CI. You will probably want to review the

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-218843734 @rodrigo93 @GabrielBrascher your comments are valid but warrant PRs on this PR. please either submit your own PR or provide @ustcweizhou with you desired chang

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63071868 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -144,6 +145,8 @@ @Inject SnapshotDataStoreDao _sn

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-218844537 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 9h 17m 35s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-218844975 I think this one is ready... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218846952 This failed during compiling: ``` [INFO] Apache CloudStack Plugin - Hypervisor KVM . FAILURE [11.036s] ``` Here is the error ``` [IN

[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1456#issuecomment-218847217 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-218848337 so @swill, I may find time to review later. In the meanwhile let's use tag:needsreview makes sense? --- If your project is set up for it, you

  1   2   3   >