Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218540891
Did a review, I have some remarks, some questions as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218542671
Good point, I am numb to travis timeouts. RM work remnance :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218543261
@swill PR1539 passed Jenkins and Travis. After you merge it should resolve
the issue in other PRs
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218544251
It was stuck due to another jenkins job running. I am still not sure I saw
what I saw. when I stopped 1252, shortly after 1253 through 1256 finished.
---
If y
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218553761
@swill OK, looks like are OK here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218577635
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 9h 06m 23s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218578631
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 24
Errors: 10
Duration: 10h 46m 24s
```
**Summary of th
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-218579019
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 9h 12m 09s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-218579831
I think this one is pretty much ready. I have one code review on this one.
Can I get one more person to look over this for me? Thanks...
---
If your project is se
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-218591057
@syed can you have a look at this one.
I am not sure why, but I am having a lot of trouble with this PR. I have
not been able to get a test run to actually w
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218592243
LGTM. Tested in a hardware lab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218596132
The additional run of these tests in a new environment gives the same
results. I think this needs some work still...
---
If your project is set up for it, you can r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218595232
Worked with @swill and @kiwiflyer and found the issue: one bit was missing
in the backport from Cosmic. Will look into that tomorrow.
---
If your project is se
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218597071
@rafaelweingartner yes, it will be forward merged. Sorry I only just got
around to answering your question. I need one more code review on this one.
Thanks...
--
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1528#issuecomment-218597484
I think this one is good to go...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218600092
LGTM. We tested this in our Lab on HW and all static routes on each PG
came up as expected.
---
If your project is set up for it, you can reply to this email and h
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218607629
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218607576
LGTM. Tested in a hardware lab.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825
LGTM. Tested in hardware lab and works as designed.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218648555
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 6h 07m 12s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218648825
This one is ready other than Jenkins. @PaulAngus, can you please either
force push the PR or close and reopen it so it kicks off Jenkins so we can get
this PR all gr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218648913
Thanks for the hard work @remibergsma. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218649126
Thank you sir. I will get this merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218649198
Thanks gents. I will get this merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218649383
@dsclose can you force push or close and reopen the PR to kick off travis
and jenkins again? Thanks...
---
If your project is set up for it, you can reply to this e
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218649701
I need some code review on this one. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-218651517
Does this require a change to the system VM template? I am pulling this in
for testing now...
---
If your project is set up for it, you can reply to this email and h
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218652190
LGTM, cc @swill let's merge this first to avoid other PRs failing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218654451
Sorry for the delay getting to this. I think this probably works in all
cases, but I suspect it will not clean up correctly always. Because this was
working sometim
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62962859
--- Diff:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
@@ -316,4 +317,9 @@ public boolean visit(final StaticR
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1511
4.9/master bountycastle changes
This PR adds bountycastle related version and code fixes from @DaanHoogland
on top of https://github.com/apache/cloudstack/pull/1510
I could not fix jav
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218656345
@DaanHoogland done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218656836
@kiwiflyer along with this patch, have you also applied the optimization
patch #1534 (make sure to apply the patch on both mgmt server and KVM agent) ?
We can debug y
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218657103
I think one way to cleanup would be to do it case by case basis for each
test case manually instead of relying on the class level cleanup. Also, it's
best to avoid us
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62963628
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (AS
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62963739
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Hi,
I came across an issue in the metrics for zone and cluster. I have logged a bug
for the same. https://issues.apache.org/jira/browse/CLOUDSTACK-9377
To quickly summarize the issue: APIs have a pagesize restriction - the
default.page.size global setting is used as the max result count - value
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62965518
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r62967100
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup = [
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1502
CLOUDSTACK-9299: Out-of-band Management for CloudStack
Support access to a hostâs out-of-band management interface (e.g. IPMI,
iLO,
DRAC, etc.) to manage host power operations (on/off etc
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62967326
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundati
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218666241
@jburwell fixed the ProcessRunner issues, please do a final review and LGTM
or suggest changes. Thanks.
@nvazquez @swill I've fixed two CI issues (Travis and
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-218667408
@swill Yes, it does. It install the Qemu Quest Agent inside the SSVM.
It doesn't hurt to do that already, it is just that the libvirt-java
bindings don't allow
Hi Mike and Will,
I'll update the admin-docs PR on this, if you take a look at the dynamic roles
FS it has pointers on how to deal with new API, what are role types (RoleType
has existed since at least 4.3) etc.
In short use the authorized field in the APICommand annotation to set default
auth
The issue is not specific to the change but the how test are run.
On OSX, when a process tries to listen on a port the firewall (enabled by
default on most cases) would block the process from running.
The other issue is the test relies on wall clock which can depend if the
test/CI env was virtual
For some reason the NioTest had been disabled historically (git history tells
me it was disabled in 881a6e as it is dependent on network config running the
test) , my PR has re-enabled it. Since this unit test `NioTest` creates actual
server/client instances -- in many environments this may fail
Rashmi,
Originally, the feature was implemented using all the available list APIs in
future we may have a backend metrics API instead of aggregation in the
UI/client side (done right now).
This feature assumes that no single cluster would have 500 hosts (also not
supported by many hypervisors t
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1538#issuecomment-218669737
@swill @nvazquez @mike-tutkowski appreciate if we can discuss the issue
here instead of ML, we'll lose discussion otherwise and I'm unable to keep up
discussions at t
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1538#issuecomment-218670692
I should be able to try your branch out later today. Thanks!
On May 12, 2016, at 12:18 AM, Rohit Yadav
mailto:notificati...@github.com>> wrote:
Thanks Rohit.
Once you play with the page size - set it to say 40, then the issues show up.
This also affects the number of cluster calculations as well.
-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
Sent: Thursday, May 12, 2016 11:44 AM
To: dev@cloudstack.apa
101 - 152 of 152 matches
Mail list logo
