Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1497#discussion_r62456142
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -0,0 +1,293 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1497#discussion_r62456186
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -0,0 +1,293 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1532#discussion_r62456988
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid)
{
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217791958
@DaanHoogland, @alexandrelimassantana, could you review the PR once again
please?
---
If your project is set up for it, you can reply to this email and have your
r
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-217795687
Sorry to be a pain, but any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-217798010
Thanks @rafaelweingartner for the updated PR.
LGTM based on code review and verification of PR on simulator.
---
If your project is set up for it, you can r
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-217809810
@swill This has the required LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user drsridevi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1532#discussion_r62469111
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid)
{
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217814496
@DaanHoogland I agree that's the best practice though there is a glitch
here. Following code returns null if _cache is not null but element is
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217814911
Probably intention is to,
```java
T result = null
if (_cache != null) {
final Element element = _cache.get(id);
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217820309
@sateesh-chodapuneedi not quite, you're missing a case. If the cache is
null (not configured) you will always return `null`, which is not the goal.
---
If your
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217820629
I pushed a change to write the method following the good practive you're
mentioning. I also updated the sibling method findById to follow the same
practice.
--
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217829031
@marcaurele @sateesh-chodapuneedi You are both right probably more then I
will ever be so please take with a grain of salt:
```
T result = null;
It seems there is a limit of 8 NICS that Hyper-V will support for user VMS:
https://technet.microsoft.com/en-us/library/jj680093.aspx
It seems CS-25155 is some internal jira ticket, do you know if the
summary/extract can be shared ?
On 06/05/16, 8:15 PM, "Octavian Popescu" wrote:
>Adding a
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1532#discussion_r62482644
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -942,12 +942,18 @@ public T findOneBy(final SearchCriteria sc) {
@D
Hi,
Short Term - all the content has moved to cloudstack.apt-get.eu
Which sections to be modified?
The Install Guide needs to be modified. Sample links/details are mentioned
below for 4.6 and same needs to be updated for other Released versions of
Cloudstack documentation:
http://docs.clouds
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217839187
@nlivens thanks for the extra test effort you put into this. Can you rename
the marvin test to adhere to python naming standards (i.e. no camal case
underscore
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-217839619
@nuxro I have rebased but did not get to testing. I don't trust the scalevm
problem. It might be in the test, in the test environment or in the actual
code. Lo
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1357#issuecomment-217840055
Is there a test already to check if the ip ranges release method is called?
If there is none, I think it should be added
---
If your project is set u
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-217842674
as @pedro-martins stated, it seems to be fitting that this method is
extracted to a class to be documented/tested. The code looks good but if the
exce
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-217853178
Thanks Daan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-217855833
We have the required code reviews and CI results. I will add this to merge
queue. Thx...
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-217856052
@ don't thank me, I just started to check but my infra is based on KVM and
it doesn't support scalevm, so I cannot investigate further
---
If your project is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-217856530
All tests are done and I have the code reviews I need. Adding to merge
queue. Thx...
---
If your project is set up for it, you can reply to this email and have you
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-217857669
Same here.
Is this XenServer specific, can anyone with an XS test bed help?
---
If your project is set up for it, you can reply to this email and have your
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217858039
@DaanHoogland, the file has been renamed to make use of the python naming
standards
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-217859785
@abhinandanprateek please check the Jenkins issues and trigger a rebuild to
get this PR green.
---
If your project is set up for it, you can reply to this email a
I’m afraid not - I found the 25155 ticket reference in some release notes but
that’s as far as it goes really…
On 09/05/2016 12:11, "Abhinandan Prateek"
mailto:abhinandan.prat...@shapeblue.com>>
wrote:
It seems there is a limit of 8 NICS that Hyper-V will support for user VMS:
https://technet
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217866994
LGTM based on code, CI pending
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-217867849
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-217867940
@ustcweizhou, I suppose it still LGTM to you as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Kishan Kavala wrote:
> Nathan,
> You can use "Secure" category instead of "Hidden". Config items with
> "Secure" category are encrypted and also included in listConfigurations API
> response.
The data that I need (specifically security.encryption.iv and
security.encryption.key) are already
Anshul Gangwar wrote:
>
> ms ——authenticate—> CPVM ——for VNC console—>Hypervisor
> ^
> | gets images from CPVM
> web browser
>
> Which of the above components you want to keep and which to re
I believe Kishan suggested that you could change those Hidden config items
to Secure (an existing category), as Secure items are returned with the
listConfiguration API.
I don't know if you can do an in-place switch, or if the value has to be
encrypted first for it to work, but you should be able
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-217873032
We have the required code review and tests, I will add this to my merge
queue. Thx...
---
If your project is set up for it, you can reply to this email and have you
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503830
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -755,6 +755,16 @@ protected HypervisorType
getClusterToStartDomainRouterForOv
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503776
--- Diff: server/src/com/cloud/network/guru/GuestNetworkGuru.java ---
@@ -396,6 +396,16 @@ public NicProfile allocate(final Network network,
NicProfile n
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1246#discussion_r62503852
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1588,6 +1588,16 @@ protected StringBuilder
createGuestBoot
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1246#issuecomment-217875751
@SudharmaJain, I've added a few comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62505096
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java
---
@@ -21,7 +21,13 @@
import com.cloud.excepti
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62505426
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
boolean processDisconnect(long agentId, Status state);
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62505386
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
boolean processDisconnect(long agentId, Status state);
Erik Weber wrote:
> I believe Kishan suggested that you could change those Hidden config items
> to Secure (an existing category), as Secure items are returned with the
> listConfiguration API.
This is chicken and egg. I need the unencrypted values so I can decrypt
other payloads. I need the
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-217880689
Hi @koushik-das thanks for reviewing! Actually it took so long due to
setUpClass method, after that, test are really simple and quick. I
included 12 minutes sleep
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62508121
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -933,7 +937,7 @@ private PlugNicAnswer execute(Plug
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-217884184
The two failures are not ones I am used to seeing in my environment, but I
did a quick once through of the code and I don't think they problem is related
to this PR.
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62509667
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -18,40 +18,69 @@
*/
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62509977
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -65,22 +94,182 @@ public b
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62511172
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -91,18 +280,5 @@ public bo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217887345
I think this one is ready. The failures are things that periodically fail
in my environment and are unrelated to this code. Thanks...
---
If your project is set up
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62513240
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod,
final String serv
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-217889598
CI has come back clean. ð I will add this to my merge queue. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217890036
@mike-tutkowski I've reviewed the code and it LGTM. I have a few minor
comments that should be fairly simple to adress.
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217892225
This has the required code reviews. @mike-tutkowski have a look at the
comments @syed made. I will get this into my CI queue so we can get it moving
forward. Thanks
listConfiguration returns unencrypted values for Secure items, but they
need to be stored encrypted in the db.
You'd need to check If those values ever change, If they don't you may try
encrypting the value and change category to Secure
Erik
Den mandag 9. mai 2016 skrev Nathan Johnson følgende:
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62545797
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java
---
@@ -21,7 +21,13 @@
import com.clo
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62546243
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
boolean processDisconnect(long agentId, Status sta
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62546214
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
boolean processDisconnect(long agentId, Status sta
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-217944726
@rhtyd it looks like one of the OOBM smoke tests failed on the Travis
build. Could you please investigate?
---
If your project is set up for it, you can reply to
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62546959
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -933,7 +937,7 @@ private PlugNicAnswer ex
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62547042
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -18,40 +18,69 @@
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62547209
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -65,22 +94,182 @
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62548252
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod,
final S
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217947984
@syed Thanks for the code review!
@swill I believe we are good to go on this PR.
---
If your project is set up for it, you can reply to this email and hav
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62547345
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -91,18 +280,5 @@
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-217971133
@rafaelweingartner @jburwell Sorry for the late reply to this. I was on
vacation and returned today. I've decided to use John's approach for the
logging test as I feel
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217972386
@rhtyd Squashed. It is pending a LGTM. If you can have a quick look at this
one, it would be awesome!
---
If your project is set up for it, you can reply to this emai
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-217972968
@swill Sqashed. I believe this is good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62568855
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Softwa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62569193
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Softwa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62569447
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Softwa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62569864
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Softwa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62570445
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Softwa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62570751
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessResult.java ---
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62570929
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Softwa
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-217990022
Thanks @syed. I will get CI run against this. I see we have the required
code review, so I just need to get CI run. Thx...
---
If your project is set up for it, y
Pierre-Luc and WIll,
While testing and CI are important topics, there may be additional topics of
high importance to those attending the conference to discuss and work.
Therefore, I think it is a good idea to collect everyone’s thoughts to ensure
the priorities of all attendees are addressed.
?Hi,
I've seen this a couple times today.
Is this a known issue?
Results :
Tests in error:
NioTest.testConnection:152 » TestTimedOut test timed out after 6
milliseco...
Tests run: 200, Failures: 0, Errors: 1, Skipped: 13
[INFO] ---
Rohit, can you look into this.
It was first introduced in: https://github.com/apache/cloudstack/pull/1493
I thought the problem was fixed with this:
https://github.com/apache/cloudstack/pull/1534
Apparently we still have a problem. This is intermittently emitting false
negatives from what I can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218003768
Thanks @DaanHoogland. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-218004078
I will get this one into my CI queue. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-218004558
Thanks @koushik-das. I will run this through CI just to be sure everything
is good... Thx.
---
If your project is set up for it, you can reply to this email and hav
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218005270
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 38m 35s
```
**Associ
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218006600
I am missing one code review for this one. @nvazquez can you re-push to
kick off Travis again? Thx...
---
If your project is set up for it, you can reply to this e
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218007214
@nvazquez: strange, this did not run any tests. Any ideas on that one?
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced
smoke
while waiting to have hardware available on Apache infra,
I'd like to setup a jenkins master on cloud.ca for now so we can phase out
jenkins.buildacloud.org.
I'm setting up a new jenkins server and shoud we take that oportunirty to
change the URL?
By something like builds.cloudstack.org ? clouds
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218031267
Sure @swill I pushed again. I also ran again tests in my environment:
[root@ussarlabcsmgt41 cloudstack]# nosetests --with-marvin
--marvin-config=s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218033521
I am a bit confused why the attributes tag of `advanced` did not work in my
test and zero tests ran. I will look at that quickly tomorrow to see if there
is something
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-218043423
Thanks @koushik-das, @swill now that there are 2 LGTM can we have this
merged?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218047244
@swill As I had mentioned in my last comment, newly added tests are not
tagged. The command you used to run these tests has tags, don't pass any tags
in order t
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218047917
@koushik-das actually I've added tags, removed time.sleep and commented out
test_04
---
If your project is set up for it, you can reply to this email and have you
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-218048251
@swill The failures doesn't look related to this PR. This can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218048625
@nvazquez My bad, didn't look at the changes. Thanks for the fixing the
tests.
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218048949
No problem ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218051058
LGTM, ran the new tests.
Test listing Volumes using 'ids' parameter ... === TestName:
test_01_list_volumes | Status : SUCCESS ===
ok
Test listin
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-218052341
@koushik-das Will you be able to review this PR? It has been waiting for
2d LGTM for a while now.
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218052889
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 1
Duration: 9h 04m 44s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218053849
The one problem that is showing up in my CI does not appear to be related
to this PR, but this is the first time I have ever seen this error. If someone
else can con
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-218053964
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 41m 18s
```
**Associ
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-218054092
The CI is coming back clean for a general run. We still need code
reviews...
---
If your project is set up for it, you can reply to this email and have your
reply a
1 - 100 of 121 matches
Mail list logo
