GitHub user ntavares opened a pull request:
https://github.com/apache/cloudstack/pull/1535
Honour GS use_ext_dns and redundant VR VIP
This patch addresses two issues:
- On redundant VR setups, the primary resolver being handed out to
instances is the guest_ip (primary IP fo
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1535#discussion_r62417835
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -68,8 +68,11 @@ def get_domain(self):
def get_dns(self):
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217645439
logic makes sense, one remark about the code made. starting integration
tests on it.
---
If your project is set up for it, you can reply to this email and hav
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217645474
should this not go on 4.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217646390
one other concern; should the behaviour be more unified between regular vr
and vpc somehow? it diverting here, can we prevent that?
---
If your project is set
Github user ntavares commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1535#discussion_r62418187
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -68,8 +68,11 @@ def get_domain(self):
def get_dns(self):
Github user ntavares commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217647008
@DaanHoogland The patch is ported from 4.7 yes.
The whole VR and VPC should be unified anyway :-)) I noticed there is
CsGuestNetwork.get_dns() but we're n
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217648298
@ntavares are you saying this is already on 4.7 or on your own 4.7 branch?
If it is on 4.7 it should get to master automatically.
---
If your project is set u
Github user ntavares commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217649109
Ooops sorry about the confusion. It's on my own 4.7 branch. 4.7 is also
missing this, but I wasn't sure how to create the PR for it.
---
If your project is set u
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217650221
Ah, ok. Plese do make it to 4.7. It's the same way as to master except you
need to make some extra choices during creation. Create it on your fork of 4.7
and w
Github user ntavares commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217654248
I understand that, my question is which one of the 1000 branches is 4.7? :)
-NT
A Sáb, 7/05/2016, 18:38, Daan Hoogland escreveu:
> Ah, ok. Pl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217655251
:) the one with the name '4.7'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217697999
LGTM, tested on 4.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
13 matches
Mail list logo
