[GitHub] cloudstack pull request: Vmdk findbugs

2016-05-06 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: Vmdk findbugs

2016-05-06 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1530 Vmdk findbugs replacing #1351 You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs Alternatively y

[GitHub] cloudstack pull request: Vmdk findbugs

2016-05-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1530#issuecomment-217370549 @jburwell Even when out of scope, your comments may make sense. please send a pull request to my branch and we can discuss those. --- If your project is set u

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-06 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-217370720 Hi @mike-tutkowski, I trust you either addressed all my previous remarks, or have a good reason not to. I've skimmed (very quickly through the di

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

2016-05-06 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-217383124 Squashed and force pushed. Tasks remaining: - [ ] Pass CI - [ ] Situational testing on VPC RvR - [ ] Some automated tests Regarding the auto

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1532#discussion_r62303317 --- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java --- @@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid) {

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-06 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1532#discussion_r62303518 --- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java --- @@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid) {

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-06 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-217392996 @DaanHoogland yes, the line `CsHelper.service("dnsmasq", "restart")` in `set_master` is in systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py. When a ba

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

2016-05-06 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-217397801 Looks like the build environment isn't sufficient on jenkins-test-a20: ``` [ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Insufficient space for sha

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread sverrirab
Github user sverrirab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62309904 --- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py --- @@ -0,0 +1,80 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-05-06 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-217407342 @rhtyd Is single NAT client is not working for you ? Multiple clients at the same time from single NATed public ip will not work. Single nat client (w

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-217410505 @jayapalu I've tried the client only one by one, one at a time. To share my environment, I'm on a 192.168.0.0/16 network from where all my clients try to connect to th

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217413162 @swill this PR is ready for CI test run and merge, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217413190 @swill this PR is ready for CI test run and merge, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217413262 @swill this PR is ready for CI test run and merge, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1531#issuecomment-217413238 @swill this PR is ready for CI test run and merge, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread borisstoyanov
Github user borisstoyanov commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217414515 I've just run final sanity tests on this PR, all the OOBM features are working and did not observed any side effects, so I'm happy with the latest changes get

Re: Any difference with the official rpms and the git 4.8 branch?

2016-05-06 Thread Linas Žilinskas
Ok, nevermind. I think I messed up something in the process of setting up my dev env. From what I saw, i probably ran the jetty instance with default configs which do not use encryption. Then later I probably launched the instance from packages, which used encryption and then the confusion occurre

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62321148 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java --- @@ -0,0 +1,128 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62321576 --- Diff: api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java --- @@ -0,0 +1,51 @@ +// Licensed to the Apache Softwar

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62321858 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -251,8 +262,9 @@ public boolean start() { } private void init(Ma

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62321963 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -412,6 +428,36 @@ protected void runInContext() { } } +

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62321985 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -412,6 +428,36 @@ protected void runInContext() { } } +

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62322259 --- Diff: server/test/com/cloud/resource/MockResourceManagerImpl.java --- @@ -172,6 +173,12 @@ public Cluster getCluster(final Long clusterId) {

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62322543 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Softwa

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62322683 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Softwa

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62325553 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Softwa

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62325927 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Softwa

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217434570 @rhtyd @swill we are very close. I have a couple of outstanding comments -- particularly around potential thread explosion in ``ProcessRunner``. Ultimately, I th

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-06 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-217437287 Thanks for your time on the review, @miguelaferreira! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62328214 --- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py --- @@ -0,0 +1,80 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62328413 --- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py --- @@ -0,0 +1,80 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62328643 --- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py --- @@ -0,0 +1,142 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62328994 --- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py --- @@ -0,0 +1,142 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62328978 --- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py --- @@ -0,0 +1,142 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62329185 --- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py --- @@ -0,0 +1,142 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1514#discussion_r62329838 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py --- @@ -54,7 +54,8 @@ def process(self): self.cloud.commit()

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217442413 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Vmdk findbugs

2016-05-06 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1530#issuecomment-217442913 @DaanHoogland I am having surgery this afternoon, so I will be unable to get it to it today (6 May 2016). I will try to put together a PR later this weekend or ea

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1472#discussion_r62331395 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsStaticRoutes.py --- @@ -0,0 +1,42 @@ +#!/usr/bin/python +# -- coding: utf-8 -- +

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-06 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217450750 @rhtyd @swill LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-06 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-217451440 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1532#discussion_r62335611 --- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java --- @@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid) {

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r62336941 --- Diff: server/src/com/cloud/user/AccountManager.java --- @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s public static

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r62337130 --- Diff: server/test/com/cloud/user/MockAccountManagerImpl.java --- @@ -401,5 +403,24 @@ public Long finalyzeAccountId(String accountName, Long domainI

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r62337077 --- Diff: server/test/com/cloud/user/MockAccountManagerImpl.java --- @@ -401,5 +403,24 @@ public Long finalyzeAccountId(String accountName, Long domainI

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r62337172 --- Diff: server/test/com/cloud/user/MockAccountManagerImpl.java --- @@ -401,5 +403,24 @@ public Long finalyzeAccountId(String accountName, Long domainI

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217456452 I will get this CI'ed. I have 4 new CI boxes in play now, but I am trying to figure out how to stabilize master, so I will run this as soon as I get master sorted ou

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-05-06 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r62336714 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java --- @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundati

Re: Number of NICs in VMWare - CS 4.6 bug?

2016-05-06 Thread Octavian Popescu
Adding a bit to this – it looks like it’s a documented bug, fixed in CS-25155 but unfortunately I couldn’t really find much about the fix other than vague references, any ideas how I could track it down? Thanks, Octavian On 06/05/2016 10:28, "Octavian Popescu" mailto:octavian.pope...@interoute

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-217460449 Can I get one more code review on this one? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-06 Thread dsclose
Github user dsclose commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1514#discussion_r62344011 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py --- @@ -54,7 +54,8 @@ def process(self): self.cloud.commit()

[GitHub] cloudstack pull request: When no zone name is available display a ...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-217471150 Unless someone is able to verify this, I think we have to take the screenshots from @remibergsma as verification. Not very many people have the ability to test regio

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-217471716 Can you do a force push again. Jenkins has been in this state for 3 days now. Thx... --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-217471764 Can you do a force push again. Jenkins has been in this state for 3 days now. Thx... --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-217472184 Can you force push again to get the jobs to kick off again. thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-217475012 Can we get another code review on this? Also, Jenkins seems to be hung, can we either close and reopen the PR or do a force push to kick it off? Thx... --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-217479698 Can we get another code review on this one. Also, can you force push to kick off Jenkins again? Thx... --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9199: Fixed deployVirtualMachi...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-217480884 @anshul1886 can you answer @rhtyd's question so we can get his code review and get this moving forward. Thanks... --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-217481732 @jburwell can I get your final review on this? I think we are probably pretty close on this one. Thanks... --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-06 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217482136 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-217482470 @remibergsma can you squash this and re-push. I need one more code review on this one and we should be ready to merge it. Thanks... --- If your project is set up f

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-06 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1532#discussion_r62349471 --- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java --- @@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid) {

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-06 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-217485432 We have rolled this patch in our lab and verified that it does indeed report the number of sockets correctly. Based on testing this LGTM. Please do a force

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

2016-05-06 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-217489945 I rebased against the latest 4.7 before force pushing. Has an error been introduced along the way? --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

2016-05-06 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-217490305 Same error over at #1519 - something introduced in an earlier commit? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-217491038 There is an issue currently on master which I am trying to get sorted out, but there should not be a problem on `4.7`. It looks like Jenkins may be out of diskspace

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

2016-05-06 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-217495575 @swill ok, thanks, good luck with the master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: zip the processed json files so we save d...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-217497179 any suggestions for how to test this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-06 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-217499701 @koushik-das @rhtyd I finished writing marvin test for this feature, I copy my test results: [root@ussarlabcsmgt41 cloudstack]# nosetests --with-m

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217500553 Thanks @swill as soon as we can merge this one, I can rebase and use some of the annotations work and ListUtils from this PR into out-of-band management PR /cc @jburw

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217501592 @jburwell thanks, I'll sort them out. Meanwhile, if we can get the dynamic-roles PR merged today/tomorrow, I can use the annotations/validation usage in APIs and furt

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1531#issuecomment-217502707 how do I test this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1531#issuecomment-217504212 @swill you can use this PR on a branch and build systemvm templates. I've updated the README on how you can setup an environment to build yourself systemvmtemplates a

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-06 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r62360949 --- Diff: tools/appliance/build.sh --- @@ -529,8 +534,6 @@ function vmware_export() { stage_vmx ${appliance_build_name}-vmware ${appliance_build_n

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-06 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r62360986 --- Diff: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh --- @@ -19,7 +19,7 @@ set -e set -x -CLOUDSTACK_R

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-06 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r62361025 --- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb --- @@ -27,15 +27,15 @@ architectures = { :i386 => { :os_typ

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1531#issuecomment-217506509 Here is a build log to prove that build succeeds using a Ubuntu 16.04 slave box with VirtualBox 5.0: [systemvmtemplate-build-consoleText.txt](https://github.

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-217507357 LGTM (code review) tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217507957 LGTM (code review only) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217513880 Ok, I will get CI run against this one to make sure that nothing else is broken. This is ready pending the CI run... --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-217514394 I am comfortable not running CI on this one given the scope of the change and the manual tests that have been run. This one is ready now. We need this force pushed

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217515255 Both this one and dynamic roles are queued up for CI as soon as I stabilize master. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217519767 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 4h 31m 04s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217521378 I am not concerned about the two failures. One happens randomly in my environment and one is a cleanup issue between test runs which is not related to this PR.

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Optimize NioTest and Nio...

2016-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-05-06 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-217537499 @swill done ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-06 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-217552585 So, Si (@kiwiflyer) and I have been testing this functionality against VPCs in our lab and we verified that static routes are indeed loaded when a VR goes from BACKU

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-217560805 I hadn't looked into the code yet so for what it's worth and pending response to the comments: CI RESULTS [1533.results.internal_lb.txt](https://github

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-217566881 @DaanHoogland can you post a 'summary' of the results when you post this. I don't want to have to download each of these files to know that they ran successfully. C

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-217567369 I am missing some code review on this one, but otherwise this is looking good so far. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-217569401 Sorry Will, Yes all passed, some after retest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-217605326 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 8h 49m 25s ``` **Associ

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-217605374 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 1 Duration: 10h 26m 38s ``` **Summary of the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217606318 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 6h 07m 49s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217606327 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 6h 11m 18s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9199: Fixed deployVirtualMachi...

2016-05-06 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-217610090 @rhtyd @swill There will not be backward compatibility issues as with static offering those parameters were not taken into consideration. They were wrongly givin

hidden configuration items

2016-05-06 Thread Nathan Johnson
If you hit the /client/console endpoint with a vmid, it sends you back some data that contains a link to a the console proxy VM and passes an encrypted json payload that has the user, password and port for a vnc connection. Normally this is meant to load in an iframe. We want to decrypt thi