Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217091053
I think `/test/integration/plugins/solidfire` is a good place to keep the
integration tests. I wouldn't disable or skip them because, IMH, it's not hard
to s
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-217094836
I'd appreciate it if someone else could do it, I do not have the setup to
perform more advanced github operations right now, other than the UI.
---
If your project i
Hello.
We're planning on setting up a local repo for our CS where we would store our
customized builds.
I just wanted to clear up some things.
Currently when editing CS code and testing changes I use jetty. I noticed a
couple of differences compared to our test cluster, where the whole setup is
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-217105794
@rhtyd @swill
The branch has been re-based against master and also squashed multiple
commits to a single.
---
If your project is set up for it, you can repl
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217110131
Currently I'm investigating @ustcweizhou suggestions above. He's quite
correct about not adding the mark for eth0 and I think I've reproduced the
problem he reporte
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-217117011
@jayapalu I appreciate if you can resolve some of the outstanding issues,
and testing efforts -- I hope to see this feature merged before the freeze date
this month, i
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-217118554
@jburwell @wido @agneya2001 @remibergsma @DaanHoogland @nvazquez @nlivens
@resmo @swill and others -- please help review and test this
---
If your project is set up f
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r62172310
--- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf ---
@@ -30,4 +35,5 @@ conn L2TP-PSK
# --
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r62172409
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -542,11 +552,11 @@ def configure_ipsec(self, obj):
secret.commit(
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62173232
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigCmd.java ---
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software Foundation
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62173792
--- Diff: api/src/org/apache/cloudstack/usage/UsageTypes.java ---
@@ -42,6 +42,7 @@
public static final int VM_DISK_BYTES_READ = 23;
publi
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62173816
--- Diff: client/WEB-INF/classes/resources/messages.properties ---
@@ -2260,3 +2260,29 @@
message.configure.firewall.rules.allow.traffic=Configure the rule
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62173874
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -485,6 +485,10 @@ updateVPCOffering=1
deleteVPCOffering=1
listVPCOfferings=15
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-217129543
I testing this using these templates I built with changes from this PR on
master: https://packages.shapeblue.com/systemvmtemplate/custom/strongswanvpn/
---
If your pr
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-217132104
Tested locally on Ubuntu Linux 16.04, had to install some build
dependencies as README suggests to get pyenv installed. LGTM
@swill ready for merge
---
If y
All,
In advance of the CCNA16 Hackathon on Wednesday, 1 June 2016, it seems like it
would be wise to organize the topics which people are interested in addressing.
My thought is anyone may suggest a topic and/or register their interest in a
topic. Also, since there will likely be a number of
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217188537
Is there a reason we need to spend 5 minutes waiting for this test every
build?
---
If your project is set up for it, you can reply to this email and have your
repl
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217188135
@rhtyd I am still having problems with the tests in this PR, but now it is
in master.
This is causing builds to fail...
```
testConnection(com.cl
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62207228
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase;
-import
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62207167
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase;
-import
Hey John,
Thanks for the initiative. We will be focusing the hackathon mainly around
testing. I will be setting up full environments for the teams to work with
and those details will be made available on the day of the hackathon.
I think it is a good idea to have a general theme for the hackatho
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62219725
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase;
-import
Thanks John for that initiative.
Good idea to start organizing teams and topics since we won't have much
time on site. As Will said the main theme would be around CI, and we are
working to get enought hardware and ressource so all teams could have their
own setup...
Cheers,
PL
On Thu, May 5, 2
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217220334
@rhtyd but `totalTestCount = 5` and I don't think that `completedTestCount`
will ever be larger than `4`, so I don't know how that check could be right...
---
If you
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1534
CLOUDSTACK-9348: Optimize NioTest and NioConnection main loop
- Reduces SSL handshake timeout to 15s, previously this was only 10s in
commit debfcdef788ce0d51be06db0ef10f6815f9b563b
- Ad
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217226167
@swill I've ran my tests, please review and merge this --
https://github.com/apache/cloudstack/pull/1534
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1534#issuecomment-217226501
@DaanHoogland @jburwell @wido @swill and others -- please review, this
mainly fixes the NioTest which was failing so if it's okay and works for Travis
and Will's CI l
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217226582
@miguelaferreira I went ahead and added four integration tests to
/test/integration/plugins/solidfire.
Please let me know if you're OK with the PR. I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217227191
In my lasts run, not a single test passed in the time frame something is
wrong. Previously it was failing on 4/5, but this time it timed out without a
single test pa
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217227342
Thanks, will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217225573
@swill I'm pushing a fix for you.
The initial value is 0, as clients send data it's incremented by 1. At the
end it's expected that total number of data sent match
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-217228739
@jburwell Just wanted to point out that an earlier PR of mine, #816, has
four Marvin integration tests (three out of four of those apply to this PR,
too). I
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-217228903
@jburwell Just wanted to point out that an earlier PR of mine, #816, has
four Marvin integration tests (three out of four of those apply to this PR,
too). I
Just in case people are looking for a place to stay in Montreal.
A friend of mine has a place to rent downtown.
https://www.facebook.com/Chickie9/media_set?set=a.10153713527700033.1073741837.614030032&type=3
--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
sk
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217252920
@rhtyd I have some bad news on this PR. I have been having issues in CI
ever since this got merged into master. When the tests don't run (and fail
which causes the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-217264750
@rhtyd we have merge conflicts. can you fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217268926
Thank you for working on fixing this. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-217269248
Can you do a force push to kick of Jenkins again. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1528#issuecomment-217269826
Thanks @mike-tutkowski. I will run CI against this one just to be sure we
did not break anything...
---
If your project is set up for it, you can reply to this emai
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217270975
@swill sure thanks, please try with PR #1534 and if you still hit the
issue, please revert the commit locally first; run against your environment and
confirm that you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-217271201
So is this going to be another reason Travis fails randomly? :( If we
know it is going to fail randomly, we probably want to remove it from the
Travis tests to make
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217272766
I confirmed that reverting this PR locally does fix my DeployDatacenter
issues.
I did an initial test with #1534 and it did get past the DeployDatacenter
pha
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1534#issuecomment-217278185
Well the test runs a lot faster/cleaner now. ð
```
Running com.cloud.utils.testcase.NioTest
2016-05-05 22:53:54,828 INFO [utils.testcase.NioTest]
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217279039
That worked a treat. The suggestions made by @ustcweizhou resulted in a
very clean set of IP rules and I was able to add IPs on eth4 and eth5 without
breaking the r
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217286830
@swill the NioTest is a unit test and will only run during compilation. If
you hit any issues, feel free to revert the commit with some details on how I
may be able t
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1534#issuecomment-217287468
@swill thanks for sharing, I made the NioConnection's main IO loop
aggressive and reduced the SSL handshake timeout to 15s (this was previously
10s, but over last yea
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-217289669
We'll be pulling this one in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217290619
Has anyone tested this with VPC VRs as of yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217290925
@kiwiflyer I have not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-217318995
@swill I've added a Travis specific change and Travis specific patched
ipmitool version (using patch from
https://bugzilla.redhat.com/show_bug.cgi?id=1286035), I'm ho
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-217319127
OK. Sounds good. :) Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217321289
I ran this in our lab and tested the failover and works as expected. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217322125
@Slair1 is that confirmation that this code worked for you? It is a bit
unclear what you were communicating. Thx.
---
If your project is set up for it, you can rep
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-217322431
I know it doesn't really need my LGTM, but this commit definitely improves
the accuracy, and possibly the performance, of marvin and I'd personally like
to see this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-217323925
@dmabry thank you. This type of feedback is very useful for me (as the RM)
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282416
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) throw
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282456
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) throw
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282499
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282559
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -144,10 +151,12 @@ public String getAdapterType() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -216,10 +226,12 @@ public String getAdapterType() {
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217338822
@swill it is confirmation the code worked for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217341007
@Slair1 perfect, thanks for confirming. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r62286863
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -542,11 +552,11 @@ def configure_ipsec(self, obj):
secret.comm
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-217343619
@swill rebased against latest master and pushed
@borisstoyanov can you help test this one last time, I think all major
issues including ordering related issues hav
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-217343777
@rhtyd
Except rebase nothing pending from my side. If you look at the my comments
on Dec 29, 2015 I have already posted my test results. Please review and give
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-217344487
@jayapalu I spent several hours testing this PR, my conclusion is that it
cannot be used for production usage yet and need more tweaking;
- We should consider
66 matches
Mail list logo
