[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...

2016-05-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-216030450 This time around Jenkins is happy and Travis times out :-s ``` No output has been received in the last 10m0s, this potentially indicates a stalled build

[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...

2016-05-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-216030504 Force pushed a final time, else I give up on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-216030568 Also force pushed this one again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: zip the processed json files so we save d...

2016-05-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-216030620 Force pushed again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Will Stevens
Yep. Looking like there is a bug in that file. Thanks for testing. :) On May 1, 2016 1:40 AM, "Tutkowski, Mike" wrote: > Here are my tests (run from http://ideone.com/). > > The short story is that having multiple methods with the same name (even > if one is an instance method and one is a class

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Tutkowski, Mike
The question then becomes, do we want to keep the instance or the class method? There exists the same problem for at least one other pair of methods. Since the class method is listed second in the file currently, it is the only one of the two that can be utilized. That being the case, we might j

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Tutkowski, Mike
However, from a design standpoint, I prefer the instance method here as it would be nice to ask the object itself to place itself in maintenance mode. So, it's really a question of just staying backward compatible (the class method) or a possibly better design (the instance method).

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Will Stevens
It will be easy to grep if there class methods, so we should start there. If not, then I agree that an instance method is probably the best way to go. On May 1, 2016 12:41 PM, "Tutkowski, Mike" wrote: > However, from a design standpoint, I prefer the instance method here as it > would be nice to

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Tutkowski, Mike
I was just "concerned" that those who have their own Marvin tests that are not checked in might be broken if I don't keep the class method. From: Will Stevens Sent: Sunday, May 1, 2016 12:03 PM To: dev@cloudstack.apache.org Subject: Re: Python Question (wi

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Will Stevens
Ya. Let's see how prevalent the class method is to start with and we will cross that bridge after. On May 1, 2016 2:07 PM, "Tutkowski, Mike" wrote: > I was just "concerned" that those who have their own Marvin tests that are > not checked in might be broken if I don't keep the class method. > ___

[GitHub] cloudstack pull request: Status of tests

2016-05-01 Thread swill
GitHub user swill opened a pull request: https://github.com/apache/cloudstack/pull/1525 Status of tests This PR is not meant to be merged, but instead be able to give a point in time status of our current tests (on KVM). I have just finished a 3 day run of all of our tests

[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...

2016-05-01 Thread remibergsma
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...

2016-05-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-216064935 @kiwiflyer Sorry but this seems to have issues. We run this in prod with Cosmic but apparently some other patch is missing here in order for this to work proper

[GitHub] cloudstack pull request: Status of tests

2016-05-01 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1525#issuecomment-216065039 And now for the files... **Associated Uploads** **`/tmp/MarvinLogs/2MVR8P:`** * [failed_plus_exceptions.txt](https://objects-east.

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

2016-05-01 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216070253 @cristofolini that would not be that simple, there is userDataApplied variable which is extern to the loop. It would be better to turn lines 2496-2515

[GitHub] cloudstack pull request: CLOUDSTACK-9040: Use Tomcat6 for Debian p...

2016-05-01 Thread ymolinet
Github user ymolinet commented on the pull request: https://github.com/apache/cloudstack/pull/1040#issuecomment-216074096 Hi, I'm trying to install CloudStack on Debian 8. it's necessary to add lsb-release in dependencies for the system detection during installation. E

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-01 Thread cristofolini
Github user cristofolini commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61694862 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +154,79 @@ public void testSta

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Tutkowski, Mike
So, the problem exists with both enableMaintenance and cancelMaintenance for hosts and with enableMaintenance for storage (not with cancelMaintenance for storage). A bunch of UI scripts use those class methods (I didn't see us trying to use the instance methods anywhere). I believe those class

Re: Python Question (with regards to Marvin)

2016-05-01 Thread Tutkowski, Mike
"A bunch of UI scripts use those class methods (I didn't see us trying to use the instance methods anywhere)." I meant that a bunch of test scripts use those methods (not UI scripts). > On May 1, 2016, at 5:24 PM, Tutkowski, Mike wrote: > > So, the problem exists with both enableMaintenance an