[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2016-04-22 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-213298570 @swill I don't exactly know how to test this with CI. I verified it with the test script I created. Don't know how we can automate this in CI. --- If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-213327217 @jburwell @GabrielBrascher @rafaelweingartner @swill if you're done with review, LGTM please or share what else should be fixed. Thanks. --- If your project is s

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-213328879 @jburwell @swill @DaanHoogland @pdube @koushik-das @pdube please share your LGTM if you're satisfied with the changes, or please comment what else needs fixing. Th

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-213329597 @GabrielBrascher @swill @jburwell @rafaelweingartner please share your LGTM or comment what needs fixing, thanks. --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-213331800 @wido we'll need to fix codebase wide mysqldb usage in python scripts and build both rpms/deb to show installation, setting up of db and setting up mgmt server wor

[GitHub] cloudstack pull request: L10n update master 20160127

2016-04-22 Thread milamberspace
Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1376#discussion_r60708800 --- Diff: tools/transifex/.tx/config --- @@ -89,3 +89,41 @@ trans.pt_BR = work-dir/messages_pt_BR.properties trans.ru_RU = work-dir/messages_ru

[GitHub] cloudstack pull request: L10n update master 20160127

2016-04-22 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-213336322 @swill Re-push-force is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread dsclose
GitHub user dsclose opened a pull request: https://github.com/apache/cloudstack/pull/1509 CLOUDSTACK-6975: Prevent dnsmasq from starting on backup RvR CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this is no-longer accurate, as service monitoring is not active

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1509#issuecomment-213345085 LGTM, tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60716681 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java --- @@ -0,0 +1,116 @@ +// L

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60716885 --- Diff: client/tomcatconf/commands.properties.in --- @@ -799,3 +799,14 @@ quotaCredits=1 quotaEmailTemplateList=1 quotaEmailTemplateUpdate=1

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213375165 Pinging for review @jburwell @swill @wido @pyr @koushik-das @agneya2001 @DaanHoogland @rafaelweingartner @GabrielBrascher @kishankavala --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60725627 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java --- @@ -0,0 +1,107 @@ +

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60726125 --- Diff: api/src/org/apache/cloudstack/api/response/ZoneResponse.java --- @@ -233,6 +234,9 @@ public void addTag(ResourceTagResponse tag) {

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-22 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-213389763 @swill this is completely a LGTM :) We have this working on CS 4.8 in production. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213391362 I did an one hour code review and found nothing that will make me :-1: it so; LGTM @swill I will however start integration tests and find more time as the siz

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60727764 --- Diff: api/src/org/apache/cloudstack/api/response/ZoneResponse.java --- @@ -233,6 +234,9 @@ public void addTag(ResourceTagResponse tag) { }

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213395335 @DaanHoogland thanks, @borisstoyanov will share QA results next week as well --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213395917 ### ACS CI BVT Run **Sumarry:** Build Number 3 Hypervisor xenserver NetworkType Advanced Passed=69 Failed=19 Skipped=3 _L

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

2016-04-22 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1510 4.9 mvn version safeupgradeonly Upgrades maven dependencies versions that can be safely upgraded without breaking console-proxy/crypto usage. Bisected changes from: https://github.com

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-213397292 @swill closing this PR, opened two new PRs that split changes from this PR --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-04-22 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1397 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: 4.9 bountycastle daan

2016-04-22 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1511 4.9 bountycastle daan This PR adds bountycastle related version and code fixes from @DaanHoogland on top of https://github.com/apache/cloudstack/pull/1510 I could not fix java compila

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-213398409 With this change we would be able to use JDK8 for building cloudstack once we fix the build issues of F5 plugin (that's the only component that fails to build with

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-213407542 I need one more LGTM code review on this one. I will try to test this in my lab today. Thanks... --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1417#issuecomment-213408951 I need one more LGTM code review on this one. I will try to test this in my lab today. Can you do a force push of this PR again to kick off jenkins so we can get th

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60732469 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() { @

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-213413569 @wido I just want to verify that the standard CI run does not have any issues. However, @bhaisaab does bring up some good points. We should try to fix this everywhe

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60732532 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,138 @@ public boolean supportsRollingUpgrade() { @

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60732582 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() { @

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60732671 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() { @

[GitHub] cloudstack pull request: L10n update 4.8 20160127

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1375#issuecomment-213415473 @milamberspace can you close and reopen this against the 4.8 branch. It is currently opened against master. Thanks... --- If your project is set up for it, you can

[GitHub] cloudstack pull request: L10n update master 20160127

2016-04-22 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1376#discussion_r60733737 --- Diff: tools/transifex/.tx/config --- @@ -89,3 +89,41 @@ trans.pt_BR = work-dir/messages_pt_BR.properties trans.ru_RU = work-dir/messages_ru_RU.prop

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1509#issuecomment-213419572 @dsclose this PR is currently opened against `apache:4.7.1-RC20160120T2318`. Should this be merged into 4.7 and then we will forward merge it to 4.8 and master?

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-213421066 Ok, perfect. Thanks @footplus for confirming. :) @anshul1886, I just need this PR to be force pushed to kick off jenkins again to get everything green so we

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213421943 Thanks guys. I will try to get this one queued up for CI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213422548 I am a bit concerned about this CI run. There is a LOT failing which does not usually fail. We will need to review the CI results and try to understand/fix the probl

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213423589 Really exciting PR @bhaisaab! We'll pull this in for testing as well. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213424108 @swill This is because of a problem with the CI environment. i will fix this and post the results again. Will remove these results for now. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

2016-04-22 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/1417#issuecomment-213424673 @swill thanks for comment , i just did a force push --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60737225 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java --- @@ -119,6 +131,9 @@ private Long getDoma

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60737450 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java --- @@ -131,7 +135,9 @@ private void createClo

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213428079 @insom Thanks for the PR. We'll pull this in for testing as we use vxlan. As it looks like this bug was introduced in 4.8, I'd suggest you may want to iss

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60738403 --- Diff: scripts/util/migrate-dynamicroles.py --- @@ -0,0 +1,134 @@ +#!/usr/bin/python +# -*- coding: utf-8 -*- +# Licensed to the Apache So

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60738644 --- Diff: scripts/util/migrate-dynamicroles.py --- @@ -0,0 +1,134 @@ +#!/usr/bin/python +# -*- coding: utf-8 -*- +# Licensed to the Apache So

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-213430064 @bvbharatk no problem. :) Thanks for the continued effort testing. I just wanted to make sure we understood what was going on. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60738990 --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java --- @@ -92,6 +94,55 @@ public void handle(final DispatchTask task) { pro

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213431039 @kiwiflyer if you wouldn't mind posting the results of your tests that would be appreciated. :) @insom if this was actually introduced in 4.8, I agree that w

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213431813 @swill Thanks! Should I rebase this against the latest 4.8 branch then? I don't think I can change where a PR is based against, so I think I'd need to open a new PR -

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213434581 @insom Yes, rebase it against the 4.8 branch and yes you'll need to issue a new PR and close this one. --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r60740846 --- Diff: services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/TestAppender.java --- @@ -0,0 +1,173 @@ +/* +* Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1509#issuecomment-213437832 @swill I raised the PR against `apache:4.7.1-RC20160120T2318` because it seemed sensible to include it in the latest 4.7 branch. I'd assumed it could be forward mer

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-213438660 Thanks for all the effort @bhaisaab. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r60742145 --- Diff: services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/TestAppender.java --- @@ -0,0 +1,173 @@ +/* +* Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213439120 @insom, yes @kiwiflyer is correct. You will need to base your change off the 4.8 branch and close this PR and open a new PR based off the 4.8 branch. Thanks for the

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r60742612 --- Diff: services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResourceTest.java --- @@ -18,91 +18,68 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/1512 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations (4.8) From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): > https://github.com/apac

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom closed the pull request at: https://github.com/apache/cloudstack/pull/1508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1508#issuecomment-213441018 #1512 is the new version of this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60743595 --- Diff: server/src/org/apache/cloudstack/acl/RoleManagerImpl.java --- @@ -0,0 +1,273 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1509#issuecomment-213442284 Lets close this PR and open it based off the 4.7 branch. @ustcweizhou's LGTM vote will still count on the new PR. Lets just reference this PR in the new PR so we re

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60743961 --- Diff: server/src/org/apache/cloudstack/acl/RoleManagerImpl.java --- @@ -0,0 +1,273 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60744168 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1512#issuecomment-213443134 You opened it against master again... ![image](https://cloud.githubusercontent.com/assets/13644/14743978/7e8dbfd6-0872-11e6-83bc-73ebe2699a9c.png) --- If

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60744528 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60744698 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60744675 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60744764 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60744905 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60745471 --- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java --- @@ -34,6 +34,10 @@ public class PropertiesUtil { private static final

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/1513 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations (4.8-2) From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): > https://github.com/ap

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

2016-04-22 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-213448269 I have made changes as per @pavanb018's comments and tested it on my environment. Following are the test results: Test restart network with cleanup ... ===

RE: [GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread Richard Klein (RSI)
First time poster to the development mailing list so greetings everyone. We ran across this issue in our environment as well (CentOS 7 with KVM) with CS 4.7.0. The problem appeared to use as a behavior of libvirt because we could reproduce the error independent of CS by manually creating a VM

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread dsclose
GitHub user dsclose opened a pull request: https://github.com/apache/cloudstack/pull/1514 CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR Rebase of PR #1509 against the 4.7 branch as requested by @swill One LGTM from @ustcweizhou carried from previous

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread dsclose
Github user dsclose closed the pull request at: https://github.com/apache/cloudstack/pull/1509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1509#issuecomment-213465470 Rebased off of 4.7 branch and opened PR #1514 - closing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1509#issuecomment-213467207 @swill and thank you for you're support - much appreciated :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-04-22 Thread insom
Github user insom closed the pull request at: https://github.com/apache/cloudstack/pull/1512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-213479837 ## CI RESULTS ### 120/120 TESTS PASSED! View the results below... **Associated Uploads** **`/tmp/Marvi

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-04-22 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-213486309 @dsclose would it be possible for you to enhance ``test/ntegration/component/test_redundant_router_services.py`` to verify that dnsmasq is only running on the mast

CaaS in CloudStack with Kubernetes

2016-04-22 Thread Sebastien Goasguen
Hi folks, I have been quite silent this past few weeks because aside from voting in a new VP (soon to be announced), I have been hard at work for my new endeavors with Skippbox. I am quite excited that today we could not wait and Skippbox together with Shapeblue announced a preview of a Kuber

[GitHub] cloudstack pull request: L10n update 4.8 20160422

2016-04-22 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1515 L10n update 4.8 20160422 @swill the good PR for 4.8 branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack

[GitHub] cloudstack pull request: L10n update 4.8 20160127

2016-04-22 Thread milamberspace
Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/1375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cloudstack pull request: L10n update 4.8 20160127

2016-04-22 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1375#issuecomment-213496639 Close, replace by #1515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60771374 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java --- @@ -119,6 +131,9 @@ private Long getDoma

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60771393 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java --- @@ -131,7 +135,9 @@ private void createClo

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60771659 --- Diff: scripts/util/migrate-dynamicroles.py --- @@ -0,0 +1,134 @@ +#!/usr/bin/python +# -*- coding: utf-8 -*- +# Licensed to the Apache So

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60771928 --- Diff: scripts/util/migrate-dynamicroles.py --- @@ -0,0 +1,134 @@ +#!/usr/bin/python +# -*- coding: utf-8 -*- +# Licensed to the Apache So

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60772392 --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java --- @@ -92,6 +94,55 @@ public void handle(final DispatchTask task) { pro

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60772677 --- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java --- @@ -34,6 +34,10 @@ public class PropertiesUtil { private static final

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60772858 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,138 @@ public boolean supportsRollingUpgrade() { @

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213520037 Thanks @swill @kiwiflyer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-04-22 Thread sudhansu7
GitHub user sudhansu7 opened a pull request: https://github.com/apache/cloudstack/pull/1516 CLOUDSTACK-9366: Capacity of one zone-wide primary storage ignored Disable and Remove Host operation disables the primary storage capacity. Steps to replicate: Base Condition: The

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

2016-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-213521104 @swill please include this PR in your list, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Here goes nothing... :)

2016-04-22 Thread Will Stevens
​In an effort to figure out which tests are working and which are not and to start compiling a list of tests with issues I have written a small python script which auto discovers and categorizes the tests in the 'smoke' and 'component' directories. This will be interesting: # HARDWARE REQUIRED ec

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-213540008 @bhaisaab yep, already got it. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

2016-04-22 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-213558371 @bhaisaab @swill it is important to note that Spring 3 only supports running JDK8 for applications built using a target version of 1.7. Applications built using S

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

2016-04-22 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/713#discussion_r60792255 --- Diff: test/integration/component/maint/test_ha_pool_maintenance.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/env python +# Licensed to the Apache Softwar

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

2016-04-22 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-213565364 I think this one is ready unless anyone has any final words... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-22 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60801905 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java --- @@ -119,6 +131,9 @@ private Long getDoma

  1   2   >