Re: [DISCUSS] Emeritus Committer Status

On Tue, Apr 19, 2016 at 11:42 PM, John Burwell wrote: > All, > > As I am sure many have observed, we have a large number of committers [1] > who are no longer active. Currently, we no status that continues to > recognize someone’s committer merit while allowing them to declare inactive > in the

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60365855 --- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java --- @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [WIP] Don't start review yet -- CLOUDSTAC...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1502 [WIP] Don't start review yet -- CLOUDSTACK-9299: Out-of-band Management for CloudStack Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, DRAC, etc.) to manage

[GitHub] cloudstack pull request: L10n update master 20160127

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-212324488 @swill I've just rebase from master, update the L10N files and push --force this PR. cc @koushik-das --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: L10n update 4.8 20160127

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1375#issuecomment-212325281 @swill I've just rebase from 4.8 branch update the L10N files and push --force this PR. The PR #1376 is not linked with this PR. cc @koushik-das

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60368615 --- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java --- @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-212325393 @swill I've just rebase from 4.7 update the L10N files and push --force this PR. cc @koushik-das --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60369373 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60369577 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60369930 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

Github user priyankparihar commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r60372700 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2030,12 +2030,29 @@ int getReservedCpuM

[GitHub] cloudstack pull request: [WIP] Don't start review yet -- CLOUDSTAC...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-212338195 Local test results (the feature is hypervisor agnostic, integration test also run with Travis as well): Marvin Init Successful === TestName:

RE: CloudStack Logging

Hi Simon, My gut says that it's probably not worth going back before 4.3. There have been large changes since then but I think that it's better to get as much data as possible, limiting to 4.6+ might not give a particularly large install base. Kind regards, Paul Angus Regards, Paul Angus

[GitHub] cloudstack pull request: [WIP] Don't start review yet -- CLOUDSTAC...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-212340052 UI Screenshots; 

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-212360074 @pedro-martins On line 503, It is not a function but It is a way to define callback method. It has been used all over the cloudstack code. On line 504, contex

Re: [DISCUSS] Emeritus Committer Status

Erik, Good question about the mechanics. I agree that removal of accounts would not be correct. It should only be the removal/suspension of the CloudStack commit bit and karma. In terms of LDAP, my (naive) expectation is that since other projects have this status, infra already has a way to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60383218 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

Github user eriweb commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1420#discussion_r60384237 --- Diff: packaging/centos7/cloud-management.service --- @@ -24,6 +24,7 @@ Description=CloudStack Management Server After=syslog.target network.target

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60384825 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60384791 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60386634 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user borisstoyanov commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-212381873 Hey guys, Just a FYI: I'll be addressing the testing of this PR at the end of next week since I'm occupied with other tasks at this time. --- If your proje

RE: Apache Jira rights for the ACS project

Thanks Rajani. Simon Weller/ENA (615) 312-6068 -Original Message- From: Rajani Karuturi [raj...@apache.org] Received: Tuesday, 19 Apr 2016, 11:57PM To: dev@cloudstack.apache.org [dev@cloudstack.apache.org] Subject: Re: Apache Jira rights for the ACS project you should be able to assign i

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60388741 --- Diff: api/src/org/apache/cloudstack/acl/Rule.java --- @@ -0,0 +1,65 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60389152 --- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java --- @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation

RE: [DISCUSS] Request for comments: Out-of-band Management for CloudStack (new feature)

Hi all, The feature is ready for code review now: https://github.com/apache/cloudstack/pull/1502 Thanks. Regards, Rohit Yadav rohit.ya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent:

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60390739 --- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java --- @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (AS

Re: [DISCUSS] Network offerings for Isolated Networks / VPCs

I'm not sure that is a good idea. There are a LOT of implications with this idea. For example, many hardware appliances can not handle overlapping ip space between networks. Because of this they can't be implemented in a vpc, only isolated guest networks. I know there are a lot more examples like

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r60393439 --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java --- @@ -206,4 +216,87 @@ public static void scpTo(String host, int port, String use

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-212395104 @swill LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [QUESTION] ACS 4.8 Centos 7 ARM / Raspberry PI B 2 with Intel KVM hypervisor

H Patrick, nobody is answerring but I know they have, Not to start off with as you intent to, though. Let us know. On Tue, Apr 19, 2016 at 6:25 PM, Patrick Miller < patrick.mil...@sungardas.com> wrote: > I built ACS 4.8 on Centos 7 ARM on a Raspberry PI B 2. With ACS 4.8 built > on a Centos 7 x

Re: [DISCUSS] Emeritus Committer Status

Guys, one thing is to ping their apache known forwarding address if we suspect they are no longer active. Some might have still addresses of former employers listed and those are emeritus when found, if I may have that opinion.

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1500#issuecomment-212400883 @koushik-das - Our use case is to emulate a snapshot revert with Ceph by using createVolume sourced from a snapshot, then detaching and reattach the root volume

Re: [DISCUSS] Emeritus Committer Status

Daan, I disagree with automatically placing someone in emeritus status. I think it is very important that some explicitly requests the status. Thanks, -John > Regards, John Burwell john.burw...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK @shapeblue

Re: [DISCUSS] Network offerings for Isolated Networks / VPCs

On Wed, Apr 20, 2016 at 1:26 PM, Will Stevens wrote: > I'm not sure that is a good idea. There are a LOT of implications with this > idea. > > For example, many hardware appliances can not handle overlapping ip space > between networks. Because of this they can't be implemented in a vpc, only > i

Re: [DISCUSS] Emeritus Committer Status

If their addresses are not valid? It would be a security measure for/from my part. On Wed, Apr 20, 2016 at 2:23 PM, John Burwell wrote: > Daan, > > I disagree with automatically placing someone in emeritus status. I think > it is very important that some explicitly requests the status. > > Than

Re: [DISCUSS] Emeritus Committer Status

Erik, The following is the response I received from infra about managing emeritus committers: commit bits are...binary bits, they can be 1 or they can be 0. We don’t operate with trinary bits here, sorry If you want to have emeritus committers, your best bet is to remove

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212404120 @bhaisaab Rebased the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60399552 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-212408609 Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

Re: [DISCUSS] Network offerings for Isolated Networks / VPCs

Ws: Inline On Apr 20, 2016 8:24 AM, "Daan Hoogland" wrote: > > On Wed, Apr 20, 2016 at 1:26 PM, Will Stevens > wrote: > > > I'm not sure that is a good idea. There are a LOT of implications with this > > idea. > > > > For example, many hardware appliances can not handle overlapping ip space > >

Re: [DISCUSS] Network offerings for Isolated Networks / VPCs

thanks Will, That is a bummer and a discouragement. On Wed, Apr 20, 2016 at 2:47 PM, Will Stevens wrote: > Ws: Inline > > On Apr 20, 2016 8:24 AM, "Daan Hoogland" wrote: > > > > On Wed, Apr 20, 2016 at 1:26 PM, Will Stevens > > wrote: > > > > > I'm not sure that is a good idea. There are a LOT

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212416597 @bhaisaab Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-212418415 Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [DISCUSS] Emeritus Committer Status

On Wed, Apr 20, 2016 at 2:26 PM, John Burwell wrote: > Erik, > > The following is the response I received from infra about managing > emeritus committers: > > commit bits are...binary bits, they can be 1 or they can be 0. We > don’t > operate with trinary bits here, sorry > >

Re: [DISCUSS] Network offerings for Isolated Networks / VPCs

that came out wrong, I mean You are right! On Wed, Apr 20, 2016 at 2:59 PM, Daan Hoogland wrote: > thanks Will, That is a bummer and a discouragement. > > On Wed, Apr 20, 2016 at 2:47 PM, Will Stevens > wrote: > >> Ws: Inline >> >> On Apr 20, 2016 8:24 AM, "Daan Hoogland" wrote: >> > >> > On W

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/792#issuecomment-212423092 @koushik-das does this fix got tested with HVM vm having more than 4 VDI? because we are experiencing issue where an HVM vm on XenServer 6.5 having 4 vdi (1 root

Re: [DISCUSS] Network offerings for Isolated Networks / VPCs

haha, i know you well enough daan to know how to read your emails. :P *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Wed, Apr 20, 2016 at 9:21 AM, Daan Hoogland wrote: > that came out wro

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1500#issuecomment-212426369 @koushik-das - Thanks for the feedback. I have added the require_hardware="false" as you suggested and pushed a new commit to the branch. If all looks good,

Re: anybody doing load testing?

Hello, Of course, I use Apache JMeter! A great tool to make load test, and the next version 3.0 [1] (currently in RC2 [2]) would be a nice version. For heavy load test, you can create some JMeter scripts locally and upload these scripts to some SaaS services [3] [4] [5] to hit your target fr

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

GitHub user olivierlemasle opened a pull request: https://github.com/apache/cloudstack/pull/1503 CLOUDSTACK-9358: StringIndexOutOfBoundsException on events Fixes JSON deserialization of `cmdInfo` (current process fails with `StringIndexOutOfBoundsException` when `cmdEventType` is th

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212471834 @SudharmaJain Will @swill is the RM for master/4.9, I'm not following these changes perhaps any Xen guru can comment, @agneya2001 ? @remibergsma do you have any

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212474106 @SudharmaJain The provided version have already released so these change need to go into 481to490 related sql /cc @swill any vmware/guest-os-mapping guru w

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-212474909 Thanks @SudharmaJain LGTM (just code review), can you do a push -f (travis job failed for some reason) --- If your project is set up for it, you can reply to this

IPv6 progress in Basic Networking

Hi, Lately I've been working on IPv6 integration on CloudStack. Not much code has been written (non actually), my work has mainly been getting things straight in my head. Honestly, the work has been focused on the use-case at PCextreme Aurora Compute: - Basic Networking - Single IPv6 address per

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60433227 --- Diff: api/src/org/apache/cloudstack/acl/Rule.java --- @@ -0,0 +1,65 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60434048 --- Diff: api/src/org/apache/cloudstack/acl/RolePermission.java --- @@ -0,0 +1,30 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60439393 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,166 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60439732 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,170 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60439905 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,170 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60440106 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,170 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r60444764 --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java --- @@ -206,4 +216,87 @@ public static void scpTo(String host, int port, String

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-212512170 @DaanHoogland I removed `@param`, `@return` and `@throws` from javadoc. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-212529350 @syed, sorry the delay, I haven't had much time. I noticed that this class is being ignored. The tests are not properly coded (test should not rely on

[GitHub] cloudstack pull request: L10n update master 20160127

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-212530190 Jenkins failed with a timeout (not related to your code). Can you squash your commits and do a force push again? Sorry for the runaround.. --- If your project is s

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-212531389 I think we are just missing 1 LGTM for this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1500#issuecomment-212533078 We need some LGTM code reviews of this one. I would also like to run CI against it because it changes code that is common to other functionality to make sure nothing

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212537408 I will admit, I don't really understand everything in play here. If I read this quickly, it seems like this PR may not be needed because #861 essentially changes the

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-212541636 I think this one is ready now. I will add it to my merge queue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

Github user simongodard commented on the pull request: https://github.com/apache/cloudstack/pull/792#issuecomment-212573040 I confirm what @pdion891 described in the previous comment. http://markmail.org/thread/4nmyra6aofxtu3o2 --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: L10n update master 20160127

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-212572821 @swill squash & force push done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: L10n update master 20160127

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-212585886 @DaanHoogland do you know why jenkins is failing here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1505 CLOUDSTACK-9172 Added cross zones check to delete template and iso Added a check to ignore the zoneid, in the delete template UI, if the template is cross zones. reference : CLOUDSTACK-9

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/1504 CLOUDSTACK-9172 Added cross zones check to delete template and iso Added a check to ignore the zoneid, in the delete template UI, if the template is cross zones. reference : CLOUDSTACK-9

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1504#issuecomment-212587181 Pushing towards 4.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

Github user pdube closed the pull request at: https://github.com/apache/cloudstack/pull/1504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1505#issuecomment-212588764 Since this is a UI change, is it possible to supply screenshots to show this behaves as expected? For UI changes we tend to use visual proof since we can't do CI. T

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-212596332 @rafaelweingartner the garbage collection issue is not the allocation/deallocation, but the reachability calculation that the garbage collector must perform for ev

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1505#issuecomment-212595733 tested with 4.7.2 + swift as Secondary Storage. with Swift,zoneid of template is empty. this should go in master too. LGTM. --- If your project is set u

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-212598453 @jburwell I agree with you. The key point here is > instances that are rapidly allocated and deallocated Singletons are not meant to be deallocated

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-212599647 @rafaelweingartner hopefully, the appender I specified in the [gist](https://gist.github.com/jburwell/98b6d94c57f409b5b778ffee6a8a12b1) should be a good start (if

ACS Testing

This is going to be a stupid question, but I don't know the answer, so I would like some guidance on this. Under 'cloudstack/test/integration/' there are the following folders: - component - smoke - plugins - testpaths Looking specifically at 'components' and 'smoke', there seems to be a lot of o

Re: ACS Testing

I think we want to test both, but we will have to consider and judge each test on it's own merits. We can start a run with everything from both directories as a parallel track and then see what to do with the failing ones. On Wed, Apr 20, 2016 at 11:52 PM, Will Stevens wrote: > This is going to

Re: ACS Testing

Ok, to keep things reasonable to start with, I am going to try to build suites specifically to test different PRs and then start consolidating them once I can validate the tests that are working into a 'full' test run. If anyone has a list of tests which they think is a complete list of working te

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212718578 @bhaisaab Thanks for the comment. I have updated with the latest now. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-212724576 @bhaisaab I pushed it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/876#issuecomment-212725838 Rebased with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Build failed in Jenkins: build-master-slowbuild #3541

See -- [...truncated 5610 lines...] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.046 sec - in com.cloud.consoleproxy.ConsoleProxyManagerTest Running com.cloud.capacity.Ca

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212742630 The existing implementation for logrotation that works with xenserver 6.0 and earlier does not works with 6.0.2 and later. That is the reason I have added this

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/892#issuecomment-212745452 Rebased the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/792#issuecomment-212753295 @pdion891 This wasn't tested with HVM VMs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/1308#issuecomment-212753742 Have done the code review and LGTM !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r60529246 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -971,33 +971,28 @@ public Answer easySend(final Long hostId, fin

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-212754454 @kansal Can you please rebase it with the master once. Code changes are fine, I will test once rebased branch. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212754742 @kansal Can you rebase it once. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: [CLOUDSTACK-9337]Enhance vcenter.py to cr...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1464#issuecomment-212756206 These changes will not have any impact on cloudstack code since it is purely to orchestrate the vcenter Server to create datacenter->cluster->hosts. Can we merge

[GitHub] cloudstack pull request: Privtmpl

Github user pavanb018 closed the pull request at: https://github.com/apache/cloudstack/pull/566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-212760624 LGTM based on code review :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r60530964 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final CancelMaintenanceCmd cm

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60531171 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check

  1   2   >