Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208751962
### CI bubble run
**Commit Reference: de53cd1799122f6448faef950cf9afd5caeaf412**
initially two test failed. I reran the 'unusual
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208752537
@ustcweizhou Can you review, the rebasing led to more commits then
expected. The result looks fine but I am not sure.
---
If your project is set up for it, yo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208753341
@remibergsma @swill this one test always failing in our environments
doesn't sit good with me. It feels like we are accepting a crippled system to
be carried.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-208755644
@kiwiflyer
I'm currently working on CLOUDSTACK-9339 to resolve the issues that I
mentioned in #1413 - I don't think this PR breaks anything that currently
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-208777850
@kollyma can you close this one if #1487 is indeed the same?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user kollyma closed the pull request at:
https://github.com/apache/cloudstack/pull/1449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-208793335
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-208794235
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1473#issuecomment-208795627
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208794882
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-208795019
@swill I don't think many people read spurious comments on the github PRs.
only fanatics do :p
I am for safeguarding as much history as possible and only r
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1474#discussion_r59341831
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -274,3 +277,46 @@ def __moveFile(self, origPath, path):
os.ma
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1474#discussion_r59342176
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -260,6 +261,15 @@ public boolean finalizeVirtualMac
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1474#discussion_r59343588
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -274,3 +277,46 @@ def __moveFile(self, origPath, path):
os.ma
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-208803326
LGTM in spite of comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1488
agent: Enable IPv6 connectivity for KVM Agent to Management Server
IPv4 is still preferred, so if the hostname of the Management Server
returns a A and -record the Agent will still connect
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-208811822
At PCextreme we have 'ipv6disabled' set to 'false' on our hypervisors and
they are all connected over IPv6.
Connections we see open from the Management Server
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208812036
Yes, seems rather stupid to keep those :)
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1487#issuecomment-208812713
Seems like a sane Python change. Looking at the code it's OK. I can't find
an issue.
Testing it is a bit harder to do for me now.
Based on the code: L
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-208814933
@pdion891 I have rebased this branch with the master. Can you please
trigger a template job on this branch. I don't have the permissions. I am
planning to ask Bhara
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-208817879
@jayapalu Please talk to @swill before merge.
I'll also have another look at it and see if I can get it to work this time.
---
If your project is set up
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1487#issuecomment-208819610
code LGTM running tests as we write
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-208819704
@wido Great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-208821534
after a long search, I can find no syntax errors. LGTM based on code and
report.
---
If your project is set up for it, you can reply to this email and have yo
@swill and @remibergsma
I saw this in the test
```
[dahn@blimbing ~]$ for i in 1 2 ; do ssh kvm$i virsh list; done
Warning: Permanently added 'kvm1,192.168.22.21' (ECDSA) to the list of
known hosts.
IdName State
2
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-208847097
@swill what's the status on getting this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Yep, I got it. Thanks... :)
1487 (1449) - 4.7 (ready) NOTE: This closes #1449
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Tue, Apr 12, 2016 at 2:14 AM, martin kolly
wrote:
> Hi Will
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208891268
Isn't there references to these files? Forget the ones in `target`, but
the references in `cloudstack/scripts/installer/windows/client.wxs` should
probably be addres
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208896922
Is that "wix-acs" maven task executed?
What does it build?
I noticed it has as an output a file called "acs.msi", what is it?
---
If your pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208897161
the windows install of acs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208898455
you mean the ACS itself?
The whole ACS? For what I have seen of the code base, it does not seem to
work in Windows environments.
---
If your pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208900500
might be just for the agent, I have never run it. I read about people
running it on windows but back in the days when i did it is was on cygwin.
---
If your p
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208903886
I also thought it was the HyperV agent; but, that agent is built in a
different way. I was going over the files, and it seems that is used to build
an ins
im not sure, i will let remi answer that.
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Tue, Apr 12, 2016 at 6:10 AM, Daan Hoogland
wrote:
> @swill and @remibergsma
>
> I saw this in the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1487#issuecomment-208907818
@DaanHoogland I already ran tests against this one as #1449. I am planning
to merge this today...
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-208909441
I am not sure what is going on with Jenkins and Travis now days, but they
are being very flaky. Maybe the added load of people being more active is
messing with them
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-208914356
Do we have any assurances that this works and does not break anything? Do
we need to run CI or how do we validate this?
---
If your project is set up for it, you ca
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208915830
@DaanHoogland for the test that often fails in my environment, check
@remibergsma's comments here:
https://github.com/apache/cloudstack/pull/1449#issuecomment-2047647
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1487#issuecomment-208917458
fine I had a failure but the re-run worked. Not very reassuring but mainly
about my test-env not the pr.
---
If your project is set up for it, you can reply t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208919017
@swill that is definitely not the same issue as I'm having. it is in the
same test however
---
If your project is set up for it, you can reply to this email a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208921203
@swill sorry it is not the same test that fails in my env:
"Ping to outside world from VM should be successful" in
test_02_redundant_VPC_default_
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-208922778
I would like to get the LGTM from @remibergsma and @pdion891 before I merge
this. Thanks for all the hard work @jayapalu..
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1487#issuecomment-208924288
Ok, perfect. I will merge this now. Thx for confirming.. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208956680
@GabrielBrascher can you do a rebase or push -f again so that Travis build
can be re-kicked
---
If your project is set up for it, you can reply to this email and
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208969926
@bhaisaab force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-208986832
@swill, @DaanHoogland
Have you already executed test on this one?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-208987688
I have tried a few times, but I also was having problems with my CI when
trying to test this. I was getting errors, but I was trying to determine if it
was my env or
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-209009495
@GabrielBrascher thanks, Travis failed again. I'll test this on my env
tomorrow (night for me here). Meanwhile, can you build with -T4 -Dnoredist
-Dsimulator flags
I forgot to reply all, I replied following to Will:
## start ##
Will, can you share the travis job URL which failed? I suspect it could be
environment related, Travis builds run on ubuntu trusty on GCE with 2 cores
and 7.5GB RAM. We're running the build process/tests in parallel with -T4
to save t
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1489
CLOUDSTACK-8562: Dynamic Role-Based API Checker for CloudStack
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack dynam
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209017286
@swill this looks ready, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209018498
## test_staticroles.py
=== TestName: test_static_role_account_acls | Status : SUCCESS ===
## scripts/util/migrate-dynamicroles.py
I'll add
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-209020597
@rafaelweingartner +1 to remove all that stuff
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209020807
@pdube we need to run CI against it first, but otherwise, yes it is ready...
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209021841
I would say it is missing an LGTM.
But, it is very good the code.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209021645
This is a feature that we definitely need. Can I please get some code
review on this PR?
---
If your project is set up for it, you can reply to this email and have
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59419363
--- Diff: tools/marvin/marvin/cloudstackConnection.py ---
@@ -143,7 +143,7 @@ def __sign(self, payload):
["=".join(
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209023846
@rafaelweingartner @swill The only thing changed was the unit tests, which
I ran. And the only code change he did was to remove useless variables. @swill
also gave hi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209028162
@bhaisaab, ok will continue tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209026886
@DaanHoogland I was pushing some changes and adding some info/screenshots
above. Since this aims to deprecate use of commands.properties (affecting
marvin and apid
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209026629
Just trying to help get things merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209025189
@pdube sorry, my brain is into something else right now and I didn't review
the scope of the code. Yes, your tests are valid tests for this change. So
yes, I will a
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209026193
Some screenshots \*
Roles Tab:
![Uploading Screenshot from 2016-04-12 23-11-42.pngâ¦]()
Add a new role:
