Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1461#issuecomment-205170921
+1 LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1462
ui: fix typo in dashboard's fetchlatest usage
cc @swill @terbolous @runseb @wido @abhinandanprateek
You can merge this pull request into a Git repository by running:
$ git pull https://g
H, for those interested in how we get to improve, here is something I
stumbled upon on reddit [1]
I must admit I think most of us are already working as described but
still,... it touches on some of the pitfalls we have been tripping in as a
project as well.
[1] : https://10kloc.wordpress.com/20
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205178712
Tested this manually by patching dashboard.js and re-gzipping it.
The parameter is now passed as 'fetchLatest' as it should.
![Request parameters]
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-205228160
Jenkins has failed on RAT, but the report doesn't indicate the nature of
the problem. As an attempt to debug, I was unable to replicate the failure
locally execut
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r58355784
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r58375427
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public Dom
Hi Wei,
I implemented your modifications on a test cloud we have here and it worked
well. Redundant routers in the backup state booted with public interfaces down.
As you said, they also negotiated the VRRP instance over eth0 which is correct.
As an aside, regarding the following code:
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205316122
@rafaelweingartner
Ok, nice. I like that option. The only question I have about this is that
if property could be changed from UI by users after inserted in
"
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205334162
I have just tested; the cluster_details table does not work as the
configuration table in which you can add an entry there and then that parameter
is disp
Jayapal (or anyone else),
Where I got so far is adding rules with counters against a certain ipset, e.g.
I add this:
execute("iptables -A " + brfw + "-OUT" + " -m physdev --physdev-is-bridged
--physdev-out " + vif + " -m set --set myipset src")
before
execute("iptables -A " + brfw + "-OUT" + " -
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205349316
@nvazquez just an update.
I was going over
"org.apache.cloudstack.api.command.admin.config.ListCfgsByCmd.execute()" that
is used to list the cluster c
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205381727
@GabrielBrascher please continue as you please. the old code has been
neglected. if you want to attribute please feel free to do so in the comment
for that com
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58407383
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Found
Well, this is what we got working in the end. If someone has any suggestions on
how to improve it, that'd be great.
https://github.com/NuxRo/cloudstack/commit/de6f97367fc2dc02378f367c462eaaec8f92e234
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
- Original Message
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58407949
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Found
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205409749
@serg38 and I found out a way to change this property from UI, inserting
the property in "configuration" table with scope="Cluster", insert sql:
INSERT INT
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205414291
I pushed a solution with this changes, without including insert in sql
schema, do you think this way could be ok?
---
If your project is set up for it, you can re
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205423791
I think this is the best way to tackle the problem.
You just need to add that insert into the versionâs upgrade script.
---
If your project is set
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205452667
Works as expected, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205509785
I agree. @bhaisaab do you mind adding a Jira ticket for this just so we
have a record of it.
---
If your project is set up for it, you can reply to this email and h
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205512194
Pulled this in manually and tested it.
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58466286
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Foundat
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205554379
Pretty clever the way you named the test methods, I liked it.
Just another thing.
The method "throwSshExceptionIfSshConnectionIsNull" you are testin
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58478990
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -1,209 +1,306 @@
-//
-// Licensed to the Apache Software Foundat
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205604082
@GabrielBrascher, since @likitha seems to have left the community, could
you take over all of the changes and just commit the changes in a way that the
di
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1461#issuecomment-205615803
### CI RESULTS
**85/85 TESTS PASS**
Everything is looking pretty good from this side.
**Associated Uploads**
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r58480834
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public DomainBlockStat
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205624341
@swill In my environment I am using macchinina templates for testing. These
are not there by default but are pretty handy in testing due to their small
si
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205643191
@swill feel free to create a JIRA ticket for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Hi Nux,
I think ipset ‘myipset’ changes might be there in other commits. If you do not
have special requirement then you can use the existing ipset which is with the
vmname ex: i-2-3-VM. Except this it looks good to me.
Thanks,
Jayapal
> On 04-Apr-2016, at 10:17 pm, Nux! wrote:
>
> Well, t
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205654507
@bhaisaab here you go: https://issues.apache.org/jira/browse/CLOUDSTACK-9335
please update the PR and add the issue to the title
---
If your project is s
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205671313
Thanks @terbolous, fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205672352
On comparing test execution times with macchinina Vs Centos builtin
template I did not find much of a difference. So modifying the test to go with
the sta
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205679998
@GabrielBrascher I ran the regression suite as defined by SBP and found two
failures. I am rerunning them individually to see if I can find out some more.
Here
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-205684992
LGTM based on the code review !!
Please squash the commits into single commit.
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205684941
the first one wwas a false positive:
[1459.results.password.txt](https://github.com/apache/cloudstack/files/203940/1459.results.password.txt)
---
If your
44 matches
Mail list logo
