[GitHub] cloudstack pull request: CLOUDSTACK-9208: Assertion Error in VM_PO...

2016-03-27 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1307#issuecomment-202054442 ### ACS CI BVT Run **Sumarry:** Build Number 135 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=4

[GitHub] cloudstack pull request: Fix new error found in findbugs slow buil...

2016-03-27 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1438#discussion_r57527860 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -395,16 +391,9

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

2016-03-27 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-202117240 ### ACS CI BVT Run **Sumarry:** Build Number 136 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

2016-03-27 Thread cristofolini
Github user cristofolini commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1451#discussion_r57535012 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java --- @@ -180,7 +179,7 @@ private Answer applyConfig(NetworkEle

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

2016-03-27 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1450#issuecomment-202152926 @ProjectMoon According to that comment on line 781 in `CommandSetupHelper` the conditional that follows is there to enable sourceNAT, yet you removed the comma

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

2016-03-27 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1451#issuecomment-202161988 @cristofolini there is no _timeout_ variable in the scope you commented. His change is valid because _VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT_ is mapped

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

2016-03-27 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-202163598 Hi @prashanthvarma. How about to use String.format() to create the strings in the loggers? The use of String format will turn the strings in the logs

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

2016-03-27 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1451#issuecomment-202164340 @alexandrelimassantana Ah, I see that now. Thanks for the clarification! :) --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

2016-03-27 Thread pedro-martins
Github user pedro-martins commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1451#discussion_r57537243 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java --- @@ -180,7 +179,7 @@ private Answer applyConfig(NetworkEl

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-03-27 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-202176758 ### ACS CI BVT Run **Sumarry:** Build Number 137 Hypervisor xenserver NetworkType Advanced Passed=101 Failed=1 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

2016-03-27 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1454 CLOUDSTACK-9323: Fix cancel host maintenance can… so that if maintenance is cancelled the host come back to normal state gracefully. Added marvin tests for host maintennac

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

2016-03-27 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-202217738 @abhinandanprateek I don't see the Marvin test case in the PR. Have you pushed the latest commit? Also, most of the changes seem to be formatting changes

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

2016-03-27 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-202221938 @jsb added the marvin file and reverted to pre-commit formatted code. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: New test to validate starting vm after ni...

2016-03-27 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1326#discussion_r57545397 --- Diff: test/integration/component/test_add_remove_network.py --- @@ -1021,6 +1021,103 @@ def test_29_remove_nic_CS22503(self):

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

2016-03-27 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-202238647 ### ACS CI BVT Run **Sumarry:** Build Number 138 Hypervisor xenserver NetworkType Advanced Passed=106 Failed=0 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

2016-03-27 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-202256571 Marvin test output: root@ccp:~/cloudstack(host-maint)# ./host_maint.sh ++ date + echo Mon Mar 28 11:47:45 IST 2016 Mon Mar 28 11:47:45