Re: [Proposal] Concerning open PRs

2016-02-20 Thread Wilder Rodrigues
Hi there all, @Sebastian: it might look a bit extreme, but I believe that at the moment it might be easier to get at least 5 of the community members investing 1 day per week to run automated tests on PRs, and hopefully merging them, than get 1 member to work 100% having a proper CI in place.

RE: [Proposal] Concerning open PRs

2016-02-20 Thread Paul Angus
Unfortunately the $dayjob keeps getting in the way of our CI work, however wrt to PRs - we should have Jenkins build and keep the RPM artefacts relating to a pull request (for a fix length of time). This will enable 'users' to deploy an environment based on those RPMs and test it. The requiremen

[GitHub] cloudstack pull request: zip the processed json files so we save d...

2016-02-20 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1421 zip the processed json files so we save diskspace Zip the processed json files and make sure they're unique (timestamp is not unique). You can merge this pull request into a Git repository

Re: [Proposal] Concerning open PRs

2016-02-20 Thread Nux!
+1 for "on PR" RPMs! -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Paul Angus" > To: dev@cloudstack.apache.org > Sent: Saturday, 20 February, 2016 12:31:56 > Subject: RE: [Proposal] Concerning open PRs > Unfortunately the $dayjob k

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

2016-02-20 Thread alexandrelimassantana
Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r53554647 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2030,12 +2030,29 @@ int getReser

[GitHub] cloudstack pull request: zip the processed json files so we save d...

2016-02-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-186664554 Test result: ![screen shot 2016-02-20 at 19 35 42](https://cloud.githubusercontent.com/assets/1630096/13198466/8c0c4b9e-d809-11e5-883b-b37b4beb53d9.png) -

[GitHub] cloudstack pull request: zip the processed json files so we save d...

2016-02-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1421#discussion_r53555684 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py --- @@ -272,5 +275,10 @@ def setPath(self, path): def __moveFile(self, origP

[GitHub] cloudstack pull request: zip the processed json files so we save d...

2016-02-20 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1421#discussion_r53555783 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py --- @@ -272,5 +275,10 @@ def setPath(self, path): def __moveFile(self, origPa

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-02-20 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1410#discussion_r53556330 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java --- @@ -1006,6 +1006,19 @@ protected synchronize

[GitHub] cloudstack pull request: CLOUDSTACK-8829 : Consecutive cold migrat...

2016-02-20 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/797#discussion_r53559299 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1776,19 +1773,26 @@ private void orchestrateStorageMigratio