[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1261#issuecomment-176045236 @remibergsma build/smoke tests passed, constructor definition was changed with unused variables removed --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176045486 @runseb this was sent for master as the author intended, non-issue actually but would satisfy SonarQube from showing up redflags --- If your project is set up for

[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1124#issuecomment-176045950 @rafaelweingartner thanks; @remibergsma should we let this be merged considering your integration test result, or you want to re-run them? --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1342#issuecomment-176046154 cc @remibergsma requires merging on 4.6 and consequent fwd merges --- If your project is set up for it, you can reply to this email and have your reply appear on G

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
[ShapeBlue] Rohit Yadav Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 8826230892 e: rohit.ya...@shapeblue.com | t: | w: www.shapeblue.com

RE: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Paul Angus
Hi, I mentioned last week I am working with a few of my colleagues to develop a repo of the Ansible plays to be able deploy both Marvin and virtualised environments - (relatively) simply and then run Marvin against that environment. As I said, we have a load of work to do to get to the bottom o

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-176055926 @runseb checked the diff, travis/jenkins passed, diff looked good to me. I've merged this and few others without integration tests as they *don't* explictly nee

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
[ShapeBlue] Rohit Yadav Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 8826230892 e: rohit.ya...@shapeblue.com | t: | w: www.shapeblue.com

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Remi Bergsma
Hi Paul, Indeed not all Marvin tests are generic enough and can be run on all environments. If you use this [1] collection of ~85 tests it should work well as we tested the PRs with these. Sure we should add more, but it’s probably way faster if you’d use these and work from there, instead of t

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Remi Bergsma
Sure Rohit, sometimes it makes no sense to run integration tests. That’s why for example I build an environment and check the UI when someone changes a javascript file. Just saying it “looks” good is valuable from a code review point of view, but not from a verification point of view. I say we

RE: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Paul Angus
Thanks Remi, That would give us a working 'good' baseline to start from - I've found tests that have hardcoded local IPs in template URLs and allsorts in the Marvin test scripts. We'll look to add a little move configurability (such as template locations) I also want to get working on expandin

Build failed in Jenkins: build-master-slowbuild #3094

2016-01-28 Thread jenkins
See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

2016-01-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-176080946 @agneya2001 Sounds like you want to set the style guide. you and @rafaelweingartner should take this discussion to a higher level and take it to a discuss thre

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

2016-01-28 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-176082402 @DaanHoogland I agree there should be some guideline on code style. If these are there I think most of us will be willing to follow these. I guess it will not be

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Daan Hoogland
On Wed, Jan 27, 2016 at 9:18 PM, Sebastien Goasguen wrote: > Now Travis is not running, Jenkins fails all the time and nobody cares… > ​Sebastien, Jenkins succeeds more then 50% of the time and I do care. Please report problems with jenkins.​ -- Daan

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

2016-01-28 Thread sarathkouk
GitHub user sarathkouk opened a pull request: https://github.com/apache/cloudstack/pull/1377 Escalation Automation of bug CS-43976 :VM snapshot fails for 12 min … …after instance creation ISSUE VM snapshot fails for 12 min after instance creation

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

2016-01-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1377#issuecomment-176095546 @sarathkouk please remove the internal bug reference and replace it by an apache equivalent. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

2016-01-28 Thread sarathkouk
Github user sarathkouk commented on the pull request: https://github.com/apache/cloudstack/pull/1377#issuecomment-176095486 TEST RESULT : @summary: Test if SS creation is successful in the first ... === TestName: test_05_check_vm_snapshot_creation_after_Instance_creation | Statu

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
So, since some have directly (over IM etc) or indirectly have thrown allegations on me since I merged most of the PRs. Here is a list of those 12 PRs and answers on why they were merged on case-by-case basis. Please keep any further replies technical and to the specific PR, please point out and

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-28 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Config Drive

2016-01-28 Thread Eric Waegeman
Hi all, we would like to port "Config drive" on KVM feature to a previous version of Cloudstack for one of our customers. We got most of it working but have a problem in udev not putting the config drive ISO in /dev/disk/by-label path because it considers it to be a removable drive. And we would

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176107957 Hi @bhaisaab I am genuinely asking because of the new release principles: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+Clo

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

2016-01-28 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-176108973 @bhaisaab actually I am not even seeing the travis runs here anymore. Reason I am asking is genuine (again), because in the last few months Travis has shown

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176114078 @runseb We could see it as a bug, but I agree with @bhaisaab that it is a non-issue that was "fixed" to make SonarQube happy. Fine to do that straight on master

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176114524 @runseb @bhaisaab I think this is worth a small but intensive discussion, preferably over a beer. What we are talking about is neither a bug nor a feature. We

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Sebastien Goasguen
Hi Folks, My proposal to freeze until we get CI was indeed due to seeing Rohit’s commit but was by no means a personal attack or judgment. We have lots of PR pending (as mentioned before by Remi) and we need people to help review and test. So thanks to Rohit. My only concerns were two fold: 1

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176115753 @bhaisaab @remibergsma @DaanHoogland ok then, just checking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

Re: disable github notifications ?

2016-01-28 Thread Sebastien Goasguen
The interesting thing is to look at our archive: http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201601.mbox/thread And try to get in the shoes of a new comer or someone browsing for info. January starts with 50 jenkins failed build emails... I agree that GH discussion need to be record

Re: disable github notifications ?

2016-01-28 Thread Daan Hoogland
On Thu, Jan 28, 2016 at 11:42 AM, Sebastien Goasguen wrote: > January starts with 50 jenkins failed build emails... > > ​Ah, don't forget we have our own jenkins and the builds.pache.org​ ones. The ones going to github are the builds builds named cloudstack-pr-analysis. The master-slow-build is i

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Rohit Yadav
All, I’m sorry to get to have the PRs merged without adhering to the strict testing requirements. While I think PRs were alright and it did not break anything, the way it was merged made people uncomfortable that there is some sort of haste in doing this fast which there is none. I’ll not repe

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1378 Emit event UUIDs on template deletion When a template is deleted, it emits a usage event over the event bus. However, it does not emit the UUID or class name of the template over the event

[GitHub] cloudstack pull request: CLOUDSTACK-8324: config drive data set/ge...

2016-01-28 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1379 CLOUDSTACK-8324: config drive data set/get scripts for the guest vm Added the guest vm scripts for set/get the vm data, password and ssh keys You can merge this pull request into a Git reposit

Re: Config Drive

2016-01-28 Thread Jayapal Reddy Uradi
Hi Eric, Please find the scripts in the below pull request. https://github.com/apache/cloudstack/pull/1379 Thanks, Jayapal On 28-Jan-2016, at 3:38 pm, Eric Waegeman mailto:eric.waege...@nuagenetworks.net>> wrote: Hi all, we would like to port "Config drive" on KVM feature to a previous versio

Re: Config Drive

2016-01-28 Thread Nux!
Hi Eric, That's great news! If udev is misbehaving, you could use blkid to get the device name instead, e.g.: blkid -t LABEL="config" -o device What OS are you seeing these problems on? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message -

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-176144240 Says a license is missing, but this only touches one existing file. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Vmdk findbugs

2016-01-28 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: Vmdk findbugs

2016-01-28 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1351 Vmdk findbugs these are two of the findbugs errors coming out of our jenkins all the time. The author seems to be unavailable so I kicked and screamed at it. notice that this is nore

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-176147131 Yes, nothing to do with your code but it is genuine. You can add the license to ActionEventUtilsTest to make the build pass. The license is there in higher bra

[GitHub] cloudstack pull request: user-authenticators/saml2: Remove unused ...

2016-01-28 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1380 user-authenticators/saml2: Remove unused dependency Removes Spring security saml extension as it is not needed or used by the SAML plugin. cc @DaanHoogland You can merge this pull

Build failed in Jenkins: build-master-slowbuild #3095

2016-01-28 Thread jenkins
See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

2016-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.7+] user-authenticators/saml2: Remove ...

2016-01-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1380#issuecomment-176157606 looks good but needs testing, right? might be a runtime issue. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-176159834 I added the license header. Out of curiosity, I ran the `org.apache.rat:apache-rat-plugin:0.10:check` locally on my PR branch and it reported 59 failure

[GitHub] cloudstack pull request: CLOUDSTACK-8324: config drive data set/ge...

2016-01-28 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1379#discussion_r51116786 --- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in --- @@ -0,0 +1,107 @@ +#!/bin/bash +# +# Init file for SSH Public Keys Download Clie

[GitHub] cloudstack pull request: CLOUDSTACK-8324: config drive data set/ge...

2016-01-28 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1379#discussion_r51116750 --- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in --- @@ -0,0 +1,107 @@ +#!/bin/bash +# +# Init file for SSH Public Keys Download Clie

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Bharat Kumar
Hi All, I agree that we need to have a CI to deal with the large volume of PRs. The current travis CI is not good enough as it runs only simulator tests. We identified this issue and came up with a effective CI for automating test runs for a each PR. This is already functional, with few github i

[GitHub] cloudstack pull request: [4.7+] user-authenticators/saml2: Remove ...

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1380#issuecomment-176170704 @DaanHoogland sure. There are no imports (git grep org.springframework.security to check) from any part of the codebase and since I had put it in I know for sure i

silence findbugs

2016-01-28 Thread Daan Hoogland
https://github.com/apache/cloudstack/pull/1351 is still open for the last two issues to silence findbugs. please all have a look. -- Daan

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-176181871 have a look in target/rat.txt and see what those are. maybe some remanence of your prior work. --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: Vmdk findbugs

2016-01-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1351#issuecomment-176191880 Seems good to me looking at it. Don't know how to test it properly, but code-wise the changes look sane to me. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-176194553 I added the license check to ActionEventUtilsTest and of course now the checks pass. But may it is a better idea to put the license in as a separate PR? Not exa

[GitHub] cloudstack pull request: Vmdk findbugs

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1351#issuecomment-176195149 LGTM, did not test it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-176197509 It looks like it was some old Debian package build causing a bunch of extraneous files to be placed into the rat report. Cleaned up those and the report is now

RE: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Paul Angus
Hi Kumar, That’s great. I've been working along similar lines, I'd love to collaborate with you on this. Are you able to share an estimated timescale with us? And are you thinking of sharing the code and construction details of how to build the environment(s) for the community and users to bui

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Erik Weber
Why not share it as is, then the community could help improving this, rather than this being a single company effort? -- Erik On Thu, Jan 28, 2016 at 1:49 PM, Bharat Kumar wrote: > Hi All, > > I agree that we need to have a CI to deal with the large volume of PRs. > The current travis CI is no

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1373#issuecomment-176200921 Added the license header to the MockUsageEventDao class to fix rat report error. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-176204562 After some discussion on IRC, going to remove the addition of the license header here and fix it in a separate PR. --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-01-28 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1373#issuecomment-176205293 Hi @ProjectMoon , Out of curiosity, why did you create the "server/test/com/cloud/user/MockUsageEventDao.java" class? --- If your project is set up f

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

2016-01-28 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1381 Add missing license header to ActionEventUtilsTest. The test class was merged without the license header. This commit fixes that problem. Also note that the license header exists o

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1381#issuecomment-176207310 My god I swear GitHub's PR interface can die in a fire. Wrong base branch again. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

2016-01-28 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

2016-01-28 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1382 Add missing license header to ActionEventUtilsTest. The test class was merged without the license header. This commit fixes that problem. Also note that the license header exists o

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1373#issuecomment-176208728 I'm not the original author of this work, but I think it was just because a class for testing was needed. Looking at it now I'm not really sure why it can't jus

Build failed in Jenkins: build-master-slowbuild #3096

2016-01-28 Thread jenkins
See Changes: [w.zhou] CLOUDSTACK-6181: Add 'root disk size' field in instance wizard for KVM -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-01-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1373#issuecomment-176263770 @rafaelweingartner I have removed the MockUsageEventDao and replaced it with a normal Mockito mock of the UsageEventDao interface. --- If your project is set u

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-01-28 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1373#discussion_r51146580 --- Diff: server/test/com/cloud/user/AccountManagerImplTest.java --- @@ -205,6 +223,11 @@ @Mock private UserAuthenticator user

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-01-28 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1373#discussion_r51146522 --- Diff: server/test/com/cloud/user/AccountManagerImplTest.java --- @@ -192,6 +205,11 @@ @Mock VMSnapshotDao _vmSnapshotDao;

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-01-28 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1373#issuecomment-176270996 @ProjectMoon that is great, Your code is ok, I would just suggest you extracting the code from "AccountManagerImpl" lines 769-778 to a method. Th

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-176289614 Added unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153892 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153916 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153907 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51154027 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

[GitHub] cloudstack pull request: [4.7+] user-authenticators/saml2: Remove ...

2016-01-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1380#issuecomment-176291448 @DaanHoogland upgraded my local 4.7.0 cloudstack to 4.7.1 without the spring-saml ext dependency and logged in as a SAML user. Log: 2016-01-28 18:16:32,085

Build failed in Jenkins: build-master-slowbuild #3097

2016-01-28 Thread jenkins
See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

2016-01-28 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1382#issuecomment-176321558 LGTM based on the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

2016-01-28 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1310#issuecomment-176351414 Hi @bhaisaab , Which test files would you like me to run? Is this ok with this command on each file? nosetests --with-marvin --marvin-config=setup/dev/

Build failed in Jenkins: build-master-slowbuild #3098

2016-01-28 Thread jenkins
See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Pinnock Jr., Clifford R
Hi. Here are logs dstk-svc&domain=na.domain.com","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"origUrl":"https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Erik Weber
On Thu, Jan 28, 2016 at 11:41 PM, Pinnock Jr., Clifford R < clifford.pinnoc...@ca.com> wrote: > Hi. > > Here are logs > > dstk-svc&domain=na.domain.com > ","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateOb

Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Pinnock Jr., Clifford R
Hi. I am with a Citrix partner and we are trying to deploy CloudPlatform integrated with Hyper-V, all is well except we get exceptionCould not find a part of the path /"secondary"tmpl/1/9 when creating the system vm's. The thing is how are we supposed to get the system vm template onto the secon

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Erik Weber
Is your management server running on linux or windows? If it is on linux I guess you could CIFS mount it and use the regular system vm install method from [1], but use the appropriate version. If it is on windows I have no idea, never used cloudstack in combination with windows/hyper-v before, som

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Todd Pigram
Clifford, I assume your running CCP 4.5.1, in the install guide did you follow section 5.4.10 Prepare the SystemVM Template? I am a Citrix partner as well, but I run CCP on XenServer. I will try and assist any way I can. Todd Pigram about.me/ToddPigram

RE: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Paul Angus
Hi Clifford, You need to install samba-client, samba-common and cifs-utils on your mgmt server to have CIFS support. then you can mount your CIFS share with something like: mount -t cifs /// -o uid=cloud,gid=cloud,username=,password='',domain= As a side note, these CloudStack mailing lists

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread ilya
I think most would agree - we welcome anyone in this mailing list - regardless of their affiliation :) There is not anything special about CCP vs ACS. Regards ilya On 1/28/16 3:22 PM, Paul Angus wrote: > Hi Clifford, > > You need to install samba-client, samba-common and cifs-utils on your >

Build failed in Jenkins: build-master-slowbuild #3099

2016-01-28 Thread jenkins
See -- [...truncated 28685 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disk co...

2016-01-28 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-176495485 @bhaisaab Could you please do the following changes? At **VirtualMachineVolumeChainInfo** class: **1 -** create Javadoc blocks (would be nice to

Build failed in Jenkins: build-master-slowbuild #3100

2016-01-28 Thread jenkins
See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Anshul Gangwar
Hi Clifford, Is this resolved or are you still waiting for response? Regards, Anshul On 29-Jan-2016, at 3:56 AM, Pinnock Jr., Clifford R mailto:clifford.pinnoc...@ca.com>> wrote: Hi. I am with a Citrix partner and we are trying to deploy CloudPlatform integrated with Hyper-V, all is well exce

Build failed in Jenkins: build-master-slowbuild #3101

2016-01-28 Thread jenkins
See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Bharat Kumar
yes, we would be sharing it with the community and get this running in the ACS infra. Currently it can create a cloudstack test bed, runs tests and email the results. Here are some details on how this works and what is needed to set this up. * we use jenkins, cobbler, puppet and marvin to cr

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Erik Weber
I'd love to see this in the cloudstack repository. Others might have an easier time getting access to hardware, and could use it to help test releases/PR Erik Den fredag 29. januar 2016 skrev Bharat Kumar følgende: > yes, we would be sharing it with the community and get this running in the >

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-176629568 With the tests this looks good to me. I have no way of verifying the Swift working itself, but based on the code and tests: LGTM --- If your project is set up for it,