[GitHub] cloudstack pull request: Quota: findbug fixes

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-175472278 This patch cleans up any find bug issues in cloud-framework-quota and cloud-plugin-database-quota, verifiy output below. I think we should not delay this @remibe

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175473551 I agree with switching to Java 8, but shouldn't this be a small PR first where we ONLY switch to Java 8? Other PRs can follow up quickly. --- If your project

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175477214 @wido I was getting some compilation issue specifically to F5, to which someone previously on ML had advised an issue related to dependency version so I've include

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-175479331 LGTM @agneya2001 master seems to be unfrozen you'll need one more review to merge it yourself --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-175488909 @remibergsma Can you please try running the below tests once and let me know. For me the tests are passed. $nosetests-2.7 --with-marvin --marvin-co

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175490258 To ease transition, it seems like the first step should be to support running ACS built to 1.7 on a 1.8 runtime. This approach would allow customers unprepared to

Re: FYI: master branch is on 4.9.0 now

> On Jan 27, 2016, at 4:53 AM, Raja Pullela wrote: > > Hi Remi, Ilya, I had the same question... do we have a release cadence ? > The cadence is that as long as we stick to our current process we can release *anytime* both minor and majors. So we are always only one VOTE away from a release

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175492873 Alright, let's keep this PR hanging then. We should then open another PR which fixes the packaging first to switch from JRE7 to JRE8 along with any JAVA_OPT or tom

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-175500735 merging LGTM from @DaanHoogland and @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Build failed in Jenkins: build-master-slowbuild #3086

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1279#issuecomment-175504959 Such a waste --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175523813 @bhaisaab if we make the packaging require Java 1.8, then users will be automatically upgraded -- defeating the purpose of the deprecation. It seems like an appro

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1289 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: OSPF: WIP: adding dynamically routing cap...

Github user agneya2001 closed the pull request at: https://github.com/apache/cloudstack/pull/1353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1240#issuecomment-175560143 2 PRs, merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-175562144 @agneya2001 okay, we need one more LGTM on this. I'll picked your marvin fix from #1240 , can you also share test results if any? --- If your project is set up fo

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175563484 @agneya2001 LGTM again, need one more review to get this merged along with some testing (though in this case, we've some unit tests for the change) --- If your pr

Unable Creare/CleanUp Virual Router After upgraded to ACS 4.6.2

Hi All, We upgraded ACS from 4.3.1 to 4.6.2. After this we tried to create new VPC/Network and getting below error from Virtual Router then after router get shutdown. We are using XenServer 6.2 and CentOS 6.3. Please help us to fix this issue. Thank you, Suneel Mallela, AxiomIO.

Re: Unable Creare/CleanUp Virual Router After upgraded to ACS 4.6.2

Sorry, it is not allowing to attach a screenshot. Please find below link. http://picpaste.com/pics/VPC-rhH48Qao.1453891619.PNG Thank you, Suneel Mallela From: mvs babu Sent: ‎Wednesday‎, ‎January‎ ‎27‎, ‎2016 ‎4‎:‎14‎ ‎PM To: us...@cloudstack.apache.org Cc: dev@cloudstack.apache.org

Re: Unable Creare/CleanUp Virual Router After upgraded to ACS 4.6.2

Hi, Latest system vm template has flask installed in it. Can you please let us which system vm template you have used. Thanks, Harikrishna On 27-Jan-2016, at 4:17 pm, mvs babu wrote: > Sorry, it is not allowing to attach a screenshot. Please find below link. > > > http://picpaste.com/pics/

[GitHub] cloudstack pull request: OSPF: WIP: adding dynamically routing cap...

GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1371 OSPF: WIP: adding dynamically routing capability to VPC adding dynamically routing capability to VPC and adding config item structure to VR quagga configuration OSPF: zone quagga c

Build failed in Jenkins: build-master-slowbuild #3087

See Changes: [abhinandan.prateek] CLOUDSTACK-9161: fix the quota marvin test [abhinandan.prateek] Quota: findbug fixes -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-ma

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175599430 Hi @agneya2001, there are a lot of duplicated lines at “QuotaManagerImplTest”, would you mind removing them? Additionally, the lines you use t

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175601093 @rafaelweingartner Can you comment on the duplicated lines. There is a way you can get to the code and comment there. --- If your project is set up for it, you

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175601814 I know that. I just did not want to go one by one and tell you that they are duplicated, I believe you can easily see that. Those duplicated lines I menti

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175603740 @rafaelweingartner if you mean initialisation of AccountVO to be moved into a method, and replacing it with a method call. I guess I would prefer it this way as

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175609511 @agneya2001 that is exactly what I meant. I disagree with you, letting this as they are, it is not simple. Why duplicate code, when we can do better?

New release manager wanted

Hi all, After picking up the RM role last summer, I've had an interesting ride with awesome results. First the release principles [1], then stabilizing master and finally 3 releases in a row: 4.6 in November, 4.7 in December and 4.8 in January (and as a bonus 3 more patch releases in between).

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175624327 @rafaelweingartner quality is what we are discussing and I simply do not think that putting 3 lines of object initialisation in a method will make it high qualit

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175630573 It is cultural; we have to stop duplicating lines; no matter where and no matter how simple those blocks may seem. We also have to stop coding th

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175634392 @rafaelweingartner If it is a black box test then the person testing will obviously try to pass a realistic data set, that is what I have done. It is possible th

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-175634193 Seems the Jenkins build is complaining about license missing. Don't see what file it is, but I assume it's the new unit test file? --- If your project is set u

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175637289 If in a remotely distant future someone that we do not even know yet changes that method and make use of some extra data (forgetting to check the test cas

[4.2] System VM volumes stuck in expunging but not removed

Hi, In a 4.2 environment, after removing the last host from a zone and destroying the system VMs, they leave behind their volume in the database stuck in Expunging, but the removed column is non-NULL. This prevents the deletion of the primary storage. Was this fixed in later versions or does it st

Re: [4.2] System VM volumes stuck in expunging but not removed

Also this is even after waiting for the main expunge thread to run. The volumes remain non-removed after the expunger runs. On Wed, Jan 27, 2016 at 1:56 PM, Jeff Hair wrote: > Hi, > > In a 4.2 environment, after removing the last host from a zone and > destroying the system VMs, they leave behin

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-175639158 @ProjectMoon Yes, just need to add the license in "SecondaryStorageManagerTest" class. --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175656788 @rafaelweingartner It is only about realistic test data that is being passed to the method tested. You should differentiate between the tested code and the code

[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1256#issuecomment-175662863 Merging as it has 2LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/669#issuecomment-175664522 @sedukull @anshul1886 please rebase against latest branch and help re-review --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-175665150 @nitt10prashant please rebase and meld into a single commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-175665698 @rafaelweingartner @nitin-maharana @DaanHoogland guys, this is really old; can we have a re-review please? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-175665865 @maneesha-p please rebase against latest branch and resubmit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-175666104 @anshul1886 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/803#issuecomment-175666319 @anshul1886 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-175667189 @sureshanaparti LGTM, can you add a unit test for the new methods and rebase against latest master --- If your project is set up for it, you can reply to this emai

Re: Unable Creare/CleanUp Virual Router After upgraded to ACS 4.6.2

Hi, Thank you for response. Followed below documentation, http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.6.0/upgrade/upgrade-4.3.html and templates are, http://cloudstack.apt-get.eu/systemvm/4.5/systemvm64template-4.5-xen.vhd.bz2 http://cloudstack.apt-get.eu/systemvm

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175667113 I do not agree. If people are comfortable with it, so let it be. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/830#issuecomment-175667434 Merging as it has 2LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/830 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-175667904 The question here is: will we write a test case for the change? If so, it has to be done, otherwise the code is ok. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/831#issuecomment-175668135 Only text change and 2LGTMs, merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-175668842 @ustcweizhou Can you please meld the commits into a single commit, and incorporate any remaining changes asked in the review? Ping, can we have a re-review

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8880: calculate free m...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/847#issuecomment-175669153 @kishankavala ping? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

RE: Quick note about $dayjob

Sebastien Sorry to hear that you have to move on. Wishing you all the best for your future plans with skippbox - a very exciting looking project You have been a dedicated, thorough and truly inspirational VP for this project – I would like to personally thank you for that. I hope very much th

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-175669973 Merging based on comments and 2LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/855 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-175671185 @SudharmaJain Please rebase and send for a re-review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-175671692 Ping review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-175672214 @ProjectMoon can you rebase against latest master, and squash changes to a single commit --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-7984: Collect network st...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/926#issuecomment-175672456 @ustcweizhou Can you please rebase against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

disable github notifications ?

Hi folks, Shall we disable github notifications to dev@ ? It has become quite noisy. On the other end you see all the comments fly by... -sebastien

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-175673522 @SudharmaJain please rebase against latest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-175670480 @bvbharat please squash the changes into a single commit ping, re-review please --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-175674716 LGTM Merging based on comments, test results shared and 2+LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: disable github notifications ?

Yeah, it is quite noisy. I would be fine with us disabling them. On Wednesday, January 27, 2016, sebgoa wrote: > Hi folks, > > Shall we disable github notifications to dev@ ? > > It has become quite noisy. > > On the other end you see all the comments fly by... > > -sebastien > -- *Mike Tutko

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-175675613 @ustcweizhou please rebase against latest and send for a re-review --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-175675521 Squashing and rebasing is definitely needed. But isn't this a bug fix though? And thus should go on to 4.6 and then be forward merged? --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-5822: keep user-added sshkeys ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1044#issuecomment-175677195 LGTM Merging based on 2+LGTMs, test results shared in comments --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: disable github notifications ?

On 27-01-16 16:01, Mike Tutkowski wrote: > Yeah, it is quite noisy. I would be fine with us disabling them. > Agree. I wouldn't mind. > On Wednesday, January 27, 2016, sebgoa wrote: > >> Hi folks, >> >> Shall we disable github notifications to dev@ ? >> >> It has become quite noisy. >> >> On

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1048#issuecomment-175679311 LGTM Merging based on review, 2+LGTM and test result shared in comments --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1087#issuecomment-175680172 @PaulAngus please rebase against latest master and force push --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1103#issuecomment-175681455 @pdion891 please rebase against latest and squash commits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Add47xmessagesproperties transifex

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1098#issuecomment-175680903 @milamberspace is this still valid, now that we've a 4.8 and master's on 4.9? cc @remibergsma --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-175681911 @wolf29 please rebase against latest and meld commits into a single commit --- If your project is set up for it, you can reply to this email and have your reply a

Build failed in Jenkins: build-master-slowbuild #3088

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-175682672 @agneya2001 @abhinandanprateek please review and close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1124#issuecomment-175683387 LGTM, @rafaelweingartner can you please rebase against latest master so we can merge this --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-175683694 LGTM anyone, needs one more? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-5822: keep user-added sshkeys ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1044 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-175683955 @sanju1010 looking forward to the test results --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-175685066 @SudharmaJain can you comment on @pedro-martins 's comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1212#issuecomment-175687426 LGTM, if we don't have any outstanding objections -- let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8654: Added guest_os m...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1244#issuecomment-175687981 @kishankavala please rebase against latest master and move the sqls to the recent sql paths --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: disable github notifications ?

I don't know exactly what to do, but I believe Rene left the list because it was too noisy, …that's not good. On Jan 27, 2016, at 4:10 PM, Giles Sirett wrote: > Is there any other way of doing it ? (i.e can we get a summary of the > comments sent to the list) > > I filter out the GH notificat

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-175689026 LGTM, merging based on comments and tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9208: Assertion Error in VM_PO...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1307#issuecomment-175689441 Ping? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-175687764 @dmytro-shevchenko can you rebase against latest master (with 4.9xx as the version) etc. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1310#issuecomment-175689785 LGTM, can we have regression test results against VMware then we would be able to merge this. --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-175690062 @sanju1010 please squash changes in to a single commit and comment if all outstanding issues are resolved now? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-175690290 LGTM, should we merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-175690469 LGTM, let's merge after some tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

  1   2   3   >