Build failed in Jenkins: build-master-slowbuild #2950

2016-01-10 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1325#issuecomment-170333261 @nitin-maharana Could you please review this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170333254 @nitin-maharana Could you please review this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: What happened to the Jenkins CI test on PRs?

2016-01-10 Thread Daan Hoogland
Remi, it shouldn't have been. I'll look at it. On Fri, Jan 8, 2016 at 8:38 PM, Remi Bergsma wrote: > Hi, > > What happened to the Jenkins test on PRs? It seems PR 1287 was the last > one to have both Travis CI and Jenkins. Since then, it’s only Travis CI. > > Why was it removed? (did I miss the

Re: What happened to the Jenkins CI test on PRs?

2016-01-10 Thread Daan Hoogland
communication seems flaky. Later jobs have run. 1316 was the last one and it completed successfully but didn't report back to github. 1315 did report back, though. I entered a ticket: INFRA-11058. On Sun, Jan 10, 2016 at 12:22 PM, Daan Hoogland wrote: > Remi, it shouldn't have been. I'll look at

Re: LTS release or not

2016-01-10 Thread Daan Hoogland
Rene, I would advice to support 4.7 as LTS. It adheres to the new development/release process unlike 4.5 and any bugfixes there can automatically be merged forward to newer releases to reduce the chance of regression. I am in favour of the general concept. On Sun, Jan 10, 2016 at 12:12 AM, Rubens

Re: [DISCUSS] Move to Github

2016-01-10 Thread Daan Hoogland
people, what we are saying by moving to github, completely is that, for now, we will be moving away from apache. Apache can not take responsibility for any code that is not under it's control. This is fine, but to satisfy the foundation policy, maintaining an *Apache* CloudStack we would have to ha

Re: gitlab.apache.org

2016-01-10 Thread Daan Hoogland
Thanks for the info David, I'll keep it in mind. The force is pulling cloudstack to the github-side strong at the moment. I thought of gitlabs as the closest, easiest, cheapest alternative but am open to any. I'll find time to have a look at those pointers. On Sun, Jan 10, 2016 at 7:08 AM, David N

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1315#issuecomment-170338260 LGTM too, thanks @shwetaag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1325#issuecomment-170339405 makes sense. pinging @ustcweizhou to check as well. It reminds me of an Leaseweb internal change. Wei can you LGTM or make other sugestions? --- If your proje

Build failed in Jenkins: build-master-slowbuild #2951

2016-01-10 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-170340253 sorry @rodrigo93 it got squashed between all the work we did during the last releases. I'll start it again. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170340809 * Results ``` [root@cs1 integration]# less /tmp//MarvinLogs/test_vpc_redundant_DIBS05/results.txt Create a redundant VPC with two networks

Pull Requests we should include in 4.7.1 / 4.8.0

2016-01-10 Thread Remi Bergsma
Hi all, Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more ti

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...

2016-01-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1212#issuecomment-170342555 @ustcweizhou any update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170343091 @wilderrodrigues I will start this in my old bubble and do some review. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-170352243 @jayapalu Unfortunately it didn't work for me. ``` Error 534, Resource [Site2SiteVpnConnection:1] is unreachable: Failed to apply site-to-site VPN

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170352576 got an error during the install: ``` /data/git/cs1/cloudstack Done. HEAD is now at 2a9927a Merge pull request #1315 from pavanb018/master Swi

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170352604 never mind, should have tried with -b 4.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9217

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1322#issuecomment-170353002 @pavanb018 I like this code. Can you point me to the (minimal) marvin definition of the environment needed to run this? --- If your project is set up for it,

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9217

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1322#issuecomment-170353332 Also I would like to see the commit and PR have a different name like: ```CLOUDSTACK-9217 test block volume migration to a pool in maintenance mode``` ---

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1323#discussion_r49276570 --- Diff: test/integration/component/test_redundant_router_cleanups.py --- @@ -666,3 +667,156 @@ def test_network_gc(self):

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1323#issuecomment-170353747 LGTM. only code review done with one remark on naming of the method. Not tested. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1324#issuecomment-170354023 makes sense. I doubt, this will do but it will reduce the chance of failure. It will not produce false negatives beyond the specified precision margin of the f

Re: Pull Requests we should include in 4.7.1 / 4.8.0

2016-01-10 Thread Ron Wheeler
Are all of the documentation PRs included now? Ron On 10/01/2016 7:23 AM, Remi Bergsma wrote: Hi all, Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little eff

Re: Pull Requests we should include in 4.7.1 / 4.8.0

2016-01-10 Thread Ron Wheeler
Are all of the documentation issues fixed? Does the documentation reflect the 4.7.1/4.8 release? Are there any new issues that need to be created to update the documentation? Ron On 10/01/2016 7:23 AM, Remi Bergsma wrote: Hi all, Below is a list of the PRs I'd like to suggest for our upcom

[GitHub] cloudstack pull request: CLOUDSTACK-9216: Fix DHCP lease removal l...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1318#issuecomment-170355370 I am in favour of simplification. one question: doesn't this fire much more release commands then needed? one for every interface on the router, while it is ne

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1296#issuecomment-170356076 LGTM (think I gave it that when it was a PR on master, already) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1252#issuecomment-170357234 @rodrigo93 I agree but it seems that this behavioral change might be a compatibility problem to some. I would like this to be tweekable with a setting. People

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-170358366 @remibergsma again I see things we have internally at Leaseweb as well. @ustcweizhou can you have a look as well? --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: New test to validate starting vm after ni...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1326#issuecomment-170358521 LGTM based on the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Build failed in Jenkins: build-master-slowbuild #2952

2016-01-10 Thread jenkins
See Changes: [pavanbandarupally] Automation for CLOUDSTACK-9214 , detect wrong GW or NM -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findb

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170359075 code reviewed, simple fix for convenience in large installations: LGTM --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-170359050 Systemvm template seems right. ![screen shot 2016-01-10 at 16 17 32](https://cloud.githubusercontent.com/assets/1630096/1209/bfd4bc64-b7b5-11e5-9690-bd170

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-170359977 The weird thing is that it is in error state, but it seems to work: ``` root@r-3-VM:~# /opt/cloud/bin/checks2svpn.sh 192.168.23.54 ISAKMP SA found

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-170360230 @DaanHoogland What a waste of resources :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-170360300 @DaanHoogland Indeed, that should work :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-170360426 When I do a "reset vpn connection" it worked. Hmm.. will destroy everything and try again. Want to see a few times that this works without errors. --- If your p

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-170360605 What could have caused the "error" is that it actually timed out. The script that was suppose to start the connection was hanging: ``` root 3237

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-170361427 @jayapalu Repeated the test, same result. The first connections gets in Error state. It does actually connect, even without "reset VPN connection" but it seems n

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

2016-01-10 Thread cristofolini
Github user cristofolini commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1310#discussion_r49279282 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1895,6 +1896,9 @@ protected StartAnswer e

Build failed in Jenkins: build-master-slowbuild #2953

2016-01-10 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2016-01-10 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-170379092 That's ok @DaanHoogland, don't need to hurry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...

2016-01-10 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/1252#issuecomment-170381257 @DaanHoogland I see... With that option in settings, things could be more manageable. That is a good suggestion. --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-10 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1324#issuecomment-170381531 I've had tests involving sleep calls fail on me seemingly arbitrarily, to the point where simply re-running them would give me a passing result. I think someth

Re: Pull Requests we should include in 4.7.1 / 4.8.0

2016-01-10 Thread Wido den Hollander
On 01/10/2016 01:23 PM, Remi Bergsma wrote: > Hi all, > > Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 > releases. Please help review and test these. Lots of them already had some > form of tesing/review so with little effort we might be able to get them in > on t

Re: LTS release or not

2016-01-10 Thread Wido den Hollander
On 01/09/2016 11:51 PM, Rene Moser wrote: > Hi > > I recently started a discussion about the current release process. You > may have noticed that CloudStack had a few releases in the last 2 months. > > My concerns were that many CloudStack users will be confused about these > many releases (whi

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1324#issuecomment-170385290 validating by compile: ``` [INFO] [INFO] BUILD SUCCESS [INFO]

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-170387660 it zooming. I think it passes all the way but I made a booboo on the test scripts running an old version. will report tomorow morning, @rodrigo93 . --- If your

Re: LTS release or not

2016-01-10 Thread Rene Moser
Hi Wido On 01/10/2016 08:23 PM, Wido den Hollander wrote: > I personally am against LTS versions. If we keep the release cycle short > enough each .1 increment in version will only include a very small set > of features and bug fixes. > > In the old days it took months for a release, if we bring

Re: LTS release or not

2016-01-10 Thread Rene Moser
Daan Have not yet decided which version, but fixes will be backported into LTS not the other way around. But I see what you mean. The code base may have much diverted before 4.7 right? It is not really a problem. It only means more work (argh...). Sooner or later this will happen for every relea

Re: LTS release or not

2016-01-10 Thread Wido den Hollander
On 01/10/2016 09:58 PM, Rene Moser wrote: > Hi Wido > > On 01/10/2016 08:23 PM, Wido den Hollander wrote: >> I personally am against LTS versions. If we keep the release cycle short >> enough each .1 increment in version will only include a very small set >> of features and bug fixes. >> >> In t

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2016-01-10 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-170394300 Alright @DaanHoogland. Thanks for the help! =) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

Build failed in Jenkins: build-master-slowbuild #2954

2016-01-10 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: LTS release or not

2016-01-10 Thread Rene Moser
On 01/10/2016 10:07 PM, Wido den Hollander wrote: > Ok, understood. However, it will be up to users on their own to pick > this LTS maintainment up. It would be up to the devs making fixes small (so no squashing for fixes) and notify the one maintaining the LTS version if they feel the fix is tha

Re: LTS release or not

2016-01-10 Thread Erik Weber
On Sun, Jan 10, 2016 at 10:27 PM, Rene Moser wrote: > > On 01/10/2016 10:07 PM, Wido den Hollander wrote: > > Ok, understood. However, it will be up to users on their own to pick > > this LTS maintainment up. > > It would be up to the devs making fixes small (so no squashing for > fixes) and noti

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-01-10 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-170406819 nice =) Can you create a java doc to explain your 'isRouterDeployed()' (even the name explaining itself)? If you can create a test case for only this

Build failed in Jenkins: build-master-slowbuild #2955

2016-01-10 Thread jenkins
See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9199: Fixed deployVirtualMachi...

2016-01-10 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-170409736 Nice :) Can you extract the code to a method with a javadoc explaining the code? If you can do a testcase for the method too, it will be apreciated :)

Build failed in Jenkins: build-master-slowbuild #2956

2016-01-10 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2957

2016-01-10 Thread jenkins
See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: LTS release or not

2016-01-10 Thread Rene Moser
On 01/10/2016 11:46 PM, Erik Weber wrote: > What if the fix is part of a refactorization or a new feature? > Providing a LTS is not 'easy as pie' with a product like CloudStack where a > lot of code changes over time. Didn't say it's easy :) Yes re-factorization is one of the unsolved "problem

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170453979 @remibergsma: Checked for all alphabet names, its sorting perfectly. But how it is sorting for special character names starting with @, #, etc. Is it sorting

[GitHub] cloudstack pull request: CLOUDSTACK-9220 Sort list of domains on D...

2016-01-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1327#issuecomment-170454175 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...

2016-01-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1240#issuecomment-170454494 @remibergsma ping, let's merge this before the freeze? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-9221 Allow admin to see user V...

2016-01-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1325#issuecomment-170454592 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

2016-01-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-170456162 @remibergsma let's test and merge this before the freeze. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Quota: findbug fixes

2016-01-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1289#discussion_r49295533 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java --- @@ -310,14 +269,12 @@ public String getDeploymentPlanner() {

[GitHub] cloudstack pull request: Quota: findbug fixes

2016-01-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-170455889 @agneya2001 can you help fix the issues, before the freeze. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on