[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167068940 @anshul1886 (ignoring my usual remarks in testing) isn't this for 4.6 and to be merged forward then? It must be missing in all releases in between, right? ---

Build failed in Jenkins: build-master-slowbuild #2814

See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-167075932 ping @borisroman. I would like to see this one go in. Code-wise it looks good. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167078298 Yes, It is missing in all releases. It can be backported to 4.6. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167079071 I would like it to be a PR to 4.6 and be forward merged to 4.7 and master, instead of being applied on master. ping @remibergsma @wilderrodrigues @borisroma

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r48408287 --- Diff: tools/marvin/marvin/lib/base.py --- @@ -3876,7 +3876,12 @@ def add(cls, apiclient, services, physicalnetworkid, else:

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167088134 Can we have review on this PR and when everybody is satisfied then create PR for 4.6? --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167094061 yes, and that would mean that we need to run the regression suite against it twice. I am satisfied with it for now, but want to see testing. better to run that

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1286 CLOUDSTACK-4572: findHostsForMigration API does not return correct host list https://issues.apache.org/jira/browse/CLOUDSTACK-4572 Fix is missing in recent releases. The api

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167095249 Closing this PR, Created new PR against 4.6 https://github.com/apache/cloudstack/pull/1286. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1260#discussion_r48411330 --- Diff: plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java --- @@ -58,34 +58,6 @@ public void setName(String

Build failed in Jenkins: build-master-slowbuild #2815

See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167105359 I've tested this PR with the additional [commits](https://github.com/nvazquez/cloudstack/pull/1) that I've requested to be merged here. My environm

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167111401 @DaanHoogland I can't figure out why the rats build is failing. Can you please help us? --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167114866 @miguelaferreira the report says api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java doesn't contain a known license --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r48415371 --- Diff: api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java --- @@ -0,0 +1,12 @@ +package com.cloud.network.guru; --- End d

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r48416674 --- Diff: api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java --- @@ -0,0 +1,12 @@ +package com.cloud.network.guru; --- End diff

Build failed in Jenkins: build-master-slowbuild #2816

See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-167135604 Null check LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

Build failed in Jenkins: build-master-slowbuild #2817

See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167148441 Nice work guys! @nvazquez This will be merged to master, which is now at `4.8.0-SNAPSHOT`. Can you please rebase with master, and move your SQL change t

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167149518 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167150961 @remibergsma Thanks a lot Remi! I rebased with master, moved sql to 4.8.0 schema and pushed it again. @miguelaferreira Thanks a lot for your help and your effor

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167155923 @DaanHoogland Jenkins failed due to this (missing artifact). Any hint on the cause? ``` Archiving artifacts ERROR: No artifacts found that match the

Build failed in Jenkins: build-master-slowbuild #2818

See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2819

See -- [...truncated 28732 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2820

See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2821

See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack