[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

2015-12-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-166087210 @andrijapanic Merge without testing and LGTMs? Really? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Request for assistance with Xenserver

2015-12-20 Thread Remi Bergsma
Hi Rafael, This is from my devtest environment: XS62 xe host-param-list uuid=uuid | grep software-version software-version (MRO): product_version: 6.2.0; product_version_text: 6.2; product_version_text_short: 6.2; platform_name: XCP; platform_version: 1.8.0; product_brand:

Build failed in Jenkins: build-master-slowbuild #2782

2015-12-20 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [DISCUSS] Move to Github

2015-12-20 Thread Remi Bergsma
Hi Rene, We’re at the stage that running the integration tests is a one-liner and 7 hour wait [1]. It’s running a subset [2] of available Marvin tests. The problem is that Marvin is slow and sometimes flaky (error found, rerun is fine). So the test results need manual review before you can publ

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

2015-12-20 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1230#discussion_r48101628 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java --- @@ -1274,7 +1274,46 @@ public Answer createVolumeFromSn

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

2015-12-20 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1230#discussion_r48101631 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java --- @@ -1274,7 +1274,46 @@ public Answer createVolumeFromSn

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

2015-12-20 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-166100502 Last code review is LGTM to me, but didn't have the time to test it yet. I *think* it works, but need to verify first. --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-20 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166109722 cc @remibergsma @kishankavala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

Re: Request for assistance with Xenserver

2015-12-20 Thread Rafael Weingärtner
Thanks, Remi, Just by looking at your output, I found the bug. I will open a Jira ticket and a PR to fix that. The problem is the following: In environments in which we use pure Xen hypervisor + XAPI, ACS is not loading the Hypervisor version properly. That happens because when you use pure Xen Hy

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166112617 @nitin-maharana Thanks. Are there any other api calls that have the same issue? --- If your project is set up for it, you can reply to this email and have your

Build failed in Jenkins: build-master-slowbuild #2783

2015-12-20 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: Request for assistance with Xenserver

2015-12-20 Thread Rafael Weingärtner
Ticket created https://issues.apache.org/jira/browse/CLOUDSTACK-9190 On Sun, Dec 20, 2015 at 9:00 AM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Thanks, Remi, > Just by looking at your output, I found the bug. > I will open a Jira ticket and a PR to fix that. > > The problem is th

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-20 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166114305 @nitin-maharana shouldn't we use the "recursive" parameter set to "true" too? --- If your project is set up for it, you can reply to this email and have

Re: Request for assistance with Xenserver

2015-12-20 Thread Remi Bergsma
Hi Rafael, Are you sure pure xen is supported? I think all code now assumes xenserver. Although when you use xapi it might as well work. This needs to be tested thoroughly. Regards, Remi > On 20 Dec 2015, at 13:39, Rafael Weingärtner > wrote: > > Ticket created https://issues.apache.org/

Re: Request for assistance with Xenserver

2015-12-20 Thread Rafael Weingärtner
When I said pure Xen, I meant XCP. XCP can be seen as an acronym to Xen hypervisor + XAPI. I recall to have explained that (difference between XCP and XenServer ) once or twice at the users list. Nowadays, the XCP version that was provided on top of an OS has been discontinued. However, we can use

Re: Build failed in Jenkins: build-master-slowbuild #2783

2015-12-20 Thread Daan Hoogland
Sateesh, Rohit, Abhi, Can you guys look at the 5 new warnings? These are in your contributions. On Sun, Dec 20, 2015 at 1:09 PM, wrote: > See > > -- > [...truncated 28722 lines...] > [INFO

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

2015-12-20 Thread GabrielBrascher
GitHub user GabrielBrascher opened a pull request: https://github.com/apache/cloudstack/pull/1263 Removed unused code from com.cloud.api.ApiServer **Removed “\_” from variables names**: private variables with “\_” at the beginning is common in C++ but not in Java.

Build failed in Jenkins: build-master-slowbuild #2784

2015-12-20 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

RE: Request for assistance with Xenserver

2015-12-20 Thread Paul Angus
Hi Rafael, I'm pretty sure XCP has not been maintained since Citrix's XenServer was made fully opensource. Tim Mackey from the Xen Project did a load of work so that the CloudStack code explicitly refers to XenServer to cover this; making way for Xen (as Xen+Libvirt) to be introduced - somethi

Re: Request for assistance with Xenserver

2015-12-20 Thread Rafael Weingärtner
I know that XCP per se is not being maintained anymore, you can read about that here: http://www.xenproject.org/developers/teams/xapi.html The XCP as an “OS” that would come with Xen hypervisor + XAPI on top of CentOS was discontinued. However, the XAPI project per se continues to be developed as i

RE: Request for assistance with Xenserver

2015-12-20 Thread Paul Angus
Rafael, Sorry I wasn't clear enough. I meant XCP support in CloudStack not having been maintained for some time. I have built Debian+Xen+XAPI for clients before, but the driver was staying open source; which became much simpler with the opensource XenServer. The result of stopping that maintena

Re: Request for assistance with Xenserver

2015-12-20 Thread Rafael Weingärtner
Now I got your point, That is true; there has not been much evolution in ACS in respect to XCP. I know that, the last commit in respect to XCP, was a bug that we (I and some colleagues) fixed a while ago. Since, we are using it in our environment; we are checking if everything is working properly w

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

2015-12-20 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-166138005 @rafaelweingartner Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

Build failed in Jenkins: build-master-slowbuild #2785

2015-12-20 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2786

2015-12-20 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Protocol to add scripts to a newer version of ACS

2015-12-20 Thread Rafael Weingärtner
Hi guys, I am working on a PR that will require some data to be added to “guest_os_hypervisor” table. However, there is no “*to480.sql” script yet. How is the protocol to add those inserts that I need into the code base? -- Rafael Weingärtner

Build failed in Jenkins: build-master-slowbuild #2787

2015-12-20 Thread jenkins
See -- [...truncated 28732 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2788

2015-12-20 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2789

2015-12-20 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: Protocol to add scripts to a newer version of ACS

2015-12-20 Thread Daan Hoogland
H Rafael, just make a PR. the 4.7.0 should serve as a proper example. On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi guys, > > I am working on a PR that will require some data to be added to > “guest_os_hypervisor” table. However, there is no “*to4

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

2015-12-20 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1264 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing Reproducible Steps: 1.Create a customer gateway for a VPC. 2.Edit it using UI(API call is UpdateVpnCustom

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

2015-12-20 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-166223258 cc @JayapalUradi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

2015-12-20 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-166223301 @nitin-maharana I am not sure if it is necessary to add the following change after success, but I added it in my fix, basides your change. ```