[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165712661 since #1257 replaces this PR I would do so, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165715666 @resmo ok sure. thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user andrijapanic commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-165716739 Anyone has any more feedback ? Should we merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-165717186 I'll see if I can run tests on it today with @borisroman on our dev setup --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1230#discussion_r48005662 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java --- @@ -1274,7 +1274,45 @@ public Answer createVolumeFromSn

RM wanted

H all, For 4.8 we need RMs. I will not continue with this job and if Remi does, he shouldn't be on his own! Any committer that feels like it is needed and they are capable, please come forward. Of course, if you feel we can do without, please elaborate on your views. I think this job can be share

[GitHub] cloudstack pull request: [4.7.0/master] DB Paths fixes: 4.5.3->4.7...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1247#discussion_r48008950 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -242,13 +243,13 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: [4.7.0/master] DB Paths fixes: 4.5.3->4.7...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1247#discussion_r48008985 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade462to470.java --- @@ -0,0 +1,29 @@ +// Licensed to the Apache Software Foundation (ASF)

4.7.0 vote passed -> freeze is over

Committers, please keep in mind our quality standards when executing your liberty to merge. -- Daan

Re: 4.7.0 vote passed -> freeze is over

Releases branches should only be written to by RMs. On Dec 18, 2015, at 11:22 AM, Daan Hoogland wrote: > Committers, please keep in mind our quality standards when executing your > liberty to merge. > > -- > Daan

Re: 4.7.0 vote passed -> freeze is over

Sebastien, On Fri, Dec 18, 2015 at 11:36 AM, sebgoa wrote: > Releases branches should only be written to by RMs. > ​Knowing how you feel about the process you mean 'master' as much as older branches, right? I would not want to be responsible for the growing number of PRs as RM. (the main reason

Re: 4.7.0 vote passed -> freeze is over

On Dec 18, 2015, at 11:44 AM, Daan Hoogland wrote: > Sebastien, > > On Fri, Dec 18, 2015 at 11:36 AM, sebgoa wrote: > >> Releases branches should only be written to by RMs. >> > ​Knowing how you feel about the process you mean 'master' as much as older > branches, right? > > I would not wan

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-165757054 cc @koushik-das @kishankavala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

Re: 4.7.0 vote passed -> freeze is over

I had to let this sink in, Sebastien. I'm not at my 'I can' endurance condition at the moment, sorry. There is a consequence; Remi, our only RM has small kids and is on holidays during the holidays, I understand. For all intended purposes we have a freeze until January ;) On Fri, Dec 18, 2015 at

Re: 4.7.0 vote passed -> freeze is over

There’s an important difference between “The RM merges to release branches” and “The RM should test everything on its own and then merge”. It’s more like the latter currently. Unfortunately not many people review and test so this is not scalable. I will be offline next week only, so we should b

[GitHub] cloudstack pull request: [4.7.0/master] DB Paths fixes: 4.5.3->4.7...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1247#discussion_r48020023 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -242,13 +243,13 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: [4.7.0/master] DB Paths fixes: 4.5.3->4.7...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1247#discussion_r48020299 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -242,13 +243,13 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: [4.7.0/master] DB Paths fixes: 4.5.3->4.7...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1247#discussion_r48020663 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -242,13 +243,13 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user voloshanenko commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1230#discussion_r48025223 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java --- @@ -1274,7 +1274,45 @@ public Answer createVolu

Results of a IPv6 brainstorm day

Hi, Yesterday we from PCextreme, Leaseweb and Schuberg Phillis sat down for a IPv6 brainstorm session. We asked a good IPv6 consultant (Sander Steffann) to join us to help us identify some glitches in our ideas. We had two ideas: - https://cwiki.apache.org/confluence/display/CLOUDSTACK/IPv6+in+B

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1230#discussion_r48026314 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java --- @@ -1274,7 +1274,45 @@ public Answer createVolumeFromSn

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r48029359 --- Diff: tools/marvin/marvin/lib/base.py --- @@ -3876,7 +3876,12 @@ def add(cls, apiclient, services, physicalnetworkid, else:

RE: RM wanted

Daan, Could you describe on the 'qualifications' required for the job. (I have a Grade 1 Violin certificate?!). [ShapeBlue] Paul Angus VP Technology , ShapeBlue d: +44 203 603 0540 | s: +44 203 617 0528 | m: +44 7711 418784 e: paul.

Re: RM wanted

I don't think we need more RMs per se. I'd rather have more people testing and reviewing the PRs. That will bring more velocity, not more RMs. Being RM now is a hell of a job because only a few people do reviews and tests and I was crazy enough to compensate for that by testing many of them mys

Re: RM wanted

And that is what it should be ;) So untill then the qualification is being able to test PRs in abundance. On Fri, Dec 18, 2015 at 5:06 PM, Remi Bergsma wrote: > I don't think we need more RMs per se. I'd rather have more people testing > and reviewing the PRs. That will bring more velocity, not

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-165892090 Integration tests are OK: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_v

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-165919008 commit one is a good improvement commit two is not usefull but harmless code looks good to me! (<== LGTM) --- If your project is set up for it, you can