Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164188525
@borisroman I don't agree with your :-1: The artifact from a port in a test
class that otherwise compiles is worth a -1?
---
If your project is set up for it,
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164189121
Hi @DaanHoogland, well then that's your opinion. Mine is, as a developer I
do not want dead code to be added to the project.
Therefore I stand by my :-1:
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164190196
Have discussed the upgrade paths with @DaanHoogland We are implementing
them as we speak.
---
If your project is set up for it, you can reply to this email and
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164191465
LGTM :+1: All pom.xml files haven been correctly changed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164191853
It is certainly not wanted but as it is in an otherwise working unit test
it is allowed. It does not interfere with the correct working of the system.
---
If
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1233
4.6.2 -> 4.7.0 upgrade does not use any scripts above 4.6.1
test build ongoing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1233#issuecomment-164194791
As discussed, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1233#issuecomment-164196319
LGTM :+1:
Nice way of not creating duplicate code!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164196808
ran the build:
```
checking for unpackaged file(s): /usr/lib/rpm/check-files
/data/git/cs1/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.2-SNAPSHOT.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1212#discussion_r47437500
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -185,6 +186,8 @@
@Mock
GlobalLoadBalancerRuleDao _gslbRuleDa
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164198697
@DaanHoogland I will add some tests in the file when I have time.
currently I have some other tasks to do (not porting).
---
If your project is set up for i
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-164199095
@DaanHoogland @wilderrodrigues
assume there are two routers now routerA (master) and routerB (backup).
if we destroy routerA (master) at first, then rou
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1209#discussion_r47437641
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -222,11 +222,20 @@ public String getIpAddress(long networkId, long
instanceId) {
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164199618
@ustcweizhou Thanks! Will see them when they arrive!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164200657
LGTM :+1:
**Environment**
- 2 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1232#issuecomment-164201023
Integration tests ran ok! @wido @remibergsma @wilderrodrigues
@miguelaferreira @DaanHoogland
**Environment**
- 2 KVM host on CentOS 7.1
- 1 Ma
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164201602
@ustcweizhou @borisroman we will release both 4.6.2 and 4.7.0 RDs tomorrow
---
If your project is set up for it, you can reply to this email and have your
repl
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164201764
@milamberspace Are we good to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1226#issuecomment-164204418
LGTM, is it in .gitignore? it should
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164204591
I'm hesitant, is really nothing usefull or being used in there? I would
like to know why this became out of use before disgarding it.
---
If your project is s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164204798
LGTM, and I agree with @borisroman the incremental change is better as we
had some initial problems with utils, After NSX and KVM I think we can
accelerate. un
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164205140
Hi @DaanHoogland
In late 2012 it was replaced with cloudmonkey. It's just some code that was
left behind. It's not touched since halfway through 2012.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164208189
OK, that makes sense. let's do it. if we need it there is always git
---
If your project is set up for it, you can reply to this email and have your
reply app
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1234
CLOUDSTACK-9153: When negative credits are added to an account the
When negative credits are added to an account the balance credits can
become negative for that account. This will fix will
101 - 128 of 128 matches
Mail list logo
