[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-04 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153629584 @jburwell I hear what you are saying, but I think it would be totally unfair to ask this plugin provider to provide independent testing capability to the community. N

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153631129 @runseb I am with you but for 4.7 instead of 4.6. The Nuage people have shown great effort of elegantly using our crappy plugin system and are now maintaining i

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-04 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153631839 @DaanHoogland yep, so we can release this right on the heel of 4.6 release, with just one commit to get 4.7. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

2015-11-04 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-153634024 @koushik-das Thanks for your comments. I pushed a new commit . --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-11-04 Thread NuxRo
Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153643254 @koushik-das You are right, I did not realise the display name was missing from there. Can't we make that table a bit wider so we can add another column or two?

[GitHub] cloudstack pull request:

2015-11-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/34fee547cd10025f91e47e5efa6a97a96dd96313#commitcomment-14176906 German is now fully translated --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

2015-11-04 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153650536 @wido code are updated. I have a node running with Ubuntu 12.04/qemu 1.2.1/libvirt 0.9.13 (not stock QEMU 1.0 and libvirt 0.9.8). It works fine in the vm snap

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

2015-11-04 Thread pritisarap12
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1031 CLOUDSTACK-9026: Modifying testpath for adding missing parameter Addning service_offering creation in testpath_storage_migration.py testpath which is missing right now You can merge this

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153656222 Talked with @karuturi and agreed that we make the tests in this PR work, then merge it. The other issue should be tracked and fixed separately as it is not a bl

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153664020 ran the regression set with some f ```nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/t

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-11-04 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1003 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

2015-11-04 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1004 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153664686 @koushik-das I understand removal of the column may not be accepted, but then the UI would look misaligned if I add another column due to strict width issues.

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread milamberspace
cc @remibergsma @DaanHoogland @karuturi You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack L10N-update-updateMaster-20151104 Alternatively you can review and apply these changes as the patch at: https://github.com

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153664875 @ustcweizhou I don't see the difference personally, as a admin you already have full access to the Instance if you want to. But this PR conflicts with mine, th

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153665922 +1 LGTM just looking at the translated strings. did not build it. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread sspans
Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153667126 Consistent Snapshots are not possible without freeze/thaw via the guest-agent. I think most people want good snapshots of their virtual machines. That sa

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153667726 @koushik-das I think it's inappropriate as we're not marking those fields to note that they have hold sensitive information; but anyway that works --- If your pro

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153667850 @sspans Indeed. Users can stop/disable the agent or even block specific commands if they wish to. As CloudStack we don't control what's in the Instance, so it's the us

[GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1030#issuecomment-153668049 I am not sure why this PR is marked blocker/critical. The implemented code is a nested. It should have been a factored out check-method with unit test, not wit

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153668057 So I wrote #985 which adds a channel by default to all guests. The question is, how do we proceed. Which one goes in? --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153668149 Also, it is possible to avoid serializing the objects by hand (like adding/appending {, >, <, } etc by hand?). Probably use any available library, and if that's no

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153669186 @runseb, yes in principle but we have a list of 4.7 candidates allready, so It would cantain a little more. Let's try to contain it though. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

2015-11-04 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-153669733 Seems good! Great to see this :) Some tests are failing though, could you look into that? --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153671338 I created https://issues.apache.org/jira/browse/CLOUDSTACK-9027 to track the new issue --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153672795 @wido this PR already includes your commits in #985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

2015-11-04 Thread Raja Pullela
Remi, Rajani, can you push this PR in ? Best, Raja -Original Message- From: Raja Pullela [mailto:raja.pull...@citrix.com] Sent: Tuesday, November 3, 2015 7:02 PM To: dev@cloudstack.apache.org Subject: Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config Cool, thanks Remi! a

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153673706 LGTM, test runs fine: ``` [root@cs1 MarvinLogs]# less test_vpc_vpn_WK8870/results.txt Test Remote Access VPN in VPC ... === TestName: test_vpc_r

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153673995 Thanks, @karuturi ! I already found the error in the test, running it now and will push the code. The problem was: * For RVR networks, an e

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1028 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153674330 @ustcweizhou Ah, I see indeed. So the discussion is: - Do we enable the port by default? I would say yes. (Less code!) - Do we enable the port for SSVMs

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153677208 @bhaisaab can you explain ? I like your comment about the annotation not being descriptive on the sensitivity of the field. So for the best solution we would h

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153678077 +1 LGTM (ignore jenkins, one of the modules crashed due to jvm issue not code issues) @remibergsma include this? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8902 Restart Network fails in ...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/898 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153680282 @bhaisaab I agree that this run on jenkins can be ignored but let's see a successful compile anyhow. I have it in my queue but I will forgive anybody that beat

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-153680788 LGTM +1 (just code review, no testing was performed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153681147 Glad you found it @wilderrodrigues and thanks for the fix! Will retest soon! --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

2015-11-04 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153681436 @wido @sspans To be honest, this code was written by me about two years ago , which is not used for now. I created the PR because you guys can judge this co

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1009#issuecomment-153681458 code LGTM, @rags22489664 can you put the integration test in the simulator on your backlog? would love to see it :) If tests pass merge, @remibergsma . Thought

[GitHub] cloudstack pull request: CID 1338016: multi catch instead of pokem...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1018#issuecomment-153681786 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-153681753 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153681687 @DaanHoogland we can simply use @LogLevel I simply shared that there is a slight chance on confusion in future, and do we then remove the requestHasSensitiveInfo/r

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9012 :automation of cores feat...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1011#issuecomment-153681911 LGTM (not tested, just reviewed code) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1010#issuecomment-153682260 @pritisarap12 I don't see any changes on the "Files changed" tab is the file plaintext with 0644 file mod, or is it already merged on master? --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153682474 @bhaisaab no we shouldn't remove those both are used. I didn't understand the {, <, >, } part. The @LogLevel is used in the gson serialization and we

[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

2015-11-04 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1010#issuecomment-153682641 @bhaisaab It's a new file with more then 2k lines, so github doesn't show it right away. Though if you click on view you can see it. https://github.com/

Re: New PMC member: Erik Weber

2015-11-04 Thread Boris Schrijver
Congrats Erik! --  Met vriendelijke groet / Kind regards, Boris Schrijver PCextreme B.V. http://www.pcextreme.nl/contact Tel direct: +31 6 33784542 > On November 3, 2015 at 9:05 AM Erik Weber wrote: > > > Thanks again all :-) > > Erik > > On Sat, Oct 31, 2015 at 7:06 PM, Jan-Arve Nygård

[GitHub] cloudstack pull request: CLOUDSTACK-8958: add dedicated ips to dom...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1007#issuecomment-153683174 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1000#issuecomment-153683247 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/997#issuecomment-153683821 Updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-153684531 LGTM (code, no testing performed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-153684702 LGTM, @abhinandanprateek do you have any comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153686114 @DaanHoogland @bhaisaab requestHasSensitiveInfo/responseHasSensitiveInfo can be removed once this PR is accepted. I don't see any other use of these parameters.

[GitHub] cloudstack pull request: CLOUDSTACK-8976 - Sorting of security gro...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/937#issuecomment-153686857 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153686801 @koushik-das You don't agree that the name LogLevel obfuscates that it is used to hide sensitive data? --- If your project is set up for it, you can reply to

Build failed in Jenkins: build-4.5 #537

2015-11-04 Thread jenkins
See Changes: [Rohit Yadav] CLOUDSTACK-9006 - ListTemplates API returns result in inconsistent order when called concurrently [Rohit Yadav] CLOUDSTACK-9006 - ListTemplates API returns result in inconsistent order when called concurrentl

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8951: validation for con...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/929#issuecomment-153688096 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/928#issuecomment-153688197 LGTM (just code review, no testing performed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/927#issuecomment-153688514 It might break compatibility as for some configs (global configs) people might be consuming global settings. With this change, list configuration API would return e

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-11-04 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-153688607 Simple configuration change. Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/927#issuecomment-153688690 I'm not sure the best to deal with it, but I would avoid putting extra security if that gets into the way of tuning the system. --- If your project is set up for i

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/926#issuecomment-153688875 LGTM (just code, no testing performed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-153689139 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153689393 @DaanHoogland I figured Travis is green and changes were just in properties file, so looked good to me --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1010#issuecomment-153689927 @borisroman cool thanks, weird though as I've seen github show the entire file in some of the previous PRs --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153690595 @DaanHoogland if you look at the changes or the code that takes in Object (Response object) and serializes it; we create the json or xml response string by manuall

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153690547 @DaanHoogland I think LogLevel is a better/generic name to suppress a field from getting logged. Currently only sensitive field is getting annotated with it. Go

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153693746 Ping @remibergsma @karuturi @borisroman @DaanHoogland @miguelaferreira Test is finally done and bug-free! Test Environment: * Hard

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153694220 @wilderrodrigues Running now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153695015 @bhaisaab Agree that the existing JSON and XML serialization can be improved but it is better to do it as a separate PR. For JSON, the standard Gson library is

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

2015-11-04 Thread Rajani Karuturi
Its merged. ~Rajani Sent from my Windows Phone From: Raja Pullela Sent: ‎04-‎11-‎15 15:55 To: dev@cloudstack.apache.org Subject: RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config Remi,

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153699912 @wilderrodrigues @remibergsma Still had the tests setup running. Here are the results: ``` === TestName: test_01_isolate_network_FW_PF_default_route

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/902 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153701619 Jenkins error is not related. It says "no failures" but still shows a red button on Cloud Server. By the way, I pushed a python file. ![image](http

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153701940 JVM died: https://builds.apache.org/job/cloudstack-pull-analysis/1150/org.apache.cloudstack$cloud-server/console --- If your project is set up for it, you

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

2015-11-04 Thread Raja Pullela
Thank you Rajani! -Original Message- From: Rajani Karuturi [mailto:rajani.karut...@citrix.com] Sent: Wednesday, November 4, 2015 5:18 PM To: dev@cloudstack.apache.org Subject: RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config Its merged. ~Rajani Sent from my Windows Phone _

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153702504 ok, travis green does not mean it actually does anything, does it? In this case I think it did compile but none of the tests were run. Maybe that's enough for

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153704575 @koushik-das makes sense so we have a policy that for any sensitive field LogLevel(LogLevel.OFF) be used. We should add that as a comment to the enum to docume

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153707458 A ticket is out for this at infra: INFRA-10703 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153708234 Shouldn't we at least try a compile and see if the UI shows up? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153708491 @DaanHoogland A picture or it didn't happen! ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153708419 Just did LGTM (logging in as a sturmbahn) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153709054 ![untitled](https://cloud.githubusercontent.com/assets/2486961/10938358/b6905d48-82f9-11e5-9fd7-2a93934c7d8d.png) --- If your project is set up for it,

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1032 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153713989 @borisroman , could you please retest? It worked for me and for you, but not for @remibergsma due to a resolving thing on RVR test. I then ran it again and

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153717404 Ping @borisroman @remibergsma @DaanHoogland @miguelaferreira @karuturi Test results: ``` Test redundant router internals ... === TestNa

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153726658 LGTM, the test from this branch now succeed: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request:

2015-11-04 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/commit/59a9db39b1d17056753385c0e091bfe26d2df522#commitcomment-14184110 Issue CLOUDSTACK-9024 refers to this commit. https://issues.apache.org/jira/browse/CLOUDSTACK-9024 --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153749695 ``` 2015-11-04 14:23:51,076 DEBUG [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-34:ctx-0d2ee513 job-104/job-105 ctx-0d5c6252) Done executing VM work job

[VOTE] Apache CloudStack 4.6.0

2015-11-04 Thread Remi Bergsma
Hi all, I've created a 4.6.0 release candidate, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522 Commit: b0ebe68e375432b28eef031ab62ccd5831234c77 Source release (checksums and signa

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153755733 @koushik-das On second thought LogLevel can not be used I think: It is used for json serialization and one might have to serialize a password to be send to an

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43891649 --- Diff: api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java --- @@ -40,6 +42,7 @@ @SerializedName("fingerprint")

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43892103 --- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java --- @@ -38,6 +40,7 @@ @SerializedName(ApiConstants.CERTIFIC

Re: [VOTE] Apache CloudStack 4.6.0

2015-11-04 Thread Nux!
Hi, Has jenkins built rpms for this somewhere? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Remi Bergsma" > To: dev@cloudstack.apache.org > Sent: Wednesday, 4 November, 2015 14:55:11 > Subject: [VOTE] Apache CloudStack 4.6.0 > Hi

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43897730 --- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java --- @@ -62,10 +65,12 @@ @SerializedName(ApiConstants.CERTIF

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43897789 --- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java --- @@ -62,10 +65,12 @@ @SerializedName(ApiConstants.CERTIF

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43898594 --- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java --- @@ -27,30 +29,40 @@ import com.google.gson.GsonBuilder; /** - *

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43899212 --- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java --- @@ -71,4 +83,19 @@ public boolean shouldSkipField(FieldAttributes f) {

  1   2   >