[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

2015-10-28 Thread kansal
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/995 CLOUDSTACk-9002: VM deployment is successful even when dhcp entry com… …mand fails - Fixed Reason: The return value of the call to accept() function in the applyRules() function of B

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

2015-10-28 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/996 [4.6] CLOUDSTACK-8984: VPC Network offerings tab missing from UI This is a regression from commit af2f21894ce061faadc8cec29b901719303a29dc added vpcofferings to the select list

Re: Build failure for plugin ovm3

2015-10-28 Thread Daan Hoogland
Sateesh, I really don't know what the root cause of your problem is. Downgrading is worth a try but no guarantees. I don't see anything in your reported platform that rings alarms. On Wed, Oct 28, 2015 at 2:03 AM, Sateesh Chodapuneedi < sateesh.chodapune...@citrix.com> wrote: > Hi Daan, > > Than

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8989 test_ps_limits.py t...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151755463 Ping @remibergsma @DaanHoogland Any time to test this one today? Cheers, Wilder --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151755364 Hi @serbaut , Could you write an integration test with marvin to cover this change? If you don't have a test environment or are not familiar with Mar

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-28 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151757451 @K0zka (1) not working: ``` [root@weizhou master]# curl -v 10.11.115.10:8080/client/ -o /dev/null * About to connect() to 10.11.115.10 port 8

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-28 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151759873 @K0zka I also cleaned the folder /var/cache/cloudstack/management/work/, it does not fix the issue. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread serbaut
Github user serbaut commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151768463 In our environment it was really easy to reproduce. * Deploy instance 1, got IP 10.7.32.101 * Delete and expunge instance 1 * Deploy instance 2, got IP 100

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151773344 @borisroman I started seeing below error messages on console and VR doesnt start. Is it related to this change? ``` [ 480.108811] "echo 0 > /proc/

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151776994 How does this impact logrotating? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-28 Thread runseb
Github user runseb closed the pull request at: https://github.com/apache/cloudstack/pull/920 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151778449 Why only RPM and not for DEB? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9000: logrotate cloudsta...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/993#issuecomment-151778493 Why only RPM and not for DEB? Keep in mind though that with systemd this is no longer valid --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-28 Thread runseb
GitHub user runseb opened a pull request: https://github.com/apache/cloudstack/pull/997 Add all tests in /test/integration/smoke to Travis run and nove nicir… Adds all tests in smoke folder to Travis. Moves nicira test to /test/integration/plugins You can merge this pull requ

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151782444 Ping @remibergsma @borisroman @karuturi @DaanHoogland @miguelaferreira @michaelandersen Test results: * Hardware required: false * Manag

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/995#issuecomment-151784319 Seems good to me, but while we are working on this. Any way we can Unit Test this? Looking at the code it's possible. If you could just write a test to validate

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/991#issuecomment-151784718 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8999: Don't override res...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/990#issuecomment-151784690 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: TransactionContextInterceptor Keeps Releasing My Lock

2015-10-28 Thread Frank Maximus
Would you happen to call the method annotated with @DB from within the same class? If so, you would directly go to the method, instead of using the proxy which applies AOP. Regards, Frank On 26 Oct 2015 12:53, "Jeff Hair" wrote: > I have narrowed it down to multithreading being the cause. I hav

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151790553 @wido fixed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9000: logrotate cloudsta...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/993#issuecomment-151790777 @wido fixed now. Do you mean with systemd, there is no point in using logrotate? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9000: logrotate cloudsta...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/993#issuecomment-151791418 @bhaisaab With systemd we no longer write a out and err file. We did this with JSVC, but now it's send to stdout and stderr which is then picked up by journald. --- I

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151792666 FYI,run a set of tests that on this branch (which I rebased myself first), just to make sure no existing functionality is broken by this PR. Looking good!

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/895#issuecomment-151794288 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

Re: TransactionContextInterceptor Keeps Releasing My Lock

2015-10-28 Thread Jeff Hair
My experience is this: - If I call the method directly from within the class, @DB seems to apply and the lock in the op_lock table stays active as long as it is needed. - If I call the method on another thread (internal class implementing Runnable), @DB does not apply and I have to wrap the acqui

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/895 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-151795514 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151798263 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[DISCUSS] personal mentoring program (was: Mentor)

2015-10-28 Thread Daan Hoogland
people, I have answered David and Prakesh on a personal note to get them started. When I started at cloudstack I had the luck to be in close quarters with a fellow developer. Not everybody is. Is there a wider call for mentoring on a personal level? Several people have proposed to be a google sum

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8989 test_ps_limits.py t...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151798750 LGTM, test runs fine: ``` === TestName: test_deploy_vm | Status : SUCCESS === === TestName: test_deploy_vm_multiple | Status : SUCCESS ===

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8989 test_ps_limits.py t...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/918 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151801262 @michaelandersen can you review this please? @insom Travis failed, please investigate or push again. Thanks! --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-151803068 @karuturi Thanks! Will test soon :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8992 Allow 32 disks to b...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/980 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151804289 @ustcweizhou Can you please rebase against current master (and resolve conflict)? Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-151804656 @pdube @pdion891 Could you please look at this PR? Would be nice to include it soon. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-28 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151805043 @remibergsma Travis seems happy but Jenkins isn't (but I can't view the Jenkins output, it's 404ing :|). I'll run the tests for the rebased version manually and see if

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread serbaut
Github user serbaut commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151805357 Thanks. I still haven't given up on writing a test for this. Just found one issue with running python2.7 marvin/marvin/deployDataCenter.py -i devcloud-k

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151805630 @bhaisaab Thanks, can you please make Jenkins happy? ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

2015-10-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/988#issuecomment-151806516 @ProjectMoon THe stuff built and is running tests. You should be able to force push it and it should build. unsure what we are looking for but probably a proble

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151806586 @remibergsma Jenkins seems quite happy - https://builds.apache.org/job/cloudstack-pull-analysis/1026/ ? See this rpm build (4.5 actually) - http://sb.bhaisaab.o

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

2015-10-28 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/988#discussion_r43242947 --- Diff: plugins/network-elements/internal-loadbalancer/test/resources/lb_mgr.xml --- @@ -36,7 +36,7 @@ - +

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

2015-10-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/988#issuecomment-151807919 @ProjectMoon impressive work. Can you create a jira ticket and describe it (including functional incentive) and prepend the PR with the ticket id? --- If your

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

2015-10-28 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/988#issuecomment-151810393 I can create a ticket, yes. I plan to push more work to this pull request today/tomorrow that moves the VirtualMachineName service and probably the UUID

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151812042 @bhaisaab Maybe you can force push again, because it failed (https://builds.apache.org/job/cloudstack-pull-analysis/1031/). probably not related to what you did,

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151816807 @remibergsma looks like JVM crashed - https://builds.apache.org/job/cloudstack-pull-analysis/1031/org.apache.cloudstack$cloud-server/console forcing pushing agai

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-28 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/997#issuecomment-151826908 @runseb Travis is green but no tests are running. I checked all the builds and the first few say this: ``` $ ./tools/travis/script.sh $TESTS

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151832340 @wido Thanks for working on this, awesome! I was testing this PR and found that the SSVM and CPVM systemvms do not start properly. This is the error:

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151836172 @remibergsma Hmm, was SELinux enabled on that system? Can't see any reason why it wouldn't work. All the directories exist. Do you by any chance have the XML th

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151836687 LGTM, tested on `CentOS 7` and the logrotate file gets properly installed: ``` [root@kvm1 logrotate.d]# pwd /etc/logrotate.d [root@kvm1 logrot

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151838470 Hi @wido : SELinux is off: ``` [root@kvm1 channel]# getenforce Permissive ``` The generated XML: ``` 2015-10-28 13:02:00

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151841925 Hi @insom It might be rotated already. Usually when you force push your commits to the branch again, Jenkins will notice this and run again. I think that is the

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151842878 Hi @serbaut I sometimes have trouble with nose after installing marvin. So what I do, is to install marvin, and then reinstall nose (forcing it to actually r

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151843525 Hi @serbaut Did the deployDatacenter.py actually work? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread serbaut
Github user serbaut commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151843789 Yes I have a running zone with advanced networking. Giving up on the tests, too much breakage everywhere. I must be doing something wrong. --- If your project is s

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151845449 @serbaut Sorry to hear that! Good that the deploy actually works. I'm not using DevCloud so I cannot help with that. I do know that I have no issues running Marv

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

2015-10-28 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-151854916 @remibergsma I rebased and repushed. I will take some screen shots later! Thanks! --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread serbaut
Github user serbaut commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151855358 Wtf Jenkins, no means no. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

RE: Build failure for plugin ovm3

2015-10-28 Thread Sateesh Chodapuneedi
Ok, will try downgrade option as well. Thanks again for looking at it Daan. Regards, Sateesh -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, October 28, 2015 1:01 PM To: dev Subject: Re: Build failure for plugin ovm3 Sateesh, I really don't know

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-28 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151859204 Hi @remibergsma - it looks like this Jenkins job is disabled? https://builds.apache.org/job/cloudstack-pull-requests/ -- I can confirm the tests pass on my rebased bra

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-28 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151864368 @remibergsma no problem. I am working on some changes , I will push the commits with rebase tomorrow. --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151871826 @remibergsma Ok, that is odd. A proper XML should look like this: ``` ``` pat

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151879029 Hi @Insom, Jenkins succeeded, see: https://builds.apache.org/job/cloudstack-pull-analysis/1034/ There is a different job with a slightly different name ;-) ---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151890952 Thanks for the details, @serbaut! I will test you PR as well. Cheers, Wilder --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151894028 @karuturi I'll check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread serbaut
Github user serbaut commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151894479 Thank you. Sorry I could not write a test for it. Maybe the instructions for running tests need to be updated because I ran into all sorts of problems. Can't even ge

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151896039 Thanks @remibergsma the jenkins build still failed due to JVM crashing --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/998 CLOUDSTACK-8957 - VR password server feature is broken This PR implements the update of the password as it use to be done with the bash file, but using the Python code for it. A

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151893972 @terbolous It doesn't effect log-rotating at all. This just let's the password_server_ip.py logs to be written to /var/log/cloud.log instead of /dev/nul --- If

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151900260 Ping @remibergsma @borisroman @wido @miguelaferreira @DaanHoogland @bhaisaab @karuturi @NuxRo Could you please have a look at this PR? I already hav

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/998#discussion_r43282110 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -41,27 +41,37 @@ from cs.CsMonitor import CsMonitor from cs.CsLoadBal

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151904440 LGTM, you may squash the commits as it's a single logical fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151904579 (forgot to mention, just reviewed code but yet to test it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151906311 Got 2 red checks. Will have a look why. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151906835 Ping @bhaisaab @DaanHoogland @remibergsma @miguelaferreira Does anyone know why this error happened? Read it but I can't take much of it. It has not

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151907240 @bhaisaab Squashed and pushed again. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/998#discussion_r43290720 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -41,27 +41,37 @@ from cs.CsMonitor import CsMonitor from cs.Cs

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151927952 @remibergsma @insom I deleted the other pull jobs to avoid this confusion. Sometimes jenkins reports the wrong build being busy. Let's see if this behaviour is

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151928213 Travis failed due to a timeout: ![image](https://cloud.githubusercontent.com/assets/5129209/10797761/6835b74c-7da4-11e5-9fd6-080b807739f1.png) ---

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151936406 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151936598 @borisroman Can you please review again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151939066 @borisroman Isn't there already another process logging to `/var/log/cloud.log` ? Will this work properly if multiple processes write to it at the same time? Hav

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/991#issuecomment-151940210 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/991 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

2015-10-28 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151944891 @remibergsma The comments I placed are fixed in 50827f7e4ba90e2cbf163a9946c84d1835630ead. Though this introduces my new comment; can the commits be squashed? As t

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151950464 @remibergsma I think it might be the problem, which also caused my vr to not restart... Looking into it --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151952219 @borisroman: the fix typos can be squashed and the one that says "use correct ip address" as well, the other two won't because they are independent: 1 for th

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151953539 @borisroman and @remibergsma, the 2 commits have been squashed. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

2015-10-28 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151953800 @wilderrodrigues Ok! Code LGTM :+1: @remibergsma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8999: Don't override res...

2015-10-28 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/990#issuecomment-151957243 Merged on 4.5 since, PR for master has been merged on master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151957189 @wilderrodrigues @remibergsma LGTM :+1: Tested VM password manually => working! ``` nosetests --with-marvin --marvin-config=/data/shared/mar

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8999: Don't override res...

2015-10-28 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151959579 Hi @serbaut and @remibergsma First tests have been executed. I got 1 error, related to private gateway ACL, but I think it was just a weird glitch o

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

2015-10-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-151958257 Nice one, @borisroman. Thanks for the tests! Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: [wip][4.6] CLOUDSTACK-8994 Add logging fo...

2015-10-28 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/983 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

2015-10-28 Thread xenserverarmy
Github user xenserverarmy commented on the pull request: https://github.com/apache/cloudstack/pull/982#issuecomment-151967711 @remibergsma How did the tests work out? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

Re: Mentor

2015-10-28 Thread Yiping Zhang
Hi, David: I am speaking as a CloudStack user/admin/operator here. Here is an issue which really really drives me crazy, but should be relatively easy for a java developer to work on: improving error log messages! Here is a specific example: when deploying a VM instance fails, often the error

  1   2   >