[DISCUSS] Move to GitHub

2015-10-25 Thread Sebastien Goasguen
Folks, We have been using GitHub for PR now for a while, it seems to work despite the fact that we still have to get used to the workflow. We lack some privileges on the mirror to be able to use labels etc. I would also be in favor of using Issues and why not the Wiki. Basically I personally wo

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150898083 copy-pasting mike's response from email ( http://markmail.org/message/bptis5kitr2chqcn ). looks like its still not working for him with vmware-managed storage >

Re: [DISCUSS] Move to GitHub

2015-10-25 Thread Remi Bergsma
+1 ! This would be a HUGE time saver from a RM perspective. Sent from my iPhone > On 25 Oct 2015, at 08:05, Sebastien Goasguen wrote: > > Folks, > > We have been using GitHub for PR now for a while, it seems to work despite > the fact that we still have to get used to the workflow. > We lac

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread Remi Bergsma
Managed VMware storage == solidfire? I believe there is a solid fire specific PR as well that we could merge to solve all cases. Is this correct Mike? Sent from my iPhone > On 25 Oct 2015, at 08:09, karuturi wrote: > > Github user karuturi commented on the pull request: > >https://gith

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150900045 @borisroman @remibergsma I've rebased on latest master and force pushed it --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

2015-10-25 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/926#issuecomment-150900227 @remibergsma code is updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [DISCUSS] Move to GitHub

2015-10-25 Thread Milamber
On 25/10/2015 07:05, Sebastien Goasguen wrote: Folks, We have been using GitHub for PR now for a while, it seems to work despite the fact that we still have to get used to the workflow. We lack some privileges on the mirror to be able to use labels etc. I would also be in favor of using Issu

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/926#issuecomment-150911520 rerunning the ssvm and vpc tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/918#discussion_r42943657 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1763,7 +1763,7 @@ private void orchestrateStorageMigration(fin

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-25 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-150917120 @DaanHoogland good point. I prefer to throw an exception if the pool is null. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

2015-10-25 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/975#issuecomment-150917774 @remi: yep did the OVM3 dance, together with KVM and separately from OVM3. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: 4.6 status update after QA Day yesterday

2015-10-25 Thread Rohit Yadav
Hi Remi, On 24-Oct-2015, at 4:43 PM, Remi Bergsma mailto:rberg...@schubergphilis.com>> wrote: 2) VR password server broken https://issues.apache.org/jira/browse/CLOUDSTACK-8957 ==> Rohit is working on this, or not? No recent update. Please unassign if someone else needs to take over. Do you nee

Re: 4.6 status update after QA Day yesterday

2015-10-25 Thread Remi Bergsma
Thanks! Sent from my iPhone On 25 Oct 2015, at 14:15, Rohit Yadav mailto:rohit.ya...@shapeblue.com>> wrote: Hi Remi, On 24-Oct-2015, at 4:43 PM, Remi Bergsma mailto:rberg...@schubergphilis.com>> wrote: 2) VR password server broken https://issues.apache.org/jira/browse/CLOUDSTACK-8957 ==> Roh

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-150938750 ok, so if (destpool == null) { throw new CloudRuntimeException("missing storage pool"); } or something like that? Or would you rather see a Nu

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/975#issuecomment-150946842 @DaanHoogland Could you please do a code review of this PR? Thx! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/971 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150947060 @DaanHoogland Could you please paste the nose command you run and the output. Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/849#issuecomment-150948113 LGTM, based on a set of tests that I run on this branch: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardwa

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create volume from...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/976#issuecomment-150948580 LGTM, based on a set of tests that I run on this branch: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardwa

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-150948753 Hi @kansal Can you please rebase this with current master? I tried running some tests but face old problems. Also, what about the db migration script to fix old

[GitHub] cloudstack pull request: CLOUDSTACK-8917 : Instance tab takes long...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/894#issuecomment-150948834 @sudhansu7 Can you please rebase with current master so I can run some tests? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8838 Interface pattern check

2015-10-25 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150953447 @remibergsma @DaanHoogland LGTM :+1: Thanks for adjusting the unit test. ``` Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResour

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create volume from...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/976#issuecomment-150954032 lgtm based on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150954369 @remibergsma I destroyed the vms in which I ran it already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/975#discussion_r42948653 --- Diff: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/Ovm3HypervisorGuru.java --- @@ -105,9 +105,6 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/975#issuecomment-150959103 one comment, code looks fine otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: CLOUDSTACK-8838 Interface pattern check

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/973 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [4.6] Can't create template or volume from snapshot

2015-10-25 Thread Andrei Mikhailovsky
I am actually having issues with 4.5.2 branch and creating templates from a snapshot on Ceph rbd primary and nfs secondary. Some ppl reported this working, but it just doesn't work for me. While creating a template from a volume or snapshot i hit timeout error after about 5-10 mins, which is o

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/975#issuecomment-150965104 Pinging @snuf to respond to the comment here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create volume from...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/976 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-150966983 @KrisSterckx Please rebase against current master. That will allow me to run some tests once @jburwell reviews the changes. Then we'll have to discuss when we

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-150967148 Hi @rodrigo93 can you please rebase against current master? Then I can run soms tests. Thanks! --- If your project is set up for it, you can reply to this email

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread Mike Tutkowski
Correct, this is still not working for me on VMware with managed storage. I'm not at home at the moment, but I plan on rebuilding my environment from scratch and trying this again with the latest code as soon as I can. On Sunday, October 25, 2015, karuturi wrote: > Github user karuturi commente

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread Mike Tutkowski
FYI that CloudByte also uses managed storage. On Sunday, October 25, 2015, Mike Tutkowski wrote: > Correct, this is still not working for me on VMware with managed storage. > > I'm not at home at the moment, but I plan on rebuilding my environment > from scratch and trying this again with the la

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-25 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/964#issuecomment-150979025 @remibergsma @snuf I've run the following tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-10-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/849#issuecomment-151016206 @remibergsma thanks a lot for running the tests.. I rebased it with the current master --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-151018044 Are we OK with this PR, everyone? If so, at this point in the release, is it the job of the RM to merge or should I do that? Thanks! --- If your project is s

Re: Development and building of ui components

2015-10-25 Thread Rajani Karuturi
There might be a better but for simple js changes, I do the below and restart jetty $ cp ./ui/scripts/domains.js ./client/target/generated-webapp/scripts/domains.js $ rm ./client/target/generated-webapp/scripts/domains.js.gz $ cp ui/scripts/domains.js client/target/cloud-client-ui-4.6.0-SNAPSHOT/

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-25 Thread Sanjeev N
I will update the PR with required changes suggested by @pvr9711. On Sat, Oct 24, 2015 at 11:36 PM, remibergsma wrote: > Github user remibergsma commented on the pull request: > > https://github.com/apache/cloudstack/pull/902#issuecomment-150838537 > > @sanju1010 Any update on this? > >

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/964 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-151027065 @mike-tutkowski currently only RM can merge, so I'll do that once the criteria are met. I need 2x LGTM and some tests run on this branch. So far, I see only a LG

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-151028024 Just talked to @karuturi and we think we should merge this now and look into the remaining VMware issue (as reported bu @mike-tutkowski) as a separate issue. Can

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread Mike Tutkowski
Let me re-build my entire CS environment from scratch tomorrow and confirm the problem exists still. Get back to you soon, Mike On Sunday, October 25, 2015, remibergsma wrote: > Github user remibergsma commented on the pull request: > > https://github.com/apache/cloudstack/pull/954#issuecom

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-151028340 OK @mike-tutkowski thanks! I'll merge this now so you can build it from master. Please let us know if you still have issues, as I'd love to resolve those as well

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-25 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-151029210 Once I re-build my CS env in the morning, I'll run through a bunch of tests in the morning and afternoon and get back to you. On Sunday, October 25

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151037118 @miguelaferreira Can you please have a look why both Travis and Jenkins are unhappy again? Thx! --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-25 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/977 CLOUDSTACK-8746: VM Snapshotting implementation for KVM You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/cloudstack vm-snapsh