Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/967#issuecomment-150772052
LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardwa
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/967
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-150773033
@SudharmaJain These are the results of tests that I run on this branch:
```
Create a redundant VPC with two networks with two VMs in each network ...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150773265
LGTM, based on a set of tests that I run on this branch:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-150777561
@pdube LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150777604
@DaanHoogland Can you address @borisroman's comment about the unit tests
and add all the cases maybe?
---
If your project is set up for it, you can reply to thi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150778214
@remibergsma i have addressed @borisroman his comments, please see the code.
---
If your project is set up for it, you can reply to this email and have your
rep
Missed that! You're fast :-)
Thanks!
> On 24 Oct 2015, at 11:08, DaanHoogland wrote:
>
> Github user DaanHoogland commented on the pull request:
>
>https://github.com/apache/cloudstack/pull/973#issuecomment-150778214
>
>@remibergsma i have addressed @borisroman his comments, please s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/945#issuecomment-150780723
@nitin-maharana Thanks! LGTM, based on a set of tests that I run on this
branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-150780848
@kansal I see many issues on the tests, but I think they're not introduced
by you. I rebased locally and run some tests and then it looks much better.
Please reb
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150782142
@snuf Thanks! LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150782431
@snuf We may want to run a specific test against OVM3, I assume you did
that? The above tests just show you didn't break anything else :-)
---
If your project i
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150783434
@borisroman Please update your review. Are you OK with it now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150783732
@DaanHoogland Can you prepend the title with CLOUDSTACK-8838 please? I put
a note on the original ticket that it was solved in a more generic way.
---
If your p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150783777
@remibergsma title prefix added to the PR, would you wnat it on the commit
as well?
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150783950
FYI: Had been running tests but now that the PR changed I restarted. Will
report results when done, probably somewhere during the weekend.
---
If your project i
Hi all,
Lots of work has been done yesterday! PRs were reviewed, tested, merged, some
were improved and then tested. Nice results in translations as well. The
channel on Slack proved to be a great way to collaborate remotely.
Important: please rebase!
=
Now that many iss
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150785113
@DaanHoogland No, just the PR title. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Yesterday was long and tiring but very productive afaict. we should do this
*some* times. congratulations on the results every body.
On Sat, Oct 24, 2015 at 1:13 PM, Remi Bergsma
wrote:
> Hi all,
>
> Lots of work has been done yesterday! PRs were reviewed, tested, merged,
> some were improved an
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150802394
@rodrigo93 You changed the PR title, nog thr commit title. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-150802473
@mike-tutkowski you'll have to force push i thinks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150802690
I'm with @borisroman the commit title "Squashing last commits" is not
descriptive of what this commit is about so please change it. You can use the
same as the t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150803646
LGTM, my run was also successful:
```
[root@cs2 integration]# cat
/tmp//MarvinLogs/test_internal_lb_WWSD41/results.txt
Test to verify access to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150803722
@borisroman @DaanHoogland Can one of you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/971#issuecomment-150804092
setting up a test env. will review when better rested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-150820547
@sspans Can you review this xenserver logrotate change please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150824034
Hi @remibergsma, thanks for the advice!
I have changed the title of the last commit already as you both suggest.
I will provide a JIRA issue and prepend th
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150832830
LGTM, based on a set of tests that I run on this branch (on a KVM cluster):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advan
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-150834389
LGTM, I also see the sessionid no longer there:
```
[root@cs2 cloudstack]# curl -v 192.168.22.62:8080/client/ >/dev/null
* About to connect()
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-150834484
Thanks for the fix @K0zka !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150835745
Thanks @rodrigo93, please also rebase with current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Hi Remi,
I'd like to include this one in 4.6 (small and low risk):
https://github.com/apache/cloudstack/pull/968/files
Thanks,
Mike
On Sat, Oct 24, 2015 at 5:13 AM, Remi Bergsma
wrote:
> Hi all,
>
> Lots of work has been done yesterday! PRs were reviewed, tested, merged,
> some were improved
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-150836024
Hi @nitin-maharana can you please rebase with current master? I'd like to
test your patch. Thanks!
---
If your project is set up for it, you can reply to this e
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-150836618
@ustcweizhou Can you please rebase with current master so I can test this?
Thanks!
---
If your project is set up for it, you can reply to this email and have yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/925#issuecomment-150836810
Hi @atrbgithub Thanks for your response. We indeed need to reimplement your
fix on current master. Once that is in place and tested, we merge it on master
(that
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/924#issuecomment-150836950
Pinging @borisroman @michaelandersen to review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/921#issuecomment-150836992
@yvsubhash can you please respond to the comments and also rebase with
current master please?
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r42936389
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-150837653
Sure @remibergsma I will do that. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-150837929
@sarathkouk For my understanding, is this the integration test for the
feature @karuturi recently developed in #755 ?
For the sake of it, please force pu
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-150838491
@nitin-maharana Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-150838537
@sanju1010 Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/899#issuecomment-150838585
@yvsubhash Please squash the commits and rebase with current master, thanks!
---
If your project is set up for it, you can reply to this email and have your
repl
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/896#issuecomment-150838644
@michaelandersen can you please review this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-150838798
@bvbharatk Can you please rebase this against current master so I can run
some tests? Let mw know if you need help!
---
If your project is set up for it, you ca
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-150838920
@michelandersen can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-150838939
@insom Please rebase against current master so we can run some tests.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
re
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/822#issuecomment-150839334
Hi @DaanHoogland LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advance
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/822
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-150839822
@mike-tutkowski Please rebase with current master and then force-push your
commits.
If you find another reviewer, I can run some tests next week to see i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-150840869
@remibergsma I ran the ssvm and vpc tests in the env from your company and
we'll have to trust Mike for the solidfire specifics. He'll have to fix broken
stuff
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-150840976
@remibergsma I was busy in some other works. Within 3-4 days I will work on
this and will give an update. Thank you.
---
If your project is set up for it, yo
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-150842979
I'm not at my computer right now, but I should be able to perform the
rebase later this afternoon.
On Saturday, October 24, 2015, Daan Hoogland
Hey Remi,
I have rebased PR 968 on top of master.
Thanks!
Mike
On Sat, Oct 24, 2015 at 11:28 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:
> Hi Remi,
>
> I'd like to include this one in 4.6 (small and low risk):
>
> https://github.com/apache/cloudstack/pull/968/files
>
> Thanks,
> M
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150897664
I was concerned the code change is against the initial design and we may be
doing it without understanding all the implications. But, since we dont have
any better
57 matches
Mail list logo
