[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

2015-09-15 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/835 CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination Also changed viewer/console identifier to vm uuid + vnc port to avoid using same connection console if

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

2015-09-15 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/834#issuecomment-140641999 Reschedule time is always based on the work type. Code changes are OK. LGTM. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39597202 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void setBasicVmConfig(VirtualMachine

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/832#issuecomment-140642411 Hi @borisroman Few months ago we had a thread on the list to discuss which PR flow we should have in place in order to increase ACS quality. The ide

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140643483 @bhaisaab it should be for 4.5 as well but It is not complete yet, unless we decide that we don't take any action on a missing report. I will make a PR for 4.5

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

2015-09-15 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140644634 Tested adding ESXi 6.0 host to advanced ACS zone successfully. Session logic is working fine. @bhaisaab you might want to go ahead merge it.

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-15 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/836 CLOUDSTACK-8863: VM doesn't reconnect to internet post VR RESTART/STO… …P-START/RECREATE The ongoing ICMP request reply session is broken when the VR is down, the expectation i

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/837 CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. earlier we were eating up exceptions from the lower layer which resulted in improper error messages. fixed p

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140645340 Hi @rafaelweingartner , I understood that @pedro-martins went through a hard time checking class by class, but I would not discuss credits and that k

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140645427 I will add the same comment to the opened PR instead. I believe is better to follow up overt here. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/838 CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. earlier we were eating up exceptions from the lower layer which resulted in improper error messages. fixed p

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/838#issuecomment-14064 Which steps should we follow to test it, @bvbharatk ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39598013 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void setBasicVmConfig(Vi

Re: After box restart CS 4.5.2 fails to start

2015-09-15 Thread Rohit Yadav
Did you try running cloudstack-setup-management as root user ? On 15-Sep-2015, at 8:24 pm, Keerthiraja SJ mailto:sjkeer...@gmail.com>> wrote: Hi All, Today I installed CS 4.5.2 on CentOS 6.7 and able to start the app successfully. All of a sudden the box reboot then while I started the cloudsat

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140645828 Why do we have 2 PR with the same issue/branch/description, @bvbharatk ? I check the PR #838 and that's about something else. Could you please edit the PR de

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140646781 @wilderrodrigues my bad, something went wrong while creating the pr. fixed this. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140648456 Hi @rafaelweingartner , Master was broken yesterday when a file containing the wrong imports was merged. I reverted about 5 minutes after the merge.

<    1   2