[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/793#discussion_r39365314 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -1046,4 +1046,51 @@ private VmWorkJobVO createPlaceHolderWork(long instanceI

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-139980724 you are decreasing the code coverage with these changes. especially with interface changes and new methods, I think unittests should be there. This is not t

Re: Build failed in Jenkins: build-master-slowbuild #2302

Dear Rajani, Will check now. Best regards, Boris Schrijver TEL: +31633784542 MAIL: bo...@pcextreme.nl > > On September 14, 2015 at 7:32 AM Rajani Karuturi > wrote: > > > slow build is broken due to a new findbugs warning > I think its not really new but, its reported maybe beca

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366792 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -3327,7 +3330,7 @@ private Answer execut

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366816 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -4420,11 +4450,13 @@ private void fillHo

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366830 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java --- @@ -115,7 +115,7 @@ p

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366916 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1971,7 +1971,7 @@ protected void finalizeNetworkRule

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366912 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1589,8 +1589,8 @@ protected StringBuilder createGues

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366935 --- Diff: server/src/com/cloud/network/security/SecurityGroupListener.java --- @@ -106,7 +106,7 @@ public boolean processAnswers(long agentId, lon

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366920 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1981,7 +1981,7 @@ private void createDefaultEgressFi

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366953 --- Diff: server/src/com/cloud/storage/LocalStoragePoolListener.java --- @@ -18,7 +18,7 @@ import javax.inject.Inject; -import

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366926 --- Diff: server/src/com/cloud/network/security/SecurityGroupListener.java --- @@ -81,7 +81,7 @@ public boolean isRecurring() { @Override

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366965 --- Diff: server/src/com/cloud/storage/LocalStoragePoolListener.java --- @@ -39,7 +39,7 @@ import com.cloud.utils.db.DB; public cla

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39366998 --- Diff: server/src/com/cloud/storage/upload/UploadListener.java --- @@ -113,7 +113,7 @@ protected void runInContext() { private Da

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39367006 --- Diff: server/src/com/cloud/storage/upload/UploadListener.java --- @@ -270,7 +274,7 @@ public AgentControlAnswer processControlCommand(long age

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-139986534 Hi @mike-tutkowski I've skimmed through the code in this PR and I saw quite a lot of nice modifications. Things like proper formatting, stricter obj

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139987172 @karuturi Fixed the findbug issue. Was due to reformatting of one method. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/793#discussion_r39367811 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -1046,4 +1046,51 @@ private VmWorkJobVO createPlaceHolderWork(long instanc

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-139987547 @bhaisaab, I've added some more unit tests on top of the existing ones --- If your project is set up for it, you can reply to this email and have your reply appear o

Re: RPM Build from Source Fails for CentOS 7.x

On 14-09-15 08:35, Keerthiraja SJ wrote: > Hi All, > > After I follow the doc to build rpm from source there seems to be some > basic issue. > > First the source is looking for the tomcat6 and @ the same time inside the > source I could see only > /root/apache-cloudstack-4.5.2-src/packaging/cen

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-139989420 @karuturi I don't get what will be validate by adding above kind of tests other than what I have mentioned in my previous comment. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-139990182 @wido you can ask @bvbharatk to close it or add the message This closes #784 to a related PR commit (same functionality, I would suggest) --- If your

Build failed in Jenkins: build-master-slowbuild #2303

See Changes: [Rajani Karuturi] CLOUDSTACK-8816 Fixed entityUuid missing in some cases is events [Rajani Karuturi] CLOUDSTACK-8816: instance uuid is missing in events for delete account [Rajani Karuturi] CLOUDSTACK-8816:

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39370166 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java --- @@ -124,6 +132,22 @@ private

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-140003171 @anshul1886 I do not agree to your statement and hence I already tried to explain what you can test in this piece of code. If you still dont get it(or dont want to

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/795#discussion_r39372256 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java --- @@ -382,7 +424,7 @@ private String p

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39372846 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -152,13 +152,26 @@ public void connect(String url, String userN

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140009394 @remibergsma That sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Recurring snapshot taking full every time

Hi All, I am using CS 4.3.1 and xenserver 6.2 I have configured daily recurring snapshot policy for all the root volumes. but recent three days onwards it is taking full snapshots and not taking any child snapshots. I have configured snapshot.delta.max to 16. please help me my secondary storage is

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39377834 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -577,41 +590,48 @@ public ManagedObjectReference getDecendentM

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39378030 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -577,41 +590,48 @@ public ManagedObjectReference getDecendentM

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/795 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Wiki edit permissions

Hi, I wanted to add some design documentation to wiki. Please grant me edit permissions. My ID: sureshkumar.anaparti. Thanks, Suresh

Re: Recurring snapshot taking full every time

Looks like the host is not instrumented properly and management server is unable to invoke plugin on the host. Can you force-reconnect the host that is throwing this error ? That should recopy the plugins on to the host. > On 14-Sep-2015, at 3:15 pm, raja sekhar wrote: > > Hi All, > > I am usin

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/817 Cherry-pick PR #795 into 4.5 branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack 4.5 Alternatively you can rev

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/818 Fixed: Network Update from RVR offering to Standalone offering fails Problem: Moving a RVR network offering to standalone makes the status of VR's as UNKNOWN and Redundant Router marked with YES.

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/819 Tagging tests appropriately to pick them for running on basic zone Adding additional tag to the list of tags. You can merge this pull request into a Git repository by running: $ git pull

Jenkins build is back to normal : build-master-slowbuild #2304

See

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/820 CLOUDSTACK-8840: Systemd service for the Usage Server There already was a uncompleted systemd service file for the Usage Server. This new one replaces sysvinit and the old systemd servi

Re: Recurring snapshot taking full every time

Hi abhinandan, Thanks for your reply. We are facing the issue only for root volumes in that host. The snapshot recurring policy for data disks in same host is working fine. if the host configuration is not properly instrumented the policy for data disks also fails, but it is working fine. please s

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140046588 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140046870 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/821 CLOUDSTACK-8645: Improve logging of RBD functionality in KVM A simple commit which changes a couple of log lines. You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/821#issuecomment-140048982 Pending Travis -> LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: Wiki edit permissions

Done. ~Rajani On 14-Sep-2015, at 3:58 pm, Suresh Kumar Anaparti wrote: > Hi, > > I wanted to add some design documentation to wiki. Please grant me edit > permissions. My ID: sureshkumar.anaparti. > > Thanks, > Suresh >

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140053317 No direct commits to master. all the commits to master should be merges. I earlier reverted and merged a PR. Please check the comments on PR #728 and merge the

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140053426 I am reverting this direct commit. Please reopen the PR and use the git pr script to merge --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140056577 FWIW LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: Tagging tests appropriately to pick them ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/819#issuecomment-140059312 @karuturi Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/821#discussion_r39388787 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java --- @@ -877,8 +877,8 @@ public boolean deletePhysi

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/821#issuecomment-140059934 comment about the log message, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

New Defects reported by Coverity Scan for cloudstack

Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 5 new defect(s) introduced to cloudstack found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390123 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -3327,7 +3330,7 @@ private Answer execute

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390243 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -4420,11 +4450,13 @@ private void fillHos

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390303 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java --- @@ -115,7 +115,7 @@ pr

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390513 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1589,8 +1589,8 @@ protected StringBuilder createGuest

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390601 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1971,7 +1971,7 @@ protected void finalizeNetworkRules

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390690 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1971,7 +1971,7 @@ protected void finalizeNetworkRules

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390674 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1981,7 +1981,7 @@ private void createDefaultEgressFir

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390723 --- Diff: server/src/com/cloud/network/security/SecurityGroupListener.java --- @@ -81,7 +81,7 @@ public boolean isRecurring() { @Override

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390730 --- Diff: server/src/com/cloud/network/security/SecurityGroupListener.java --- @@ -106,7 +106,7 @@ public boolean processAnswers(long agentId, long

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390851 --- Diff: server/src/com/cloud/storage/LocalStoragePoolListener.java --- @@ -18,7 +18,7 @@ import javax.inject.Inject; -import

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390917 --- Diff: server/src/com/cloud/storage/LocalStoragePoolListener.java --- @@ -39,7 +39,7 @@ import com.cloud.utils.db.DB; public clas

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390966 --- Diff: server/src/com/cloud/storage/upload/UploadListener.java --- @@ -270,7 +274,7 @@ public AgentControlAnswer processControlCommand(long agen

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39390959 --- Diff: server/src/com/cloud/storage/upload/UploadListener.java --- @@ -113,7 +113,7 @@ protected void runInContext() { private Dat

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140071482 Hi Miguel, Fortunately this PR is such that there is essentially no existing test code that needed to be modified. At a high level, this code simply g

[GitHub] cloudstack pull request: CID 1324349: conditionally return -1 or t...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/822 CID 1324349: conditionally return -1 or the dc id for the volume You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstac

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140077337 Hi again Mike, Thanks for addressing my questions. Regarding the commented-out code, I see from your answers that the reason for leaving com

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r39394113 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java --- @@ -124,6 +132,22 @@

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140080679 Hi Miguel, I can remove those commented-out lines. No problem. Some companies like such lines left in, but others - as you point out - like them remov

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140095795 Hi @mike-tutkowski Thanks for being open about removing the commented-out code. IMHO (and not just mine btw) commented-out code poses a serious risk

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140097887 Sure, I'd be happy to get your input on how you see us unit testing this code. In the past, I've mainly restricted my CloudStack testing (automated and manual

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-140101031 @bvbharatk or @ke4qqq something went wrong with the auto-close (wasn't merged properly) Could either of you close this PR please? Thanks! --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/823 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id When calling listServiceOfferings with VM id as parameter. It is returning incompa

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39427179 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -60,10 +60,25 @@ public boolean supportsRollingUpgrade() { @O

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39427372 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -60,10 +60,25 @@ public boolean supportsRollingUpgrade() { @O

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39427690 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +469,35 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-140166203 @bhaisaab I understand there are multiple classes implementing the functionality, but I am still confused as to why the quota plugin can't use the existing SMTP gl

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39428645 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39428719 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-140171936 @kansal Thanks! Can you add the Jira issue id please? Looks like CLOUDSTACK-8844, right?! If you add it, it will also put a comment on the Jira issue. --- If y

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140185766 LGTM - tested again with the new changes and the package build succeeds and the packages install fine on CentOS 7. Also tested start/stop/status and rebooted the

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140185056 @wido I get this error when I run `./package.sh -d centos7` ``` install: cannot stat ‘packaging/cloudstack-usage.service’: No such file or direct

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-140189221 Just an FYI that I went ahead and updated the code to remove the commented-out lines. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39451499 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,214 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39452237 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,214 @@ +//Licensed to the Apache Software Found

Build failed in Jenkins: build-systemvm-master #624

See Changes: [Rajani Karuturi] CLOUDSTACK-8816 Fixed entityUuid missing in some cases is events [Rajani Karuturi] CLOUDSTACK-8816: instance uuid is missing in events for delete account [Rajani Karuturi] CLOUDSTACK-8816: en

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469257 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,88 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469282 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,82 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469356 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469398 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469424 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469479 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,82 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469518 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469559 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469677 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469736 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469705 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r39469760 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software Foundati

  1   2   >