[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/800 CLOUDSTACK-8798 Fixed the vrrp virtual ip config in case of rvr enabl… Fixed the vrrp virtual ip config in case of rvr enabled isolated networks. changed the CsRedundant.py to bring down

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39248790 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -95,9 +95,25 @@ def get_control_if(self): return ip

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/801 CLOUDSTACK-8832 : Update Nuage VSP plugin to work with Nuage VSP rele… …ase 3.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/c

Re: Repo still pointing 4.5.1

On 11-09-15 08:20, Keerthiraja SJ wrote: > Really need someone to do createrepo because the repodata seems to be very > old. > > repodata/ 2015-05-07 > 16:04 > > Kindly do the need full as soon as possible. > That should be fixed now! Wido >

[GitHub] cloudstack pull request: Fixed secstorage.proxy is not setting pro...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/802 Fixed secstorage.proxy is not setting proxy configuration on SSVM in some cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul18

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 10-09-15 23:15, Andrija Panic wrote: > Wido, > > could you folow maybe what my colegue Dmytro just sent ? > Yes, seems logical. > Its not only matter of question fixing rados-java (16 snaps limit) - it > seems that for any RBD exception, ACS will freak out... > No, a RbdException will b

[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/800#issuecomment-139486801 Hey @bvbharatk Thanks, dude! I really loved the test report! :) LGTM :+1: Cheers, Wilder --- If your project is set up for i

[GitHub] cloudstack pull request: CLOUDSTACK-5863: Add unit tests for volum...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/796#issuecomment-139489439 LGTM -> Test run fine and increase coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139493789 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Cloudstack 4.5.2 startup ERROR

Hi All, After successfully installation I could while starting the cloudstack-management ther seems to some error while connecting to my database. I am right now into production setup. ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to upgrade the database com.cloud.utils.exception.Cloud

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/803 CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id in volume_sto

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/804 CLOUDSTACK-8834: Fixed unable to download Template , when in multi zones We were listing image stores by zone id which was resulting in listing of only one image store If in that image st

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/805 CLOUDSTACK-8822 - Replacing Runnable by Callable That's the first part of the refactor, which will touch the ManagedContextRunnable and all its subclasses. However, in order to reduce i

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/806 CLOUDSTACK-8820: Showing error when try to add vCenter 6 CLOUDSTACK-8820: Showing error when try to add advance zone using VMware ESXi 6.0 host Summary: In vCenter 6.0, response

[GitHub] cloudstack pull request: CLOUDSTACK-5863: Add unit tests for volum...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/796 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: unittests to verify empty password is not...

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/807 unittests to verify empty password is not allowed during account/user create You can merge this pull request into a Git repository by running: $ git pull https://github.com/karuturi/cloud

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/808 CLOUDSTACK-8835: Added alerts incase of template download failure Authored-By: @sanjaytripathi Reviewed-By: Devdeep You can merge this pull request into a Git repository by running: $

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-139513737 After applying patch, was able to create VPC successfully. LGTM. Sub-process optimization is good to have. This PR will unblock the VPC creation.

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/805#discussion_r39262559 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -1315,6 +1321,10 @@ protected void doTask(final Task task) throws

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/805#issuecomment-139520511 Nice work @wilderrodrigues. Pinging @snuf to have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/805#issuecomment-139520736 @wilderrodrigues LGTM (minor issue - s/taks/task) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: unittests to verify empty password is not...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/807#issuecomment-139521022 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-139521285 Great PR @sureshanaparti I was going to work on supporting this as ESXi6 works well on top of KVM; I can test this for you next week; LGTM on code change (not teste

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-139521497 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/808#issuecomment-139521444 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/803#issuecomment-139521700 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/800#discussion_r39263080 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDatabag.py --- @@ -130,7 +136,10 @@ def get_router_password(self): This is slight

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139523955 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/800#issuecomment-139523586 Minor issues, otherwise code changes look alright --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Fixed secstorage.proxy is not setting pro...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/802#issuecomment-139521867 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-139522260 Can you increase its unit test code coverage? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139524401 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139524204 @borisroman looks good, can you increase code coverage by adding tests for the utils and core changes? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-139524505 @anshul1886 LGTM, can you add some unit test for the new methods? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-139524565 @nitin-maharana you changed a single line in a 102 line method. Though the code LGTM, I do not feel confident. Can you write unit tests or specify how this can

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/792#issuecomment-139524545 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change while configur...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/791 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/805#issuecomment-139530031 pending pull-analysis results; LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-139530205 @bhaisaab, I'll increase the unit test code coverage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-139530956 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: unittests to verify empty password is not...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/807#issuecomment-139530930 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39265018 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -152,13 +152,26 @@ public void connect(String url, String userNam

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39265110 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -577,41 +590,48 @@ public ManagedObjectReference getDecendentMoR

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39265179 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -577,41 +590,48 @@ public ManagedObjectReference getDecendentMoR

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 11-09-15 10:19, Wido den Hollander wrote: > > > On 10-09-15 23:15, Andrija Panic wrote: >> Wido, >> >> could you folow maybe what my colegue Dmytro just sent ? >> > > Yes, seems logical. > >> Its not only matter of question fixing rados-java (16 snaps limit) - it >> seems that for any RBD

[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/800#issuecomment-139532157 @bhaisaab , should we wait for a new commit from @bvbharatk on this PR before merging it? Cheers, Wilder --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-139532380 change makes sense but I have some comments on the coding style. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/805#issuecomment-139532454 Thanks, guys! @bhaisaab: I will change that and push in the second part of the refactor. Thanks again for a quick review! I will paste the te

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/808#issuecomment-139532776 Makes sense and LGTM. I see some code duplication in ImageStoreUploadMonitorImpl, though. A good moment to get rid of this? --- If your project is set up for i

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-139533946 the ticket (CLOUDSTACK-8834) mentions a screenshot, which is not there. the explanation give reproduction hints but is not completely clear because of this. The

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/803#discussion_r39266451 --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java --- @@ -350,4 +351,20 @@ public void expireDnldUrlsF

[GitHub] cloudstack pull request: Fixed secstorage.proxy is not setting pro...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/802#issuecomment-139536217 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

Thanks a lot Wido! Any chance to find out why management server decided that it lost connection to agent after that exceptions? It's not so critical as this bug with 16 snapshots, but during last week we catch situation when Agent failed unprotect snapshot, rise exception and this is was a reas

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139537389 Looks like what I meant @borisroman , LgreatTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/805#issuecomment-139537936 @remibergsma @bhaisaab @DaanHoogland Tests Results: Environment KVM + CentOS 7.1 Management Server + CentOS 7.1 Latest Syte

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/808#issuecomment-139538657 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: unittests to verify empty password is not...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/807 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/799#issuecomment-139538952 LGTM. With @bhaisaab though. Please fix Centos 7 as well. Btw, we should really use systemd :) --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-8822 - Replacing Runnable by C...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/805 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/800#issuecomment-139539283 I will merge this, since it got 2 LGTM, and will change the if as suggested by Rohit in my next PR that will touch the python files. --- If your project is

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/809 Changes made to DeployDataCenter to support Baremetal Basic Zone Creation 1. Made changes to deployDataCenter.py to support zone creation with Baremetal as the Hyeprvisor 2. Added test fil

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-139542841 @sanju1010 I had a look and didn't see you add your test to the travis yaml, is it included in the travis run? (if yes no need for any test report) --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

On 11-09-15 14:43, Dmytro Shevchenko wrote: > Thanks a lot Wido! Any chance to find out why management server decided > that it lost connection to agent after that exceptions? It's not so > critical as this bug with 16 snapshots, but during last week we catch > situation when Agent failed unprote

CS 4.5.2 Fails to Start.

Hi All, Today I tried to install the CS 4.5.2 on fresh box where I could able to successfully deploy the cloudstack-setup-databases. After I tried number of times the fresh installation I could see the same issue been reproducing it. While stating the cloudstack servers I could see below error c

[GitHub] cloudstack pull request: CLOUDSTACK-8798 Fixed the vrrp virtual ip...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/800#issuecomment-139551429 cool --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

Re: CS 4.5.2 Fails to Start.

I really face this issue when I install on MariaDB. If I do the same on MySQL this pass it. On Fri, Sep 11, 2015 at 7:09 PM, Keerthiraja SJ wrote: > Hi All, > > Today I tried to install the CS 4.5.2 on fresh box where I could able to > successfully deploy > the cloudstack-setup-databases. > > Af

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39275218 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -95,9 +95,25 @@ def get_control_if(self): return ip

Build failed in Jenkins: build-master-slowbuild #2281

See Changes: [nitinkumar.maharana] CLOUDSTACK-8821: Provide appropriate message in the UI when configuring the Firewall rules. [Boris Schrijver] Removal of test/debug code. [w.zhou] CLOUDSTACK-5863: Add unit tests for cre

No more direct commits to master please!

Hi all, What happened to master? I see a lot of direct commits. I thought we agreed to make a PR, then _merge_ it to master with the script in ./tools/git/git-pr. We’re getting ready for a 4.6 RC and this makes stuff extra hard to track. Most direct commits seem to come from PRs, but I don’t th

Re: No more direct commits to master please!

On 11-09-15 16:26, Remi Bergsma wrote: > Hi all, > > What happened to master? I see a lot of direct commits. I thought we agreed > to make a PR, then _merge_ it to master with the script in ./tools/git/git-pr. > Errr, I used that script? This is what my Bash history shows me: wido@wido-desk

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

THx a lot Wido !!! - we will patch this - For my understanding - is this "temorary"solution - since it raises limit to 256 snaps ? Or am I wrong ? I mean, since we dont stil have proper snapshots removal etc, so after i.e. 3-6months we will again have 256 snapshots of a single volume on CEPH ? BTW

Re: No more direct commits to master please!

Hi Wido, In order to figure out what went wrong, could you please point me to the merge commit (the one saying “Merge pull request …”) for commit b66dcda49f370e6fc91ebff889a694f17826ca44 ? Cheers, \ Miguel Ferreira mferre...@schubergphilis.com On 11

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-139582425 Hi @sanju1010 please use git-pr script to merge pull requests. Its in the source code at tools/git/git-pr Here is a doc on how to use it https://cwiki.apache.or

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-139586066 I reverted the directed commit and merged this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

Re: No more direct commits to master please!

Hi Wido, Thanks, good to know. Will try to figure out what went wrong here. Regards, Remi > On 11 Sep 2015, at 16:40, Wido den Hollander wrote: > > > >> On 11-09-15 16:26, Remi Bergsma wrote: >> Hi all, >> >> What happened to master? I see a lot of direct commits. I thought we agreed >>

Build failed in Jenkins: build-master-slowbuild #2282

See Changes: [shweta.agarwal] CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 5.9 [bharat.kumar] CLOUDSTACK-8798 Fixed the vrrp virtual ip config in case of rvr enabled isolated networks. [Rajani Kar

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-139623577 Thanks @karuturi ! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Build failed in Jenkins: build-master-slowbuild #2283

See -- [...truncated 28183 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

Build failed in Jenkins: build-systemvm-master #621

See Changes: [shweta.agarwal] CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 5.9 [nitinkumar.maharana] CLOUDSTACK-8821: Provide appropriate message in the UI when configuring the Firewall rules. [Bori

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

GitHub user ashwinswaroop opened a pull request: https://github.com/apache/cloudstack/pull/810 This is the fix for the JIRA issue CLOUDSTACK-8817. This is my first contribution to Apache CloudStack. The return values for endpoint and startpoint have now been changed to Integer inste

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139684337 Interesting your proposal, but you forgot to change the respective getters and setters method. Didn’t you use an IDE to make that change? I would

Build failed in Jenkins: build-master-slowbuild #2284

See -- [...truncated 28183 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

Github user ashwinswaroop commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139697149 Sorry for not changing the setter. I'm using eclipse now and I can see that there is a FirewallResponse.java file in both cloud and cloudstack-api. Should I ma

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139698329 @ashwinswaroop, no problem. About the class duplicity, it just seems that there are two classes, but in reality there is only one. The question is that

Build failed in Jenkins: build-master-slowbuild #2285

See -- [...truncated 28183 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

Github user ashwinswaroop commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139703362 Okay that makes sense. I went through the entire project and found only one caller of setStartPort and setEndPort which was from the relevant class(Firewall Re

Build failed in Jenkins: build-master-slowbuild #2286

See -- [...truncated 28183 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi