[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r38385699 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/755#issuecomment-136589494 updated the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Quota master WIP (just to follow changes)

2015-08-31 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/768 Quota master WIP (just to follow changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack quota-master Alternatively

Build failed in Jenkins: build-master-slowbuild #2198

2015-08-31 Thread jenkins
See -- [...truncated 28153 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/764#issuecomment-136590200 closing in favor of a better fix @ #762 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...

2015-08-31 Thread karuturi
Github user karuturi closed the pull request at: https://github.com/apache/cloudstack/pull/764 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/15#issuecomment-136596035 Looks good to me, but have we been informed of this change from infra? Did a search for closer.cgi and closer.lua in my mailbox, and the only reference I found

[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/762#issuecomment-136599746 @rafaelweingartner I see windows line endings in the new test file. Can you fix that please? Other than that, LGTM. once thats fixed I will merge --- If your p

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136601269 @karuturi @bhaisaab @DaanHoogland @koushik-das Anyone with some time to have a look at this PR? Thanks in advance. Cheers, Wild

<    1   2