[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136286725 Changes LGTM for 4.4. @miguelaferreira @remibergsma These can be fixed properly in a future release. isVmAlive() can return some enum (like yes, no, unknown)

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Wido den Hollander
On 08/31/2015 07:59 AM, Mike Tutkowski wrote: > Hi, > > I'm having a problem migrating a VM from one 12.04 KVM host to another > 12.04 KVM host in the same cluster in CS 4.6. > > Anyone know why I might be receiving this error message? > > invalid argument: virDomainDefFormat: unsupported flag

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

2015-08-31 Thread Daan Hoogland
I agree On Mon, Aug 31, 2015 at 6:45 AM, kansal wrote: > Github user kansal commented on the pull request: > > https://github.com/apache/cloudstack/pull/685#issuecomment-136250704 > > @DaanHoogland Yes the first test in a way does the same thing only. > The thing is that the second test

Build failed in Jenkins: build-master-slowbuild #2191

2015-08-31 Thread jenkins
See Changes: [koushik] Made following fixes in simulator [miguelferreira] Add vm scalling test that runs on simulator [Rajani Karuturi] Revert "Merge pull request #714 from rafaelweingartner/master-lrg-cs-hackday-003" --

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136302213 I didn't realise this was a hotfix for 4.4. I wouldn't want this fix for master, but for a previous release that has a critical bug, I can live with it.

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136302649 The rats build failed because some files (mostly travis related) do not have license headers. These files have not been changed in this PR. ```

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/751#issuecomment-136305158 Code LGTM and travis passes but I do not know what to test and the analysis gives a lot of *solved* issues from findbugs which I am sure have nothing to do with

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/750#issuecomment-136305163 Code LGTM and travis passes but I do not know what to test and the analysis gives a lot of new issues fro findbugs which I am sure have nothing to do with this

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/751#issuecomment-136306330 @DaanHoogland this is just the UI :) Alright 2LGTM, merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/751 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/763#issuecomment-136306743 Works fine now, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/750 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Rohit Yadav
Hi Mike, I think it is related to this, the libvirt version is really old that lacks the flags: https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112 If VM migration flag (8) is not available, can you check if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/763#issuecomment-136309843 Thanks @remibergsma. Since this isnt my code, LGTM from me as well(The actual PR also has 2 LGTMs). merging now --- If your project is set up for it, you can reply

Build failed in Jenkins: simulator-4.5-singlerun #268

2015-08-31 Thread jenkins
See -- Started by upstream project "build-4.5-simulator" build number 323 originally caused by: Started by upstream project "build-4.5" build number 521 originally caused by: Started by an

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136314787 Travis error seems not related. I can force push to see if it works this time. At least the Apache pull-analysis build succeeded. --- If your project is set up

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136317069 Seems Travis is broken for 4.4 :-s --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/692 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/763 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...

2015-08-31 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/764 Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High ex.printStacktrace prints to System.err by default. Used it and removed the printwriter which was causing the findbugs issue.

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136318482 It has been partially fixed on 4.6, but still the code can be improved since it might return null. Below an snippet of the 4.6 code: @Override

Build failed in Jenkins: simulator-4.5-singlerun #269

2015-08-31 Thread jenkins
See -- Started by user Daan Hoogland [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace

Re: Build failed in Jenkins: build-master-slowbuild #2176

2015-08-31 Thread Rajani Karuturi
The below pr would fix the findbugs issue. https://github.com/apache/cloudstack/pull/764 ~Rajani On Sun, Aug 30, 2015 at 2:59 PM, Daan Hoogland wrote: > The job is removed after 10 others are run. Look at > http://jenkins.buildacloud.org/job/build-master-slowbuild >

Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Hi, Has anyone seen this before and can translate to English? The logs don't say much, it's obviously SSL related somehow. The agent says: java.io.IOException: SSL: Fail to init SSL! java.io.IOException: Connection closed with -1 on reading size. at com.cloud.utils.nio.NioClient.init(N

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136321979 Just discussed with @remibergsma and went over the old (4.4) code, the change made by @rajesh-battala - which broke the behaviour - and how 4.6 now is. The

[GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...

2015-08-31 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/754#issuecomment-136322596 Yes, I'm still getting the same error. It could very well be an environment issue. ping @wilderrodrigues @remibergsma can you guys give it a try?

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136322597 Changes included from the PR, branch rebased from latest master. Please help review - @karuturi @jburwell @DaanHoogland @remibergsma @kishankavala and other

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed by a reboot of the management server seems to have fixed it, but it's not a solution I like very much. Anyone has any clues as to what causes that error? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! w

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Rajani Karuturi
Hi Lucian, Can you share the point release numbers of java before and after the upgrade? (May be that would help us find the issue.) ~Rajani On Mon, Aug 31, 2015 at 3:42 PM, Nux! wrote: > A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed by > a reboot of the management serv

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136326260 I will re-review later today (31 August 2015). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136326696 @bhaisaab lot of code :) .. I will review tomorrow. Can you review 755 if possible? ;) --- If your project is set up for it, you can reply to this email and ha

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Rajani, Sure: Downgrade java-1.6.0-openjdk-1:1.6.0.35-1.13.7.1.el6_6.x86_64 @base Downgraded1:1.6.0.36-1.13.8.1.el6_7.x86_64 @updates Downgrade java-1.7.0-openjdk-1:1.7.0.85-2.6.1.3.el6_6.x86_64 @updates Downgraded1:1.7.0.85-2.6.1.3.el6_7.

[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/764#issuecomment-136332126 @karuturi please have a look at https://github.com/apache/cloudstack/pull/762/files Your solution will work but I like the other one as well. --- If your proj

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38301615 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licen

Re: Build failed in Jenkins: build-master-slowbuild #2176

2015-08-31 Thread Rajani Karuturi
sorry. I didnt see that. Will review 762 and close 764. ~Rajani On 31-Aug-2015, at 4:21 pm, Daan Hoogland wrote: > https://github.com/apache/cloudstack/pull/762 by Rafael, did as well. Let's > have a run-off ;) > > On Mon, Aug 31, 2015 at 11:56 AM, Rajani Karuturi wrote: > >> The below pr

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38301757 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licen

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Rajani Karuturi
If I am reading it right, java 1.7 has no version change and 1.6 is changed from 1.6.0.35 to 16.0.36 which caused the failure Interestingly, I do not see release notes for 1.6.0_36 http://www.oracle.com/technetwork/java/javase/releasenotes-136954.html ~Rajani On Mon, Aug 31, 2015 at 4:09 PM, Nux

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136335429 7.5kloc would justify 15klotc (kilo-lines of test code) I am not very worried about the quality of this code or the zeal of some bluely shaped programmers to ma

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38302004 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licen

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38302129 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licen

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Rajani, Yes, you read right. The rpm changelog shows: Tue Jul 28 2015 Andrew Hughes - 1:1.6.0.36-1.13.8.1 - Update tarball to fix TCK regression (PR2565) - Resolves: rhbz#1235150 * Wed Jul 22 2015 Andrew Hughes - 1:1.6.0.36-1.13.8.0 - Update to IcedTea 1.13.8 - Update no_pr2125.patch to work a

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38302765 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licen

Build failed in Jenkins: build-master-slowbuild #2192

2015-08-31 Thread jenkins
See Changes: [Rohit Yadav] CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing [Rajani Karuturi] CLOUDSTACK-8725 RVR functionality is broken in case of isolated networks, conntrackd fails to

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38303216 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java --- @@ -39,6 +39,9 @@ private static final

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38303506 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled(

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38303622 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled(

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38303769 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled(

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38303804 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled(

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38304057 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled(

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-08-31 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/765 CLOUDSTACK-8688 - default policies for INPUT and FORWARD should be se… …t to DROP instead of ACCEPT - In order to be able to access the routers via the link local interface

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Milamber
Hello, Perhaps an issue on SSL/TLS requirement. Check difference of the file below (now and after the update) JAVA_HOME/jre/lib/security/java.security Particularly the keys: jdk.certpath.disabledAlgorithms and jdk.tls.legacyAlgorithms Also, check the keystore contains the ssl keys with the

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136354474 Some screenshots: VMs: ![image](https://cloud.githubusercontent.com/assets/5129209/9578445/681a3194-4fea-11e5-80c8-b085d4bf9809.png)

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Thanks Milamber, I'll have to set up a test env for this and follow your advice. I'll get back with any findings. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Milamber" > To: dev@cloudstack.apache.org > Sent: Monday, 31 August, 2

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136363043 VM Life Cycle tests (Advanced Zone) ``` [root@cs1 integration]# nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLAT

[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-08-31 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/762#issuecomment-136363041 The tests that have failed do not seem to be related to the code that was changed. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-08-31 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-136366153 Hi @karuturi, If you take a look at here: https://github.com/rafaelweingartner/cloudstack/blob/master-lrg-cs-hackday-003/plugins/hypervisors/vmware/src

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Sebastien Goasguen
did you do the aws configure ? aws cli needs to know your keys as well.. > On Aug 28, 2015, at 6:04 PM, Rajani Karuturi wrote: > > Hi Carlos, > I have the signature fix and config looks like below. I also checked that > the keys are correct. > > > On Fri, Aug 28, 2015 at 20:53 PM, Carlos Reat

New Defects reported by Coverity Scan for cloudstack

2015-08-31 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 3 new defect(s) introduced to cloudstack found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(

Build failed in Jenkins: build-master-slowbuild #2193

2015-08-31 Thread jenkins
See -- [...truncated 28153 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-08-31 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-136390913 @karuturi, I was just reviewing my commit, I am really sorry. I indeed forgot to commit the removal of the static keyword in that method. It was right i

[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-136397028 Hi @nlivens , I'm looking int your PR and also and some documentation of Cloudstack 4.2 related to Netscaler as external load balancer for VPCs:

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
There are a bunch of things like this in the code already, and they're wrapped in version checks. See _hypervisorLibvirtVersion in LibvirtComputingResource. We just need to figure out which versions need to be left out. On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav wrote: > Hi Mike, > > I thi

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Rajani Karuturi
Yes. I did. Can you point me logs or a way to debug? On Mon, Aug 31, 2015 at 18:46 PM, Sebastien Goasguen wrote: did you do the aws configure ? aws cli needs to know your keys as well.. > On Aug 28, 2015, at 6:04 PM, Rajani Karuturi > wrote: > > Hi Carlos, > I have the signature fix and confi

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread David Nalley
On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das wrote: > I am no longer able to start MS after this. I did a clean build followed by > starting MS. Did travis pass for it? Should we revert? > Yes, and in general, when things break you should feel empowered to revert (still send a note to the list,

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0 (version 100 in how the Libvirt API reports), and VIR_DOMAIN_XML_SECURE was all the way back in v0.8.0 (version 8000). On Mon, Aug 31, 2015 at 8:04 AM, Marcus wrote: > There are a bunch of things like this in the code alr

Build failed in Jenkins: build-master-slowbuild #2194

2015-08-31 Thread jenkins
See -- [...truncated 28153 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
Thanks, everyone Marcus - Do you think I should put in a version check or is that version of Libvirt too old to bother supporting? On Monday, August 31, 2015, Marcus wrote: > Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0 > (version 100 in how the Libvirt API reports

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread Daan Hoogland
As David says; Though I think it is very polite of you to wait and ask around, you have this right if you can show master doesn't work. On Mon, Aug 31, 2015 at 6:06 PM, David Nalley wrote: > On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das > wrote: > > I am no longer able to start MS after this. I

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
Might as well put the check in, to ensure we don't try to use flags that aren't available. On Mon, Aug 31, 2015 at 10:21 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Thanks, everyone > > Marcus - Do you think I should put in a version check or is that version of > Libvirt too old t

[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-136449843 @wilderrodrigues I agree. @nlivens maybe a conditional display can be concocted. I suppose you made this because the dropdown was hindering your eyesight..? -

[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-08-31 Thread kmccormick
GitHub user kmccormick opened a pull request: https://github.com/apache/cloudstack/pull/766 CLOUDSTACK-8678: Reserve RAM for KVM host OS Use host.reserved.ram.mb agent property to modify total system RAM before reporting to management server. You can merge this pull request into

RE: Discuss reserving memory on KVM hypervisors ref: CLOUDSTACK-8678

2015-08-31 Thread Kevin McCormick
I've submitted a pull request here: https://github.com/apache/cloudstack/pull/766. Basically just does a totalRAM - host.reserved.mem.mb before reporting total RAM to the management server. Remi, if you can test, that would be great. We can get it done later this week, but we don't have automa

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
Sounds good Does this look reasonable (I haven't tested it yet): CVE-2015-3252: Get XML with sensitive information suitable for migration by using VIR_DOMAIN_XML_MIGRATABLE flag (value = 8) https://libvirt.org/html/libvirt-libvirt-domain.html#virD

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
This is probably more esthetically pleasing to most people (and simpler looking): CVE-2015-3252: Get XML with sensitive information suitable for migration by using VIR_DOMAIN_XML_MIGRATABLE flag (value = 8) https://libvirt.org/html/libvirt-libvirt-

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
I see a test was failing: LibvirtComputingResourceTest.testMigrateCommand. I'm not sure if you can do an "or" with Mockito, but I changed a check to the following and it passes now (it was failing because a 1 was being passed in now instead of an 8 on my platform): try { veri

Build failed in Jenkins: build-master-slowbuild #2195

2015-08-31 Thread jenkins
See -- [...truncated 28153 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

Re: [DISCUSS] Let's fix CloudStack Upgrades and DB migrations with CloudStack Chimp

2015-08-31 Thread David Nalley
On Sat, Aug 29, 2015 at 4:27 AM, Wido den Hollander wrote: > > > On 08/28/2015 07:16 PM, David Nalley wrote: >> I REALLY like the idea. I wish we could gut the existing upgrade process >> and replace it wholesale. >> However, I'd urge us to use some existing tool as the foundation (while >> there

Re: [DISCUSS] Let's fix CloudStack Upgrades and DB migrations with CloudStack Chimp

2015-08-31 Thread Rene Moser
+1! On 08/28/2015 08:51 AM, Rohit Yadav wrote: > Hi all, > > Some of us have discussed in the past on fixing CloudStack’s upgrade and > DB migration, I’m trying to explore if we can really fix this. Please > review, advise changes, add suggestions along with your upgrade > experience so we can im

Build failed in Jenkins: build-master-slowbuild #2196

2015-08-31 Thread jenkins
See -- [...truncated 28153 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-www/pull/15 update download URL Update download URL because of change on apache servers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdion891/clo

[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread pdion891
Github user pdion891 closed the pull request at: https://github.com/apache/cloudstack-www/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-www/pull/15#issuecomment-136538156 Will do directly as the site is impacted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
OK, just an FYI that the version-checking code I put in based on Marcus' comments worked. I can now live migrate the VM. I plan to open a PR for this later tonight. On Mon, Aug 31, 2015 at 1:49 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > I see a test was failing: LibvirtComputing

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread Mike Tutkowski
What do we think, though, about tickets listed as Minor going in at this point in 4.6 development? If they entail a trivial change in only a file or two, it's probably OK, but where should we draw the line? At some point as the release goes on, we should stop accepting PRs that are tied to Minor

Build failed in Jenkins: build-master-slowbuild #2197

2015-08-31 Thread jenkins
See -- [...truncated 28153 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38383968 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licensed

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38383999 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licensed

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384030 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licensed

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384040 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licensed

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384079 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + * Licensed

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384082 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java --- @@ -39,6 +39,9 @@ private static final Con

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384124 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled() {

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384161 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled() {

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-08-31 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/767 Support live migration on older version of Libvirt https://issues.apache.org/jira/browse/CLOUDSTACK-8792 A flag being passed to Libvirt assumes v1.0.0 or later. We need t

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384216 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled() {

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38384226 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled() {

Request for PR Review (Cannot live migrate VM with Libvirt < v1.0.0)

2015-08-31 Thread Mike Tutkowski
Hi, I was wondering if a couple people could take a look at the following PR: https://github.com/apache/cloudstack/pull/767 There is not much code involved. It solves the following issue related to live migration on KVM: https://issues.apache.org/jira/browse/CLOUDSTACK-8792 Thanks! -- *Mike

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Rohit Yadav
+1 (binding) Following install and api tests performed; pip install ec2stack-configure ec2stack-register ec2stack_server_address # or register user using curl pip install awscli aws configure set default.ec2.signature_version v2 aws ec2 describe-images —endpoint= # minor issue here, aws prin

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Rohit Yadav
On 28-Aug-2015, at 4:34 pm, Rajani Karuturi mailto:rajani.karut...@citrix.com>> wrote: $ ec2stack-register http://localhost:5000 cs_api_key cs_secret_key $ aws ec2 describe-images --endpoint=http://localhost:5000 # it gave the below error message # Unable to locate credentials. You can configure

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136585198 LGTM, whoever merged, please merge on 4.5 branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

  1   2   >