[GitHub] cloudstack pull request: CLOUDSTACK-8755: xs-tools.iso missing fro...

2015-08-25 Thread shwetaag
Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/727#issuecomment-134504724 Result information : Test delete ISO ... === TestName: test_07_list_default_iso | Status : SUCCESS === ok

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134504869 What is the page size? can you attach a screenshot? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134508369 @karuturi the sharedFunctions.js defines a global pagesize (fixed to value 20) See in the screenshot; the listTemplates call does not call the API with a p

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134509669 @karuturi this is the screenshot from chrome devtools with the UI fix, as you can see pagination is implemented ![screenshot from 2015-08-25 12 54 50](http

Re: review wanted

2015-08-25 Thread sebgoa
On Aug 25, 2015, at 12:41 AM, Rafael Weingärtner wrote: > Hi Daan, > I think that we should do a proper introduction. > It might seem kind of odd to some people that a bunch of folks suddenly > started working for free. > > Our first PR was done a while ago: > https://github.com/apache/cloudst

Re: review wanted

2015-08-25 Thread Daan Hoogland
Thanks Rafael, I had no idea of the formation and origin of the group and your introduction as well as your contributions are very welcome. On Tue, Aug 25, 2015 at 9:40 AM, sebgoa wrote: > > On Aug 25, 2015, at 12:41 AM, Rafael Weingärtner < > rafaelweingart...@gmail.com> wrote: > > > Hi Daan, >

Fwd: Returned post for annou...@cloudstack.apache.org

2015-08-25 Thread Daan Hoogland
Just now I got this message and realize that 4.4.4 has never been announced as the mail (from d...@apache.org) had not been moderated. I did not see a moderation mail. Anything that should have been done? -- Forwarded message -- From: Date: Tue, Aug 25, 2015 at 7:07 AM Subject: Re

[GitHub] cloudstack pull request: CLOUDSTACK-8685: Fix for missing defaultr...

2015-08-25 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/738#issuecomment-134521171 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134522578 tested it and confirm the behaviour in the screenshots before and after the fix. :+1: --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-134522790 :+1: as per #740 (I havent tested it on 4.5) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134523092 Thanks for testing and verifying @karuturi :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/731 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-134523852 thanks @karuturi the screenshots are from a 4.5 env, I've tested this on 4.5 --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: CLOUDSTACK-8685: Fix for missing defaultr...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

CCC Dublin Oct 8-9 2015

2015-08-25 Thread Sebastien Goasguen
It’s coming up fast, http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe Register soon, so we can all share, collaborate and have fun -sebastien

Re: review wanted

2015-08-25 Thread Remi Bergsma
Great! Welcome :-) > On 25 Aug 2015, at 00:41, Rafael Weingärtner > wrote: > > Hi Daan, > I think that we should do a proper introduction. > It might seem kind of odd to some people that a bunch of folks suddenly > started working for free. > > Our first PR was done a while ago: > https://gith

[GitHub] cloudstack pull request: Made following fixes in simulator

2015-08-25 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/741 Made following fixes in simulator - Support for ScaleVmCommand/NetworkRulesVmSecondaryIpCommand in resource layer - Added support for scaling up a running VM in simulator - Fixed som

Re: How does the parameter startdate/enddate of api listEvents() use new time format like 'yyyy-MM-dd HH:mm:ss' ?

2015-08-25 Thread Abhinandan Prateek
Yes, as per https://cloudstack.apache.org/api/apidocs-4.2/root_admin/listEvents.html > On 24-Aug-2015, at 2:08 pm, tony_caot...@163.com wrote: > > Hello Every. > > I know this is a very simple question to most of you. but it is really hard > for me to continue my work. > > So could Anyone spen

Re: How does the parameter startdate/enddate of api listEvents() use new time format like 'yyyy-MM-dd HH:mm:ss' ?

2015-08-25 Thread Daan Hoogland
Tony/Cao Tong, just as a guess and as I see you are chinese; the chacter between the date and the time is a 32 (uri encoded %20)? Not sure if that is your problem but it might be. Looking at the stack trace you might as well want to look at the version of your client library as it seems to refus

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-08-25 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134553590 LGTM to me too. Tested on a master test deployment (Ubuntu 14.04 / KVM / NFS) Success with a manual snapshot from cloudmonkey and web ui Success

[GitHub] cloudstack pull request: Made following fixes in simulator

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134556011 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/732#discussion_r37854506 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java --- @@ -91,7 +102,6 @@ public void execute() { boo

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/732#discussion_r37854560 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java --- @@ -31,25 +31,36 @@ import org.apache.cloudstack.api.r

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134558876 In general LGTM, please see if you could fix the response class and object of the API (pl see the comments). --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134558902 Wow, great code and tests!. Love what you did with the Restclient, will be using that for sure soon :). LGTM! --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/731#discussion_r37855588 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -699,17 +698,6 @@ public boolean configure(

[GitHub] cloudstack pull request: CLOUDSTACK-8765: fix vm migration failure...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/736#issuecomment-134567460 LGTM, tested deployment of 2 KVM hypervisors on CentOS 7 and could live migrate without issues. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: [Automation]Volume migration between pool...

2015-08-25 Thread nitt10prashant
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/742 [Automation]Volume migration between pools times out in ACS, but but the migration completes on Xenserve Ticket :CLOUDSTACK-8771 description: Volume migration between p

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134576306 Force pushed to fix typos in license header of file `utils/src/test/java/com/cloud/utils/rest/RESTServiceConnectorTest.java` --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134579465 Force pushed again to add the missing license headers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/735#discussion_r37865908 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java --- @@ -286,7 +287,11 @@ private void deleteExitingLinkLoca

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-25 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/735#issuecomment-134591140 While it is a small nit and not expressly within the scope of this PR, could you fix the spelling mistake in the ``deleteExitingLinkLocalRouteTable`` name? --- I

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-25 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134595147 See comments on PR #735 regarding extracting the parsing logic and unit testing. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134595872 Force pushed again for two more license headers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/731#discussion_r37874182 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -699,17 +698,6 @@ public boolean configu

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134632894 Force pushed again to fix NiciraNvp module structure refactoring that left out the resources configuration in pom.xml --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134636230 @remibergsma changes looks fine. I would like to test it and get back to you, hopefully by tomorrow. --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134664222 @kishankavala Thanks, that would be great! Let me know if I can be of any help. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134695303 LGTM - Deployed a full stack Nicira environment: 3 controllers, a manager, a service node and 2 KVM hypervisors, all inside my development VM: ``` #

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/737#issuecomment-134699346 All builds are passing and we have 2xLGTM. Will merge it. Thanks @miguelaferreira ! --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134706080 @shwetaag Thanks. I was also able to run your test. Please change the title, see previous comment. ``` [root@cs2 cloudstack]# cat /tmp//MarvinLogs/t

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-134706537 @shwetaag I have no VMware so cannot run this test. Is there any way to make the test more generic? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/692#issuecomment-134707371 @bvbharatk Had a quick look and it seems to solve the problem. Can you please rebase against latest master so we can have a clean merge? Thanks! @DaanHoo

Re: How does the parameter startdate/enddate of api listEvents() use new time format like 'yyyy-MM-dd HH:mm:ss' ?

2015-08-25 Thread Yiping Zhang
Tony: Your date format seems to be OK. I just tried on my cs 4.5.1 with cloudmonkey 5.3.1: (local) 🐵 > list events startdate='2015-08-25 15:20:00' count = 1 event: id = 983c0369-80f2-4431-801c-273bffd925e5 account = admin created = 2015-08-25T15:29:54-0500 description = user has logged in from I

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-08-25 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134820562 Can you add some tests please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-25 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/743 Removed unused agent command AttachVolumeCommand and corresponding an… …swer AttachVolumeAnswer These types are not used anywhere in the orchestration layer. You can merge this

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37946859 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,85 @@ +// Licensed to the Apache Software F

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37946936 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,136 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947002 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,136 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947073 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilder.java --- @@ -0,0 +1,62 @@ +//Licensed to the Apache Sof

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947136 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947139 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947194 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-25 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134834411 @ustcweizhou is just calling the wrapper for the system in millis, which was added to the profiler. For the remaining cases, the nano time will be used (getD

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947237 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947252 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947294 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947297 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947561 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947679 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947704 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947741 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947791 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947918 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948373 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948706 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948797 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948835 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948903 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948934 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948942 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948979 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949008 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949049 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949030 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949069 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949073 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949093 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949107 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949186 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949195 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949444 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949568 --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java --- @@ -294,6 +294,14 @@ private void setFieldValue(final Field field, final BaseCmd

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949627 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949667 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949700 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949748 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949824 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949885 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949858 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-134855999 @jburwell was looking at com.cloud.utils.db.Transaction class the db is hardcoded in there: execute() short databaseId = TransactionLegacy.

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950136 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: [Automation]Volume migration between pool...

2015-08-25 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/742#discussion_r37950149 --- Diff: test/integration/component/maint/test_migrate_volume_timeout.py --- @@ -0,0 +1,286 @@ +#!/usr/bin/env python +# Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950152 --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java --- @@ -294,6 +294,14 @@ private void setFieldValue(final Field field, final

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [Automation]Volume migration between pool...

2015-08-25 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/742#discussion_r37950166 --- Diff: test/integration/component/maint/test_migrate_volume_timeout.py --- @@ -0,0 +1,286 @@ +#!/usr/bin/env python +# Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950196 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950222 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950233 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

  1   2   >