Re: Merging Pull Requests

2015-08-20 Thread Wido den Hollander
On 19-08-15 17:27, Remi Bergsma wrote: > Hi all, > > As it is now, additions to CloudStack need to go through a GitHub PR and, if > accepted, merged to the Apache remote (not in GitHub). This means that > merging a PR for CloudStack is a bit more involved than merging a normal > GitHub PR. >

[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

2015-08-20 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/722 Fixing syntax error introduced in PR #717 Commit 0062ff2672e257f2a4290e054e23ef4333a34983 in PR #717 introduced a new parameter in two constructors. However, there is a test class (Citr

[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

2015-08-20 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/722#issuecomment-132925325 ping @karuturi @bhaisaab Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Jenkins build is back to normal : build-master-slowbuild #2103

2015-08-20 Thread jenkins
See

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

2015-08-20 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132949485 LGTM This PR is a great example of how to do code refactoring. Write unit tests that exercise the semantics, change the logic around it, run the unit

Re: Merging Pull Requests

2015-08-20 Thread Remi Bergsma
Hi Wido, Nice! The latest version should detect your Apache GitHub remote name. Regards, Remi > On 20 Aug 2015, at 09:13, Wido den Hollander wrote: > > > > On 19-08-15 17:27, Remi Bergsma wrote: >> Hi all, >> >> As it is now, additions to CloudStack need to go through a GitHub PR and, if

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

2015-08-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132957093 Thanks all for your efforts, I'm merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

2015-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/700 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...

2015-08-20 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132962997 LGTM here as well. Used this script a couple of times --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Problems with first steps of CS plugin development

2015-08-20 Thread Giebner, Sascha
Hello guys, I'm trying to complete this tutorial for the development of a Cloudstack API plugin: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+API+Development I checked out the latest version from the cloudstack master and followed the tutorial to the letter, however when I

Question regarding @Local usage on CS

2015-08-20 Thread Rafael Weingärtner
Hi folks, I noticed that CloudStack uses EJB alongside with Spring. I am trying to understand the use of @Local, are beans of classes marked with @Local singletons? -- Rafael Weingärtner

[GitHub] cloudstack pull request: More typos

2015-08-20 Thread radu-stefanache
GitHub user radu-stefanache opened a pull request: https://github.com/apache/cloudstack/pull/723 More typos Some more typos that I've found . You can merge this pull request into a Git repository by running: $ git pull https://github.com/radu-stefanache/cloudstack typo_fixes A

Re: [DISCUSS] apache builds vs reviews

2015-08-20 Thread Daan Hoogland
fair points Rajani, not related to my question but worthy of attention. In the meanwhile I am taking them as a "yes we can schedule regular (master) build down to once a day" On Thu, Aug 20, 2015 at 8:02 AM, Rajani Karuturi wrote: > pull-rat doest the rat check > pull-analysis does a roredist bu

Re: Problems with first steps of CS plugin development

2015-08-20 Thread Mike Tutkowski
I don't have easy access to the code right now, but did you update the commands.properties file with your new API commands? On Thursday, August 20, 2015, Giebner, Sascha wrote: > Hello guys, > > I'm trying to complete this tutorial for the development of a Cloudstack > API plugin: > > https://cw

Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)

2015-08-20 Thread Remi Bergsma
Hi all, +1 (binding) Tested: 1. Advanced zone with XenServer - Deployed VPCs, VMs and VPNs between them - Crashed a XenServer, watched it recover - Tested it again and all was fine. All I had to do was reset the VPN connection, but maybe it'd have done it automatically if I waited longe

SDN solutions in use today with CloudStack

2015-08-20 Thread Simon Weller
Hi all, We are currently exploring options for improving our networking setup (read SDN) within CS for our advanced zones. There are a few plugins currently available for various third party SDN providers (Nicira, Big Switch VNS, MidoNet, Stratosphere SSP, Nuage VSP et al), as well as some p

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37571366 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572081 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572286 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572319 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572729 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37573045 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundatio

Re: SDN solutions in use today with CloudStack

2015-08-20 Thread Chiradeep Vittal
Nuage seems to be in production in quite a few CloudStack clouds From: Simon Weller mailto:swel...@ena.com>> Reply-To: "dev@cloudstack.apache.org" mailto:dev@cloudstack.apache.org>> Date: Thursday, August 20, 2015 at 11:41 AM To: "dev@cloudstack.apache.org

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37573761 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37573927 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundatio

Re: SDN solutions in use today with CloudStack

2015-08-20 Thread Remi Bergsma
Hi Simon, At Schuberg Philis we use Nicira (which nowadays is called VMware NSX-MH) in production since 2012. It works well for us. The plugin is also still maintained and is getting some tlc as we speak. The Nuage plugin was introduced recently, I think in 4.5. I hear people are using this a

Re: SDN solutions in use today with CloudStack

2015-08-20 Thread Simon Weller
Thanks guys. We've seen a lot of reports of MidoNet as well, but I haven't seen them discussed much on the list. I haven't heard of anyone using GRE. We have experimented in our lab with VXLAN on KVM and it seems to work. - Si From: Remi Bergsma Sent:

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37580929 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDao.java --- @@ -0,0 +1,43 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37581010 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582361 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582377 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582389 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582401 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582427 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582453 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582431 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582467 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582475 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582547 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582530 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582598 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582622 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582759 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582819 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583016 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583025 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583163 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583437 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583449 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583531 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,106 @@ +//Licensed to the Apache Software Foundat

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37584764 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,85 @@ +// Licensed to the Apache Software F

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37585801 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateUpdateCmd.java --- @@ -0,0 +1,111 @@ +//Licensed to the Apa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37585845 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37585892 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586539 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java --- @@ -0,0 +1,93 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586787 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586853 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586898 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587109 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587088 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587187 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587233 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

Re: Question regarding @Local usage on CS

2015-08-20 Thread Rafael Weingärtner
I have just checked now, that annotation is not making any sense to me. Why would you use EJB annotation on spring beans!? On Thu, Aug 20, 2015 at 10:46 AM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi folks, > I noticed that CloudStack uses EJB alongside with Spring. > > I am tr

Re: Problems with first steps of CS plugin development

2015-08-20 Thread Abhinandan Prateek
The document is bit outdated, you need to do following three things: 1. You need to add the new cmd in ManagementServerImpl.getCommands() or your impl of pluggable service as: 2. Then you need to tell spring that the above is a bean and exists "” This should be in “-context.xml” inside resou

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37604919 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37604903 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37604908 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37604922 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605032 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605101 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605166 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605231 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDao.java --- @@ -0,0 +1,43 @@ +//Licensed to the Apache Software F

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605238 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605235 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605216 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605243 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605247 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605260 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605251 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605245 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605257 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605263 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605268 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605276 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605271 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605319 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605311 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605332 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605350 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605358 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605339 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605347 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605369 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605375 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,106 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605363 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605389 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,85 @@ +// Licensed to the Apache S

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605394 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateUpdateCmd.java --- @@ -0,0 +1,111 @@ +//Licensed t

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605399 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605406 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java --- @@ -0,0 +1,93 @@ +//Licensed to the Apac

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37605401 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apac

  1   2   >