[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36832023 --- Diff: client/pom.xml --- @@ -478,6 +478,12 @@ + --- End di

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36833745 --- Diff: client/pom.xml --- @@ -478,6 +478,12 @@ + --- End

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-130219642 open for review, tests added; cc @abhinandanprateek @remibergsma @wilderrodrigues @karuturi --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36839282 --- Diff: client/pom.xml --- @@ -478,6 +478,12 @@ + --- End di

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130231279 @wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes related to https://github.com/apache/cloudstack/pull/593. --- If your project is set u

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-130232580 @wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes related to #593. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Some KVM fixes

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/682 Some KVM fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack kvm-fixes Alternatively you can review and apply these

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

GitHub user pavanb018 opened a pull request: https://github.com/apache/cloudstack/pull/683 CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a new VM Attach multiple Volumes simultaneously to a Running VM ... === TestName: test_attach_multiple_volumes | Stat

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/683#discussion_r36845123 --- Diff: test/integration/component/test_simultaneous_volume_attach.py --- @@ -0,0 +1,264 @@ +# Licensed to the Apache Software Foundation (ASF

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/683#discussion_r36845173 --- Diff: test/integration/component/test_simultaneous_volume_attach.py --- @@ -0,0 +1,264 @@ +# Licensed to the Apache Software Foundation (ASF

[GitHub] cloudstack pull request: Some KVM fixes

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/684 CLOUDSTACK-8728: Testcase to Verify if VRs IP Testcase to check if VR's IP changes if it is destroyed and re-created in basic zone. You can merge this pull request into a Git repository b

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/684#issuecomment-130273467 Testcase result: Check if Virtual Router has same IP after network restart or not. ... === TestName: test_01_vr_has_same_ip | Status : SUCCESS === o

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/685 CLOUDSTACK-8727: API call listVirtualMachines returns same keypair Currently the user can register same key with different names. Upon listing the VM's the name which got registered first is bein

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-130282420 @kansal Can you add a similar check for duplicates keys in the createSSHKeyPair API validation? --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855234 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_spe

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855422 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_spe

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855515 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_spe

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36855563 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_spe

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36856027 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36857039 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_spe

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user kansal commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36858306 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed

Re: Release EC2stack 1.0.0

On 12-Aug-2015, at 4:01 pm, sebgoa mailto:run...@gmail.com>> wrote: How do people feel about this ? Has anyone used it lately with 4.5.x releases ? I had test ec2stack with 4.5.1 release and help set it up for a pre-production environment as well. Last time I checked I was able to work awscli

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130313964 @koushik-das Added tests. Please have a look! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/680#discussion_r36865162 --- Diff: ui/scripts/instances.js --- @@ -618,11 +618,11 @@ createForm: { title: 'label.

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/680#discussion_r36865186 --- Diff: ui/scripts/instances.js --- @@ -2425,11 +2425,15 @@ var allowedActions = []; if (jsonObj.state == 'Destroyed

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/680#discussion_r36865220 --- Diff: ui/scripts/instances.js --- @@ -2498,8 +2502,11 @@ } else if (jsonObj.state == 'Error') { allowedActions.push(

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-130321431 please comment on testing the stuff, for instance ref unit - or integration tests that cover the code in the PR description/comment or, alternatively add unit t

Re: Release EC2stack 1.0.0

On Aug 12, 2015, at 12:31 PM, sebgoa wrote: > Hi folks, > > I am working towards making a release of EC2stack. > Since it was given to our project we have not made an official release. > > I just added a few documentation files, added license headers, notice files, > copied over the release s

[GitHub] cloudstack pull request: [CLOUDSTACK-8427] Add missing localizatio...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/686 [CLOUDSTACK-8427] Add missing localization for some labels in Web UI - on new functionnality: upload volume/template from Local - on the zone configuration wizard for the "Next" button

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/687 [CS45] Add missing localization for some labels in Web UI - on the zone configuration wizard for the "Next" button - on templates, Shared, extratable and Dynamically Scalable - Impr

Build failed in Jenkins: build-master-slowbuild #2043

See Changes: [mike.tutkowski] getUsedBytes should query the SolidFire cluster to acquire the size of the given volume if there is no volume_details info for that volume (and then create a volume_details row for this volume

Re: Release EC2stack 1.0.0

Hey Sebastien, Thank you for doing this. If there's any small jobs I can help out let me know, I'm allowed to work on this type of stuff again once Friday the 14th passes. On Wednesday, August 12, 2015, sebgoa wrote: > > On Aug 12, 2015, at 12:31 PM, sebgoa > > wrote: > > > Hi folks, > > > > I

Build failed in Jenkins: build-master-slowbuild #2044

See -- [...truncated 27471 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130523246 @mike-tutkowski master slow build failed as this commit introduced a new findbugs issues. Can you please take a look? http://jenkins.buildacloud.org/job/build-maste

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130526955 It doesn't like this line: long lVolumeId = Long.valueOf(volume.getFolder()); The folder column is a string, but it's storing a long for me (t

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130535022 valueOf returns a new Long() where as parseLong returns primitive long. valueOf causes unboxing as what is required is a primitive long. Using parseLong will satisf

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user kansal commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/685#discussion_r36940851 --- Diff: setup/db/db/schema-452to460.sql --- @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS `cloud`.`user_vm_details` `custom_speed

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/683#discussion_r36940905 --- Diff: test/integration/component/test_simultaneous_volume_attach.py --- @@ -0,0 +1,256 @@ +# Licensed to the Apache Software Foundation (ASF

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130535316 OK, but - ultimately - I do want to convert it to a primitive long. On Wed, Aug 12, 2015 at 10:50 PM, Rajani Karuturi wrote: > valueOf re

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536383 I think I confused you :). Since what is required is primitive long, findbugs wants you to use parseLong instead of valueOf(which returns Long object) --- If your

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536491 BTW, I just noticed, this PR is missing jira issue. It would be good to have one. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536522 No, what you said made perfect sense. :) I just read it incorrectly at first. On Wed, Aug 12, 2015 at 11:02 PM, Rajani Karuturi wrote:

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130536585 No, what you said made perfect sense. :) I just read it incorrectly at first. --- If your project is set up for it, you can reply to this email and have your

Re: [GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

I'm not sure what the protocol is on this, so I just went ahead and checked in the code to fix the FindBugs issue and noted the PR (674) it is related to. Here is the commit: 8fcc76e On Wed, Aug 12, 2015 at 10:55 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Oh, I read what you wr

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-130539282 @kishankavala The current implementation of the createSSHKeyPair checks for the keypair-name in the table ssh_keypairs and if that name exists it will return "A keyp

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

GitHub user manasaveloori opened a pull request: https://github.com/apache/cloudstack/pull/688 verify that when createTemplate is ued to create templates with same … …name, all of them fet unique_name under vm_template table so that templates with same name does not

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Github user manasaveloori commented on the pull request: https://github.com/apache/cloudstack/pull/688#issuecomment-130540793 Test when createTemplate is used to create templates having the same name all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status : SUC