[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

2015-07-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120803952 @abhinandanprateek @jburwell @wilderrodrigues ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

2015-07-12 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120815287 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...

2015-07-12 Thread nitt10prashant
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/579 CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_p… …s_max_limits.py for lxc hypervisor test results Test Try to deploy VM with admin accou

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...

2015-07-12 Thread Sanjeev N
LGTM On Mon, Jul 13, 2015 at 11:02 AM, nitt10prashant wrote: > GitHub user nitt10prashant opened a pull request: > > https://github.com/apache/cloudstack/pull/579 > > CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_p… > > …s_max_limits.py for lxc hypervisor > >

RE: [PROPOSAL] Commit to master through PR only

2015-07-12 Thread Paul Angus
I agree with Daan, Lazy consensus QA is not going to improve code quality. If anything we're highlighting a structural issue with the amount of resource available to review these PRs - which is a different issue and would need looking at as such as it is fundamental to our push for improved qua