[GitHub] cloudstack pull request: Vpcr Marvin test and some fixes for vprc

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/558#discussion_r34012792 --- Diff: test/integration/component/test_vpc_redundant.py --- @@ -0,0 +1,506 @@ +# Licensed to the Apache Software Foundation (ASF) under one

Re: [ACS4.5] status

On Jul 7, 2015, at 8:17 AM, Daan Hoogland wrote: > I haven't heard of this in a few days. Does anyone keep track of 4.5 > releasebility at the moment? I would like to move on to 4.6:) So can > we make a release candidate for 4.5.2 yet? if you think it needs to be done, just do it > > -- > D

Re: [PROPOSAL] Commit to master through PR only

On Jul 3, 2015, at 12:01 PM, Wilder Rodrigues wrote: > Hi John, > > If you look at the discrete operations wearing a hat of a Project Manager, > you won’t care… neither would I. However, from a Software Engineer > perspective, as much as the other people contributing with the Java code, I >

Re: [ACS4.5] status

> On 07-Jul-2015, at 11:47 am, Daan Hoogland wrote: > > I haven't heard of this in a few days. Does anyone keep track of 4.5 > releasebility at the moment? Yes. I’ve shared this earlier that I plan to start this in 1-2 weeks time, till then I’m looking for regressions and bugs that need to be f

defects cleanup drive...

Hi, There are a number of Resolved Defects and was wondering if some of us can work on closing the defects - I know this is one of the things that Sebastien had on the To Dos... Following is a snapshot from today... Blockers : 114 Criticals: 556 Majors

[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/563 ui: Allow UI plugins to be shown on navigation bar Introduces a boolean option in UI plugins setting it to 'true' would display the UI plugin on the left navigation bar. Signed-off-

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

Rohit, are you basing this on 4.5? seems like a feature (meaning it should be based on master). On Tue, Jul 7, 2015 at 11:42 AM, wrote: > Repository: cloudstack > Updated Branches: > refs/heads/4.5-ui-plugin-enhancement [created] f8693d24a > > > ui: Allow UI plugins to be shown on navigation b

Re: defects cleanup drive...

Raja, thanks for picking this up. I have practiced the principle of awaiting (at least verbal) confirmation from the reporter that an issue could indeed be closed. With the increased activity on integration tests we might base ourselves on that. ideas? On Tue, Jul 7, 2015 at 11:42 AM, Raja Pullel

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/535#issuecomment-119151038 changes looks good. Please go ahead with the merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

resource leaks exception to the 2LGTM rule

Guys `n' Dolls, I want an exception to the rule requiring two LGTMs for any commit: coverity reports 73 high impact issues at the moment. All of them are resource leaks that can be solved by the well known pattern of using try-with-resource. We (and I do mean a lot of us) have been fixing this in

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

On 07-Jul-2015, at 3:17 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: Rohit, are you basing this on 4.5? seems like a feature (meaning it should be based on master). Not a feature but refactoring - I want to show any UI plugin on left nav without forking the core code which is done

Re: resource leaks exception to the 2LGTM rule

On 07-Jul-2015, at 3:29 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: I want permission to go ahead and address these issues and not create one huge or 73 small PRs. Can I? One huge commit would be fine, testing/merging 73 small PRs is going to be some work. Regards, Rohit Yadav S

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

ok, but we should not wait with a release for this or wait releasing 4.6? On Tue, Jul 7, 2015 at 12:02 PM, Rohit Yadav wrote: > > On 07-Jul-2015, at 3:17 pm, Daan Hoogland wrote: > > Rohit, are you basing this on 4.5? seems like a feature (meaning it > should be based on master). > > > Not a f

Re: resource leaks exception to the 2LGTM rule

I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav wrote: > > On 07-Jul-2015, at 3:29 pm, Daan Hoogland wrote: > > I want permission to go ahead and address these issues and not create > one huge or 73 small PRs. Can

Re: resource leaks exception to the 2LGTM rule

On Jul 7, 2015, at 12:10 PM, Daan Hoogland wrote: > I will not do it in one commit, if we insist on a PR i will do 73 commits > in one PR. > are you automating those commits ? I would not mind scanning through them and giving green light. and in that case squash might be good :) > On Tue, J

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

Depends - I would want this. One could say it’s a bug that UI plugins are listed but hidden (see the code, a is added, but if the section is a plugin it hides it by setting display:none). Quick question - if a new feature, refactoring work or enhancement is sent for master, will they be blocke

Re: resource leaks exception to the 2LGTM rule

Sorre Sebastien, I will -1 squashing any other then typo or to and fro commits. On Tue, Jul 7, 2015 at 12:15 PM, sebgoa wrote: > > On Jul 7, 2015, at 12:10 PM, Daan Hoogland wrote: > >> I will not do it in one commit, if we insist on a PR i will do 73 commits >> in one PR. >> > > are you automat

Re: resource leaks exception to the 2LGTM rule

On 07-Jul-2015, at 3:40 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. Fine. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 |

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

On Tue, Jul 7, 2015 at 12:16 PM, Rohit Yadav wrote: > Depends - I would want this. One could say it’s a bug that UI plugins are > listed but hidden (see the code, a is added, but if the section is a > plugin it hides it by setting display:none). > ​I can go for that :) ​ > > Quick question -

[GitHub] cloudstack pull request: findbugs: write to static from instance

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/539#discussion_r34026647 --- Diff: server/src/com/cloud/api/auth/APIAuthenticationManagerImpl.java --- @@ -52,17 +55,25 @@ public void setApiAuthenticators(List authenticators)

[GitHub] cloudstack pull request: coverity resource leaks

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/564 coverity resource leaks This PR holds fixes for different resource leaks of the type that can be fixed by using try-with resource. The complete category is to be absent from coverity repor

RE: defects cleanup drive...

Daan, appreciate the quick response... we can go that route for the less Priorities ones and higher priorities ones, we should make an effort to validate/close. Otherwise, not sure when we will be able to bring the counts down ? blockers/criticals are higher risk items as well... Other thin

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/565 CLOUDSTACK-8615 :skip all tests in test_ps_limits.py for lxc issue --- All test cases are failing due to unsupported storage type solution --- skip tes

Re: resource leaks exception to the 2LGTM rule

This not a good candidate for squashing/huge commit. If a regression is found in any of the fixes, it will be easier to just revert it than reverting all the 70 commits. ~Rajani On Tue, Jul 7, 2015 at 3:47 PM, Rohit Yadav wrote: > > On 07-Jul-2015, at 3:40 pm, Daan Hoogland wrote: > > I will n

Re: defects cleanup drive...

To avoid misunderstanding arising from my unclear way of communicating: I propose(d): Let us base ourselves on integration testing whenever we can. Let us seek affirmation by reporters whenever we can. Let us not take the luxury to require both before closing issue but act on either. On Tue, Jul

Re: resource leaks exception to the 2LGTM rule

On Tue, Jul 7, 2015 at 1:37 PM, Rajani Karuturi wrote: > This not a good candidate for squashing/huge commit. > If a regression is found in any of the fixes, it will be easier to just > revert it than reverting all the 70 commits. > > ~Rajani Thanks Rajani, I allready made a booboo in the first

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

CS DR Staus

Hi All, Will the DR solution of Alena Prokharchyk will be implemented in the next release of CS. Or is there any DR solution available other than this. Thanks, Keerthi

Build failed in Jenkins: simulator-singlerun #1342

See -- Started by upstream project "build-master-simulator" build number 2159 originally caused by: Started by an SCM change Started by upstream project "build-master" build number 2449 origin

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/565#issuecomment-119188008 Test assign Vm to different account ... SKIP: unsupported storage type Test assign Vm to different account ... SKIP: unsupported storage type Stop attac

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/565#issuecomment-119189897 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

RE: marvin installation error on cloudstack 4.3; Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'

Hi Santosh, I had already tried doing “python setup.py install”. Thanks, Urvi -- Forwarded message -- From: Santhosh Edukulla mailto:santhosh.eduku...@gmail.com>> Date: Mon, Jul 6, 2015 at 11:17 PM Subject: Re: marvin installation error on cloudstack 4.3; Unable to load plugin

Any Plan on developing the cloudstack on this

Hi All, Since the DR structure is not ready yet in the CS 4.5.x is there any plan to on Zone to Zone VM Migration this will really help us to make the DR implementation or region to region migration for both xenserver and kvm. Thanks, Keerthi

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Automation for issue, Private template no...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/241#discussion_r34118957 --- Diff: test/integration/component/test_project_template.py --- @@ -0,0 +1,155 @@ +from marvin.codes import FAILED, PASS +from marvin.cloudstac

[GitHub] cloudstack pull request: Automation for issue, Private template no...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/241#discussion_r34118976 --- Diff: test/integration/component/test_user_taglisting.py --- @@ -0,0 +1,137 @@ +from marvin.cloudstackTestCase import cloudstackTestCase +fro

Build failed in Jenkins: simulator-singlerun #1343

See -- Started by upstream project "build-master-simulator" build number 2160 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely o

Build failed in Jenkins: simulator-singlerun #1344

See -- Started by upstream project "build-master-simulator" build number 2161 originally caused by: Started by upstream project "build-master" build number 2450 originally caused by: Started