Github user TimRots commented on the pull request:
https://github.com/apache/cloudstack/pull/10#issuecomment-65944285
Hi Rohit,
>What does this PR do?
Fix bad practice demonstration
>What is the issue and what does this fix do?
The main method demonstrates bad-
merge conflicts :)
~Rajani
On Thu, Dec 4, 2014 at 2:13 AM, wrote:
> Repository: cloudstack
> Updated Branches:
> refs/heads/master 8cb11f407 -> fac7bfc5d
>
>
> CLOUDSTACK-8011: Upgrade maven dependencies
>
> Changes;
> - Upgrades maven-war plugin to 4.5 (faster war packaging)
> - Upgrade spr
> On Jan. 24, 2014, 6:52 a.m., Prachi Damle wrote:
> > I see many files unrelated to this fix have been updated and present in the
> > patch.
> > Please can you update the patch with changes needed for the fix only?
> >
> > Following are some such files.
> > api/src/com/cloud/user/AccountServic
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/47#issuecomment-66013624
I tested this with a noredist build. The "stripped" functions work fine ;)
I will apply the patch.
---
If your project is set up for it, you can reply to this e
Hi Rajani,
On Monday 08 December 2014 09:58 AM, Rajani Karuturi wrote:
merge conflicts :)
This commit is already on master, thanks to you for the maven-war plugin
version suggestion.
Did you rebase over something, I'm sure you can fix them :)
~Rajani
On Thu, Dec 4, 2014 at 2:13 AM, wro
last attempt was a failure with travis failures before and after the pull
requests and hence abandoned the merge. Now that travis is green, I
planning to put up another pull request.
let me know if you see any issues.
~Rajani
some of local changes in the pom files caused conflicts and were easy to
solve. Thanks for upgrading the versions.
~Rajani
On Mon, Dec 8, 2014 at 12:14 PM, Rohit Yadav
wrote:
> Hi Rajani,
>
>
> On Monday 08 December 2014 09:58 AM, Rajani Karuturi wrote:
>
>> merge conflicts :)
>>
>
> This commi
I have added the additional info as requested.
How can we get someone who knows the code a bit more, to look at the bug report?
Should I send the private mail over to Rohit Yadav, who seems currently to be
working on 3.4.2 release back-porting patches and all?
Thank you.
F.
On 05 Dec 2014, at 15
