Re: Findbugs report on 4.3-forward

Animesh, I took up a lot of messages from findbugs in the server package over the weekend. Not that I will attach my soul to the shipping of my fixes but some of them are == vs eq and some are really nasty nullpointer issues (a chack after first use is very common). You can cherry-pick them or not

Review Request 17447: Fix for CLOUDSTACK-5948

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17447/ --- Review request for cloudstack and Girish Shilamkar. Summary (updated) -

Re: Findbugs report on 4.3-forward

Hi Ian, Any reasons for changing the LDAP random password logic? I think this way it would make it less secure than the previous one. Thanks, ~Rajani On 28-Jan-2014, at 10:55 am, Ian Duffy wrote: > Hi Animesh, > > Can you cherry-pick the below commit from from 4.3-forward to 4.3 branch? >

Re: Findbugs report on 4.3-forward

Rajani, The findbugs report recorded that the conversion from the bytes array to a string failed. As a result the database value was ending up as some object. On 28 January 2014 08:49, Rajani Karuturi wrote: > Hi Ian, > Any reasons for changing the LDAP random password logic? I think this way >

Re: Review Request 17307: Juniper Contrail Plugin fixes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17307/#review32976 --- Ship it! commit cc98125067575f305ea7621df28c70785128750a Author: Sa

Re: KVM memory overprovision breaking me

Hi Marcus, if you want to get what is assigned in the service offering then we can simply disable the overcommit feature. Thanks, Bharat. On 28-Jan-2014, at 12:37 pm, Marcus Sorensen wrote: > They're both very specific. As mentioned, ballooning only works if > you're basically just making vm

Re: Findbugs report on 4.3-forward

Hey Animesh, I agree with Daan here. We focussed on the bugs with a findbugs annotation of scariest. I think that would warrant them to be included in the 4.3 release, so please cherry-pick them all. Cheers, Hugo On 28 jan. 2014, at 09:32, Daan Hoogland wrote: > Animesh, > > I took up a l

Re: KVM memory overprovision breaking me

On 28.01.2014 06:57, Marcus Sorensen wrote: Actually, does anyone have objections to adding an agent.properties tunable to disable balloon? That would allow anyone who wants to overcommit to do so, without messing with the existing FS, and the calculations for allocation at least are all accurate

Re: KVM memory overprovision breaking me

Hi, The calculations when overcommitting are on a per VM basis. I am not sure if these will be valid when using KSM. IMO KSM is applicable to a set of VMs not a single VM. so how do we keep track of how much free memory is actually available on the host. This was not problem in case of balloo

Re: [ACS 4.3] Release Notes

On Jan 24, 2014, at 9:44 AM, sebgoa wrote: > > On Jan 24, 2014, at 8:27 AM, Animesh Chaturvedi > wrote: > >> Folks >> >> I have updated the Release Notes in 4.3 with a link to Known Issues and >> Fixed Issues in 4.3 release and kicked off the build. We need a volunteer to >> fix u

Build failed in Jenkins: build-master #138

See Changes: [jessicawang] CLOUDSTACK-5557: UI > Network > VPC > Router > Public IP Address > fix a bug that Configuration tab was wrongly hidden. [brian.federle] Instances UI: Don't show 'view host' link if VM is stopped [sateesh]

Re: KVM memory overprovision breaking me

On 28.01.2014 09:56, Bharat Kumar wrote: Hi, The calculations when overcommitting are on a per VM basis. I am not sure if these will be valid when using KSM. IMO KSM is applicable to a set of VMs not a single VM. so how do we keep track of how much free memory is actually available on the host.

Re: Useless egress in SG zone?

On 28.01.2014 05:20, Jayapal Reddy Uradi wrote: Hi Nux, 1. By default we are allowing egress in SG. 2. But when you configure any rule in egress, it allows ONLY configured rule traffic and other traffic will be BLOCKED. If admin wants allow to only specific ports/addresses this can be done by

Jetty on Windows

All, I'm successfully getting the UI to build and getting it to run on my windows machine through Jetty. That said, I always get the following error from the command line (at bottom of email). I notice it's a SQL issue regards to auto scaling - is this my configuration that's broken or is this

Review Request 17452: Added Fi for CLOUDSTACK-5963

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17452/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5963 h

Review Request 17452: Added Fi for CLOUDSTACK-5963

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17452/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5963 h

Jenkins build is back to normal : build-master #139

See

Re: Persistent Networks - Assign VM operation

I have logged issue CLOUDSTACK-5964for this. Regards, Gaurav On Mon, Jan 27, 2014 at 2:56 PM, Gaurav Aradhye wrote: > Hello all, > > According to the Persistent Networks test plan at [1], if we assign a > virtual machine deployed in a persi

Missing documentation

Hi, I pushed updated docs for LDAP authentication while back but I see they are missing from https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git I'm assuming they may of been lost in documentation from master. The commit details of the updated ones are below. Is there a reason why the

Re: Findbugs report on 4.3-forward

toString() will just print its hashcode. I think what we should be doing is new String(Base64.encode(bytes)) instead of Base64.encode(bytes).toString() ~Rajani On 28-Jan-2014, at 2:28 pm, Ian Duffy mailto:i...@ianduffy.ie>> wrote: Rajani, The findbugs report recorded that the conversion f

RE: Persistent Networks - Assign VM operation

Gaurav, I have updated the ticket with my comments. Essentially it is a network property , persistent vs non-persistent and VM should not dictate it. Let me know Thanks, RamG > -Original Message- > From: Gaurav Aradhye [mailto:gaurav.arad...@clogeny.com] > Sent: 28 January 2014 16:25

Build failed in Jenkins: build-master-noredist #2176

See -- [...truncated 7927 lines...] 91 KB 95 KB 99 KB 103 KB 107 KB 111 KB 112 KB Jan 28, 2014 12:04:00 PM org.apache.maven.wagon.providers.http.httpclient.client.protocol

RE: Missing documentation

Hi, I did a git log, but I am not able to locate your commit. -Original Message- From: Ian Duffy [mailto:i...@ianduffy.ie] Sent: Tuesday, January 28, 2014 4:31 PM To: CloudStack Dev; David Nalley Subject: Missing documentation Hi, I pushed updated docs for LDAP authentication while bac

Re: Jetty on Windows

Hey Alex, Did you reinitialize the database prior to running the jetty target? Cheers, Hugo On 28 jan. 2014, at 11:42, Alex Hitchins wrote: > All, > > I'm successfully getting the UI to build and getting it to run on my windows > machine through Jetty. That said, I always get the following

Re: Missing documentation

Ian, they are probably still in the cloudstack.git repo Can you commit in the new .rst format to https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs-admin.git;a=summary On Jan 28, 2014, at 12:01 PM, Ian Duffy wrote: > Hi, > > I pushed updated docs for LDAP authentication while back but

Build failed in Jenkins: build-master-noredist #2177

See Changes: [likitha.shetty] CLOUDSTACK-5965. VM displayname is not returned by API. -- [...truncated 5496 lines...] [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-rem

Re: Missing documentation

> I did a git log, but I am not able to locate your commit. git show a6c1b75674bb3f5a1b7cf25cc8df2837ee3e9b12 Should pull it right up on master on the cloudstack main repo. > Can you commit in the new .rst format to Will do! On 28 January 2014 11:40, sebgoa wrote: > Ian, they are probably

Jenkins build is back to normal : build-master-noredist #2178

See

RE: Jetty on Windows

I'm fairly sure I did - however that makes me wonder if I restored over the top. Good pointer, I'll check that out. Alex Hitchins +44 7788 423 969 -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: 28 January 2014 11:33 To: dev Subject: Re: Je

RE: Jetty on Windows

Rebuilt the database, now failing on a spring framework issue. Going to rebuild all and try again. Alex Hitchins +44 7788 423 969 -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: 28 January 2014 11:33 To: dev Subject: Re: Jetty on Windows H

Re: Review Request 17391: Fix base.py for Dynamic compute offerings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17391/ --- (Updated Jan. 28, 2014, 12:46 p.m.) Review request for cloudstack, Santhosh Edu

Re: Persistent Networks - Assign VM operation

Thanks Ram, I have updated ticket with my comment, it can be closed, not an issue. Regards, Gaurav On Tue, Jan 28, 2014 at 4:33 PM, Ram Ganesh wrote: > Gaurav, > > I have updated the ticket with my comments. Essentially it is a network > property , persistent vs non-persistent and VM should no

Build failed in Jenkins: build-master #141

See -- [...truncated 634 lines...] Receiving objects: 87% (407694/467969), 282.19 MiB | 410 KiB/s Receiving objects: 87% (410827/467969), 282.36 MiB | 359 KiB/s Receiving objects: 88% (411813/46

Build failed in Jenkins: build-master #142

See -- [...truncated 574 lines...] Receiving objects: 79% (373653/467977), 209.64 MiB | 422 KiB/s Receiving objects: 79% (373653/467977), 210.06 MiB | 367 KiB/s Receiving objects: 79% (373653/46

Build failed in Jenkins: build-master #143

See -- [...truncated 573 lines...] Receiving objects: 79% (373670/467993), 221.32 MiB | 764 KiB/s Receiving objects: 79% (373670/467993), 222.21 MiB | 808 KiB/s Receiving objects: 79% (373725/46

Build failed in Jenkins: build-master #144

See -- [...truncated 641 lines...] Receiving objects: 89% (416514/467993), 283.48 MiB | 795 KiB/s Receiving objects: 89% (417982/467993), 283.93 MiB | 820 KiB/s Receiving objects: 89% (419525/46

Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review32987 --- Commit 226df296d0fe98fbaba328eaa7d24546c42f36d2 in branch refs/heads

Build failed in Jenkins: build-master #145

See -- [...truncated 574 lines...] Receiving objects: 79% (374144/468028), 234.89 MiB | 470 KiB/s Receiving objects: 79% (374144/468028), 235.43 MiB | 468 KiB/s Receiving objects: 79% (374144/46

Error creating bean with name 'lockMasterListener'

I'm now getting the following error : [ERROR] Failed startup of context org.mortbay.jetty.plugin.Jetty6PluginWebAppContext@58385dae{/client,C:\_Repositories\cloudstack\client\target\generated-webapp} org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'lockMast

Build failed in Jenkins: build-master #146

See -- [...truncated 573 lines...] Receiving objects: 79% (373731/468054), 221.06 MiB | 713 KiB/s Receiving objects: 79% (373731/468054), 221.86 MiB | 716 KiB/s Receiving objects: 79% (373732/46

Build failed in Jenkins: build-master #147

See -- [...truncated 565 lines...] Receiving objects: 79% (373799/468054), 226.06 MiB | 493 KiB/s Receiving objects: 79% (373869/468054), 226.34 MiB | 498 KiB/s Receiving objects: 79% (374162/46

Build failed in Jenkins: build-master #148

See -- [...truncated 569 lines...] Receiving objects: 77% (364480/468054), 183.09 MiB | 402 KiB/s Receiving objects: 77% (364482/468054), 183.59 MiB | 300 KiB/s Receiving objects: 77% (364488/46

Build failed in Jenkins: build-master #149

See -- [...truncated 574 lines...] Receiving objects: 78% (366122/468054), 191.74 MiB | 544 KiB/s Receiving objects: 78% (366127/468054), 192.07 MiB | 558 KiB/s Receiving objects: 78% (366383/46

Build failed in Jenkins: build-master #150

See -- [...truncated 573 lines...] Receiving objects: 79% (373794/468122), 196.61 MiB | 441 KiB/s Receiving objects: 79% (373794/468122), 197.17 MiB | 430 KiB/s Receiving objects: 79% (373794/46

Build failed in Jenkins: build-master #151

See -- [...truncated 567 lines...] Receiving objects: 79% (370088/468122), 194.43 MiB | 670 KiB/s Receiving objects: 79% (373798/468122), 195.21 MiB | 712 KiB/s Receiving objects: 79% (373798/46

Build failed in Jenkins: build-master #152

See -- [...truncated 572 lines...] Receiving objects: 79% (373793/468140), 203.86 MiB | 346 KiB/s Receiving objects: 79% (373793/468140), 204.06 MiB | 338 KiB/s Receiving objects: 79% (373793/46

Minified JQuery

Do we ship using the 'full-fat' JQuery library? From my machine it looks like we do. Would this not be better practice to move to a minified version? Same with the CSS. I know it would be an extra set to add a grunt job - has this already been discussed? Regards, Alex Hitchins VP Software En

Build failed in Jenkins: build-master #153

See -- [...truncated 563 lines...] Receiving objects: 76% (357353/468140), 152.45 MiB | 490 KiB/s Receiving objects: 76% (357354/468140), 153.06 MiB | 472 KiB/s Receiving objects: 76% (357356/46

Build failed in Jenkins: build-master #154

See -- [...truncated 559 lines...] Receiving objects: 77% (364646/468140), 186.66 MiB | 303 KiB/s Receiving objects: 77% (364646/468140), 186.82 MiB | 271 KiB/s Receiving objects: 77% (364646/46

Build failed in Jenkins: build-master #155

See -- [...truncated 558 lines...] Receiving objects: 76% (357100/468163), 137.58 MiB | 387 KiB/s Receiving objects: 76% (357100/468163), 138.13 MiB | 447 KiB/s Receiving objects: 76% (357100/46

Build failed in Jenkins: build-master #156

See -- [...truncated 559 lines...] Receiving objects: 76% (357463/468174), 155.37 MiB | 457 KiB/s Receiving objects: 76% (357468/468174), 156.18 MiB | 483 KiB/s Receiving objects: 76% (357472/46

Build failed in Jenkins: build-master #157

See -- [...truncated 557 lines...] Receiving objects: 76% (357242/468186), 132.80 MiB | 379 KiB/s Receiving objects: 76% (357242/468186), 132.93 MiB | 380 KiB/s Receiving objects: 76% (357242/46

Build failed in Jenkins: build-master #158

See -- [...truncated 557 lines...] Receiving objects: 73% (346344/468186), 122.59 MiB | 494 KiB/s Receiving objects: 73% (346344/468186), 123.17 MiB | 517 KiB/s Receiving objects: 73% (346344/46

Build failed in Jenkins: build-master #160

See -- [...truncated 557 lines...] Receiving objects: 76% (357307/468186), 139.26 MiB | 346 KiB/s Receiving objects: 76% (357307/468186), 139.63 MiB | 340 KiB/s Receiving objects: 76% (357307/46

RE: Error creating bean with name 'lockMasterListener'

I've traced this down to an underlying SQL error, most likely as I have been working on the database. Alex Hitchins +44 7788 423 969 From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com] Sent: 28 January 2014 14:11 To: dev@cloudstack.apache.org Subject: Error creating bean with name 'loc

Build failed in Jenkins: build-master #161

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-b5f in workspace

cloudstack presenting wrong used memory values

Hi all, I am mailing this to the dev and users list, since I am not sure which one would be the best to make such question. So, I deployed Zenoss to monitor my Cloud, and I noticed something weird on a graph that it was generating about the Cloud's memory. The graph was showing total memory as 2

[EVENTS] CCC NA Denver

Hi everyone, You should know by now that we are going to have a CloudStack conference in Denver on april 9th-11th: http://cloudstackcollab.org The CFP is closing very shortly, so you need to get your papers in ASAP. Also register to get the early bird rates. Finally, we are looking for voluntee

Build failed in Jenkins: build-master #159

See -- [...truncated 557 lines...] Receiving objects: 76% (355851/468186), 125.87 MiB | 657 KiB/s Receiving objects: 76% (357302/468186), 127.07 MiB | 730 KiB/s Receiving objects: 76% (357302/46

Plugin Architecture

I am new to CloudStack development. I have been looking at the plugin architecture and trying to follow the guide athttps://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+API+Development I am getting a response of "{ "errorresponse" : {"uuidList":[],"errorcode":432,"cserrorcode":

Build failed in Jenkins: build-master #162

See -- [...truncated 568 lines...] Receiving objects: 77% (364703/468205), 186.10 MiB | 540 KiB/s Receiving objects: 77% (364711/468205), 187.01 MiB | 573 KiB/s Receiving objects: 77% (364711/46

Re: Minified JQuery

Alex, The UI team were looking to simplify the CSS by moving to SASS, the discussion can be seen over here: http://markmail.org/thread/iovlfytsgb5bmurw I suggested using grunt to manage the compiling of the SASS and also to introduce minification of scripts, css etc. However, I have no idea if th

Re: Plugin Architecture

Hi Matt, Within client/pom.xml you'll have to add a dependency for your plugin: example: org.apache.cloudstack cloud-plugin-api-helloworld ${project.version} You will also need to edit client/tomcatconf/applicationContext.xml.in example: and lastly we need to list all the newly added

RE: Minified JQuery

I have used grunt before and love it. I noticed also some of the sprites aren't optimised either. Fairly certain grunt can take care of this too. I don’t think it would be that massive to introduce it. It would only need to be included as a last step on release, or for dev's like me to get worke

Re: KVM memory overprovision breaking me

They don't seem to be on a per-vm basis. It seems to be service offering size divided by cluster overprovision setting. I do get what is trying to be accomplished, the best is to have both KSM and balloon. Ideally the balloon settings would all be maxed by default, and then if KSM is insufficient

master not building

It looks like commit fae05560 fails checkstyle. [INFO] [INFO] Building Apache CloudStack Server 4.4.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-checkstyle

RE: Findbugs report on 4.3-forward

Folks these issues reported by find-bugs have existed for some time. I am not confident in picking them up now for 4.3 as it may break code that assumed old way of working. We can take them up for 4.3 maintenance release. I wish we had done this exercise and not waited until now. I will pick Hu

Re: KVM memory overprovision breaking me

Commit 1530c162e58abd8e572a89d2a2706de00bd49e26 in branch refs/heads/master from [~mlsorensen] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1530c16 ] CLOUDSTACK-5968 create vm.memballoon.disable agent parameter This is just a tuneable that you have to explicitly set, otherwise eve

Re: KVM memory overprovision breaking me

On 28.01.2014 17:49, Marcus Sorensen wrote: Commit 1530c162e58abd8e572a89d2a2706de00bd49e26 in branch refs/heads/master from [~mlsorensen] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1530c16 ] CLOUDSTACK-5968 create vm.memballoon.disable agent parameter How do I lobby for it?

Re: KVM memory overprovision breaking me

just send an email requesting that it be cherry-picked, with the reasoning. I don't feel strongly that it's a bug, but if you really want it in 4.3 it's worth a shot to make your case. On Tue, Jan 28, 2014 at 10:57 AM, Nux! wrote: > On 28.01.2014 17:49, Marcus Sorensen wrote: >> >> Commit 1530c16

Cherry-pick request for 4.3 please, re memory overprovisioning

Hello, Kindly add this to 4.3 https://issues.apache.org/jira/browse/CLOUDSTACK-5968 It enables memory overprovisioning without modifying VM internal settings, quite critical for cloud sellers. Thanks! -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

Re: Exception when starting up the MS in 4.3

Actually upon rebooting my SSVM, CPVM, and VR, all three fail to boot with the following error message (in 4.3): http://i.imgur.com/dLHf37W.png The system template I'm using is this: http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14-master-xen.vhd.bz2 Is anyone else having t

Re: Callback pattern

Mike, This is a very dirty hack that I personally hate it. This is the hack to utilize Eclipse¹s (or other smart IDE) to do auto-completion for you to find the right callback method. if you write caller.getTarget().createVolumeFromBaseImageCallBack(null, null); Java will interprete it as a

Re: Callback pattern

Thanks Kelven Yeah, that code is pretty crazy. :) I followed that the getTarget() method actually dynamically extends a class and allows us to inject logic in the new class that enables us to save createVolumeFromBaseImageCallBack as the method we want to invoke when our async operation has compl

Jenkins build is back to normal : build-master #164

See

Devcloud 2 - veewee/Vagrant projects

I would like to build the devcloud2 image [1] from scratch using veewee (or packer) and turn it into a vagrant box. There seems to be several versions of Vagrant files and veewee definitions in the code base, making it difficult to know which one to start from, or whether they are still valid. Ma

RE: Exception when starting up the MS in 4.3

Hi Mike I am using same template with 4.3 build; and didn't observed any issue like you reported. Please verify the checksum, it should be 3e29b40377272803eebccfe40efea199 http://download.cloud.com/templates/4.3/systemvm64template-2014-01-14-master-xen.vhd.bz2 Regards, Rayees -Origina

RE: Cherry-pick request for 4.3 please, re memory overprovisioning

Can you put the fix in 4.3-forward branch. I tried cherry picking from master and there were conflicts Animesh -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Tuesday, January 28, 2014 10:16 AM To: dev@cloudstack.apache.org Subject: Cherry-pick request for 4.3 please, re mem

Re: Exception when starting up the MS in 4.3

If not already done, please use a new primary storage location or cleanup the old images if using the same primary storage location. On 28/01/14 1:54 PM, "Rayees Namathponnan" wrote: >Hi Mike > >I am using same template with 4.3 build; and didn't observed any issue >like you reported. > >Please

Re: Callback pattern

This is to support fluent coding style to chain all the callback setup calls in one line. Using caller.getTarget().callbackMethod() alone may cause people to think the statement as a logic requirement and actually it is not but hackings. It is like to setup a function pointer in C or delegate in C

Re: Findbugs report on 4.3-forward

Your call Animesh, I'm fine with it On Tue, Jan 28, 2014 at 6:48 PM, Animesh Chaturvedi wrote: > Folks these issues reported by find-bugs have existed for some time. I am not > confident in picking them up now for 4.3 as it may break code that assumed > old way of working. We can take them up f

Re: Exception when starting up the MS in 4.3

I'm curious why the checksum value is missing in my template.properties file: filename=b47ace7b-cf9e-4509-8072-ed913844700e.vhd description=SystemVM Template checksum= hvm=false size=2626564608 vhd=true id=1 public=true vhd.filename=b47ace7b-cf9e-4509-8072-ed913844700e.vhd uniquename=routing-1 vhd

Re: Exception when starting up the MS in 4.3

Admittedly I didn't start from a fresh XenServer image, but I did confirm via xe that there were no VDIs on my local storage SR. Hopefully that is sufficient. On Tue, Jan 28, 2014 at 2:59 PM, Nitin Mehta wrote: > If not already done, please use a new primary storage location or cleanup > the ol

Re: Exception when starting up the MS in 4.3

By the way, it seemed to work at first; however, it became a problem when I rebooted my system VMs. On Tue, Jan 28, 2014 at 3:19 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Admittedly I didn't start from a fresh XenServer image, but I did confirm > via xe that there were no VDIs

Re: Callback pattern

I see...just for chaining purposes. In some places I notice we chain this and in others we don't. Thanks for the clarification! On Tue, Jan 28, 2014 at 3:13 PM, Kelven Yang wrote: > This is to support fluent coding style to chain all the callback setup > calls in one line. Using caller.getTarg

Re: Cherry-pick request for 4.3 please, re memory overprovisioning

Done. e624632dfd532ba2885a8e7dffcb40d1436d02c1 On Tue, Jan 28, 2014 at 2:57 PM, Animesh Chaturvedi wrote: > Can you put the fix in 4.3-forward branch. I tried cherry picking from master > and there were conflicts > > Animesh > > -Original Message- > From: Nux! [mailto:n...@li.nux.ro] >

Re: Findbugs report on 4.3-forward

Hey Animesh, Not in agreement here. These are squashed bugs and we want as less bugs in the release as possible. This is why we test any RC before we release it. I say include all the big fixes we have in the release. If that means more testing before we cut the RC then that is what it is. I c

Re: Callback pattern

I originally thought to just ask developer to use plain string literals, it has better readability but it can’t take advantage of IDE provided refactoring (callback method renames), it ended up to this crazy approach. Hopefully one day Java may provide C# delegate like feature, then all these hacki

RE: Findbugs report on 4.3-forward

-Original Message- From: Hugo Trippaers [mailto:trip...@gmail.com] Sent: Tuesday, January 28, 2014 2:37 PM To: dev@cloudstack.apache.org Cc: dev@cloudstack.apache.org Subject: Re: Findbugs report on 4.3-forward Hey Animesh, Not in agreement here. These are squashed bugs and we want as l

RE: Cherry-pick request for 4.3 please, re memory overprovisioning

You had two commits in master. So need one more change to agent.propeties. Animesh -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Tuesday, January 28, 2014 2:34 PM To: dev@cloudstack.apache.org Subject: Re: Cherry-pick request for 4.3 please, re memory overpr

Re: Cherry-pick request for 4.3 please, re memory overprovisioning

I merged them into one commit, since they wouldn't cherry pick anyway. On Tue, Jan 28, 2014 at 3:58 PM, Animesh Chaturvedi wrote: > You had two commits in master. So need one more change to agent.propeties. > > Animesh > > -Original Message- > From: Marcus Sorensen [mailto:shadow...@gmail

Re: Cherry-pick request for 4.3 please, re memory overprovisioning

Oh, I see, you wanted the comments On Tue, Jan 28, 2014 at 4:02 PM, Marcus Sorensen wrote: > I merged them into one commit, since they wouldn't cherry pick anyway. > > On Tue, Jan 28, 2014 at 3:58 PM, Animesh Chaturvedi > wrote: >> You had two commits in master. So need one more change to ag

Re: Cherry-pick request for 4.3 please, re memory overprovisioning

[4.3-forward 661a19b] On Tue, Jan 28, 2014 at 4:02 PM, Marcus Sorensen wrote: > Oh, I see, you wanted the comments > > On Tue, Jan 28, 2014 at 4:02 PM, Marcus Sorensen wrote: >> I merged them into one commit, since they wouldn't cherry pick anyway. >> >> On Tue, Jan 28, 2014 at 3:58 PM, Anim

RE: Cherry-pick request for 4.3 please, re memory overprovisioning

No I see that for master you had also changed agent.properties but that has not been included in your 4.3-forward commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=agent/conf/agent.properties;h=a7376b689470fd169a983add791ada609222f96b;hp=5f5f3682afdc2aea25ff607984bca

Re: Cherry-pick request for 4.3 please, re memory overprovisioning

Yeah, the comments for agent.properties are in [4.3-forward 661a19b] On Tue, Jan 28, 2014 at 4:05 PM, Animesh Chaturvedi wrote: > No I see that for master you had also changed agent.properties but that has > not been included in your 4.3-forward commit > > > > https://git-wip-us.apache.org/repos

RE: Cherry-pick request for 4.3 please, re memory overprovisioning

Ok got it off to building RC now -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Tuesday, January 28, 2014 3:05 PM To: dev@cloudstack.apache.org Subject: Re: Cherry-pick request for 4.3 please, re memory overprovisioning [4.3-forward 661a19b] On Tue, Jan 28,

Re: Findbugs report on 4.3-forward

Sent from my iPhone > On 28 jan. 2014, at 23:50, Animesh Chaturvedi > wrote: > > > -Original Message- > From: Hugo Trippaers [mailto:trip...@gmail.com] > Sent: Tuesday, January 28, 2014 2:37 PM > To: dev@cloudstack.apache.org > Cc: dev@cloudstack.apache.org > Subject: Re: Findbugs r

RE: VM instance view UI is broken in 4.3-forward (This is an API bug, not UI bug. )

Koushik, I just tested in 4.3-forward branch. This is an API bug, not UI bug. (1) "virtualmachine" object returned by deployVirtualMachine API, queryAsyncJobResult API does NOT include name, displayname, zonename, state property. http://10.215.3.26:8080/client/api?command=deployVirtualMachine

RE: Findbugs report on 4.3-forward

Are you sure all of the ones are needed. A quick look at 20+ commits from Daan show many formatting changes that may not be necessary and hinder quick review. -Original Message- From: Hugo Trippaers [mailto:trip...@gmail.com] Sent: Tuesday, January 28, 2014 3:16 PM To: dev@cloudstack.ap

Re: Review Request 17120: added an extra column to mark the imported ldap users as from ldap

> On Jan. 24, 2014, 6:52 a.m., Prachi Damle wrote: > > I see many files unrelated to this fix have been updated and present in the > > patch. > > Please can you update the patch with changes needed for the fix only? > > > > Following are some such files. > > api/src/com/cloud/user/AccountServic

  1   2   >