Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Girish Shilamkar
> On Oct. 24, 2013, 9:24 a.m., Prasanna Santhanam wrote: > > 0780604 master Shouldn't this fix also go to 4.2 branch ? - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/#review27

Documentation: Where are the page numbers in the PDFs? Publican changes?

2013-11-01 Thread Ryan Lei
Quick question. Ever since ACS 4.1.1, the PDFs downloaded from the doc website no longer have a "page number" at the bottom-left or bottom-right corner of a page. This may make the printed version hard to navigate through the pages! Also, many words, tables, and figures get truncated when they ap

RE: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Santhosh Edukulla
yes, even few other changes we did around marvin,should also go to 4.2 i believe. Santhosh From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish Shilamkar [gir...@clogeny.com] Sent: Friday, November 01, 2013 3:07 AM To: Prasanna Santhana

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Girish Shilamkar
Santhosh, I believe there are more such patches which need to go into 4.2 branch. Could you please send me the list, so that I can push them ? Thanks ! Regards, Girish On 01-Nov-2013, at 12:58 PM, Santhosh Edukulla wrote: > yes, even few other changes we did around marvin,should also go to 4

Re: Review Request 15068: Change labels for VLAN to vNet

2013-11-01 Thread Sebastien Goasguen
Pinging Jessica and Brian on this review, On Oct 31, 2013, at 9:28 PM, Toshiaki Hatano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15068/#review27992 > --

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Sebastien Goasguen
Girish, You can review all of Santosh patches on review board: https://reviews.apache.org/users/santhoshe/ Right now it seems that everything has been reviewed, so Santosh will need to submit his patches through review board and assign you as reviewer. Hope that helps, -sebastien On Nov 1, 2

Review Request 15175: Added a verifyElementInList utility function

2013-11-01 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Reposit

Re: Review Request 15108: Grab MacAddress in a more deterministic fashion

2013-11-01 Thread Laszlo Hornyak
> On Oct. 31, 2013, 8:29 a.m., Laszlo Hornyak wrote: > > I haven't had a chance to test it yet, but I prefer this solution over my > > own patchset, since I was only trying to fix some broken functionality > > without radically changing the behavior. > > One minor problem I see in there is that

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Girish Shilamkar
Sebastien, I thought only a few patches did not make it to 4.2. I will go over the list do the needful Regards, Girish On 01-Nov-2013, at 1:13 PM, Sebastien Goasguen wrote: > Girish, > > You can review all of Santosh patches on review board: > https://reviews.apache.org/users/santhoshe/ > >

Re: haPlanners error in fresh 4.2 checkout

2013-11-01 Thread sebgoa
I deleted my local 4.2 branch and did a brand new checkout, same result. latest 4.2 does not work for me -same error as below - On Oct 31, 2013, at 8:34 PM, Srikanteswararao Talluri wrote: > I too faced this issue today. Is there any resolution for this? > > Thanks, > ~Talluri > > On 31/10/1

CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

2013-11-01 Thread SuichII, Christopher
It looks like some changes made in 858ce766659101eb731c83c806892dd5d9baa976 prohibit any managed storage pool other than ISCSI from starting a VM. It looks like you’ assuming that if the storage pool is managed then we should use getIscsiSR() to get the xen SR, which isn’t the case. I also beli

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

2013-11-01 Thread Mike Tutkowski
Hey Chris, A bunch of these do make the assumption managed storage is iSCSI based (which was the situation in 4.2). At the time, we had decided to deal with the only managed storage type that was in use. You and I should work together to update managed storage in 4.3 to handle your situation. L

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

2013-11-01 Thread Mike Tutkowski
By the way, when we say "managed" storage in CloudStack, we mean the storage is not preallocated (as was the only case prior to 4.2). For example, before 4.2 (using a SAN and XenServer as an example) you had to create an iSCSI target, create an SR, then introduce the SR into CS as primary storage.

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

2013-11-01 Thread Mike Tutkowski
What it comes down to is if your storage does not require the hypervisor code to create/delete SRs (datastores for VMware) dynamically, then it is not managed storage. On Fri, Nov 1, 2013 at 8:42 AM, Mike Tutkowski wrote: > By the way, when we say "managed" storage in CloudStack, we mean the >

Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled

2013-11-01 Thread David Grizzanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15181/ --- Review request for cloudstack. Bugs: CLOUDSTACK-5023 https://issues.apache.

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

2013-11-01 Thread SuichII, Christopher
Ah, interesting. I didn’t realize that is what ‘managed’ meant. We are only doing NFS right now and everything is preallocated. I’ll update all my code to avoid the ‘managed’ flag. Sorry about the confusion! -- Chris Suich chris.su...@netapp.com NetApp Software Eng

Re: [MERGE] network-guru-orchestration into master

2013-11-01 Thread Pedro Roque Marques
Darren, On Oct 31, 2013, at 10:05 AM, Darren Shepherd wrote: > Yeah I think it would be great to talk about this at CCC. I'm > hesitant to further narrow down the definition of the network. For > example, I think OpenStack's Neutron is fundamentally flawed because > they defined a network as

Re: CitrixResourceBase execute(StartCommand) only works with ISCSI managed storage

2013-11-01 Thread Mike Tutkowski
No problem :) Talk to you later On Fri, Nov 1, 2013 at 10:11 AM, SuichII, Christopher < chris.su...@netapp.com> wrote: > Ah, interesting. I didn’t realize that is what ‘managed’ meant. We are > only doing NFS right now and everything is preallocated. I’ll update all my > code to avoid the ‘man

Re: Review Request 15068: Change labels for VLAN to vNet

2013-11-01 Thread Chris Cameron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15068/ --- (Updated Nov. 1, 2013, 4:52 p.m.) Review request for cloudstack, Brian Federle,

Re: Review Request 14549: Rename net.juniper.contrail to org.apache.cloudstack.network.contrail

2013-11-01 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14549/#review28016 --- Ship it! commit 6b5fab2f5cd939f64b5c9c1ee8d87ca8b6f6514d Author: Pe

Re: Tiered Quality

2013-11-01 Thread Laszlo Hornyak
I have heard about commercial tools that do more advanced coverage tracking. But if you think in open source, not sure Sonar really has an alternative. It is pretty cool anyway. Btw the overall code coverage is about 3.6%, probaly it is not worth trying something more advanced for that much. On T

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-01 Thread Sheng Yang
Nice work Will! I've checked the code, it included the UI part and unit test as well. Really impressed! Just one comment: you can git-format-patch to generate the patch. It would includes author and description information automatically, which is easier for applying. +1! --Sheng On Thu, Oct

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

2013-11-01 Thread Will Stevens
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/ --- (Updated Nov. 1, 2013, 9:10 p.m.) Review request for cloudstack and Sheng Yang.

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-01 Thread Will Stevens
Great, thank you Sheng... I have updated the diff for the patch review with a new version which was created using the 'git format-patch' format. A note that may help others. I found this very helpful when squashing my branch of changes to a patch for master: http://stackoverflow.com/questions/61

Marvin deploy failed on master

2013-11-01 Thread Min Chen
Hi there, Mavin deployment failed on master, localhost:devcloud minc$ python ../marvin/marvin/deployDataCenter.py -i min_xenvm_sec2.cfg Traceback (most recent call last): File "../marvin/marvin/deployDataCenter.py", line 19, in import configGenerator File "/Users/minc/dev/cloud-asf/tool

Re: note to devcloud users on db.properties.override

2013-11-01 Thread Pedro Roque Marques
Darren, On Oct 31, 2013, at 9:27 AM, Darren Shepherd wrote: > This is fixed now. Maybe i'm doing something really dumb... but i still see the problem. I do see the commit afaf637 in the branch history. Steps to reproduce: 1. plugins/network-elements/juniper-contrail/test/resources/mysql_db_st

S3 as secondary storage is broken in master

2013-11-01 Thread Min Chen
Hi Marcus, Your commit a504c004bf10555e5ea67ec89fe7bf6f00fe4622 broke S3 functionality. With S3 as secondary storage, system vm cannot be started. Since for S3, copy template to primary will be from an ImageCache store. Your following line of code : if (srcData.getObjectType() == DataObj

Re: [MERGE] network-guru-orchestration into master

2013-11-01 Thread Marcus Sorensen
On Fri, Nov 1, 2013 at 10:16 AM, Pedro Roque Marques wrote: > Darren, > > On Oct 31, 2013, at 10:05 AM, Darren Shepherd > wrote: > >> Yeah I think it would be great to talk about this at CCC. I'm >> hesitant to further narrow down the definition of the network. For >> example, I think OpenStac

Re: note to devcloud users on db.properties.override

2013-11-01 Thread Darren Shepherd
Yeah, I see there was a commit a3cec3802c4c56173c33ccc1e08af059547fe90e that broke it again. I'll reverted that commit and ran the following to sanity test and its seems to be working now mvn -T 1.5C -DskipTests clean install chmod +x plugins/network-elements/juniper-contrail/test/resources/mysql

opencontrail in master

2013-11-01 Thread Darren Shepherd
I just noticed that opencontrail is in master. There is some small work that needs to be done to make org.apache.cloudstack.network.contrail.management.EvenUtils.EventInterceptor work in the new Spring model. Is somebody working on this? Additionally the new spring config needs to be setup for t