Re: Minor changes to Marvin tests for Netscaler

2013-08-15 Thread Prasanna Santhanam
On Thu, Aug 15, 2013 at 04:27:19AM +, Sowmya Krishnan wrote: > I am planning to modify some of the Netscaler tests (test_netscaler_lb_algo, > test_netscaler_lb_sticky, test_netscaler_lb) in our integration suite to > include adding of NS device in the setUpClass(). And remove the device in >

RE: Minor changes to Marvin tests for Netscaler

2013-08-15 Thread Sowmya Krishnan
> -Original Message- > From: Prasanna Santhanam [mailto:t...@apache.org] > Sent: Thursday, August 15, 2013 12:42 PM > To: dev@cloudstack.apache.org > Subject: Re: Minor changes to Marvin tests for Netscaler > > On Thu, Aug 15, 2013 at 04:27:19AM +, Sowmya Krishnan wrote: > > I am pla

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-15 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 15, 2013, 7:53 a.m.) Review request for cloudstack, Chiradeep Vit

Re: [Doc] Please review: VM root disk reset on reboot doc

2013-08-15 Thread Harikrishna Patnala
Thank you Jessica, doc looks good for me. -Harikrishna On 15-Aug-2013, at 8:54 AM, Jessica Tomechak mailto:jessica.tomec...@gmail.com>> wrote: Since no comments have been made against this doc, I am resolving the bug. Jessica T. On Thu, Aug 8, 2013 at 11:16 PM, Jessica Tomechak mailto:jessic

RE: Whats involved in adding an extra hypervisor

2013-08-15 Thread Donal Lafferty
Definitely possible to add new Hypervisor types, if that's what you're asking. How easy it is depends on how much existing CloudStack infrastructure you can exploit. Let me out line the task with the help of some planning questions: 1. What will be your agent model? Will you talk directly to

vpc gateways on sdn

2013-08-15 Thread Daan Hoogland
For those interested in the subject, please have a look at https://cwiki.apache.org/confluence/x/RY7lAQ I have implemented this on 4.1.1 and want to port it to master in four phases. the phases i have defined as subtasks of jira ticket CLOUDSTACK-1532. the first phase is out as a review request

RE: Disk Allocated Versus Disk Used

2013-08-15 Thread Donal Lafferty
Hi Mike, I've had problems with GUI stats as well. I tried to solve the issue by focusing on the kernel commands that are used to populate database entries the GUI relies on. There seem to be three important commands: GetStorageStatsCommand, StartupStorageCommand and ModifyStoragePoolCommand

ui development

2013-08-15 Thread Daan Hoogland
H, Is there a (wiki-)page on cloudstack ui development? I am looking at some ui enhancements. (for https://issues.apache.org/jira/browse/CLOUDSTACK-4328 and https://issues.apache.org/jira/browse/CLOUDSTACK-1532) thanks, Daan

Re: ui development

2013-08-15 Thread Daan Hoogland
found it https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+API+Development thanks On Thu, Aug 15, 2013 at 1:34 PM, Daan Hoogland wrote: > H, > > Is there a (wiki-)page on cloudstack ui development? I am looking at > some ui enhancements. > > (for https://issues.apache.org/jira/b

Re: ui development

2013-08-15 Thread Daan Hoogland
sorry, no I was to quick to be enthousiastic. I mean UI dev:( https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+UI+Development but I did find it :) On Thu, Aug 15, 2013 at 1:59 PM, Daan Hoogland wrote: > found it > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudSt

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-15 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review25215 --- Ship it! With no open issues and all review items processed i'm shi

reviewboard-tool

2013-08-15 Thread Hugo Trippaers
Heya all, Together with Daan we made some changes to the reviewboard buildtool. The following changes are now implemented: * Re-build if a new diff is submitted after the original build * Don't try to build a review that already has a ship-it review On the todo list it: * honour the branch

Re: Building Documents with publican

2013-08-15 Thread Mike Tutkowski
I'm new to Publican, as well. When I run the following: c:\docs\en-US>publican build --formats=test --langs=en-US I get the following error message: Config file not found: publican.cfg. at script/publican line 689 Unfortunately I don't know much about Publican. I'm just trying to document the

LocalNfsSecondaryStorageResource vs NfsSecondaryStorageResource

2013-08-15 Thread Donal Lafferty
To save me a bit of time, could someone explain the use case for LocalNfsSecondaryStorage? Seems to be used in engine/storage/src/org/apache/cloudstack/storage/LocalHostEndpoint.java, but I've no idea why. Any comments most welcome, DL

Re: Building Documents with publican

2013-08-15 Thread Marty Sweet
Hi Mike, Try the --config=publican-all.cfg option. Please let me know if you can get it to build successfully? Thanks, Marty On Thu, Aug 15, 2013 at 5:58 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > I'm new to Publican, as well. > > When I run the following: > > c:\docs\en-US>pu

Re: LocalNfsSecondaryStorageResource vs NfsSecondaryStorageResource

2013-08-15 Thread Min Chen
Used in S3/Swift as secondary storage, when we add S3 image store, we need to automatically download system vm template to these image stores, which are done at MS host since ssvm is not up yet at that point. Thanks -min On 8/15/13 10:41 AM, "Donal Lafferty" wrote: >To save me a bit of time, co

Re: Building Documents with publican

2013-08-15 Thread Wei ZHOU
You can follow what Prasanna do in jenkins. Have a look at http://linux.die.net/man/1/publican 2013/8/15 Mike Tutkowski > I'm new to Publican, as well. > > When I run the following: > > c:\docs\en-US>publican build --formats=test --langs=en-US > > I get the following error message: > > Config f

Re: Building Documents with publican

2013-08-15 Thread Mike Tutkowski
You know, as I re-read the instructions, I just found that I had missed a step. Everything seems to be building at the moment. The one problem I did have was installing the "cloudstack" brand. I had to comment the brand line out of my publican.cfg file. Any thoughts on this? Thanks! On Thu, Au

Re: LocalNfsSecondaryStorageResource vs NfsSecondaryStorageResource

2013-08-15 Thread Chiradeep Vittal
It runs in the context (same java vm) as the MS. On 8/15/13 10:45 AM, "Min Chen" wrote: >Used in S3/Swift as secondary storage, when we add S3 image store, we need >to automatically download system vm template to these image stores, which >are done at MS host since ssvm is not up yet at that poi

Re: Building Documents with publican

2013-08-15 Thread Mike Tutkowski
It looks like my build did eventually fail: Processing file tmp/en-US/xml_tmp/writing-new-documentation.xml -> tmp/en-US/xml/writing-new-documentation.xml Processing file tmp/en-US/xml_tmp/xenserver-maintenance-mode.xml -> tmp/en-US/xml/xenserver-maintenance-mode.xml Processing file tmp/en-US/xml_

Changes to cloud-client-ui jetty webAppSourceDirectory and hot deploying API Plugins

2013-08-15 Thread SuichII, Christopher
Some of you may remember a previous thread where I talked a bit about this, so bear with me: We are working on an API plugin that we would like to be hot deployable (not committed to source and can be deployed at any time). In a previous discussion, I was told that this had not been tested with

Re: Minor changes to Marvin tests for Netscaler

2013-08-15 Thread Chiradeep Vittal
LGTM On 8/14/13 9:27 PM, "Sowmya Krishnan" wrote: >I am planning to modify some of the Netscaler tests >(test_netscaler_lb_algo, test_netscaler_lb_sticky, test_netscaler_lb) in >our integration suite to include adding of NS device in the setUpClass(). >And remove the device in tearDownClass(). C

Re: Building Documents with publican

2013-08-15 Thread Mike Tutkowski
Looks like the file reference is wrong (two .xml parts): removed-api-4.2.xml.xml I changed it and plan to rebuild. I did find removed-api-4.2.xml (one .xml) in the proper folder. On Thu, Aug 15, 2013 at 12:04 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > It looks like my build di

Re: Building Documents with publican

2013-08-15 Thread Marty Sweet
Hi Mike, Are you building from the 4.2 branch? Marty On Thu, Aug 15, 2013 at 7:09 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Looks like the file reference is wrong (two .xml parts): > > removed-api-4.2.xml.xml > > I changed it and plan to rebuild. I did find removed-api-4.2.xm

Re: Building Documents with publican

2013-08-15 Thread Mike Tutkowski
Yes On Thu, Aug 15, 2013 at 12:15 PM, Marty Sweet wrote: > Hi Mike, > > Are you building from the 4.2 branch? > > Marty > > > On Thu, Aug 15, 2013 at 7:09 PM, Mike Tutkowski < > mike.tutkow...@solidfire.com> wrote: > > > Looks like the file reference is wrong (two .xml parts): > > > > removed-a

Re: Building Documents with publican

2013-08-15 Thread Mike Tutkowski
Doh! The message I'm looking for is part of this e-mail chain! :) On Thu, Aug 15, 2013 at 12:18 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Now I get the following. > > I think there was an e-mail about this maybe yesterday. I'm going to check > to see if I still have it. > > DTD

Re: Building Documents with publican

2013-08-15 Thread Mike Tutkowski
Now I get the following. I think there was an e-mail about this maybe yesterday. I'm going to check to see if I still have it. DTD Validation failed: cloudstack.xml:26: validity error : ID hypervisor-support-for-primarystorage already defined cloudstack.xml:51: validity error : ID prereq-addnic a

Re: Changes to cloud-client-ui jetty webAppSourceDirectory and hot deploying API Plugins

2013-08-15 Thread Chiradeep Vittal
Seems related to https://issues.apache.org/jira/browse/CLOUDSTACK-3650 Not sure about why the mvn repo is used. Have you tried clean install? On 8/15/13 11:05 AM, "SuichII, Christopher" wrote: >Some of you may remember a previous thread where I talked a bit about >this, so bear with me: > >We ar

Re: 4.3 compatibility matrix

2013-08-15 Thread Chiradeep Vittal
Probably closer to feature freeze (9/30) On 8/14/13 8:02 AM, "La Motta, David" wrote: >Can anybody provide any insight as to when 4.3 is going to be added to the >compatibility matrix? > >https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.2+Compatiblity+Ma >t >rix > > >Thanks. > > >-- >Dav

Re: 4.3 compatibility matrix

2013-08-15 Thread Mike Tutkowski
I was just curious about something with regards to our release schedule. Is it going to be the norm that one release will overlap another by a month or so? For example, we're still working on 4.2 until 8/19, but this month and next are when features are supposed to be worked on for 4.3. Thanks!

Re: [DISCUSS] git commit messages

2013-08-15 Thread Chiradeep Vittal
Not good. Especially since it is documented https://cwiki.apache.org/confluence/x/4wnVAQ On 8/13/13 1:41 AM, "Daan Hoogland" wrote: >LS, > >I see a lot of commits with only ticket numbers as commit messages. >This is not very descriptive and makes me suspicious of what I am >pulling in. Can peo

Re: 4.3 compatibility matrix

2013-08-15 Thread Chiradeep Vittal
https://cwiki.apache.org/confluence/x/6x-VAQ On 8/15/13 11:34 AM, "Mike Tutkowski" wrote: >I was just curious about something with regards to our release schedule. > >Is it going to be the norm that one release will overlap another by a >month >or so? > >For example, we're still working on 4.2 u

RE: [DISCUSS] git commit messages

2013-08-15 Thread Animesh Chaturvedi
Yes the commit message should have a brief summary of the change > -Original Message- > From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] > Sent: Thursday, August 15, 2013 11:36 AM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] git commit messages > > Not good. Especia

Re: 4.3 compatibility matrix

2013-08-15 Thread Mike Tutkowski
Thanks! This helps. On Thu, Aug 15, 2013 at 12:44 PM, Chiradeep Vittal < chiradeep.vit...@citrix.com> wrote: > https://cwiki.apache.org/confluence/x/6x-VAQ > > On 8/15/13 11:34 AM, "Mike Tutkowski" > wrote: > > >I was just curious about something with regards to our release schedule. > > > >Is

Re: [DISCUSS] git commit messages

2013-08-15 Thread Daan Hoogland
ok, I saw some violation passing by containing only CLOUDSTACK- as message. I am probably not the best citizen in the world but this freaks me, so this is a reminder to everyone to add a message (and for committers to refuse submissions without it?) thanks, Daan On Thu, Aug 15, 2013 at 8:49 PM,

Re: 4.3 compatibility matrix

2013-08-15 Thread La Motta, David
Ok, thanks. -- David La Motta Technical Marketing Engineer - Citrix Solutions | NetApp david.lamo...@netapp.com On 8/15/13 2:29 PM, "Chiradeep Vittal" wrote: >Probably closer to feature freeze (9/30) > >On 8/14/13 8:02 AM, "La Motta, David" wrote: > >>Can anybody provide any insight as to

CloudStack 4.2 Quality Question

2013-08-15 Thread Mike Tutkowski
Hi everyone, I've only been working on CS for about 8 months now, so I don't have a lot of experience with the way releases go. My question is this: I've noticed over 100 commits to 4.2 since Monday (one week from a potential release of the product). Is this normal? Unless we have a super great s

Re: Changes to cloud-client-ui jetty webAppSourceDirectory and hot deploying API Plugins

2013-08-15 Thread SuichII, Christopher
As I look in to this, it looks like the problem definitely comes from switching Jetty from using the target/...4.3.0/ to target/generated-webapp/ The maven-war-plugin creates all the war files in target/cloud-client-ui-4.3.0-SNAPSHOT/ then copies *some* of it to target/generated-webapp/ from cl

RE: CloudStack 4.2 Quality Question

2013-08-15 Thread Sudha Ponnaganti
Mike, I have similar concern as well. We have regression and BVT tests running daily on 4.2 branch locally besides manual validation of the defects and impacted areas. Even though we would not be able to catch all the issues, several regressions were caught and you can see the defects by usi

RE: 404 on some .css files

2013-08-15 Thread Brian Federle
Good catch, yeah the 404s are caused because those plugins do not have any .css file associated with them. I can probably just add a few blank .css files to silence the errors, though otherwise they are harmless. -Brian -Original Message- From: La Motta, David [mailto:david.lamo...@neta

advice on next submit wanted

2013-08-15 Thread Daan Hoogland
H, I want to change the code using getHost() to use BroadcastDomainType.getValue() for getting the id of the network (vlan or otherwise). Also I need to change code that uses URI.create(String) into using BroadcastDomainType.fromString(String) or the generic BroadcastDomainType..toUri(T). This ha

Re: CloudStack 4.2 Quality Question

2013-08-15 Thread Daan Hoogland
H Mike, Make sure you write plenty of unit tests for whatever methods you need for the features you are implementing. You can not exaggerate for a while. Coverage is behind quite a bit and I am not a betting man, so I bet there is going to be a 4.2.1. In short: I share your concern. Daan On Thu,

Re: CloudStack 4.2 Quality Question

2013-08-15 Thread Mike Tutkowski
I plan to write automated system tests, but I don't think there's any way for me to check them in and get use out of them because they require a SolidFire SAN. In other words, I guess I will just have to keep them local (as in just something I run). So far, I have manual regression tests I run and

Re: CloudStack 4.2 Quality Question

2013-08-15 Thread Daan Hoogland
Hugo has a local jenkins that runs as code gets checked in at apache, You could have your SolidFire SAN base install be updated by a trigger on commits in the central git at apache's, and then run your regression tests on it. Hope that helps, Daan On Thu, Aug 15, 2013 at 9:58 PM, Mike Tutkowski

RE: [DISCUSS] git commit messages

2013-08-15 Thread Alex Huang
+1 --Alex > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Thursday, August 15, 2013 11:58 AM > To: dev > Subject: Re: [DISCUSS] git commit messages > > ok, > > I saw some violation passing by containing only CLOUDSTACK- > as message. > > I am proba

Re: CloudStack 4.2 Quality Question

2013-08-15 Thread Mike Tutkowski
Good idea, Daan. On Thu, Aug 15, 2013 at 2:17 PM, Daan Hoogland wrote: > Hugo has a local jenkins that runs as code gets checked in at apache, > You could have your SolidFire SAN base install be updated by a trigger > on commits in the central git at apache's, and then run your > regression test

Single Server | Advanced Mode | KVM | Cent OS 6.4

2013-08-15 Thread Maurice Lawler
Hello, I'm working with KVM | CloudStack 4.1.1 | CentOS 6.4, I am running into a issue where it goes through all the motions of setting up just fine. However, I notice when it attempts to download the CentOS template it fails, with error message: No Route To Host. I am utilizing two subnets on

[RESULTS] (Was: Re: [VOTE] Update by-laws: non-technical decisions and other minor changes)

2013-08-15 Thread Noah Slater
Okay, thanks folks. 4 +1 votes, 3 of which are binding. The vote is a success. I will apply the patch. On 5 August 2013 22:43, Noah Slater wrote: > Hi dev, > > I have some more by-law changes to propose. This is essentially round 2 > for these changes. I incorporated feedback from the last thre

Re: [VOTE] Update by-laws: non-technical decisions and other minor changes

2013-08-15 Thread Noah Slater
Thanks Hugo. Will wrap this up now! On 13 August 2013 06:30, Hugo Trippaers wrote: > +1 > > Cheers, > > Hugo > > Sent from my iPhone > > On 12 aug. 2013, at 20:01, Noah Slater wrote: > > > Bumping the thread for a 3rd +1 vote from the PMC. Our by-laws stipulate > we > > need 3 +1 PMC votes. > >

[VOTE] Minor edits to the by-laws

2013-08-15 Thread Noah Slater
Devs, Got some more cosmetic edits to make. :) I noticed that our by-laws look pretty crapy at the moment, as we're not actually marking up the headers properly. cf. http://cloudstack.apache.org/bylaws.html Per the by-laws, we're using a lazy majority for this vote. Please cast your vote now. I

Re: Single Server | Advanced Mode | KVM | Cent OS 6.4

2013-08-15 Thread Marcus Sorensen
You may be able to leverage the devcloud-kvm configuration as a reference. You can either use marvin to deploy an edited version of tools/devcloud-kvm/devcloud-kvm-advanced.cfg (just swapping out your ip address ranges), or take a look at the example advanced KVM network configs that I sent out awh

[PROPOSAL] Breaking apart networkmanagerimpl...

2013-08-15 Thread Alex Huang
As some of you might have noticed, I've been breaking apart code in the server package. Code that is crucial to orchestration such as life cycle management of virtual entities and orchestrating plugins to implement the virtual entities on the physical hardware are being moved into the engine pa

RE: Changes to cloud-client-ui jetty webAppSourceDirectory and hot deploying API Plugins

2013-08-15 Thread Donal Lafferty
Hi Christopher, Could you take a quick look at the permissions on scripts in the ./client folder? I raised https://issues.apache.org/jira/browse/CLOUDSTACK-3650, because the Maven project that launched Jetty does not set execution permissions for scripts in ${project.build.directory}/${proje

Review Request 13610: Bugfix CLOUDSTACK-4359: Default username is Admin not admin

2013-08-15 Thread Jonathan Creasy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13610/ --- Review request for cloudstack. Bugs: CLOUDSTACK-4359 Repository: cloudstack-g

Re: Single Server | Advanced Mode | KVM | Cent OS 6.4

2013-08-15 Thread Maurice Lawler
I have reviewed the links you provided (namely one nick) I made the interfaces as described, however, upon starting the setup process it stalls out (failed network) because cloudstack creates cloudbr0 which is not what I set up,so it does not pass through the connections. I had to go in a revert

Re: [VOTE] Minor edits to the by-laws

2013-08-15 Thread Hugo Trippaers
+1 Cheers, Hugo Sent from my iPhone On 16 aug. 2013, at 01:06, Noah Slater wrote: > Devs, > > Got some more cosmetic edits to make. :) I noticed that our by-laws look > pretty crapy at the moment, as we're not actually marking up the headers > properly. > > cf. http://cloudstack.apache.org/

Re: Single Server | Advanced Mode | KVM | Cent OS 6.4

2013-08-15 Thread Maurice Lawler
Actually, I corrected that issue now I am utilizing a /27 subnet which to me would mean that's more then enough IP's for both management / guest IPs, or am I wrong in this thinking; it would appear to be as such. Now upon downloading the 5.5 CentOS image as it does when you set it up, I am get

Re: Single Server | Advanced Mode | KVM | Cent OS 6.4

2013-08-15 Thread Maurice Lawler
SORRY! I forgot one important thing, I am able to proceed as normal while utilizing the basic zone. I just want to know why the advanced mode is giving me grief. - Maurice On Aug 16, 2013, at 1:02 AM, Maurice Lawler wrote: > Actually, I corrected that issue now I am utilizing a /27 subnet whi

RE: [DISCUSS] git commit messages

2013-08-15 Thread Koushik Das
Agree. The message should indicate the root cause of the problem and the solution. -Koushik > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Friday, August 16, 2013 2:58 AM > To: dev@cloudstack.apache.org > Subject: RE: [DISCUSS] git commit messages > > +1

Re: [PROPOSAL] Breaking apart networkmanagerimpl...

2013-08-15 Thread Hugo Trippaers
Hey Alex, +1 This looks very good! There are some things for network manager that i wanted to do, but didn't get around to yet. Maybe some of them can be part of this change. First of all the way gurus are queries. At the moment each guru is asked to design a network and has to make its won d

Re: [Doc] Developer Guide API Section for Review

2013-08-15 Thread Harikrishna Patnala
Hi Radhika, Thank you for the doc. Some changes are required, 1) updateCluster: The following request parameters are added: cpuovercommitratio, ramovercommitratio - These parameters are removed from the updateCluster API. Please remove from the doc as well. - Same doc entry exists in Page 24

Re: Whats involved in adding an extra hypervisor

2013-08-15 Thread Ian Duffy
Hi Donal and Chiradeep, Thanks for your comments. It was an interesting read. I might be missing something here but I will ask anyways. If I understand correctly, at current with awsapi we are able to submit our aws api credentials to Cloudstack and spin up VMs on aws correct? Is there a reason t

RE: Whats involved in adding an extra hypervisor

2013-08-15 Thread Likitha Shetty
Ian, with AWS it’s the other way around. The package allows us to spin up VMs in CS using AWS EC2 API's. -Likitha >-Original Message- >From: Ian Duffy [mailto:i...@ianduffy.ie] >Sent: Friday, August 16, 2013 12:07 PM >To: CloudStack Dev >Subject: Re: Whats involved in adding an extra hyp

Re: [VOTE] Minor edits to the by-laws

2013-08-15 Thread Daan Hoogland
Noah, You use the same two-hash indent for two digit paragraph numbers as for three digit paragraph numbers. Is this intentional? regards, Daan On Fri, Aug 16, 2013 at 6:55 AM, Hugo Trippaers wrote: > +1 > > Cheers, > > Hugo > > Sent from my iPhone > > On 16 aug. 2013, at 01:06, Noah Slater w

Re: Single Server | Advanced Mode | KVM | Cent OS 6.4

2013-08-15 Thread Marcus Sorensen
Something isn't right if it is trying to create a cloudbr0... I haven't seen it do that with these configs. Your agent.properties file must not be getting created/updated on host join, still referencing a non existent bridge. On Aug 15, 2013 11:17 PM, "Maurice Lawler" wrote: > SORRY! I forgot one

Re: [PROPOSAL] Breaking apart networkmanagerimpl...

2013-08-15 Thread Daan Hoogland
apart from the conflicts I will encounter, a big +1 On Fri, Aug 16, 2013 at 8:22 AM, Hugo Trippaers wrote: > Hey Alex, > > +1 This looks very good! > > There are some things for network manager that i wanted to do, but didn't get > around to yet. Maybe some of them can be part of this change. >