Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

2013-07-30 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13004/#review24296 --- I looked at latest 4.2 code, toURI() only contains one line code: r

Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format

2013-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13088/#review24297 --- Commit a310815aacd5c742caecc0e00cdec08182a38230 in branch refs/heads

Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format

2013-07-30 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13088/#review24299 --- Ship it! Ship It! - edison su On July 30, 2013, 10:18 p.m., Tosh

Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format

2013-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13088/#review24298 --- Commit 7774ecfd5ab3e2ecf1fc75634a959737a302dc79 in branch refs/heads

Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format

2013-07-30 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13088/#review24303 --- Review 13088 PASSED the build test The url of build cloudstack-maste

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24305 --- Commit 20831d00fb56d0553860bcb5efe47ce45bd1e74c in branch refs/heads

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Min Chen
> On July 28, 2013, 3:59 a.m., Min Chen wrote: > > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249 > > > > > > This is not right. For cross-zone template, in > > HypervisorTemplateAdapter.create

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24307 --- Commit c2192808aa5f7a391a79fb6c84592819c032fa45 in branch refs/heads

Review Request 13093: Put retry logic to check existence/non-existence of created/deleted files even though vSphere returns successful completion on wait for asynchronous task.

2013-07-30 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13093/ --- Review request for cloudstack, Alena Prokharchyk, Chip Childers, Kelven Yang, an

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

2013-07-30 Thread Jijun
> On July 30, 2013, 11:13 p.m., edison su wrote: > > I looked at latest 4.2 code, toURI() only contains one line code: return > > new URI(scheme + "://" + value.toString());, thus can't apply your patch. > > Could you tell me which branch are you using? The master? hi edison, yes,it is in the

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

2013-07-30 Thread edison su
> On July 30, 2013, 11:13 p.m., edison su wrote: > > I looked at latest 4.2 code, toURI() only contains one line code: return > > new URI(scheme + "://" + value.toString());, thus can't apply your patch. > > Could you tell me which branch are you using? The master? > > Jijun wrote: > hi e

Re: [jira] [Created] (CLOUDSTACK-3964) [KVM] failed to deploy VM in advanced zone

2013-07-30 Thread Marcus Sorensen
Permission denied on vmdata_kvm.py? How did that happen? Can you look at the file mode on the virtual router in /opt/cloud/bin? The iso build is supposed to set all scripts to executable, regardless of the file mode in git. Might be worth mounting the iso and looking at cloud-scripts.tgz as well. O

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

2013-07-30 Thread Toshiaki Hatano
> On July 30, 2013, 11:13 p.m., edison su wrote: > > I looked at latest 4.2 code, toURI() only contains one line code: return > > new URI(scheme + "://" + value.toString());, thus can't apply your patch. > > Could you tell me which branch are you using? The master? > > Jijun wrote: > hi e

Re: [jira] [Updated] (CLOUDSTACK-3964) [KVM] failed to deploy VM in advanced zone

2013-07-30 Thread Marcus Sorensen
OK, that's interesting. I will dig further and see what might be broken with the cloud-scripts.tgz, as the patch was tested to work by myself, Wido, and Prasanna. We can set it in git, but there is supposed to be a mechanism to ensure they are all executable when packaged. On Jul 30, 2013 7:32 PM,

Re: Review Request 13093: Put retry logic to check existence/non-existence of created/deleted files even though vSphere returns successful completion on wait for asynchronous task.

2013-07-30 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13093/#review24312 --- Review 13093 PASSED the build test The url of build cloudstack-maste

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

2013-07-30 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 31, 2013, 2:46 a.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method

2013-07-30 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/ --- (Updated July 31, 2013, 2:52 a.m.) Review request for cloudstack, Prasanna Sant

Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method

2013-07-30 Thread Sheng Yang
> On July 31, 2013, 3:22 a.m., Sheng Yang wrote: > > Ship It! Looks fine to me. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/#review24316

Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method

2013-07-30 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/#review24316 --- Ship it! Ship It! - Sheng Yang On July 31, 2013, 2:52 a.m., Marc

Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.

2013-07-30 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/#review24318 --- Ship it! Ship It! - Abhinandan Prateek On July 30, 2013, 10:52 a

Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.

2013-07-30 Thread Abhinandan Prateek
> On July 31, 2013, 4:31 a.m., Abhinandan Prateek wrote: > > Ship It! Failed on master: error: patch failed: engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java:433 error: engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java: patch does not apply Patch failed at 0001 Cloudsta

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

2013-07-30 Thread Prasanna Santhanam
> On July 30, 2013, 11:13 p.m., edison su wrote: > > I looked at latest 4.2 code, toURI() only contains one line code: return > > new URI(scheme + "://" + value.toString());, thus can't apply your patch. > > Could you tell me which branch are you using? The master? > > Jijun wrote: > hi e

Re: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-07-30 Thread Prasanna Santhanam
On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi wrote: > > > > -Original Message- > > From: Alex Huang [mailto:alex.hu...@citrix.com] > > Sent: Tuesday, July 30, 2013 2:06 PM > > To: dev@cloudstack.apache.org > > Subject: RE: [ACS42] Release Status Update: After Code Freeze N

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Saksham Srivastava
> On July 28, 2013, 3:59 a.m., Min Chen wrote: > > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249 > > > > > > This is not right. For cross-zone template, in > > HypervisorTemplateAdapter.create

Re: Review Request 13061: Unable to create the Internal LB vm.

2013-07-30 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13061/#review24324 --- Ship it! Branch: refs/heads/4.2 Commit: 91bf54652ec6450a58f1c44d5d6

Re: Noisy ASFBot

2013-07-30 Thread Prasanna Santhanam
On Tue, Jul 30, 2013 at 03:17:22PM +0530, Prasanna Santhanam wrote: > On Sat, Jul 20, 2013 at 12:15:33PM +0200, Daan Hoogland wrote: > > I agree, > > > > @Prasanna, can we make ignore default and /activate ASFBot? That would have > > my preference. > > > > I got annoyed about this today myself.

Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.

2013-07-30 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/ --- (Updated July 31, 2013, 5:51 a.m.) Review request for cloudstack and Abhinandan

Re: Open up ports beyond 80/443/8080 for downloading templates

2013-07-30 Thread Thomas O'Dowd
I guess what I still don't understand is why restrict urls to certain ports? If the ports are not open it will cause an error. If the ports are open it will work (assuming the protocol is implemented on that port). For example, for register template if I choose a closed port then give me a connecti

Re: Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.

2013-07-30 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/#review24321 --- test/integration/component/cpu_limits/test_cpu_limits.py

[GSoC] Generate API doc

2013-07-30 Thread Nguyen Anh Tu
Hi guys, I need your help about generating api document for some new API I added. Without this, building failed: Traceback (most recent call last): File "/home/mint/cloudstack/gsoc/gre/sdnextension/cloudstack/tools/apidoc/gen_toc.py", line 189, in category = choose_category(fn) File "/ho

<    1   2