---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11960/
---
Review request for cloudstack and Abhinandan Prateek.
Description
---
Clou
Agree with Min. How about CRUD operations on staging - all apis available ?
Thanks,
-Nitin
On 19/06/13 6:44 AM, "Min Chen" wrote:
>Edison, we can just add a parameter in listImageStoreCmd to show cache
>store.
>
>Thanks
>-min
>
>On 6/18/13 6:06 PM, "Edison Su" wrote:
>
>>Currently, no, I can a
Hi,
I'm attempting to run tests on the simulator as outlined in
https://cwiki.apache.org/CLOUDSTACK/marvin-testing-with-python.html
Executing the checkin tests results in errors. Anybody got any feedback on this?
$ mvn -Pdeveloper,marvin.test -Dmarvin.config=setup/dev/advanced.cfg
-pl :cloud-mar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11962/
---
Review request for cloudstack and Prasanna Santhanam.
Description
---
Addi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11910/
---
(Updated June 19, 2013, 11 a.m.)
Review request for cloudstack, Abhinandan Prat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/
---
(Updated June 19, 2013, 11:37 a.m.)
Review request for cloudstack and Devdeep S
The Project Management Committee (PMC) for Apache CloudStack has asked Mike
Tutkowski to become a committer and we are pleased to announce that they have
accepted.
Being a committer allows many contributors to contribute more autonomously. For
developers, it makes it easier to submit changes a
Congratulations Mike! Welcome...
Regards,
Sateesh
> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: 19 June 2013 19:10
> To: dev@cloudstack.apache.org
> Subject: FW: [ANNOUNCE] New committer: Mike Tutkowski
>
>
> The Project Management Committee (PMC) for A
Congrats Mike!
2013/6/19 Sateesh Chodapuneedi
> Congratulations Mike! Welcome...
>
> Regards,
> Sateesh
>
>
> > -Original Message-
> > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > Sent: 19 June 2013 19:10
> > To: dev@cloudstack.apache.org
> > Subject: FW: [ANNOUNCE] New committer
Anybody has the same situation before ? Any comments or suggestions will be
great appreciated.
Thanks,
William
-Original Message-
From: William Jiang [mailto:william.ji...@manwin.com]
Sent: June-18-13 12:45 PM
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: RE: start
Congrats, Mike.
On Jun 19, 2013, at 10:02 AM, Wei ZHOU wrote:
> Congrats Mike!
>
>
> 2013/6/19 Sateesh Chodapuneedi
>
>> Congratulations Mike! Welcome...
>>
>> Regards,
>> Sateesh
>>
>>
>>> -Original Message-
>>> From: Alex Huang [mailto:alex.hu...@citrix.com]
>>> Sent: 19 June 2
William,
There can be several seasons.
Could you attach the agent.log?
-Wei
2013/6/19 William Jiang
> Anybody has the same situation before ? Any comments or suggestions will
> be great appreciated.
>
> Thanks,
> William
>
>
> -Original Message-
> From: William Jiang [mailto:william.j
Congrats Mike !! Welcome aboard :)
-Original Message-
From: John Burwell [mailto:jburw...@basho.com]
Sent: Wednesday, June 19, 2013 7:39 PM
To: dev@cloudstack.apache.org
Subject: Re: [ANNOUNCE] New committer: Mike Tutkowski
Congrats, Mike.
On Jun 19, 2013, at 10:02 AM, Wei ZHOU wrote
Congrats, Mike :)
On Wed, Jun 19, 2013 at 10:26 PM, Pranav Saxena wrote:
> Congrats Mike !! Welcome aboard :)
>
> -Original Message-
> From: John Burwell [mailto:jburw...@basho.com]
> Sent: Wednesday, June 19, 2013 7:39 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ANNOUNCE] New co
On Wed, Jun 19, 2013, at 08:39 AM, Alex Huang wrote:
> Please join me in congratulating Mike!
Congrats Mike!
Best,
jzb
--
Joe Brockmeier
j...@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/
All,
Since the threads discussing these patches have been very long, I want to roll
up the issue list, and ensure that we are on track to have them resolved before
the 4.2. The following is my current issue list and the associated status:
Mutual Exclusion of hypervisor throttled I/O and storag
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11962/
---
(Updated June 19, 2013, 2:50 p.m.)
Review request for cloudstack and Prasanna S
Thank you very much for your reply!
On Wed, 19 Jun 2013 10:30:22 +0530, Prasanna Santhanam wrote:
On Tue, Jun 18, 2013 at 10:45:27PM -0400, Han,Meng wrote:
Hi all,
I have a few questions about CloudStack deployment.
1. I am trying to deploy CloudStack, use CloudStack to start a
cluster and ru
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11962/#review22120
---
Commit 5140473f2b754c1f178aae7946798d95027ec69a in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11962/#review22121
---
Ship it!
5140473
- Prasanna Santhanam
On June 19, 2013, 2:50 p.m
Hi,
There is no agent log on management server /var/log/cloud/agent, do I need
manually enable it ?
Thanks,
William
-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: June-19-13 10:25 AM
To: dev@cloudstack.apache.org
Subject: Re: starting VM and get error of "unable
Hi all,
Joe asked me to facilitate the meeting today, however I have a $dayjob
responsibility that just came up. I'm not going to be able to do
anything other than lurk in the channel.
I'm going to suggest that we cancel the meeting for today, unless
someone else wants to run it.
-chip
Awesome stuff Mike. Excellent work getting solid fire in while the storage
refactor was going on! Well deserved sir.
Ahmad
On Jun 19, 2013, at 6:39 AM, Alex Huang wrote:
>
> The Project Management Committee (PMC) for Apache CloudStack has asked Mike
> Tutkowski to become a committer and we a
I'm happy to run it
On Jun 19, 2013, at 8:45 AM, Chip Childers
wrote:
> Hi all,
>
> Joe asked me to facilitate the meeting today, however I have a $dayjob
> responsibility that just came up. I'm not going to be able to do
> anything other than lurk in the channel.
>
> I'm going to suggest th
We should start a bounty on this one.
@ke4qqq/@chipc - want to reward the fix at #CCC13? :)
On Fri, Jun 14, 2013 at 01:57:28PM -0400, Shane Witbeck wrote:
> I actually opened an issue for this:
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-2863
>
> I've seen the failure using both wir
Comments below in red.
Thanks
On Wed, Jun 19, 2013 at 8:35 AM, John Burwell wrote:
> All,
>
> Since the threads discussing these patches have been very long, I want to
> roll up the issue list, and ensure that we are on track to have them
> resolved before the 4.2. The following is my current
On Wed, Jun 19, 2013 at 10:34:58AM -0600, Mike Tutkowski wrote:
> Comments below in red.
We can't see the red for text emails. ;-)
Maybe I'll just have to start doing bold like this: Bold even if it
just displays as text. :)
On Wed, Jun 19, 2013 at 10:36 AM, Chip Childers
wrote:
> On Wed, Jun 19, 2013 at 10:34:58AM -0600, Mike Tutkowski wrote:
> > Comments below in red.
>
> We can't see the red for text emails. ;-)
>
--
Hi there,
I need to fix a bug for 4.1.1, which requires some schema change. Two existing
files (schema-40to410.sql and schema-410to420.sql) seem not fit here. In this
case, should we create a new schema-410to411.sql for this purpose? Also, for
fix required for 4.1.1, can we directly check into
On Wed, Jun 19, 2013 at 10:53:37AM -0400, Han,Meng wrote:
> >
> >You can run all the management server code from your laptop as a
> >development environment and add an external hypervisor host (Either
> >Xen/KVM) to it. The guests, system VMs etc will then be deployed on
> >your host and not eat up
Adding that 410to411 file was on my list of things to get done, but go
ahead and do it. We also need the DB upgrade maps to be updated to
include it (as well as on master for 4.2).
The branch is not "controlled"... so go for it!
-chip
On Wed, Jun 19, 2013 at 04:43:12PM +, Min Chen wrote:
>
Ideally if the fix involves schema changes then it should go to 4.2. If there
is no alternative then 410to411.sql looks like the option. But then the upgrade
path becomes complicated. The following needs to be handled 4.1.0 -> 4.2.0,
4.1.1 -> 4.2.0. Or else the upgrade sql script needs to be gua
Min, Edison,
Either way is fine with me.
Jessica
-Original Message-
From: Min Chen [mailto:min.c...@citrix.com]
Sent: Tuesday, June 18, 2013 6:07 PM
To: Edison Su; dev@cloudstack.apache.org
Subject: Re: NFS Cache storage query
Edison, we can just add a parameter in listImageStoreCmd to
Congrats Mike!
> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: Wednesday, June 19, 2013 7:10 PM
> To: dev@cloudstack.apache.org
> Subject: FW: [ANNOUNCE] New committer: Mike Tutkowski
>
>
> The Project Management Committee (PMC) for Apache CloudStack has
>
Nitin,
If we provide any APIs for the staging/temporary area, they must be read-only.
Allowing any external manipulation of its content could cause break in-flight
transfers or cause data loss. I think we should consider the following APIs:
List contents including name, reference count, and s
On Wed, Jun 19, 2013 at 01:07:29PM -0400, John Burwell wrote:
> Nitin,
>
> If we provide any APIs for the staging/temporary area, they must be
> read-only. Allowing any external manipulation of its content could cause
> break in-flight transfers or cause data loss. I think we should consider t
Well done Mike,
-Sebastien
On 19 Jun 2013, at 16:38, Joe Brockmeier wrote:
> On Wed, Jun 19, 2013, at 08:39 AM, Alex Huang wrote:
>> Please join me in congratulating Mike!
>
> Congrats Mike!
>
> Best,
>
> jzb
> --
> Joe Brockmeier
> j...@zonker.net
> Twitter: @jzb
> http://www.dissociatedp
We had about 4 of us in the meeting, so we just dropped it until next week.
On Jun 19, 2013, at 9:15 AM, John Kinsella
wrote:
> I'm happy to run it
>
> On Jun 19, 2013, at 8:45 AM, Chip Childers
> wrote:
>
>> Hi all,
>>
>> Joe asked me to facilitate the meeting today, however I have a $dayj
Chip,
Good catch. Yes, we need definitely need a create staging/temporary area API
call. However, destroy is a bit more complicated due in-flight operations.
Given the complexities and time pressures, I recommend supporting only create
in 4.2, and addressing delete in 4.3. Does that make se
On Wed, Jun 19, 2013 at 01:23:47PM -0400, John Burwell wrote:
> Chip,
>
> Good catch. Yes, we need definitely need a create staging/temporary area API
> call. However, destroy is a bit more complicated due in-flight operations.
> Given the complexities and time pressures, I recommend supporti
Chip,
Your concern had not occurred to me -- making me realize that either destroy or
a zone attach/detach operation for the staging/temporary area mechanism in 4.2.
Thinking through it, there are two types of operations occurring with the
staging/temporary area. The first is data being pulle
> -Original Message-
> From: John Burwell [mailto:jburw...@basho.com]
> Sent: Wednesday, June 19, 2013 10:42 AM
> To: dev@cloudstack.apache.org
> Cc: Edison Su
> Subject: Re: NFS Cache storage query
>
> Chip,
>
> Your concern had not occurred to me -- making me realize that either destr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11977/
---
Review request for cloudstack.
Description
---
This patch would re-enable
Edison,
For 4.2, are we going to state that the object store is just a backup of NFS
(i.e. the same as 4.1)?
Thanks,
-John
On Jun 19, 2013, at 1:58 PM, Edison Su wrote:
>
>
>> -Original Message-
>> From: John Burwell [mailto:jburw...@basho.com]
>> Sent: Wednesday, June 19, 2013 10:4
Hi,
I've created the https://reviews.apache.org/r/11977/ for review. The
branch re-enabled the baremetal for master. And all major bugs are cleaned.
https://issues.apache.org/jira/browse/CLOUDSTACK-1610
https://issues.apache.org/jira/browse/CLOUDSTACK-1618
https://issues.apache.org/jira/browse/C
Sorry. I had to drop out due to day job as well.
--Alex
> -Original Message-
> From: John Kinsella [mailto:j...@stratosec.co]
> Sent: Wednesday, June 19, 2013 10:19 AM
> To:
> Subject: Re: IRC meeting today
>
> We had about 4 of us in the meeting, so we just dropped it until next week.
Yes and No:)
Yes, as all the hypervisors(KVM/Vmware/Xenserver) still need NFS in 4.2, even
S3 is used as the place to store templates.
No, we make NFS is optional, if you don't want to use NFS. E.g the HyperV
implementation will not depend on NFS.
In 4.3, we can start work on the hypervisor sid
On Wed, Jun 19, 2013 at 11:00:33AM -0700, Sheng Yang wrote:
> Hi,
>
> I've created the https://reviews.apache.org/r/11977/ for review. The
> branch re-enabled the baremetal for master. And all major bugs are cleaned.
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1610
> https://issues.apac
On Tue, Jun 18, 2013 at 4:53 PM, Sheng Yang wrote:
> Hi,
>
> Due to absent of Frank, I've tried to make sure Baremetal wouldn't miss
> 4.2. So for the last a few days work, I am able to re-enable baremetal for
> master.
>
> It turn out the change is not big, and most of it just compose of revert o
On Wed, Jun 19, 2013 at 11:24 AM, Chip Childers
wrote:
> On Wed, Jun 19, 2013 at 11:00:33AM -0700, Sheng Yang wrote:
> > Hi,
> >
> > I've created the https://reviews.apache.org/r/11977/ for review. The
> > branch re-enabled the baremetal for master. And all major bugs are
> cleaned.
> >
> > https
On Wed, Jun 19, 2013 at 11:36:11AM -0700, Sheng Yang wrote:
> On Wed, Jun 19, 2013 at 11:24 AM, Chip Childers
> wrote:
>
> > On Wed, Jun 19, 2013 at 11:00:33AM -0700, Sheng Yang wrote:
> > > Hi,
> > >
> > > I've created the https://reviews.apache.org/r/11977/ for review. The
> > > branch re-enabl
Edison,
Based on the stance you have outlined, the usage of NFS in the object_store
branch and 4.1 are not comparable. In 4.1, NFS is the store of record for
data. Therefore, presence of the file in the NFS volume indicates that the
data is permanently stored. However, in object_store, prese
> -Original Message-
> From: John Burwell [mailto:jburw...@basho.com]
> Sent: Wednesday, June 19, 2013 11:43 AM
> To: Edison Su
> Cc: dev@cloudstack.apache.org
> Subject: Re: NFS Cache storage query
>
> Edison,
>
> Based on the stance you have outlined, the usage of NFS in the object_st
John and others,
I have been looking for the point where the wrong path is instantiated.
After analyses I came to the DownloadAnswer class which contains the
original fixPath method that I c&p'ed to do my thing. I cannot support this
with logging however. Where the DownloadAnswer is created eludes
Thanks, everyone! :)
On Wed, Jun 19, 2013 at 11:13 AM, Sebastien Goasguen wrote:
> Well done Mike,
>
> -Sebastien
>
> On 19 Jun 2013, at 16:38, Joe Brockmeier wrote:
>
> > On Wed, Jun 19, 2013, at 08:39 AM, Alex Huang wrote:
> >> Please join me in congratulating Mike!
> >
> > Congrats Mike!
> >
One thing I have been noticing is that there are now a lot of columns in
the Service Offerings - Disk Offerings table since Wei's four hypervisor
QoS fields are there. I don't know if others have observed this, but this
many columns seems to skew the table a bit: The columns don't entirely line
up.
Well...it's not "necessary" per se. :) I just wanted to throw it out there
and get people's thoughts. I certainly don't want to take anything away
from your feature that you may value a lot.
On Wed, Jun 19, 2013 at 2:03 PM, Wei ZHOU wrote:
> Mike,
>
> You can remove them from UI if necessary.
>
The double slash can happen in every where, there is bug fix long time
ago(http://bugs.cloud.com/show_bug.cgi?id=14066), which tries to change all the
path concatenation, unfortunately, it's not been checked into cloudstack.
I am +1 with your patch, which at least fixes this particular issue, wit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11980/
---
Review request for cloudstack.
Description
---
- writeToFile removed since
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11980/#review22133
---
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/Libv
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11981/
---
Review request for cloudstack and Hugo Trippaers.
Description
---
This is
Seeing this issue with latest master.
> -Original Message-
> From: Srikanteswararao Talluri [mailto:srikanteswararao.tall...@citrix.com]
> Sent: 14 June 2013 18:55
> To: dev@cloudstack.apache.org
> Subject: instance is not coming on the vmware deployment
>
> I am encountering the followin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11026/#review22139
---
Commit b3fb4851ee204b1be514e389c66fd6e08d4b7fa4 in branch refs/heads
Hi Sateesh,
This happens because of a stale systemvm.iso existing in the systemvm directory
on the secondary storage - if you delete it and then rebuild the systemvm.iso,
and redeploy, the latest systemvm.iso gets copied over to the secondary
systemvm directory and the problem will go away.
Ch
Hi,
I just found out that some commands (e.g. AddBaremetalHostCmd,
AddBaremetalKickStartPxeCmd) didn't show in the marvin's
API(tools/marvin/marvin/cloudstackAPI), make it hard for me to write marvin
test case for them.
The baremetal function is disabled for master but these commands are still
th
Hi Vijay!
Thanks a lot for the tip. It worked wonderfully.
Yes, Deleteing stale systemvm.iso from secondary storage did it.
Regards,
Sateesh
> -Original Message-
> From: Vijayendra Bhamidipati [mailto:vijayendra.bhamidip...@citrix.com]
> Sent: 20 June 2013 06:14
> To: dev@cloudstack.apac
Great! :)
Cheers!
Regards,
Vijay
-Original Message-
From: Sateesh Chodapuneedi [mailto:sateesh.chodapune...@citrix.com]
Sent: Wednesday, June 19, 2013 6:04 PM
To: dev@cloudstack.apache.org
Subject: RE: instance is not coming on the vmware deployment
Hi Vijay!
Thanks a lot for the tip.
There are so many wonderful sessions; is it open or just for whom brought
ideas?
I really want to join.
On Tue, Jun 18, 2013 at 8:49 PM, David Nalley wrote:
> On Tue, Jun 18, 2013 at 7:49 AM, John Burwell wrote:
> > Daan,
> >
> > I think that would make a lot of sense. My plan is to collect a
It is completely open - come have fun with us.
--David
On Wed, Jun 19, 2013 at 10:02 PM, Gavin Lee wrote:
> There are so many wonderful sessions; is it open or just for whom brought
> ideas?
> I really want to join.
>
>
> On Tue, Jun 18, 2013 at 8:49 PM, David Nalley wrote:
>
>> On Tue, Jun 18,
On Tue, Jun 18, 2013 at 2:24 PM, Rohit Yadav wrote:
> On Tue, Jun 18, 2013 at 9:08 PM, David Nalley wrote:
>
>> On Tue, Jun 18, 2013 at 11:33 AM, Sebastien Goasguen
>> wrote:
>> >
>> >
>> >
>> > On 18 Jun 2013, at 17:08, David Nalley wrote:
>> >
>> >> On Mon, Jun 17, 2013 at 7:00 AM, Prasanna S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11984/
---
Review request for cloudstack, Chip Childers, edison su, and Min Chen.
Descript
Hi everyone,
when i add iscsi primary storage with chap enabled,i don't see anywhere in
the GUI to provide it.
I wonder that does cloudstack have already supported in new version 4.1 or
in the other release?
Thanks and best regards.
Hi,
Following my previous post about implementing PCI Passthrough on
CloudStack (KVM), I have taken Edison Su’s and others’ comments into
account and came up with an improved design.
Because the devices available at each agent may be different, the
available devices for passthrough are now config
Hi,
I've forgot to describe the detach-attach mechanism, so I'll describe
it in this reply.
PCI Device detach is done automatically by the agent when a
MigrateCommand is processed. In KVM case, the server gets a list of
attached PCI devices from libvirt's XML and detach very device. If
detach is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11910/#review22145
---
Ship it!
Ship It!
- Abhinandan Prateek
On June 19, 2013, 11 a.m.
Hi,
At present (4.1 and earlier), CHAP is not supported when creating Primary
Storage.
If you want to use CHAP (as I often do), you must set it up from the
hypervisor side.
For example, if you're using XenServer, create a storage repository based
on your iSCSI target and use CHAP.
Then, go into
I discuss Primary Storage in CloudStack in this video, if you're interested:
http://www.youtube.com/watch?v=Mg2nTWejiwM
Also, I wrote this document up that might be of use to you:
http://buildacloud.org/blog/260-cloudstack-storage-configuration-guide.html
On Wed, Jun 19, 2013 at 10:43 PM, Mike
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11988/
---
Review request for cloudstack, Anthony Urso, Abhinandan Prateek, Murali Reddy,
a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11960/#review22147
---
Ship it!
Ship It!
- Abhinandan Prateek
On June 19, 2013, 7 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11910/
---
(Updated June 20, 2013, 5:19 a.m.)
Review request for cloudstack, Abhinandan Pr
> On June 20, 2013, 4:42 a.m., Abhinandan Prateek wrote:
> > Ship It!
Patch fails:
Applying: CLOUDSTACK-2987 Ensure XStools to be there in template inorder to
enable dynamic scaling of vm
error: patch failed: setup/db/db/schema-410to420.sql:1857
error: setup/db/db/schema-410to420.sql: patch d
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review22148
---
Ship it!
Ship It!
- Likitha Shetty
On June 19, 2013, 11:37 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review22149
---
Commit e420c3be8c597da6abf8915a99b0e3f860fda034 in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review22150
---
Commit fd77b60c5d3a3a5029d40583d4fc391e0cb41253 in branch
refs/head
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11959/
---
(Updated June 20, 2013, 5:37 a.m.)
Review request for cloudstack and Abhinandan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11910/#review22151
---
Commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11959/
---
(Updated June 20, 2013, 5:39 a.m.)
Review request for cloudstack and Abhinandan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22152
---
Ship it!
Ship It!
- Abhinandan Prateek
On June 18, 2013, 8:38 a.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22154
---
Commit 576884ec10b4a46b243b8138926c0fc650bcdaba in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22153
---
Commit d3d6350219c9f02ce5d604a81a0c3c12ff700672 in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11981/#review22157
---
Minor nitpick : our code conventions recommend the method naming to
91 matches
Mail list logo
