Jetty server fail to start in master branch

2013-06-02 Thread Isaac Chiang
Hi all: I checked out lastest master code. I successfully built the code and deployed the database, but failed to start the jetty server. Did anyone happen to see the error? ERROR [web.context.ContextLoader] (main:) Context initialization failed org.springframework.beans.factory.BeanCreation

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread John Burwell
Wei, My opinion is that no features should be merged until all functional issues have been resolved and it is ready to turn over to test. Until the total Ops vs discrete read/write ops issue is addressed and re-reviewed by Wido, I don't think this criteria has been satisfied. Also, how does this

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread Mike Tutkowski
Hi John, I believe Wei's feature deals with controlling the max number of IOPS from the hypervisor side. My feature is focused on controlling IOPS from the storage system side. I hope that helps. :) On Sun, Jun 2, 2013 at 6:35 PM, John Burwell wrote: > Wei, > > My opinion is that no features

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread Mike Tutkowski
Perhaps I should add more detail. :) The SolidFire plug-in is based on and requires Edison's new storage framework (also going in with 4.2). Leveraging Edison's framework, the plug-in is invoked at certain times to create and delete volumes on the SAN (and also to create and delete SRs in XenServ

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread John Burwell
Mike, The things I want to understand are the following: 1) Is there value in capturing IOPS policies be captured in a common data model (e.g. for billing/usage purposes, expressing offerings). 2) Should there be a common interface model for reasoning about IOP provisioning at runtime?

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread Mike Tutkowski
Sending to the CS e-mail list (I accidentally only sent this to John before). On Sun, Jun 2, 2013 at 7:10 PM, Mike Tutkowski wrote: > Hi John, > > Let me see if I can answer your questions. > > 1) If we mean provide the ability to charge more for higher IOPS Disk > Offerings, then I would say '

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread Mike Tutkowski
I should also point out, John, that I am only supporting Disk Offerings for 4.2 (not Compute Offerings). I plan to support Compute Offerings in 4.3. Also, the patch I submitted is for XenServer only. Depending on when we freeze 4.2, I could submit code for VMware. The XenServer and VMware code, t

Re: Jetty server fail to start in master branch

2013-06-02 Thread Isaac Chiang
Hi all: I found that commit : f24e81fe0da let the jetty fail to start in master. Did anyone see this error? Here's my steps : 1. mvn clean install -P developer,systemvm 2. mvn -pl developer,tools/devcloud -Ddeploydb -P developer 3. mvn -pl client jetty:run Regards Isaac On

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread Wei ZHOU
John, Thanks for your reply. I will revert the commit for the opnion from Wido and you, and ask you reviewing it after modification. -Wei 2013/6/3, John Burwell : > Wei, > > My opinion is that no features should be merged until all functional issues > have been resolved and it is ready to turn o

RE: Jetty server fail to start in master branch

2013-06-02 Thread Sateesh Chodapuneedi
Hi Isaac, Fixed this issue. Can you please pull the latest code and re-try? Regards, > -Original Message- > From: Isaac Chiang [mailto:isaacchi...@gmail.com] > Sent: 03 June 2013 09:21 > To: dev@cloudstack.apache.org > Subject: Re: Jetty server fail to start in master branch > > Hi all: >

Re: VMware API Question

2013-06-02 Thread Mike Tutkowski
Hi Vijay, I have a quick question for you. :) I have about 99% of the VMware-related code written. This is what it does and how it fits in with my storage plug-in. * Let's say an admin creates a Disk Offering for a volume that is 1 GB and has certain Min, Max, and Burst IOPS set. * An end user

Re: Inconsistent error while creating instances

2013-06-02 Thread Nitin Mehta
Refer to this - http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201303.mb ox/%3c67ef18fdca335f489b366120481ab6c5f6be740...@banpmailbox01.citrite.net% 3E On 01/06/13 4:18 AM, "Ahmad Emneina" wrote: >I've hit this in the past when there was a mismatch between the actual >guest

Re: Jetty server fail to start in master branch

2013-06-02 Thread Isaac Chiang
It works, thanks :) Regards Isaac On Mon, Jun 3, 2013 at 1:14 PM, Sateesh Chodapuneedi < sateesh.chodapune...@citrix.com> wrote: > Hi Isaac, > Fixed this issue. > Can you please pull the latest code and re-try? > > Regards, > > -Original Message- > > From: Isaac Chiang [mailto:isaa

Re: [MERGE] disk_io_throttling to MASTER

2013-06-02 Thread Wei ZHOU
Hi John, Mike I hope Mike's aswer helps you. I am trying to adding more. (1) I think billing should depend on IO statistics rather than IOPS limitation. Please review disk_io_stat if you have time. disk_io_stat can get the IO statistics including bytes/iops read/write for an individual virtual

Is it nessesary to test getBase64Keystore 100000 times in ConfigurationServerImplTest.java

2013-06-02 Thread Wei ZHOU
The build of latest master branch spent much more time on ConfigurationServerImplTest.java, which includes test getBase64Keystore 10 times. Is it neccesary? [root@weizhou-centos incubator-cloudstack]# git diff 2f29185943ac0412aa501b59493837b4055642e0 4894187991d581b72807b4282b7a29a48a8031e5 +

Re: Is it nessesary to test getBase64Keystore 100000 times in ConfigurationServerImplTest.java

2013-06-02 Thread Prasanna Santhanam
On Mon, Jun 03, 2013 at 08:19:41AM +0200, Wei ZHOU wrote: > The build of latest master branch spent much more time on > ConfigurationServerImplTest.java, which includes test getBase64Keystore > 10 times. > > Is it neccesary? > > [root@weizhou-centos incubator-cloudstack]# git diff > 2f2918594