RE: orchestrateTakeVolumeSnapshot Call

2014-03-18 Thread Alex Hitchins
7788 423 969 alex.hitch...@shapeblue.com -Original Message- From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com] Sent: 18 March 2014 14:21 To: dev@cloudstack.apache.org Subject: RE: orchestrateTakeVolumeSnapshot Call Thanks for the information Chris, I can check for the returned null to de

RE: orchestrateTakeVolumeSnapshot Call

2014-03-18 Thread Alex Hitchins
-Original Message- From: SuichII, Christopher [mailto:chris.su...@netapp.com] Sent: 18 March 2014 14:08 To: dev Subject: Re: orchestrateTakeVolumeSnapshot Call Ah, yes. Now seeing this snippet I can explain the issue. So, during "orchestrateTakeVolumeSnapshot(work.getVol

Re: orchestrateTakeVolumeSnapshot Call

2014-03-18 Thread SuichII, Christopher
Ah, yes. Now seeing this snippet I can explain the issue. So, during "orchestrateTakeVolumeSnapshot(work.getVolumeId(), work.getPolicyId(), work.getSnapshotId(), account, work.isQuiesceVm());” if an exception is thrown, it is caught and ignored by VolumeServiceImpl.takeSnapshot(VolumeInfo): @O

orchestrateTakeVolumeSnapshot Call

2014-03-18 Thread Alex Hitchins
All, I'm looking at the following issue[0]. The reporter says in the second sentence the method is always returning success even when an exception occurs or otherwise fails. Looking at the code, if the inside call to orchestrateTakeVolumeSnapshot raises an exception, it should bubble up and not